2019-10-15 J.C. Jones <jjones@mozilla.com>
* cmd/addbuiltin/addbuiltin.c:
Bug 1465613 - Fixup clang format a=bustage
[f657d65428c6] [NSS_3_47_BETA2]
2019-10-11 Marcus Burghardt <mburghardt@mozilla.com>
* automation/abi-check/expected-report-libnss3.so.txt, automation/abi-
check/expected-report-libsmime3.so.txt, automation/abi-check
/expected-report-libssl3.so.txt, cmd/addbuiltin/addbuiltin.c,
cmd/lib/secutil.c, gtests/softoken_gtest/manifest.mn,
gtests/softoken_gtest/softoken_gtest.gyp,
gtests/softoken_gtest/softoken_nssckbi_testlib_gtest.cc,
lib/certdb/certdb.c, lib/certdb/certt.h, lib/ckfw/builtins/README,
lib/ckfw/builtins/certdata.txt, lib/ckfw/builtins/manifest.mn,
lib/ckfw/builtins/nssckbi.h, lib/ckfw/builtins/testlib/Makefile,
lib/ckfw/builtins/testlib/builtins-testlib.gyp,
lib/ckfw/builtins/testlib/certdata-testlib.txt,
lib/ckfw/builtins/testlib/config.mk,
lib/ckfw/builtins/testlib/manifest.mn, lib/ckfw/builtins/testlib
/nssckbi-testlib.rc,
lib/ckfw/builtins/testlib/testcert_err_distrust.txt,
lib/ckfw/builtins/testlib/testcert_no_distrust.txt,
lib/ckfw/builtins/testlib/testcert_ok_distrust.txt,
lib/ckfw/manifest.mn, lib/nss/nss.def, lib/pki/pki3hack.c,
lib/softoken/sdb.c, lib/util/pkcs11n.h, nss.gyp, tests/cert/cert.sh:
Bug 1465613 - Created two new fields for scheduled distrust from
builtins and updated support commands. r=jcj,kjacobs,mt
Added two new fields do scheduled distrust of CAs in
nssckbi/builtins. Also, created a testlib to validate these fields
with gtests.
[52024949df95]
2019-10-14 Martin Thomson <martin.thomson@gmail.com>
* lib/ssl/tls13con.c:
Bug 1588557 - Fix debug statement, r=jcj
[0f563a2571c3]
2019-10-15 Dana Keeler <dkeeler@mozilla.com>
* gtests/mozpkix_gtest/pkixder_universal_types_tests.cpp,
lib/mozpkix/include/pkix/pkixder.h, lib/mozpkix/lib/pkixcert.cpp:
bug 1579060 - fix handling of issuerUniqueID and subjectUniqueID in
mozilla::pkix::BackCert r=jcj
According to RFC 5280, the definitions of issuerUniqueID and
subjectUniqueID in TBSCertificate are as follows:
issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL,
subjectUniqueID [2] IMPLICIT UniqueIdentifier OPTIONAL,
where UniqueIdentifier is a BIT STRING.
IMPLICIT tags replace the tag of the underlying type. For these
fields, there is no specified class (just a tag number within the
class), and the underlying type of BIT STRING is "primitive" (i.e.
not constructed). Thus, the tags should be of the form CONTEXT
SPECIFIC | [number in class], which comes out to 0x81 and 0x82,
respectively.
When originally implemented, mozilla::pkix incorrectly required that
the CONSTRUCTED bit also be set for these fields. Consequently, the
library would reject any certificate that actually contained these
fields. Evidently such certificates are rare.
[c50f933d37a5]
2019-10-14 Deian Stefan <deian@cs.ucsd.edu>
* lib/softoken/pkcs11c.c:
Bug 1459141 - Rewrite softoken CBC pad check to be constant time.
r=kjacobs,jcj
[474d62c9d0db]
2019-10-11 J.C. Jones <jjones@mozilla.com>
* .hgtags:
Added tag NSS_3_47_BETA1 for changeset 93245f5733b3
[f60dbafbc182]
Differential Revision: https://phabricator.services.mozilla.com/D49365
--HG--
extra : moz-landing-system : lando
This change removes the following specifiers in the `mochitest` manifest files:
- api >= 23
- api <= 17
- api == 22
Of the three, api >= 23 may present some risks, but `mochitest-media` suite does not appear to report any issues.
Differential Revision: https://phabricator.services.mozilla.com/D49337
--HG--
extra : moz-landing-system : lando
We extract tags from the result title only when `info.style.includes("bookmark")`, but that only captures one of the two cases where we include tags in the title: the "bookmark" style. We also include tags for the "tag" style. So the bug reports in this bug are hitting that "tag" case. It doesn't have anything to do with non-Latin tags afaict (see the bug summary).
I took the opportunity to streamline `UnifiedComplete._addFilteredQueryMatch`, which was a little hard to follow. I had to look at it to make sure I captured all the cases where tags are included in the title. I think I've made it easier to follow.
Differential Revision: https://phabricator.services.mozilla.com/D49223
--HG--
extra : moz-landing-system : lando
The fix in Bug 1577634 only worked for the beta channel as it didn't consider the RC case.
There's several situations:
* beta without comments --> beta with comments: handled by bug 1577634, but with fallout
* beta with comments --> beta with comments: `channel-prefs.js` is identical so we never need to apply any transforms
* beta with comments --> rc with comments: the channel changes in `channel-prefs.js` (by design) so we apply transforms
* rc with comments --> beta with comments: the channel changes in `channel-prefs.js` (by design) so we apply transforms
By moving the channel fixing transforms forward the file will become identical before we need to try the comment transform. The code breaks early in this case.
The release/esr case is simpler:
* release without comments --> release with comments: handled by comment transform, channel transforms only used for beta tests
* release with comments --> release with comments: `channel-prefs.js` already identical, no transforms applied
Differential Revision: https://phabricator.services.mozilla.com/D49224
--HG--
extra : moz-landing-system : lando
This changes the either-or semantics to one-after between the local and remote fluent files for ASRouter.
Differential Revision: https://phabricator.services.mozilla.com/D49068
--HG--
extra : moz-landing-system : lando
Note - This change is only visible in the light variation of the default theme.
Differential Revision: https://phabricator.services.mozilla.com/D49179
--HG--
extra : moz-landing-system : lando
Note - I did not edit the refernces to `--in-content-box-border-color` across the following refernces:
login-list:
:host (Also contained references to backround color: `--in-content-box-background`)
.meta (Also contained references to backround color: `--in-content-box-background`)
.create-login-button-container (Shadow color property)
menu-button:
.menu (Also contained references to backround color: `--in-content-box-background`)
Differential Revision: https://phabricator.services.mozilla.com/D49188
--HG--
extra : moz-landing-system : lando
This commit builds on the last one to chunk all bound parameters.
In most cases, we just move the statements into a loop that
iterates over the chunks instead of the array. There are two
exceptions which need a bit more work: `cleanupPages` and `remove`.
In `cleanupPages`, we chunk `pagesToRemove`, and clean up
`moz_updateoriginsdelete_temp` and orphan icons after the loop. This
doesn't change functionality, because none of the statements that
follow depend on `moz_origins`, `moz_icons`, or frecency stats.
In `remove`, we now fetch page info for URLs and GUIDs in separate
statements. This makes chunking URL params easier.
Differential Revision: https://phabricator.services.mozilla.com/D49074
--HG--
extra : moz-landing-system : lando
This is a wrapper around the `sqlite3_limit` interface that returns the
binding parameter limit. Adding this getter lets us clean up the inline
`SQLITE_MAX_VARIABLE_NUMBER` constants scattered around Places.
Differential Revision: https://phabricator.services.mozilla.com/D49071
--HG--
extra : moz-landing-system : lando
This patch intends to change the internal reprensentation of certList
from nsIX509CertList to Array for TransportSecurityInfo.
Differential Revision: https://phabricator.services.mozilla.com/D48744
--HG--
extra : moz-landing-system : lando
These assertion counts were removed (accidentally?) by bug 1321127, effectively
not tracking assertion count mismatches in the reftest harness and instead
relying on mozharness to fail tasks based on the logged error messages.
Restoring the counts ensures:
- the reftest summary includes accurate assertion counts like
REFTEST INFO | Unexpected: 12 (..., 11 unexpected asserts, ...)
REFTEST INFO | Known problems: 64 (..., 31 known asserts, ...)
- assertion mismatches cause the harness to exit with an error code so
that the job fails even if the log parsing is broken (bug 1587139)
or the tests are being run locally with mach.
Differential Revision: https://phabricator.services.mozilla.com/D48594
--HG--
extra : moz-landing-system : lando
Most of these tests have been disabled for a long time; they run well
in the current test environment.
With the additional tests running, task times increase; I have added one
more test chunk for android mochitest-plain.
These tests were identified from a random sampling of mochitest manifests;
I intend to enable more mochitests in future patches.
Differential Revision: https://phabricator.services.mozilla.com/D48912
--HG--
extra : moz-landing-system : lando
Usually it covers a different area than the window's ChildView. But in some cases
it can overlap with the ChildView, and in those cases, it's better if the
ChildView is on top.
Differential Revision: https://phabricator.services.mozilla.com/D49332
--HG--
extra : moz-landing-system : lando
As suggested in patch review, some of the mozilla::Variant matcher classes in
Script.cpp could be written more clearly using lambda-based matching. This patch
applies that technique in the implementations of DebuggerScript's create,
getStartLine, and getFormat methods.
Differential Revision: https://phabricator.services.mozilla.com/D38559
--HG--
extra : moz-landing-system : lando
Additionally, this fixes test dom/tests/mochitest/bugs/test_bug1530292.html
which fails if fission is enabled.
Differential Revision: https://phabricator.services.mozilla.com/D47779
--HG--
extra : moz-landing-system : lando
We can't set wl_egl_window from widget code as it must match GL rendering pipeline,
so let compositor to set the egl window size.
Depends on D49136
Differential Revision: https://phabricator.services.mozilla.com/D49137
--HG--
extra : moz-landing-system : lando
wl_egl_window size must exactly march GL rendering pipeline setting.
Compositor and widget can have different window sizes during window resize when widget
is resized faster than layout can render. Firefox window is rendered misplaced then
and it's "jumping" as layout size is behind toolkit size.
Differential Revision: https://phabricator.services.mozilla.com/D49136
--HG--
extra : moz-landing-system : lando
This indicates to the Normandy server that this client understands the
capabilities model, which is used for backwards compatibility. Without this
change, the server will only send recipes that are compatible with the
functionality that existed in Firefox 70, and other recipes will not be
included. With this change, we'll get the full picture of recipe.
Differential Revision: https://phabricator.services.mozilla.com/D48448
--HG--
extra : moz-landing-system : lando
