Automatic update from web-platform-testsAsync Cookies: Expose oncookiechange on ServiceWorkerGlobalScope.
cookiechange events have been dispatched to ServiceWorkerGlobalScope
since https://crrev.com/c/979334 landed, and can be observed using
addEventListener, as shown by the WPT test at
cookie-store/serviceworker_cookieStore_subscriptions_basic.tentative.https.html
This CL adds the oncookiechange attribute to ServiceWorkerGlobalScope,
allowing the event to be handled by a DOM0-style event handler.
Bug: 729800
Change-Id: Ic27979d94934abf833c116787cdad5243422324b
Reviewed-on: https://chromium-review.googlesource.com/1123766
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572400}
--
wpt-commits: bf35451761ed3c9063f928bc8c4c340ee66634f3
wpt-pr: 11761
Automatic update from web-platform-testsRewrite BlobBytesConsumer to not rely on blob URLs.
The existing implementation depended on the non-mojo blob URL code path,
and so would break soon after mojo blob URLs ship when the old code gets
deleted. So rewrite the implementation to read blobs more directly rather
than going through a blob URL.
Bug: 859109
Change-Id: Ia6f2432e48ac5304ea8f5598d293e31c2c1e1905
Reviewed-on: https://chromium-review.googlesource.com/1120679
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572363}
--
wpt-commits: 8f6ed28158100d414ddac343e6a6f44a74a37e3a
wpt-pr: 11738
Automatic update from web-platform-testsAdd more WPT tests for client hints
The WPT tests check the Accept-CH-Lifetime (ACL) header functionality.
Add tests for:
(i) When ACL header is sent by a same-origin iframe.
(ii) When ACL header is sent by a cross-origin iframe.
(iii) When ACL header is sent by a subresource.
(iv) When ACL header is sent on the main frame.
Also, change the ACL persistence time-duration from 20
seconds to 5 seconds to make it easier to run multiple tests
quickly and without waiting too long.
Change-Id: I31047598bbb1e7c64cadf3e6845bf850c29aca8b
Bug: 856700
Reviewed-on: https://chromium-review.googlesource.com/1119848
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#572273}
--
wpt-commits: 59d4a411a8ead528f17b124b03c07387a3d43d07
wpt-pr: 11735
Automatic update from web-platform-testsDeflake cache-storage/script-tests/cache-storage-match.js WPT
The test assumed no cache named 'foo' existed, but another test
cache-keys-attributes-for-service-worker creates a cache by that name,
so the test would flakily fail in some runs depending on the ordering
of the tests.
Make the test defensive by deleting such a cache before proceeding.
Bug: 840850
Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d
Reviewed-on: https://chromium-review.googlesource.com/1119104
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572232}
--
wpt-commits: 5c8e16d4499991fd344359e44cf6ee85b25bb413
wpt-pr: 11721
Automatic update from web-platform-testsClean up the css-font-loading IDL test (#9771)
--
wpt-commits: 5c05fc07d58b1352de26f62434103c8ec3941749
wpt-pr: 9771
Automatic update from web-platform-testsAdd a new test case for Element#innerText in Web Platform Test
This patch introduces a new test case for Element#innerText to verify that
result has a collapsed whitespace due by soft line break.
In the test case, the layout object associated to space character between
<span> elements, doesn't have neither InlineTextBox and NGPhysicalTextFragment.
Thus, Element#innerText implementation should detect this and handle it.
Bug: 651764
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: Ia25d06a2a3fe993f2e966188b81f9e9c1d0fe982
Reviewed-on: https://chromium-review.googlesource.com/1124264
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572164}
--
wpt-commits: 5d0c4eb770570e966e9b878b787c7de217462567
wpt-pr: 11763
MozReview-Commit-ID: KMSrvRpCH7R
Automatic update from web-platform-testsBackground-size should not accept negative values.
Follow the spec[1], negative values are not allowed.
We should reject the negative values of background-size during parsing.
[1]: https://drafts.csswg.org/css-backgrounds/#background-size
Bug: 825549
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ib260bafa421249aed471ff801c8b49a4b97aba1e
Reviewed-on: https://chromium-review.googlesource.com/989529
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572149}
--
wpt-commits: a04dd9954d333e4f11d093eec4620a2aac95298b
wpt-pr: 10366
Automatic update from web-platform-testsWPT tests for http-equiv accept-ch header
This CL adds WPT tests for http-equiv accept-ch header:
(1) The header is not honored on HTTP pages
(2) Malformed header is not honored
(3) When the header is present, client hints are attached only
on the same-origin subresources, and not on cross-origin
subresources in the same navigation.
(4) When the header is present, client hints are attached only
on the same origin subresources, and not on subresources in
a new navigation.
Bug: 856700
Change-Id: I3f82df8cd02816b06542256062eb291577ebe8b7
Reviewed-on: https://chromium-review.googlesource.com/1120953
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#571986}
--
wpt-commits: 2937bc40761173d438d67b6ebf2b0abcfbb911a4
wpt-pr: 11736
--HG--
rename : testing/web-platform/tests/client-hints/accept_ch.sub.https.html.headers => testing/web-platform/tests/client-hints/accept_ch.tentative.sub.https.html.headers
Automatic update from web-platform-testsDon't use six.string_types in wptserve.
In python 2, it's defined as basestring, so it matches both str and unicode,
but in python 3, it matches only str (and not bytes). This does not seem like
a useful approach as we add python 3 support, and the now-passing tests
support that view.
--
wpt-commits: f1587a318576ff766b8237e3428ff5377eedfb8e
wpt-pr: 11754
Automatic update from web-platform-testsMerge pull request #11636 from ewilligers/css-color-parsing
[css-color] Parsing color and opacity
--
wpt-commits: 8bb14e8b2bd36d97b216ef72ec46eaae44695707
wpt-pr: 11636
Automatic update from web-platform-testsUpdate requests from 2.18.4 to 2.19.1
--
Update requests from 2.18.4 to 2.19.1
--
wpt-commits: 1b5a507e1d141b6c8cdf14897ff206e85fff0753, c88d124cd2bcd2760735fac91a3e2eef4693ad05
wpt-pr: 11508
Automatic update from web-platform-tests[fullscreen] Do not return value from cleanup fns
Today, the return value of functions provided to the global
`add_cleanup` function has no effect on the behavior of the test runner.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1].
Despite this, some existing tests have already been authored to return a
value: the result of `document.exitFullScreen`. Although this is
expected to be a Promise in conforming implementations, some browsers do
not yet implement this functionality.
To allow the new test harness feature to land without introducing
harness errors, refactor existing tests to omit a return value.
Additionally, use `Promise.prototype.catch` to avoid race conditions
resulting from unhandled Promise rejections (which trigger a harness
error in testharness.js today).
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 31a51c70f74e23dc52f2033e552990a03f3166a9
wpt-pr: 11733
Automatic update from web-platform-tests[html] Do not return value from cleanup fns
Today, the return value of functions provided to the `Test#add_cleanup`
function has no effect on the behavior of the test runner. Despite this,
some existing tests have already been authored to return a value: the
result of `Element#removeChild`.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1]. To allow the new test harness
feature to land without introducing harness errors, refactor existing
tests to omit a return value.
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 21369c1a88085d4804d520887978392d19c8c656
wpt-pr: 11740
Automatic update from web-platform-tests[fetch] Do not return value from cleanup fns
Today, the return value of functions provided to the `Test#add_cleanup`
function has no effect on the behavior of the test runner. Despite this,
some existing tests have already been authored to return the `null`
value.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1]. To allow the new test harness
feature to land without introducing harness errors, refactor existing
tests to omit a return value.
[1] https://github.com/web-platform-tests/wpt/issues/6075
--
wpt-commits: 86455a624bb05eb7503ccbe340dca973f5dea4c8
wpt-pr: 11741
Automatic update from web-platform-testsAsync Cookies: Update Cookie Store API to match spec.
This CL changes the signatures of cookieStore.{get,getAll,set,delete}
and introduces the CookieStoreDeleteOptions and
CookieStoreSetExtraOptions dictionary. The CL also updates the
CookieListItem dictionary.
TBR=haraken
Bug: 729800
Change-Id: Iaa62b5a51cc79b19cb567be30a2f0dda54e326d8
Reviewed-on: https://chromium-review.googlesource.com/1117868
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571736}
--
wpt-commits: 0e96b1f8627cf798ebea0c2a0cdf6b5d8cb8825e
wpt-pr: 11724
Automatic update from web-platform-tests[Squad] Generate ::before/::after/::backdrop in style recalc.
We used to create these pseudo elements and their computed styles in
Element::AttachLayoutTree when building the layout tree. Now we create
or dispose these elements from style recalc, that is,
UpdatePseudoElement. To make pseudo elements live through a style recalc
with a layout tree re-attach we no longer clear the pseudo elements
during DetachLayoutTree for performing_reattach=true. We do however need
to clear the pseudo elements which do not get a layout object for the
re-attach. That is done in AttachLayoutTree for the originating element
when the originating element does not generate a layout box.
We stop using the pseudo style cache on ComputedStyle for PseudoElements
and instead return the ComputedStyle when creating the pseudo element
and store it as non-attached style which can later be retrieved when
attaching the layout object.
An effect of this change is that we can detect transitions on pseudo
elements when ancestors display types changes and causes re-attachment.
That is issue 836140.
::first-letter may still be generated during layout tree building, and
the ::first-letter layout structure may still be updated during style
recalc.
Bug: 836126, 836140
Change-Id: Iafad705b7a7b988d4c1598e8a126ce0d79c5873d
Reviewed-on: https://chromium-review.googlesource.com/1112244
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571665}
--
wpt-commits: ec35b03ca5e8eec6eb1767a77f0aea13855515a3
wpt-pr: 11634
Automatic update from web-platform-tests[LayoutNG] Allow epsilon when fitting into a line
When NGLineBreaker tries to fit items into a line, rounding
errors are hard to avoid. One case is to fit `monospace` font
into a container whose `width` is set by `ch` unit.
Blink computes `ch` units in float, then round to LayoutUnit.
This rounding often prevents the specified number of
characters to fit into the line. All 4 impls pass this test
for `3ch` to `100ch`.
Bug: 636993
Cq-Include-Trybots: luci.chromium.try :linux_layout_tests_layout_ng
Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee
Reviewed-on: https://chromium-review.googlesource.com/1116409
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571642}
--
wpt-commits: c360ca023dc5c341065de0f2814914b3c6004e4f
wpt-pr: 11688
MozReview-Commit-ID: IgzIRG31IMn
Automatic update from web-platform-tests[testdriver.js] Implement `bless` method (#11511)
A common use case for the testdriver.js library is to create a task that
was triggered by user interaction [1]. Doing so using the current API
requires a fair amount of logic which is unrelated to the behavior under
test. This has a number of drawbacks:
- it makes tests less descriptive
- it makes tests less uniform both in terms of implementation and in
terms of user experience (in non-automated scenarios, human operators
may be prompted to provide the necessary input)
- it makes tests more susceptible to bugs
Define a utility method as a consistent and concise way to facilitate
the common use case. Require descriptive text via the `intent` parameter
in order to encourage test authors to explicitly describe the rationale
for requesting additional privileges.
[1] https://html.spec.whatwg.org/#triggered-by-user-activation
--
wpt-commits: 8b8082f30267410e4b3729439be23df8b803dde8
wpt-pr: 11511
Automatic update from web-platform-testsMake sure stacking context is always updated for ::first-letter.
::first-letter sadly has at least three code paths for computing its
computed style. Two of them were lacking stacking context update. There
is work in progress for Squad to mend this, but let's fix the current
code paths for now.
Bug: 856806
Change-Id: Ifeea799643bfa266e58c948f476bc23481fcdd5e
Reviewed-on: https://chromium-review.googlesource.com/1120249
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571512}
--
wpt-commits: 02cfdfe53b794884bcd731e18f845bec59dfd707
wpt-pr: 11731
Automatic update from web-platform-testsMake sync-tests.sh work with git.
--
Allow specifying the mozilla tree via argument.
--
wpt-commits: 8b61c282650bf72bce0147df320425343ea27f2f, e639f5b4158852b16ffa28613730c2b0b63f5e83
wpt-pr: 11715
Automatic update from web-platform-testsSync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/6041c030780420b6205cf2d6640513606609884c
This contains two changes:
* One by Mihir Iyer from [bug 1398483](https://bugzil.la/1398483), reviewed by
@dholbert, adding flexbox column-{row,gap} reftests.
* One by myself from [bug 1464782](https://bugzil.la/1464782), replacing the
usage of offset-* logical properties by the standard name inset-*, reviewed
by @upsuper.
--
wpt-commits: dc302574be5e27db4ade270698c966a39a09e300
wpt-pr: 11714
Automatic update from web-platform-testsUpdate external/wpt/webrtc/RTCRtpParameters* tests.
This is in preparation for get/setParameters[1] and
RTCRtpTransceiver[2].
Tests are updated to use promise_test and async/await to make them
easier to write and to execute sequentially.
Tests are updated to set up a call before getParameters() because many
parameters are defined as "that has been negotiated". If we want to test
what is returned before negotiation we should add that as separate
tests. For now, this is necessary for the tests to run on [1][2].
Some tests are removed because they no longer reflect the spec.
Because get/setParameters() and RTCRtpTransceiver has not landed yet,
the tests are still expected to fail.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1102436
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771
Bug: 803494, 777617
Change-Id: I3f14a37925837576a602d91bb67e48181c56a946
Reviewed-on: https://chromium-review.googlesource.com/1102502
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571430}
--
wpt-commits: 36fb033a4051e63a0ab4bd073fdaadf808953564
wpt-pr: 11526
