Commit Graph

494 Commits

Author SHA1 Message Date
Eitan Isaacson
2cee1b8c81 Bug 1472274 - Alter selection direction according to the last change. r=surkov
nsIAccessibleText.setSelectionBounds should accept a start offset that is larger than an end offset. This is an indica tion that it is a reverse selection, and the caret should be at the start of the selection.

This should also be consistent with how multiple range selections work interactively - the caret should re
main at the last offset reached.
2018-07-05 15:19:00 +03:00
Alexander Surkov
32562a67f0 Bug 1349223 - cut aria-hidden tree, r=yzen 2018-07-04 10:20:49 -04:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Chris Peterson
2afd829d0f Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.

MozReview-Commit-ID: 5UQVHElSpCr

--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Cosmin Sabou
aeb2ada3aa Backed out changeset b2df5de436bd (bug 1349223) for permafailling marionette harness on test_accessibility.py. CLOSED TREE 2018-06-25 22:50:58 +03:00
Alexander Surkov
3da9b86da8 Bug 1349223 - cut aria-hidden tree, r=yzen 2018-06-25 14:17:01 -04:00
Eitan Isaacson
09ec9609fb Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov 2018-06-21 14:47:00 +03:00
Alexander Surkov
9b16d6de3d Bug 759650 - turn 'Called on accessible unbound from tree' assertion into moz_assert 2018-06-18 14:04:08 -04:00
Alexander Surkov
3364a60bed Bug 886215 - trun 'Children of not selected deck panel are not accessible' into moz_assert 2018-06-18 14:02:27 -04:00
Alexander Surkov
94ab51d46c Bug 687011 - aria-activedescendant change on inserted node doesn't fire focus change, r=jamie 2018-06-08 10:55:08 -04:00
Samuel Thibault
73a24b5b8a Bug 1319273 - Accessible: Make TextBounds return rect of whole frame if content is empty. r=surkov 2018-05-23 17:02:33 +02:00
Gurzau Raul
ff15f3c828 Backed out changeset f585271d250d (bug 1319273) for eslint failures on /gecko/accessible/tests/browser/bounds/browser_test_zoom_text.js on a CLOSED TREE 2018-06-01 22:25:19 +03:00
Samuel Thibault
fa531b0477 Bug 1319273 - Accessible: Make TextBounds return rect of whole frame if content is empty. r=surkov 2018-05-23 17:02:33 +02:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Emilio Cobos Álvarez
fe09ffd3af Bug 1465478: Introduce Element::FromNode. r=smaug
And use it in a couple places I noticed.

MozReview-Commit-ID: 8baSMrbdEbF
2018-05-31 02:46:10 +02:00
Alexander Surkov
246756a336 Bug 1460244 - Tables with CSS display properties no longer participate in layout table calculation, r=marcoz 2018-05-25 10:55:52 -04:00
Kris Maglione
8340513b0c Bug 1463287: Add QueryInterface helper macro for concrete class types. r=bz
Using concrete class types with static IIDs in QueryInterface methods is a
pretty common pattern which isn't supported by any existing helper macros.
That's lead to separate ad-hoc implementations, with varying degrees of
dodginess, being scattered around the tree.

This patch adds a helper macro with a canonical (and safe) implementation, and
updates existing ad-hoc users to use it.

MozReview-Commit-ID: HaTGF7MN5Cv

--HG--
extra : rebase_source : ace930129d85960d22bc3048ca3bb19bbbd4a63e
extra : histedit_source : 03a87f746d957789d41381e4e1bfcc4fd7eebaf2%2C9c5bae9feeeef7721105db67be0f83e0ded66bb7
2018-05-21 16:33:18 -07:00
Boris Zbarsky
2e09ba1f75 Bug 1377980 part 2. Remove most C++ use of nsIDOMRange. r=mccr8 2018-05-17 12:01:38 -04:00
Tokio Kajitsuka
55c94aedca Bug 1438193 - part11-9: NativeState r=surkov
turn NativeState into const functions
2018-05-16 03:04:50 +09:00
Tokio Kajitsuka
2b0e583f32 Bug 1438193 - part11-8: DoAction r=surkov
turn DoAction & ActionCount into const functions
2018-05-16 02:40:22 +09:00
Tokio Kajitsuka
4815618b61 Bug 1438193 - part11-7: TakeFocus r=surkov
turn TakeFocus & AnchorURIAt into const functions
2018-05-16 02:19:54 +09:00
Tokio Kajitsuka
eb3d9b85ce Bug 1438193 - part11-6: Value r=surkov
turn Accessible::Value into a const function
2018-05-16 01:55:28 +09:00
Tokio Kajitsuka
0f609dc771 Bug 1438193 - part11-4: Name r=surkov
turn Name & ARIAName & NativeName into const functions
2018-05-16 01:13:02 +09:00
Tokio Kajitsuka
41078f48d3 Bug 1438193 - part11-2: RelationByType r=surkov
turn RelationByType into const functions
2018-05-15 22:47:10 +09:00
Tokio Kajitsuka
17d2e291d4 Bug 1438193 - part11-1: Role r=surkov
turn Accessible::Role into a const function
2018-05-15 21:50:38 +09:00
Dorel Luca
0d2ff9e60d Merge mozilla-inbound to mozilla-central. a=merge 2018-05-16 00:54:22 +03:00
Tokio Kajitsuka
d4d0782393 Bug 1438193 - part10: SetCurrentItem r=surkov
turn SetCurrentItem & GetChromeFlags & HasChildren into const functions
2018-05-13 19:14:55 +09:00
Tokio Kajitsuka
d50e800761 Bug 1438193 - part9: CurrentItem r=surkov
turn Accessible::CurrentItem into const functions
2018-05-13 18:26:02 +09:00
Alexander Surkov
6faf449ca5 Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz 2018-05-15 09:44:21 -04:00
Emilio Cobos Álvarez
29a24373d9 Bug 1459529: Remove some useless nsIDocumentObserver notifications. r=heycam
MozReview-Commit-ID: DzuiqVGKsiu
2018-05-15 18:44:28 +02:00
Narcis Beleuzu
932adad93d Merge inbound to mozilla-central. a=merge 2018-05-15 00:36:35 +03:00
Adrian Wielgosik
aec99c32e5 Bug 1460940 - Remove nsIDOMDocument uses in accessible/. r=bz
MozReview-Commit-ID: LQ91rgrJIy

--HG--
extra : rebase_source : 143e2a3b8971aa1a4e604414c704d28deb1e5594
2018-05-11 19:46:15 +02:00
Tokio Kajitsuka
9b9c3780fe Bug 1438193 - part7: NativeRole r=surkov
turn NativeRole into const functions
2018-05-08 04:05:50 +09:00
Tokio Kajitsuka
005aa74ac6 Bug 1438193 - part6: DoCommand r=surkov
turn Accessible::DoCommand into a const function
2018-05-07 02:11:06 +09:00
Tokio Kajitsuka
80aa8d9625 Bug 1438193 - part5: IsMultiColumn r=surkov
turn ColCount and IsMultiColumn into const functions
2018-05-06 00:55:29 +09:00
Alexander Surkov
5d3b238323 Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz 2018-05-08 13:13:38 -04:00
Chris Peterson
71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Tokio Kajitsuka
e23756cebc Bug 1438193 - turn Accessible::FirstChild & LastChild into const functions, r=surkov 2018-05-04 22:06:49 +09:00
Tokio Kajitsuka
71145a2b80 Bug 1438193 - turn IsLink() into a const function, r=surkov 2018-05-04 21:48:34 +09:00
Andreea Pavel
7955752872 Merge mozilla-inbound to mozilla-central. a=merge 2018-05-01 13:13:09 +03:00
James Teh
e8f0bb8cd9 Bug 1455745: Remove more accessibility related diagnostic crashes on Nightly. r=aklotz
This condition is rare and does indicate a problem which breaks accessibility.
However, we aren't getting any closer to diagnosing this as a result of this crash, so it causes user pain without any gain to us.

MozReview-Commit-ID: GacAQDbhB0h

--HG--
extra : rebase_source : 478ec67da378ff763c0e0d8a998de1956b51b85b
2018-04-23 12:27:17 +10:00
Yura Zenevich
ca5c7ae6a2 Bug 1457148 - ensure bounds does not crash for application accessible. r=surkov
MozReview-Commit-ID: DqGzNlCdFMy
2018-04-30 20:26:20 -04:00
Boris Zbarsky
21f3e98292 Bug 1455674 part 15. Remove use of nsIDOMElement in accessible. r=qdot 2018-04-26 23:37:33 -04:00
Emilio Cobos Álvarez
a1b2e5070a Bug 1455885: Inline and make document casts fatally assert. r=bz
For consistency with AsElement / AsContent / AsDocumentFragment, etc.

MozReview-Commit-ID: 8GSj8R9hLBe
2018-04-26 17:05:12 +02:00
Boris Zbarsky
dac6314cb8 Bug 1456588 part 2. Change nsIFocusManager::MoveFocus to take Element. r=enndeakin 2018-04-26 10:37:47 -04:00
Boris Zbarsky
8a0b50bea8 Bug 1456588 part 1. Change nsIFocusManager::SetFocus to take Element. r=enndeakin 2018-04-26 10:37:46 -04:00
Yura Zenevich
55fe960cc1 Bug 1450927 - add getBoundsInCSSPixels XPCOM method. r=surkov r=jld
MozReview-Commit-ID: CTANPVQw1sG
2018-04-25 14:51:09 -04:00
Tiberius Oros
2fffa00bb3 Backed out 2 changesets (bug 1450927) for failing on ProxyAccessible.cpp(247) on a CLOSED TREE
Backed out changeset ca285aed3926 (bug 1450927)
Backed out changeset d7dd8b0d2473 (bug 1450927)
2018-04-25 19:31:50 +03:00
Yura Zenevich
db18588465 Bug 1450927 - add getBoundsInCSSPixels XPCOM method. r=surkov r=jld
MozReview-Commit-ID: CTANPVQw1sG
2018-04-25 11:45:47 -04:00
Eitan Isaacson
70e1c57e9b Bug 1454785 - Make TakeFocus user initiated. r=surkov
--HG--
extra : rebase_source : 554b1a7dabcdd3f14e67028ad5effc69dabed4b9
2018-04-23 09:02:00 +03:00