Bug 1286530 made TCPSocket ChromeOnly, eliminating both the
dom.mozTCPSocket.enabled preference check as well as the "tcp-socket"
permission check. The API is now always exposed in chrome contexts.
This patch removes the leftover (and confusing) dead code.
Renamed and why:
- test_tcpsocket_enabled_no_perm.html renamed to
test_tcpsocket_not_exposed_to_content.html because it's now just a
question of content never seeing the API.
Removed tests and why:
- test_tcpsocket_enabled_with_perm.html used to be a standalone
verification of our permission check. We have no permission check
now and both test_tcpsocket_jsm.html and
test_tcpsocket_client_and_server_basics.html serve as tests that we
affirmatively expose the API and there are no "late" failure (such
as a secondary check in the parent).
- test_tcpsocket_default_permissions.html duplicated what (now)
test_tcpsocket_not_exposed_to_content.html accomplishes. It tried to
use the API and expect an exception. This is just superstition in a
WebIDL. (TCPSocket was not originally WebIDL-y.)
--HG--
rename : dom/network/tests/test_tcpsocket_enabled_no_perm.html => dom/network/tests/test_tcpsocket_not_exposed_to_content.html
extra : rebase_source : d2231ed3b0fb00541cc266569c2a7908a4074f9c
The use of add_task.js was ever only intended to be temporary until
bug 1078657 landed.
--HG--
extra : rebase_source : d9570859b35691002cf7f4642603f6730ddab7ad
Right now SelectHelper and InputWidgetHelper are loaded in browser.js,
which means they only work for GeckoApp. This patch loads them in
PromptService.js instead, which means they will work in all windows. The
patch also changes some code in SelectHelper and InputWidgetHelper that
used to assume they are running under the browser.xul chrome window.
MozReview-Commit-ID: HveDzIzK1b4
MozReview-Commit-ID: AmS5oBNV7Po
When creating a new interceptor, we already have the correct target interface.
The interceptor ignores this and does a redundant inter-thread QI to resolve
an interface that we already have!
This patch adds a fast path to interceptor initialization that skips all of that
stuff and directly initializes itself using the given target interceptor.
--HG--
extra : rebase_source : bb017b8098b3d94c453d6be982a205ade36c772d
Two things here:
- The default stack size of the thread pool is not very big, it's better to
stick the buffer we need on the object.
- There was a unit mismatch between bytes and samples. This changes the name to
make the unit more obvious, and fixes its usage by dividing by the sample size.
MozReview-Commit-ID: 19bbS6iGvTw
--HG--
extra : rebase_source : bb5c2c074b8c1c3d69e002c8d82f4f72cc57582d
Removing no-op code.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because no-op code
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: e2ae3b683eefbdb58477d3b696304f0aff7ec6ef
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 68dc02a16c7d9e0cf89f210ccb502dfaef1c709a
When gecko go through the reusing case, the aUseExternalImage isn't set to the correct value. It is always false here.
Then, gecko will use the non-external-image code path later. Add a new data member "mUseExternalImage" to save the previous status.
MozReview-Commit-ID: KvzgIzYXNAB
