Commit Graph

713076 Commits

Author SHA1 Message Date
Olli Pettay
3b7865f462 Bug 1644119 - Pass loadingEntry to the docshell also when load is similar origin, r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D78814
2020-06-12 20:53:11 +00:00
Matt Woodrow
20d25fdc03 Bug 1644945 - Implement a wrapper nsIParentChannel for ParentProcessDocumentChannel so that we can use the same code in DocumentLoadListener. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D79241
2020-06-12 21:03:06 +00:00
Narcis Beleuzu
010f052da8 Bug 1594467 - Fix lint. a=jlast . CLOSED TREE 2020-06-13 00:00:01 +03:00
Kris Maglione
391fb42766 Bug 1644439: Don't force frame loader initialization during reflow from focus manager. r=hsivonen
When trying to get the current focused element during reflow, when the current
focused element in the document is a frame which has yet to be initialized,
attempting to walk through that frame's BrowsingContext causes immediate frame
loader initialization. Since frame loader initialization often requires running
scripts, that's unsafe, which is why we defer initialization until the end of
any in-progress reflow or document update.

This patch fixes the focus manager code to ignore any uninitialized frame
loaders it comes across, since by definition they cannot have any
currently-focused element until their subdocuments have been created.

Differential Revision: https://phabricator.services.mozilla.com/D79392
2020-06-12 10:22:56 +00:00
M. Sirringhaus
97e194bc86 Bug 1644412 - Deactivate peephole optimization on big endian. r=iain
Peephole optimizations are not supported by upstream on big endian and deactivated there as well.
Fixes segfault on startup on s390x.

Differential Revision: https://phabricator.services.mozilla.com/D79039
2020-06-10 12:49:18 +00:00
Emilio Cobos Álvarez
2ecda03866 Bug 1640441 - Don't do fancy floating point precision shenanigans on DOMRect::SetLayoutRect. r=dholbert
There are some issues with this code. It's using doubles, but SetRect
only takes floats, so we lose precision there already. Instead of
getting fancy, use the same conversion that the rest of Gecko uses, so
that pages that compute style values out of getBoundingClientRect values
don't get minor floating point changes.

Differential Revision: https://phabricator.services.mozilla.com/D79326
2020-06-12 18:57:15 +00:00
Marco Zehe
1b32b90556 Bug 1644669 part 2 - Make the flex container view more accessible to screen reader users, r=yzen
This patch does the following:

1. Both the flex-direction and flex-wrap badges are being treated as illustrations, not generic containers, so screen readers immediately pick up the full meaning from the title.
2. Turns the flex item list sub heading into an actual heading for screen readers. It is level 3 because the accordeon headings are all level 2.

Differential Revision: https://phabricator.services.mozilla.com/D79129
2020-06-12 17:39:44 +00:00
Marco Zehe
760479ff25 Bug 1644669 Part 1 - Label the button to return to the flex container view for screen readers, r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D79128
2020-06-12 14:50:30 +00:00
Stepan Stava
7b50798bc1 Bug 1594467 - Add 'Restart frame' r=loganfsmyth
Adds 'Restart frame' context menu item to the Call stack

Differential Revision: https://phabricator.services.mozilla.com/D75620
2020-06-12 18:26:40 +00:00
Mitchell Hentges
bc40ce6513 Bug 1645228: Support topdir in test _populate_context mock r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D79380
2020-06-12 20:09:41 +00:00
Jonathan Kew
4a4f4331c2 Bug 1645482 - Don't leak dwrite font table references after reading font names. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D79534
2020-06-12 19:50:07 +00:00
Mitchell Hentges
d92816473f Bug 1645047: Recommend adding cinnabar to path if not exists r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D79393
2020-06-12 19:43:38 +00:00
Mike Conley
fa1e81542c Bug 1643503 - Make the WebRTC indicator's drag-ability more obvious, and update button styles. r=pbz
This also splits out the indicator theme-ing into an include file, with
platform-specific CSS files that import it. This allows us to do
platform-specific tweaks, such as changing the ordering of the window
controls and drag indicator, which we do on macOS.

Differential Revision: https://phabricator.services.mozilla.com/D79344
2020-06-12 19:09:20 +00:00
Mike Conley
7b3f111c7f Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79343
2020-06-12 18:59:59 +00:00
Mike Conley
09a22f3ca2 Bug 1643503 - Compact the WebRTC global indicator to a height of 32px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79342
2020-06-12 19:00:02 +00:00
Mike Conley
5b3d01aad0 Bug 1643503 - Reduce minimum window dimensions for non-popup windows to 32x32 on macOS. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D79341
2020-06-12 19:00:04 +00:00
R. Martinho Fernandes
96975d5c9b Bug 1286250 - return correct error code for bad AES key length r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D79455
2020-06-12 20:25:35 +00:00
Narcis Beleuzu
a8dde16e58 Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
Narcis Beleuzu
fa98afc362 Backed out 4 changesets (bug 1643503) for bc failures on browser_parsable_css.js . CLOSED TREE
Backed out changeset a890be633ec3 (bug 1643503)
Backed out changeset 1f8dcaafb864 (bug 1643503)
Backed out changeset b28d0c018553 (bug 1643503)
Backed out changeset 1bcaedf06fb9 (bug 1643503)
2020-06-12 21:56:16 +03:00
Jason Laster
d213ae4f61 Bug 1644813 - Remove references to autoBlackbox. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D79167
2020-06-12 18:06:42 +00:00
Olli Pettay
4aaccd7b6e Bug 1645109 - handle the case when contentlist is modified while iterating it, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D79523
2020-06-12 18:04:16 +00:00
Nika Layzell
9c5d47c53f Bug 1508306 - Part 2: Fix Large-Allocation tests for new changes, r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D78999
2020-06-12 16:52:15 +00:00
Nika Layzell
47c0aeb539 Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-12 16:52:13 +00:00
Nika Layzell
161a57fbda Bug 1640019 - Part 8: Remove unnecessary ASSERT_UNLESS_FUZZING when looking up CP, r=mattwoodrow
This assertion would spuriously fire if a content process died after its id was
taken.

Differential Revision: https://phabricator.services.mozilla.com/D78976
2020-06-12 16:52:11 +00:00
Nika Layzell
8119d83e05 Bug 1640019 - Part 7: Remove the unused 'navigateAndRestoreByIndex' method, r=Gijs
This method was used by GroupedSHistory for prerendering, and was missed when we
ripped out the incomplete code.

Differential Revision: https://phabricator.services.mozilla.com/D78975
2020-06-12 16:52:09 +00:00
Nika Layzell
eb18c1a614 Bug 1640019 - Part 6: Get rid of the rebuild_frameloaders pref, r=Gijs
This pref was enabled on all platforms, and the codepath which has it disabled
has been untested for some time. Remove the pref to simplify the code handling
the old case.

Differential Revision: https://phabricator.services.mozilla.com/D78974
2020-06-12 16:52:07 +00:00
Nika Layzell
6069ccac68 Bug 1640019 - Part 5: Remove a number of now-unused 'updateBrowserRemoteness' parameters, r=Gijs
These were only used by process switches triggered via DocumentChannel, which
now take the PROCESS_BEHAVIOR_STANDARD codepath.

Differential Revision: https://phabricator.services.mozilla.com/D78973
2020-06-12 16:52:04 +00:00
Nika Layzell
38d3ef0a32 Bug 1640019 - Part 4: Get rid of PROCESS_BEHAVIOR_CUSTOM, r=mattwoodrow,Gijs,necko-reviewers,valentin
As tabbrowser now uses `PROCESS_BEHAVIOR_STANDARD`, `PROCESS_BEHAVIOR_CUSTOM` is
now unused. This patch removes that now-unused code.

Differential Revision: https://phabricator.services.mozilla.com/D78972
2020-06-12 16:52:02 +00:00
Nika Layzell
a97cf42257 Bug 1640019 - Part 3: Also allow switching between remote and non-remote, r=mattwoodrow,necko-reviewers,valentin
Due to the PPDC process switching changes, we also handle switching between
remote and non-remote browsers with DocumentLoadListener. Adds support to
CanonicalBrowsingContext::ChangeFrameRemoteness to allow it to handle non-remote
browsers as well.

Differential Revision: https://phabricator.services.mozilla.com/D78971
2020-06-12 16:52:01 +00:00
Nika Layzell
aaf6c3a006 Bug 1640019 - Part 2: Use new process switch logic in tabbrowser, r=mattwoodrow,Gijs
Add a series of extra hooks and methods to allow tabbrowser to use the new
process switching codepath. This duplicates some of the logic from
`updateBrowserRemoteness` into event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D78970
2020-06-12 16:52:01 +00:00
Nika Layzell
e999957c00 Bug 1640019 - Part 1: Support toplevel process switches outside of tabbrowser, r=mattwoodrow
This new process switching behavior is only enabled for some browser elements,
which have specified a specific attribute. Turning this on for all browsers with
a `remote` attribute causes breakage in reftests.

The initial version does not handle switching from remote to parent or
vice-versa, that is covered in a later part.

Differential Revision: https://phabricator.services.mozilla.com/D78969
2020-06-12 16:52:00 +00:00
Morgan Reschenberg
10236aef18 Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen
Differential Revision: https://phabricator.services.mozilla.com/D72184
2020-06-12 17:02:45 +00:00
Olli Pettay
2223b8660b Bug 1643677, ensure mServiceNotifier is still there when handling EventSource messages, and add some assertions, r=FarooqAR
Some existing tests crash if we just add the assertions and the rest of the patch
fixes those.

mServiceNotifier is now created always on the main thread and used only on the target thread.
And use of it is protected by the mutex so that at the same time when it is created, target thread
can't try to delete it.

Differential Revision: https://phabricator.services.mozilla.com/D79269
2020-06-12 16:57:48 +00:00
Kartikaya Gupta
8004743db4 Bug 1643884 - Don't run APZCCallbackHelper::NotifyPinchGesture synchronously to avoid re-entrancy in InputQueue::ProcessQueue. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D79459
2020-06-12 16:45:28 +00:00
Emma Malysz
affa2cc671 Bug 1627676: add telemetry probes for downloads panel r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D78709
2020-06-12 17:18:07 +00:00
Agi Sferro
a2f65accfd Bug 1644519 - Wait for permission change to settle in browser_doorhanger_installs.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D79382
2020-06-12 17:13:37 +00:00
Agi Sferro
e97469625b Bug 1644519 - Remove code duplication in browser_doorhanger_installs.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D79381
2020-06-11 23:38:20 +00:00
Yura Zenevich
30512f1f1c Bug 1598026 - only reset panel state on document-ready event of the top level document. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D78595
2020-06-12 17:32:35 +00:00
Yura Zenevich
af845d619c Bug 1598026 - keep track of accessibility walkers to ensure that accessibility events get handled across the whole tree, including the OOP frames. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D78552
2020-06-12 17:32:33 +00:00
Yura Zenevich
ff9694b163 Bug 1643091 - simplify listening to lifecycle events. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D78197
2020-06-12 17:32:26 +00:00
Yura Zenevich
d37e33ce1c Bug 1643086 - clean up reset in MainFrame component. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D78118
2020-06-12 17:32:24 +00:00
Dzmitry Malyshau
8a480da876 Bug 1642495 - Limit WebRender instance buffer sizes r=gw
This is an attempt to improve our relationship with the drivers.
Currently, we work with the instance buffer limit dictated by the macOS drivers.
We can consider lowering it, since it will only make the driver work eaiser.

Differential Revision: https://phabricator.services.mozilla.com/D78164
2020-06-12 16:46:51 +00:00
Brindusan Cristian
bff7221969 Backed out changeset 5200dd8a0de5 (bug 1645328) for cppunit assertion failures at Maybe.h. CLOSED TREE 2020-06-12 20:12:37 +03:00
Tim Huang
16c32eb29a Bug 1587743 - Part 4: Enable test browser_permission_delegate_geo.js in Fission. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79135
2020-06-12 16:32:11 +00:00
Tim Huang
f5adef2650 Bug 1587743 - Part 3: Using WindowContext to test delegated permissions. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79134
2020-06-12 16:32:03 +00:00
Tim Huang
8422436b6c Bug 1587743 - Part 2: Removing mTopLevelPrincipal from the PermissionDelegateHandler. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D79133
2020-06-12 16:31:56 +00:00
Tim Huang
eab7aa2b87 Bug 1587743 - Part 1: Pre-compute the delegated permissions for the top-level content and store it in the WindowContext. r=baku,nika
In order to delegate the permission to the top-level window, in this
patch, we pre-compute the permissions of the top-level context and set
them to the top-level WindowContext. So, the cross-origin iframe can
know the permission of the top-level window through the WindowContext.
Thus, the permission can be delegated in Fission.

Differential Revision: https://phabricator.services.mozilla.com/D79132
2020-06-12 16:31:49 +00:00
Mike Conley
300d6ff764 Bug 1643503 - Make the WebRTC indicator's drag-ability more obvious, and update button styles. r=pbz
This also splits out the indicator theme-ing into an include file, with
platform-specific CSS files that import it. This allows us to do
platform-specific tweaks, such as changing the ordering of the window
controls and drag indicator, which we do on macOS.

Differential Revision: https://phabricator.services.mozilla.com/D79344
2020-06-12 16:18:15 +00:00
Mike Conley
5c002a5922 Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79343
2020-06-12 15:39:01 +00:00
Mike Conley
5a093a8f0c Bug 1643503 - Compact the WebRTC global indicator to a height of 32px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79342
2020-06-12 15:35:09 +00:00