Re: Small usage simplification for Rhino
Date:
Tue, 23 Jan 2001 16:01:42 +0100
From:
Igor Bukanov <igor@icesoft.no>
To:
Norris Boyd <nboyd@atg.com>
References:
1 , 2 , 3 , 4
Norris Boyd wrote:
> Thanks. I've patched in your changes and checked it into CVS.
I also looked at other places with similar pattern of few lines of
common code to construct error messages. The following was occurred too
often not to avoid temptations to move it to a separated function:
NativeGlobal.constructError(
Context.getContext(), "TypeError",
ScriptRuntime.getMessage1("msg.default.value", arg),
this)
It can be replaced by
NativeGlobal.typeError1("msg.default.value", arg, this)
There are other similar usages but they are not to frequent to bother
with code reduction because even the above replacement saves just 200
bytes in uncompressed jars (it is expensive to introduce new methods in
Java).
In any case, if you think it makes any sense, patches are attached. They
are made via
diff -cbB javascript.orig javascript > patch_context
diff -bB javascript.orig javascript > patch_std
from org/mozilla directory.
Regards, Igor
Subject:
Recent rhino broke security support
Date:
Tue, 23 Jan 2001 08:07:45 -0500
From:
"Kurt Westerfeld" <kurt@managedobjects.com>
To:
"Norris Boyd" <nboyd@atg.com>
Norris.....I like the changes made to FunctionObject to do method invocation
much faster. Very slick.
Problem tho: this mechanism does not veer into the security support plugin
on context for defining a class. This is crucial do creating event adapter
code later in applet environments.
I'm going to look into this, but perhaps you could probably make the changes
faster than I.
Unfortunately for us, we found this problem yesterday at a customer site.
:-( Shame on us.
________________________________________________________________________
Kurt Westerfeld
Senior Software Architect
Managed Objects
mailto:kwester@ManagedObjects.com
703.770.7225
http://www.ManagedObjects.com
Managed Objects: manage technology > rule business
Add regchrome & installed-chrome.txt to unix package list.
Add --flat/-l option to pkgcp.pl so that the intermediate component directory is not created.
Added dist target to xpinstaller/Makefile which will create a tarball using the packages file for a list.
Add BZ2 package type.
Thanks to Ben Bucksch <mozilla@bucksch.org> for the patch.
Bug #53462. r=cls
The individual fixes:
1) A complete QA failure produces a readable email now
2) the nssqa has goes thru a central Exit
3) hanging processes under NT and Win2K are killed (tail -f)
4) Functionallity is implemented to kill other remaining processes (killpif file)
5) improved general cleanup in Exit functions
6) the header is sourced from the nssqa dir rateher than /u/sonmi/bin
7) Problems with QA being reported as passed even if missing fixed
8) Most problems with the "missing Platform list" fixed
9) One QA failure path (cd to a dir without permission) did not give
errormessage about the reason of failure before
10) fixed html errors in generated email
11) stopped filtering the "bad password" cases as real failures (was fixed in
nssqa a while ago, but still filtered
12) removing more tmp files from /tmp (decreased debugging)
