The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
========
cf613656fe
Author: Nick Alexander <nalexander@mozilla.com>
Bug 1022749 - Part 2: Show custom server URLs in status activity.
========
91268a261f
Author: Nick Alexander <nalexander@mozilla.com>
Bug 1022749 - Part 1: Show custom server URLs in setup activities.
========
2582a39b7f
Author: Nick Alexander <nalexander@mozilla.com>
Bug 1022748 - Review comments.
========
8c9a8df84f
Author: Nick Alexander <nalexander@mozilla.com>
Bug 1022748 - Part 4: Don't show Get Started activity when custom server URLs are passed.
The Get Started activity provides no feedback about custom URLs, and it
just gets in the way of power users, so skip it entirely.
========
2701a9ea52
Author: Nick Alexander <nalexander@mozilla.com>
Date: Mon Jun 9 17:25:51 2014 -0700
Bug 1022748 - Part 3: Pass through server details to update credentials activity.
This information can be extracted from the AndroidFxAccount object in
the activity, but feeding the information through extras keeps the
processing and display pipeline uniform across all setup activities.
========
b9dd884764
Author: Nick Alexander <nalexander@mozilla.com>
Date: Mon Jun 9 17:17:57 2014 -0700
Bug 1022748 - Part 2: Use custom server URLs passed through extras in setup activities.
========
be8284ea25
Author: Nick Alexander <nalexander@mozilla.com>
Date: Mon Jun 9 15:06:03 2014 -0700
Bug 1022748 - Part 1: Pass extras through setup activities.
This also passes the password button's show/hide state between create
and set up.
========
872d926e32
Author: Nick Alexander <nalexander@mozilla.com>
Date: Wed Jun 4 14:21:17 2014 -0700
Bug 993134 - Part 5: Work around Android intermittent issue.
========
c76bb53901
Author: Nick Alexander <nalexander@mozilla.com>
Date: Tue Jun 3 17:02:15 2014 -0700
Bug 993134 - Part 4: Make fxa.TestAccountPickler robust.
This tested extracting data from an AndroidFxAccount before, and another
after, backed by different Android Accounts. Unfortunately, one Account
replaced the other, but had the same name, leading to a race
condition (between reading and deleting the first account). To address
this, we extract all the data before deleting, and then compare it to
the data from the newly pickled account.
========
bd32978f7b
Author: Nick Alexander <nalexander@mozilla.com>
Date: Tue Jun 3 15:34:09 2014 -0700
Bug 993134 - Part 3: Use AndroidSyncTestCaseWithAccounts to make fxa.TestAccountPickler when accounts exist.
========
ec7d910187
Author: Nick Alexander <nalexander@mozilla.com>
Date: Tue Jun 3 15:33:29 2014 -0700
Bug 993134 - Part 2: Extract AndroidSyncTestCaseWithAccounts.
========
6563ad7bd8
Author: Nick Alexander <nalexander@mozilla.com>
Date: Tue Jun 3 15:30:15 2014 -0700
Bug 993134 - Part 1: Make getApplicationContext return getTargetContext.
I was finding that repeated instrumentation-test runs were returning a
null application context, indicating a race between test start-up and
target instantiation. This works well for me on two test devices.
