Also remove IsBookmarkedInDatabase(), mItemCount, RecursiveFindRedirectedBookmark(), UpdateKeywordsForRemovedBookmark() from nsNavBookmarks as they aren't used anywhere.
MozReview-Commit-ID: 4cZXAdRuVoF
--HG--
extra : rebase_source : 2c08a09de48cfb06c3e8db261dfe7ea1b1526e10
Optimise adding a folder with child bookmarks for transactions by allowing PlacesTransactions.NewFolder to take children details and use insertTree rather than needing separate NewFolder and then multiple NewBookmark transactions.
MozReview-Commit-ID: 6s9j0pbsiUB
--HG--
extra : rebase_source : 0b4029905dc76a0ca49d16a7e71c85f1f07b8e2d
This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The
places where nsXPIDLStrings are null-checked are replaced with |rv| checks.
The patch also removes a couple of unused declarations from
nsIStringBundle.idl.
Note that nsStringBundle::GetStringFromNameHelper() was merged into
GetStringFromName(), because they both would have had the same signature.
--HG--
extra : rebase_source : ac40bc31c2a4997f2db0bd5069cc008757a2df6d
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
All the SizeOf{In,Ex}cludingThis() functions take a MallocSizeOf function
which measures memory blocks. This patch introduces a new type, SizeOfState,
which includes a MallocSizeOf function *and* a table of already-measured
pointers, called SeenPtrs. This gives us a general mechanism to measure
graph-like data structures, by recording which nodes have already been
measured. (This approach is used in a number of existing reporters, but not in
a uniform fashion.)
The patch also converts the window memory reporting to use SizeOfState in a lot
of places, all the way through to the measurement of Elements. This is a
precursor for bug 1383977 which will measure Stylo elements, which involve
Arcs.
The patch also converts the existing mAlreadyMeasuredOrphanTrees table in the
OrphanReporter to use the new mechanism.
--HG--
extra : rebase_source : 2c23285f8b6c3b667560a9d14014efc4633aed51
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.
I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.
MozReview-Commit-ID: Gq16sNm7K2e
--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.
MozReview-Commit-ID: 6s78RvPFMzv
--HG--
extra : rebase_source : 009ea39eb4dac1c927aa03e4f97d8ab673de8a0e
Allows to set browser.urlbar.maxHistoricalSearchSuggestions to fetch a given number of
historical search suggestions.
Allots to set browser.urlbar.matchBuckets to change the location bar mixup of results.
The system is based on an array of buckets, each bucket is an array containing the type
of the match accepted by the bucket (MATCHTYPE) and the number of available slots in the bucket.
At every new match insertion, addMatch() loops all the buckets to find the first
compatible and available slot.
Note that the pref format may change in the future, we plan to add an id to each bucket and
frecency may change from an absolute to a relative value.
MozReview-Commit-ID: 5j7esakF5bu
--HG--
extra : rebase_source : e6470d1fe0015664935628bef069a7684052c0d5
