XPCOM's string API doesn't have the notion of a "null string". But it does have
the notion of a "void string" (or "voided string"), and that's what these
functions are returning. So the names should reflect that.
--HG--
extra : rebase_source : 4e3f982e0873877174a08a25413595ff66f7d20e
QuotaManager is now a hip, popular subsystem used by many consumers, many of
which are now latency sensitive. There is no longer any meaningful benefit to
using LazyIdleThread, but there are latency downsides. Also, LazyIdleThread
has some bugs at shutdown and complications for callers that use
NS_GetCurrentThread(). So, begone LazyIdleThread!
--HG--
extra : rebase_source : d6f3c1835bf2ef386b8bb4d24678b3610988282c
Also, one unused include of nsIProgrammingLanguage, which is unrelated.
MozReview-Commit-ID: LJf2NSwmaYG
--HG--
extra : rebase_source : 63dfca9185535dbfa695cf2f383d81a14ce423c0
This patch makes the following changes to the macros.
- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
mostly misused.
- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
universally available now anyway.
- Combines the first two string literal arguments of PROFILER_LABEL and
PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
them to be separate, and it forced a '::' in the label, which isn't always
appropriate. Also, the meaning of the "name_space" argument was interpreted
in an interesting variety of ways.
- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
it clearer they construct RAII objects rather than just being function calls.
(I myself have screwed up the scoping because of this in the past.)
- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
the caller doesn't need to. This makes a *lot* more of the uses fit onto a
single line.
The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).
- Fixes a bunch of labels that had gotten out of sync with the name of the
class and/or function that encloses them.
- Removes a useless PROFILER_LABEL use within a trivial scope in
EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
a good idea.
- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
done within them, instead of at their callsites, because that's a more
standard way of doing things.
--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
The UpgradeSchemaFrom17_0To18_0Helper class is never instantiated, so its constructor and destructor don't need to be define.
dom/base/nsContentUtils.cpp:529:21 [-Wunused-member-function] unused member function 'GetResult'
dom/indexedDB/ActorsParent.cpp:2715:3 [-Wunused-member-function] unused member function 'UpgradeSchemaFrom17_0To18_0Helper'
dom/indexedDB/ActorsParent.cpp:2720:3 [-Wunused-member-function] unused member function '~UpgradeSchemaFrom17_0To18_0Helper'
dom/indexedDB/ActorsParent.cpp:6464:3 [-Wunused-member-function] unused member function 'GetPrincipalInfo'
dom/indexedDB/ActorsParent.cpp:6545:3 [-Wunused-member-function] unused member function 'ReleaseTransactionThreadObjects'
dom/indexedDB/ActorsParent.cpp:6548:3 [-Wunused-member-function] unused member function 'ReleaseBackgroundThreadObjects'
dom/indexedDB/ActorsParent.cpp:7710:3 [-Wunused-member-function] unused member function 'operator<'
dom/indexedDB/ActorsParent.cpp:7753:3 [-Wunused-member-function] unused member function 'IsOtherProcessActor'
dom/quota/ActorsParent.cpp:809:3 [-Wunused-member-function] unused member function 'GetState'
dom/quota/StorageManager.cpp:76:3 [-Wunused-member-function] unused member function 'GetType'
MozReview-Commit-ID: FbfMj2YJ4Fx
--HG--
extra : source : a38727295681d5368ed05a1b2758599f4debc424
extra : intermediate-source : 2010739762c276b15d8431d2df4725fb8281d549
extra : histedit_source : e9e4eb1c7d7813c6dda7ded023de4bd6e7b4b52a
For the Quatum DOM project, it's better to work in terms of event targets than
threads. This patch converts DOM code to operate on event targets rather than
threads, when possible.
MozReview-Commit-ID: 5FgvpKadUA2
This function is arguably nicer than calling NS_ProcessNextEvent
manually, is slightly more efficient, and will enable better auditing
for NS_ProcessNextEvent when we do Quantum DOM scheduling changes.
This makes most users of |NS_EscapeURL| use the fallible version. A few are
left infallible as it seems like the entire function is assumed to be
infallible.
MozReview-Commit-ID: Cy1L5jQwjO1
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.
MozReview-Commit-ID: AzVbApxFGZ0
The patch is generated from following command:
rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,
MozReview-Commit-ID: AtLcWApZfES
--HG--
rename : mfbt/unused.h => mfbt/Unused.h
This makes a lot of code more compact, and also avoids some redundant nsresult
checks.
The patch also removes a handful of redundant checks on infallible setters.
--HG--
extra : rebase_source : f82426e7584d0d5cddf7c2524356f0f318fbea7d
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
This change renames OriginAttributes.mInBrowser to mInIsolatedMozBrowser and
nsIPrincipal::GetIsInBrowserElement to GetIsInIsolatedMozBrowserElement. Other
methods that pass these values around also have name changes.
Tokens such as "inBrowser" have previously been serialized into cache keys, used
as DB column names, stored in app registries, etc. No changes are made to any
serialization formats. Only runtime method and variable names are updated.
No behavior changes are made in this patch, so some renamed methods may have
nonsensical implementations. These are corrected in subsequent patches
focused on behavior.
MozReview-Commit-ID: 66HfMlsXFLs
