To prevent code duplication each of the user prompt tests can
be parametrized for "alert", "confirm", and "prompt".
MozReview-Commit-ID: DtA5bKmfljt
--HG--
extra : rebase_source : 2c92596f642a65c031c39842db6f6b66f37eb58a
Both the 'create_dialog' and 'assert_dialog_handled' methods
should make use of publicly available wdclient commands, and
not send custom messages, or even use transport class methods.
MozReview-Commit-ID: 5QrznRN6qgq
--HG--
extra : rebase_source : 2492716e350f83812202eed94eb4bad0afa3295a
Increasing geckodriver's Keep-Alive timeout duration to 90
seconds, from the default five seconds, will reduce the number of
HTTP connections a persistent-enabled client will have to make,
potentially boosting performance.
In more recent hyper versions the default is 90 seconds, which
means we can get rid of this line when hyper is upgraded.
This will help mitigate https://github.com/mozilla/geckodriver/issues/1304
but not fundamentally resolve it, due to a standard library bug in
Python 2.7's urllib.
MozReview-Commit-ID: 98AFDQgWfpw
--HG--
extra : rebase_source : 75ce5a143533134b60848f2351aab60778c53d78
This allows us to call emplace_back, saving us a move.
MozReview-Commit-ID: 4wRiAxl7LSN
--HG--
extra : rebase_source : 48a0eee8f61f568e0910476dbf672cb43827187e
In l10n repacks we run the repackage multiple times, once for each locale. If something low level fails (like compare-locales) we'll abort out and call _add_failure (from _map) which then will set the return code based on the type of failure.
However it, by default, will increment the return code each time it is called in BaseScript, so to preserve expectations here we should disable that from desktop_l10n.py
Differential Revision: https://phabricator.services.mozilla.com/D1971
--HG--
extra : moz-landing-system : lando
In order to do that, we pass an onCmdCtrlClick to the ObjectInspector.
We also extract the dispatching of the SHOW_OBJECT_IN_SIDEBAR action to
its own function so it can be called directly with a grip.
browser_webconsole_object_in_sidebar is renamed and repurposed to test
this specific behavior, since there's already a test checking the context
menu way (browser_webconsole_context_menu_object_in_sidebar.js).
MozReview-Commit-ID: GCF1wFPWTH
--HG--
rename : devtools/client/webconsole/test/mochitest/browser_webconsole_object_in_sidebar.js => devtools/client/webconsole/test/mochitest/browser_webconsole_object_ctrl_click.js
extra : rebase_source : ad40ffb48695e3156a5730a5a41c1e8d9cb73b88
This test is directly calling Autocomplete popup methods and only uses the
console for the instance and the input it provides. This patch moves the
test to the shared component folder, where the autocompletion code lives
so it feels more natural.
A few test cases are added in the jsterm_accessibility test, this time in
direct relation with the console input.
MozReview-Commit-ID: Ih7rOJ3vHpb
--HG--
rename : devtools/client/webconsole/test/mochitest/browser_jsterm_popup.js => devtools/client/shared/test/browser_autocomplete_popup.js
extra : rebase_source : 148e7d3d9ac69a40facc428c1201a9aa52eeda29
extra : source : b8b912f1999018c8f1677299d7180d3a03bcb2d7
Notice as TimeStamp is not an integral type, it can't be wrapped by
mozilla::Atomic. However, we wrap it in MainThreadData to assure it only
is accessed from the main thread.
Another issue is that TimeStamp class does allow some operations on a
Null value, with assertions on debug builds.
MozReview-Commit-ID: 9GPNDUooQmI
--HG--
extra : rebase_source : e2b5fe81a4c5c696425583a04395f2ae79aeaccc
window.event is set on the wrong window when the target and the
callback are from different realms and the callback is an XPCOM
callback.
MozReview-Commit-ID: HXeUIicdMuT
--HG--
extra : rebase_source : 978a3fecf87e1ac4414ec0ea93335796bc24951a
The new pref is "network.dns.resolver-thread-extra-idle-time-seconds"
The default is 60 seconds. This means that threads will stay idle for an extra 60 seconds, after which they are shutdown.
Setting the pref to 0 would preserve the behaviour before the threads were swiched to use nsThreadPool - meaning that they would be shutdown immediately after ThreadFunc completes.
Setting the pref to -1 would keep the threads alive forever.
MozReview-Commit-ID: CoUB5gan4MR
--HG--
extra : rebase_source : 7b444789eebaf43c939ce9d7153218c4cd594b65
Instead of creating and deleteing each thread, we use a nsThreadPool with a max of 8 resolver threads.
Whereas before each thread would run ThreadFunc exactly once then shut down, the threads may now remain active for a while. During this time we may post another task(runnable) to the thread.
MozReview-Commit-ID: FiE370ic1ah
--HG--
extra : rebase_source : 065bbf1f9867dfb38ac7b13816d4d06824d3a05d
This reduced the additional string duplication that we currently do every time
we add a preference observer.
It changes the string that we store in the observer objects to be absolute,
rather than relative to the branch, but keeps the semantics the same, by
resolving the full preference name in the places we were previously matching
by relative string.
This actually has the effect of simplifying a lot of code, since the absolute
preference name is usually what we want.
MozReview-Commit-ID: 10WjHb0tNGB
--HG--
extra : rebase_source : b3cb0ba103fc239e42459e77cd389db0b5ecde18
Most preference callbacks use literal strings for their domain filters, which
means that there's no need to make copies of them at all. Currently, however,
every preference observer node makes a separate heap-allocated copy of its
domain string.
This patch switches the domain string storage to nsCString instances, which
dramatically reduces the amount of unnecessary copies, at the expense of
making the callback nodes slightly larger.
MozReview-Commit-ID: 8NA3t2JS2UI
--HG--
extra : rebase_source : 628ad9af65cec16fb8be0c8dddc608b5ee5602e2
