Commit Graph

749731 Commits

Author SHA1 Message Date
Brindusan Cristian
442d9401c1 Backed out changeset 7c3c130fc7df (bug 1688703) for bc leaks. CLOSED TREE 2021-03-20 03:59:04 +02:00
Brindusan Cristian
a831a71a2c Backed out changeset c83b1889124d (bug 1699777) for wine bustages. CLOSED TREE 2021-03-20 03:43:46 +02:00
Emilio Cobos Alvarez
d1e5b2d2ed Bug 1699682 - Consistently initialize UI state to hide focusrings by default. r=mhowell
UIS_INITIALIZE does something like setting the flag if the last input event was
a mouse event or clearing it if it was a keyboard event. Unfortunately, if this
is initialized to always show focus rings we start always showing outlines for
all content, all the time, which is both undesired and confusing.

It's also not clear from the docs _which_ event it looks at specially at
startup, but anyhow the result we get is clearly flaky, from my testing.

Explicitly clear the flag. It's not clear to me if other applications can cause
the state to change... but otherwise maybe we can just remove the code dealing
with these flags?

Differential Revision: https://phabricator.services.mozilla.com/D109086
2021-03-20 01:28:20 +00:00
Emilio Cobos Álvarez
423e4b6902 Bug 1699777 - Update wine. r=glandium
Wine 6.0 fixes this locally.

 https://treeherder.mozilla.org/jobs?repo=try&revision=d298c6976323480b44fc8bb5fccbc13fff08d780

Differential Revision: https://phabricator.services.mozilla.com/D109167
2021-03-20 01:25:21 +00:00
Kagami Sascha Rosylight
bf334c85a9 Bug 1672141 - Part 2: Remove fails_with_native_injection flag from test_wpt_touch_action r=edgar
This test synthesizes touch input only in continuous way via dragging functions, so theoretically it should never trigger InjectTouchInput() 100ms timeout issue.

Depends on D109158

Differential Revision: https://phabricator.services.mozilla.com/D109159
2021-03-20 00:16:26 +00:00
Kagami Sascha Rosylight
6f1f65561f Bug 1672141 - Part 1: Use promiseNativePointerDrag in touch action helpers r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D109158
2021-03-20 00:16:26 +00:00
Alexandru Michis
c3da6488ee Backed out changeset f588378316fd (bug 1699259) for causing mochitest failures in test_focusrings.xhtml
CLOSED TREE
2021-03-20 03:10:02 +02:00
Gijs Kruitbosch
de70de9765 Bug 1699578 - adjust positioning of Windows 10 submenu arrow and checkmark as well as item height, r=jaws
This commit:

- reduces the extra height on checkbox/radio items and iconified items.
  This was caused by -moz-appearance for the icon items, and by the
  fixed height of menu-iconic-left for the checkbox/radio items.
- moves the submenu arrow left so the bounding box of the icon aligns
  with the separator ends
- moves the checkmark right based on the spec (12/8 spacing instead of
  10/10).

Differential Revision: https://phabricator.services.mozilla.com/D109014
2021-03-20 00:07:49 +00:00
Daniel Holbert
9df46f429e Bug 1699853: Use "InProcess" version of GetCrossDocParentFrame() in DOMIntersectionObserver.cpp. r=emilio
This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)

We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.

These two callsites in DOMIntersectionObserver.cpp are part of an algorithm
that was already modernized to work with fission in bug 1599795.  In a
fission-enabled scenario: when we end up with null `containerFrame` due to
hitting an oop-iframe boundary, we should end up handling things properly via
our subsequent application of the passed-in `aRemoteDocumentVisibleRect` arg.

Differential Revision: https://phabricator.services.mozilla.com/D109169
2021-03-19 23:58:30 +00:00
Edgar Chen
7cc94abb58 Bug 1694674 - Unify nsXULElement::RegUnRegAccessKey and nsGenericHTMLElement::RegUnregAccessKey; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D109087
2021-03-19 23:26:21 +00:00
Alexandru Michis
ddfba392b6 Backed out 3 changesets (bug 1616700) for causing failures in browser_privatebrowsing_about.js
Backed out changeset 5e1b8f75fef5 (bug 1616700)
Backed out changeset fdf97a561019 (bug 1616700)
Backed out changeset de3717cc63ef (bug 1616700)
2021-03-20 01:23:39 +02:00
Edgar Chen
58408449f9 Bug 1699635 - Part 3: Cleanup IsAccessKeyTarget in EventStateManager.cpp; r=masayuki
1. Use Element as argument as we always pass Element.
2. Get frame from the Element argument.

Differential Revision: https://phabricator.services.mozilla.com/D109042
2021-03-19 23:21:22 +00:00
Edgar Chen
4ddbc4b626 Bug 1699635 - Part 2: Use Element for EventStateManager::mAccessKeys; r=masayuki
As we always add Element into the array

Differential Revision: https://phabricator.services.mozilla.com/D109041
2021-03-19 23:21:22 +00:00
Edgar Chen
5cb610c73f Bug 1699635 - Part 1: Rename EventStateManager::GetFocusedContent to GetFocusedElement; r=masayuki
And make it return Element*

Differential Revision: https://phabricator.services.mozilla.com/D109040
2021-03-19 23:21:21 +00:00
Emilio Cobos Álvarez
9d854aa834 Bug 1699259 - Add a ChromeOnly FocusOptions.preventFocusRing to opt out of focus ring heuristics. r=edgar,Gijs
This seems easier than making those heuristics work across processes
somehow.

Differential Revision: https://phabricator.services.mozilla.com/D108931
2021-03-19 23:10:35 +00:00
Dave Hunt
45ce828ce6 Bug 1677125 - Schedule live desktop page loads r=perftest-reviewers,sparky
Schedule live desktop page load for all recorded sites. Also provide fission variants for all browsertime desktop tests running on webrender platforms and moved sheriffed live page load tests into a separate job.

Differential Revision: https://phabricator.services.mozilla.com/D108959
2021-03-19 22:17:10 +00:00
Daniel Holbert
714c3178d4 Bug 1699810: Use "InProcess" version of GetCrossDocParentFrame() in nsPresContext.cpp. r=tnikkel
This patch doesn't change behavior; it's just switching us between two
functions that do the same thing. (One is literally a trivial wrapper for the
other.)

We're using the new "InProcess" version of this API as a way of annotating
callsites that have been vetted as behaving properly in out-of-process iframes.

This callsite in nsPresContext.cpp is for some invalidation logic that we only
need to perform when the outer and inner document are part of the same display
list (i.e. part of the same process), as discussed in the adjacent
code-comment.  It behaves just fine (doing nothing) if GetCrossDocParentFrame()
fails due to being in an out-of-process iframe.

Differential Revision: https://phabricator.services.mozilla.com/D109145
2021-03-19 22:07:13 +00:00
Mike Kaply
23ab045c93 Bug 1691551 - Add enterprise policy for showing the home button. r=emalysz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D108963
2021-03-19 22:07:05 +00:00
Daniel Holbert
57a889a9d6 Bug 1674823: Adjust crashtest 370174-4.html to have an upper-bound on how many times its setInterval can fire. r=emilio
This test doesn't use "reftest-wait", so really, we should be able to load it
and move on without even caring about its setInterval.  But occasionally we get
unlucky and see a still-pending paint (caused by the setInterval) every time we
make a decision about whether the test is done or not.  Let's avoid this issue
by just setting an upper-bound of 10 iterations on the number of times we'll
let the setInterval fire.

Differential Revision: https://phabricator.services.mozilla.com/D109153
2021-03-19 22:06:50 +00:00
Tom Schuster
b8fe9a39dc Bug 1699823 - Fix assertRejects call on Beta/Release. r=robwu DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D109157
2021-03-19 22:03:07 +00:00
Dana Keeler
047c44bdd9 Bug 1688703 - reuse certviewer utility files in devtools r=johannh,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D106340
2021-03-19 21:44:16 +00:00
Harry Twyford
8355d18946 Bug 1616700 - Part 3 - Update the placeholder string on the handoff input to read "Search with {engine} or enter address" r=fluent-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108266
2021-03-19 21:31:13 +00:00
Harry Twyford
fcb20aa58c Bug 1616700 - Part 2 - Apply a disabled appearance to the handed-off input rather than hiding it. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108826
2021-03-19 21:31:13 +00:00
Harry Twyford
5808a2b7b2 Bug 1616700 - Part 1 - Use default address bar search mode for new tab search handoff r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108825
2021-03-19 21:31:12 +00:00
Bob Owen
682d7c9cc0 Bug 1699802: Add the CanvasWorkers to the Firefox Graphics profiler presets. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D109141
2021-03-19 20:53:16 +00:00
Sean Feng
dff0c3d7c5 Bug 1699780 - Add the missing type name for MouseUpFollowedByClick payload r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D109101
2021-03-19 20:40:24 +00:00
Scott
fc1515023f Bug 1699516 - Change Pocket main.js file name to pktUI.js r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D109096
2021-03-19 20:18:15 +00:00
Sebastian Hengst
698f99e9cc Bug 1699758 - adjust expectation for new test windowproxy-define-own-property-unforgeable-same-origin.html as having unexpected passes on release and beta. r=mccr8 DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D109136
2021-03-19 20:12:50 +00:00
Jonathan Kew
2decdf11e0 Bug 1699329 - Add Hiragino fallbacks to font.name-list.monospace.ja, for cases where Osaka is not installed. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D108936
2021-03-19 19:28:09 +00:00
Valentin Gosu
b3b6a9b1d0 Bug 1658278 - Fix test_httpssvc_iphint.js - do not set trr.mode before test a=testonly
Differential Revision: https://phabricator.services.mozilla.com/D109118
2021-03-19 19:24:41 +00:00
Tom Ritter
d68a653330 Bug 1691975: Take into account that the vendoring directory may be different from the moz.yaml directory r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104791
2021-03-19 19:23:06 +00:00
Tom Ritter
c781fce5dd Bug 1691975: Wire up removing files from moz.build files r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104758
2021-03-19 19:23:06 +00:00
Tom Ritter
51f7eb3ae9 Bug 1691975: Add logic to remove a file from a moz.build file r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104757
2021-03-19 19:23:05 +00:00
Tom Ritter
c459ca2966 Bug 1691975: Integrate the new code into ./mach vendor r=firefox-build-system-reviewers,mhentges
This does not address files that should be removed from the moz.build file

Differential Revision: https://phabricator.services.mozilla.com/D104756
2021-03-19 19:23:05 +00:00
Tom Ritter
015084cc33 Bug 1691975: Extend the algorithm to actually rewrite the moz.build file r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104755
2021-03-19 19:23:04 +00:00
Tom Ritter
b4a8c15931 Bug 1691975: Logic for editing moz.build files r=firefox-build-system-reviewers,mhentges
This commit adds the core algorithm for editing moz.build files, tests for a few
pieces of it, and the code to manually run the algorithm over the gecko codebase
and see dynamically how well it performs at trying to assigning existing source
files back into their original locations.

Differential Revision: https://phabricator.services.mozilla.com/D104754
2021-03-19 19:23:04 +00:00
Tom Ritter
c89fd6a83d Bug 1691975: Undo autovendored sources from libdav1d r=mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104753
2021-03-19 19:23:03 +00:00
Andreas Pehrson
70f6748e8f Bug 1696794 - Drain all full pages in OggWriter::GetContainerData. r=bryce
With bug 1464268 and friends the ContainerWriters starting being called once per
second to get written data out. OggWriter was only able to handle getting one
page out per call, so if we had written N pages to OggWriter while processing a
second worth of data, it'd still have N-1 pages in a buffer. That led to
MediaRecorder writing much too short files when recording audio/ogg.

This patch fixes this properly in OggWriter by extracting all available pages in
GetContainerData().

Differential Revision: https://phabricator.services.mozilla.com/D109029
2021-03-19 19:16:58 +00:00
Andreas Pehrson
545b469340 Bug 1696794 - Add gtest. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D109028
2021-03-19 19:16:57 +00:00
Lee Salzman
d09a7fe1d0 Bug 1698009 - Avoid negative Y values in brush_yuv_image that can break blending in SWGL. r=jrmuizel
The line occurs due to the use of clip-masking creating a tile boundary. The SWGL YUV fast-path uses
saturated math and clamping to adequately deal with this issue, but when we fall off the fast-path
at the boundary, the main shader itself does not do any such clamping. When the generated negative
RGB values hit the blend stage and it tries to clip-mask it, it generates a bogus result.

To avoid this, it is sufficient to ensure that we clamp the Y value to be positive, if there is an
invalid Y value inside the headroom of the encoding space. This should only add a single SIMD
instruction to the alpha-pass variant without negatively impacting the other variants.

Differential Revision: https://phabricator.services.mozilla.com/D108983
2021-03-19 19:14:53 +00:00
Lee Salzman
f3478ec9c5 Bug 1694721 - Check for valid FB before drawing in SWGL. r=jrmuizel
There are some theoretical cases where the FB state might get a bit tortured
and we might encounter some invalid FB state while drawing. This adds some
extra validation just to be safe.

Differential Revision: https://phabricator.services.mozilla.com/D108988
2021-03-19 19:14:11 +00:00
Mike Conley
cbe68c948b Bug 1699550 - Apply a 0.7 opacity to checkboxes in permission panels when Proton is enabled. r=harry,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D109074
2021-03-19 19:14:10 +00:00
Tom Ritter
09a3343784 Bug 1695311: If Updatebot tasks are present, enforce certain values in the moz.yaml schema r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D106659
2021-03-19 19:02:34 +00:00
Mark Banner
e8d532d179 Bug 1699747 - Clean up old references to nsIDocShellLoadInfo. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D109095
2021-03-19 18:38:32 +00:00
Andrew McCreight
77cb6426d5 Bug 1699784 - Fix two 'outselves' typos. r=smaug DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D109106
2021-03-19 18:32:09 +00:00
Molly Howell
c25fad5446 Bug 1695783 - Update copy for app menu notifcations relating to app update. r=mconley,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D108891
2021-03-19 18:19:56 +00:00
Tim Nguyen
846814feae Bug 1699677 - Shift .tab-icon-overlay for non-proton PiP mode. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D109100
2021-03-19 17:57:15 +00:00
Valentin Gosu
166fcff1ca Bug 1658278 - Add test for multiple failures triggering confirmation r=necko-reviewers,dragana,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D109001
2021-03-19 17:51:28 +00:00
Valentin Gosu
7996cfd62e Bug 1658278 - Make TRRServer.registerDoHAnswers easier to extend r=necko-reviewers,dragana,nhnt11
We now pass a map object instead multiple arguments.
This way if we need to add/remove/change something we don't need to worry
about backwards compatibility and having to change all the callsites as
we do in this patch :)

Differential Revision: https://phabricator.services.mozilla.com/D109000
2021-03-19 17:51:27 +00:00
Valentin Gosu
45d5e3c349 Bug 1658278 - Add TRR confirmation test r=necko-reviewers,dragana,nhnt11
Also adds nsIDNSService.currentTrrConfirmationState IDL method for test use

Differential Revision: https://phabricator.services.mozilla.com/D108999
2021-03-19 17:51:27 +00:00