Commit Graph

675469 Commits

Author SHA1 Message Date
Julian Descottes
459b71deed Bug 1589087 - Update regular expression used in ADB to extract Fenix version r=ladybenko
The format of the Fenix versionName on Nightly no longer matches our regular expression.
Updating the regular expression to accommodate both versions such as "2.1.0" and "Nightly 191016 06:01"

Differential Revision: https://phabricator.services.mozilla.com/D49428

--HG--
extra : moz-landing-system : lando
2019-10-17 09:08:44 +00:00
Sebastian Hengst
980ba2bfa5 No bug - fix a comment typo. CLOSED TREE
--HG--
extra : rebase_source : 34090c21576d5244dd000103b442be87c552bbca
extra : amend_source : 05b5993ca400c072b516b5aa8233228cc1a5f9e5
2019-10-17 10:05:59 +02:00
Bogdan Tara
7e9efc5de3 Backed out changeset 29bc3ebe8b4e (bug 1588997) for browser_ext_devtools_panels_elements_sidebar.js && browser_ext_find.js failures CLOSED TREE
--HG--
rename : devtools/shared/fronts/environment.js => devtools/shared/client/environment-client.js
rename : devtools/shared/fronts/property-iterator.js => devtools/shared/client/property-iterator-client.js
rename : devtools/shared/fronts/symbol-iterator.js => devtools/shared/client/symbol-iterator-client.js
2019-10-17 10:51:19 +03:00
Marian Raiciof
3825075bc6 Bug 1567122 - Enable Fission for AWSY. r=perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D48660

--HG--
extra : moz-landing-system : lando
2019-10-16 21:14:33 +00:00
DimiDL
39ce8c862e Bug 1584931 - Replace ContentTask.spawn with SpecialPowers.spawn for flash blocking testcases. r=gcp
To make us pass flash blocking testcases when fission is enabled, we should use
SpecialPowers.spawn instead of ContentTask.spawn because the iframes in the testcases
may be cross-origin iframes.

Differential Revision: https://phabricator.services.mozilla.com/D49388

--HG--
extra : moz-landing-system : lando
2019-10-16 07:38:34 +00:00
Tim Nguyen
b9f098544d Bug 1589188 - Reintroduce '.textbox-contextmenu:-moz-locale-dir(rtl)' rule. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D49493

--HG--
extra : moz-landing-system : lando
2019-10-16 22:12:42 +00:00
jaril
e1c2cd6db5 Bug 1588997 - Convert ObjectClient to protocol.js front. r=nchevobbe.
- Converted the ObjectClient into an protocoljs Front
- Converted the SymbolIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the PropertyIteratorClient into a protocoljs Front and moved it to devtools/shared/fronts
- Converted the EnvironmentClient into a protocoljs Front and moved it to devtools/shared/fronts
- Modified calls to `DebuggerClient.release()` so that it tries to call the ObjectFront's release method first, and falls back on `DebuggerClient.release()` if there's no object front
- Changed reps so that it instantiates only one ObjectClient per grip
- Changed tests so that they expect what the Front's request method resolves to where applicable (i.e. ObjectFront.allocationStack resolves to allocationStack, not a packet object with an allocationStack property)
- Changed callbacks provided to ObjectClient methods to be chained to the ObjectFront methods (e.g. ObjectClient.getScope(callback) changed to ObjectFront.getScope().callback())
- Changed tests to use async/await (test_framebindings-x.js, test_functiongrips-x.js, test_objectgrips-x.js)
- Changed tests to expect protocoljs to throw an error string instead of an error object (test_objectgrips-fn-apply-03.js, test_threadlifetime-02.js, test_pauselifetime-03.js)

Differential Revision: https://phabricator.services.mozilla.com/D48182

--HG--
rename : devtools/shared/client/environment-client.js => devtools/shared/fronts/environment.js
rename : devtools/shared/client/property-iterator-client.js => devtools/shared/fronts/property-iterator.js
rename : devtools/shared/client/symbol-iterator-client.js => devtools/shared/fronts/symbol-iterator.js
extra : moz-landing-system : lando
2019-10-16 17:09:35 +00:00
David Walsh
34cd114993 Bug 1576145 - Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D45248

--HG--
extra : moz-landing-system : lando
2019-10-17 02:04:45 +00:00
Daisuke Akatsuka
1cfc17bb27 Bug 1588961: Add a test for the event that the selected node is changed. r=rcaliman
Depends on D49377

Differential Revision: https://phabricator.services.mozilla.com/D49378

--HG--
extra : moz-landing-system : lando
2019-10-17 01:30:56 +00:00
Daisuke Akatsuka
0e91f94568 Bug 1588961: Update the content when the selected node is changed. r=rcaliman
Depends on D49256

Differential Revision: https://phabricator.services.mozilla.com/D49377

--HG--
extra : moz-landing-system : lando
2019-10-16 14:34:26 +00:00
Miriam
b43fd031d9 Bug 1582304: Ensure you can add a watchpoint to property within a bucket, prototype, or default properties.
Differential Revision: https://phabricator.services.mozilla.com/D49496

--HG--
extra : moz-landing-system : lando
2019-10-17 00:45:31 +00:00
Emilio Cobos Álvarez
6752dad196 Bug 1548718 - Support multiple parts in ::part() selectors. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D48753

--HG--
extra : moz-landing-system : lando
2019-10-17 00:51:54 +00:00
Srujana Peddinti
e41bc4753a Bug 1570009 - Part 3 : Added GPU Process testing to the framework. r=bobowen
Adds support for creating and using a PSandboxTesting actor in the GPU process.

Differential Revision: https://phabricator.services.mozilla.com/D42386

--HG--
extra : moz-landing-system : lando
2019-10-14 15:26:47 +00:00
Srujana Peddinti
847842be97 Bug 1570009 - Part 2 : Added Content Process testing to the framework. r=bobowen
Adds the ability to create and run sandbox tests in a content process.

Differential Revision: https://phabricator.services.mozilla.com/D37913

--HG--
extra : moz-landing-system : lando
2019-10-14 15:08:47 +00:00
Srujana Peddinti
51255aa5b8 Bug 1570009 - Part 1: Create a top-level actor in child processes capable of testing the sandbox. r=bobowen,dmajor
This patch includes a new browser chrome mochitest that uses a new XPCOM service (moxISandboxTest) to create a new top-level actor (PSandboxTesting) between the chrome process and any supported child processes (in later parts of this patch set). The framework is makes it easy to add new C/C++ instructions to be tested for permission under real sandbox conditions. Test results can be conditioned on the type of OS, process, sandbox level, etc.

Differential Revision: https://phabricator.services.mozilla.com/D37706

--HG--
extra : moz-landing-system : lando
2019-10-15 07:19:54 +00:00
Daosheng Mu
364240c628 Bug 1589257 - Update Vive Cosmos controller binding file. r=kip
Cosmos changes their controller binding of grip/x/y buttons, so we need to give an update.

Differential Revision: https://phabricator.services.mozilla.com/D49502

--HG--
extra : moz-landing-system : lando
2019-10-17 00:24:42 +00:00
Logan Smyth
6e3be305df Bug 1581530 - Re-apply usage of .enable/.disable accidentally reverted in Bug 997119. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49382

--HG--
extra : moz-landing-system : lando
2019-10-16 18:13:41 +00:00
zhaogang
bd399a64e2 Bug 1578752 - Pass event listener column to debugger for more accurate pretty print. r=davidwalsh
Now the event listener tooltip url in the inspector will have an additional column part for generated file, which will be parsed as location.column to debugger, and the debugger pretty print can correctly create and use source map. It's the same bug as [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1045237 | Bug 1045237]], [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1134798 | Bug 1134798 ]], and [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1175911 | Bug 1175911 ]]

Differential Revision: https://phabricator.services.mozilla.com/D48812

--HG--
extra : moz-landing-system : lando
2019-10-16 23:03:15 +00:00
Sam Foster
f3166b49e8 Bug 1538955 - Enable test_basic_form_autocomplete.html for linux+debug. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D49489

--HG--
extra : moz-landing-system : lando
2019-10-16 21:56:11 +00:00
Sam Foster
57002e999f Bug 1587328 - Fix popup-closing races that can leave an indeterminate state for next task. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D49488

--HG--
extra : moz-landing-system : lando
2019-10-16 21:55:57 +00:00
Mihai Alexandru Michis
d874b02b52 Backed out 2 changesets (bug 1588469, bug 1588464) for causing bc failures in browser_test_focus_urlbar.js CLOSED TREE
Backed out changeset c5bff62e1640 (bug 1588464)
Backed out changeset b85a79175973 (bug 1588469)
2019-10-17 02:09:57 +03:00
Florens Verschelde
995baa5ff2 Bug 1588796 - New search-in-file highlight style in Debugger and Style Editor; r=davidwalsh,gl
Differential Revision: https://phabricator.services.mozilla.com/D49439

--HG--
extra : moz-landing-system : lando
2019-10-16 22:12:30 +00:00
Ciure Andrei
e2d920bc53 Backed out changeset 48816580680d (bug 1583042) for causing browser_ext_commands_onCommand.js to perma fail CLOSED TREE 2019-10-17 01:36:27 +03:00
Chris Manchester
e69835925b Bug 1587913 - Fix rust target detection for rustc 1.38. r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D48996

--HG--
extra : moz-landing-system : lando
2019-10-16 22:16:13 +00:00
Marco Bonardo
3db57b200e Bug 1588037 - Don't show 'Search in a private window' if an alias was typed. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D49423

--HG--
extra : moz-landing-system : lando
2019-10-16 22:07:43 +00:00
Marco Bonardo
e24c974e7d Bug 1588464 - Add a delay to Search in a private window to reduce flicker. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D49266

--HG--
extra : moz-landing-system : lando
2019-10-16 22:07:26 +00:00
Marco Bonardo
eddf83bc7a Bug 1588469 - Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8
Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.

Differential Revision: https://phabricator.services.mozilla.com/D49172

--HG--
extra : moz-landing-system : lando
2019-10-16 22:07:14 +00:00
Matt Brandt
73375c18cb Bug 1586290 - [iris firefox] Add email notifications for failing builds r=KWierso,tomprince
Differential Revision: https://phabricator.services.mozilla.com/D48738

--HG--
extra : moz-landing-system : lando
2019-10-16 21:32:44 +00:00
Hiroyuki Ikezoe
f6dee32218 Bug 1588675 - Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D49272

--HG--
extra : moz-landing-system : lando
2019-10-16 21:34:45 +00:00
Nico Grunbaum
91f56e850f Bug 1588571 - renew SDP comparison telemetry; r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D49187

--HG--
extra : moz-landing-system : lando
2019-10-15 15:58:25 +00:00
Mike Conley
a86e625bba Bug 1585769 - Regression test. r=JSON_voorhees
This added test, browser_thirdPartyIframe.js, is disabled for Fission until
we get Picture-in-Picture support working for it (Bug 1576915).

Differential Revision: https://phabricator.services.mozilla.com/D48201

--HG--
extra : moz-landing-system : lando
2019-10-16 21:23:58 +00:00
David Parks
b044993630 Bug 1384260: Part 4 - Remove SystemParametersInfo from Windows content proc plugin code r=jmathies
We use SystemParametersInfo to get the current system scroll wheel settings when we process scrollwheel movement in the content process.  We need to remove SystemParametersInfo for sandboxing the content process so this code changes the plugin behavior to cache the system wheel settings.  We do this by 1) sending wheel settings to the plugin whenever a plugin takes focus and 2) forwarding wheel settings update messages from Windows to the currently focused plugin.

Differential Revision: https://phabricator.services.mozilla.com/D47938

--HG--
extra : moz-landing-system : lando
2019-10-16 21:24:48 +00:00
David Parks
33f854d97a Bug 1384260: Part 3 - Remove GetKeyState from Windows content proc plugin code r=jmathies
As part of sandboxing the content process for Windows, we want to remove these calls from it.  These instances of GetKeyState should not be in actual use since plugin mouse events are handled through different means.  When they come to nsPluginInstanceOwner::ProcessEvent, they come with a pre-filled-in mPluginEvent, and this code is conditional on that not happening.  Despite that, I am preserving the existing behavior by moving the GetKeyState calls to the plugin process (where they are brokered to the parent process).  This fix is more robust to change than just removing the code would be.

Differential Revision: https://phabricator.services.mozilla.com/D47937

--HG--
extra : moz-landing-system : lando
2019-10-16 21:21:57 +00:00
David Parks
61e2e5b22d Bug 1384260: Part 2 - Remove GetForegroundWindow from Windows plugin code path r=jmathies
GetForegroundWindow in PluginInstanceParent is used as part of message throttling in windowed plugins -- which we no longer officially support.  We need to remove it from normal behavior for sandboxing the content process as part of win32k-lockdown.  We are not removing windowed plugin code yet so, rather than break the behavior, I've gated the win32 calls so that they aren't run with windowless plugins.

Note that the original behavior was fine as the sandbox just makes the function return NULL -- but it would still show up in stack analysis so the behavior in this patch is preferred.

Differential Revision: https://phabricator.services.mozilla.com/D47936

--HG--
extra : moz-landing-system : lando
2019-10-16 21:21:50 +00:00
David Parks
2c043f0a5f Bug 1384260: Part 1 - Remove RegisterWindowMessage from Windows plugin content process r=jmathies
This message was always being created in the constructor for nsPluginNativeWindowWin.  We want to remove RegisterWindowMessage from content for sandboxing (win32k-lockdown).  The message is only used in the old windowed plugin behavior, which is no longer supported, although the code remains in the code base.  I've simply moved RegisterWindowMessage to the windowed plugin path instead of removing it, since there is no need to break it.

Differential Revision: https://phabricator.services.mozilla.com/D47935

--HG--
extra : moz-landing-system : lando
2019-10-16 21:21:43 +00:00
David Walsh
6ded71ab21 Bug 1583042 - Change devtools debugger shortcut r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D47502

--HG--
extra : moz-landing-system : lando
2019-10-16 17:18:18 +00:00
Nick Thomas
4f61eb6771 Bug 1588392 - Switch to new GCP treescript workers, r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D49360

--HG--
extra : moz-landing-system : lando
2019-10-16 20:41:11 +00:00
Dragana Damjanovic
f300e9d596 Bug 1587226 - Make HTTP_CHANNEL_ONSTART_SUCCESS available on release channel.r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D48967

--HG--
extra : moz-landing-system : lando
2019-10-15 19:27:28 +00:00
Jeff Gilbert
6c3e1d29c0 Bug 1586423 - Revert bug 1470568 for breaking Google Meet, etc. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D49364

--HG--
extra : moz-landing-system : lando
2019-10-16 16:40:19 +00:00
Henrik Skupin
513521f536 Bug 1585272 - [remote] Register ChannelEventSinkFactory only once, and allow for multiple client connections. r=remote-protocol-reviewers,maja_zf
To allow for multiple client connections the ChannelEventSinkFactory
class only has to be registered once. By reference counting consumers
of this factory it can be made sure to only unregister it once no
consumers of the factory exist anymore.

With this refactoring we basically allow multiple client connections
to our CDP implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49329

--HG--
extra : moz-landing-system : lando
2019-10-16 20:23:05 +00:00
Henrik Skupin
3dce432d4f Bug 1563746 - [remote] Implement Page.captureScreenshot. r=remote-protocol-reviewers,maja_zf,ato
Differential Revision: https://phabricator.services.mozilla.com/D49203

--HG--
extra : moz-landing-system : lando
2019-10-16 19:36:56 +00:00
David Major
2bf032d442 Bug 1468131 - Avoid a ubsan complaint in GetTrimmableWhitespaceCount r=emilio
ubsan was complaining about the expression
```
    const char* str = aFrag->Get1b() + aStartOffset;
```
when `aFrag->Get1b() == nullptr` and `aStartOffset == -1`, because the addition generates an invalid pointer.

Due to other logic in the function, we would never dereference that pointer, so it was reasonably harmless, but this patch silences the complaint.

Differential Revision: https://phabricator.services.mozilla.com/D49345

--HG--
extra : moz-landing-system : lando
2019-10-15 22:59:51 +00:00
Mark Banner
dcfbcb56d7 Bug 1588872 - Enable ESLint rule mozilla/prefer-boolean-length-check by default, disable for failing locations. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D49437

--HG--
extra : moz-landing-system : lando
2019-10-16 20:11:31 +00:00
Harry Twyford
e928de6825 Bug 1589169 - Stop calling _addTextContentWithHighlights for the tip text. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D49468

--HG--
extra : moz-landing-system : lando
2019-10-16 20:00:16 +00:00
Harry Twyford
e897e72031 Bug 1586861 - Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D48405

--HG--
extra : moz-landing-system : lando
2019-10-16 14:46:44 +00:00
Matt Brandt
58fd4f9f86 Bug 1589194 - Win10x64 builds - pin to Python 3.7.3 r=KWierso
Differential Revision: https://phabricator.services.mozilla.com/D49472

--HG--
extra : moz-landing-system : lando
2019-10-16 19:51:09 +00:00
Jan-Ivar Bruaroey
45fe5da43a Bug 1588640: Show OS Screen Recording helper prompt when user makes a selection. r=johannh,haik
Depends on D49217

Differential Revision: https://phabricator.services.mozilla.com/D49328

--HG--
extra : moz-landing-system : lando
2019-10-16 16:13:15 +00:00
Jan-Ivar Bruaroey
8f436b2bf0 Bug 1588640: Split out Screen Recording OSX permission from Camera, and reject even own window sharing sans OS permission. r=johannh,haik
Differential Revision: https://phabricator.services.mozilla.com/D49217

--HG--
extra : moz-landing-system : lando
2019-10-16 19:35:42 +00:00
jaril
7628563796 Bug 1504025 - Fixed replay line indicator to display properly r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D49327

--HG--
extra : moz-landing-system : lando
2019-10-16 19:06:11 +00:00
J.C. Jones
ab56e5f10e Bug 1577822 - land NSS NSS_3_47_BETA3 UPGRADE_NSS_RELEASE, r=kjacobs
2019-10-16  J.C. Jones  <jjones@mozilla.com>

	* lib/softoken/pkcs11c.c:
	Bug 1459141 - Backed out changeset 474d62c9d0db for PK11_Wrap/Unwrap
	issues r=me
	[f10c3e0757b7] [NSS_3_47_BETA3]

2019-10-15  J.C. Jones  <jjones@mozilla.com>

	* .hgtags:
	Added tag NSS_3_47_BETA2 for changeset f657d65428c6
	[3ca8b20b24ee]

	* cmd/addbuiltin/addbuiltin.c:
	Bug 1465613 - Fixup clang format a=bustage
	[f657d65428c6] [NSS_3_47_BETA2]

2019-10-11  Marcus Burghardt  <mburghardt@mozilla.com>

	* automation/abi-check/expected-report-libnss3.so.txt, automation/abi-
	check/expected-report-libsmime3.so.txt, automation/abi-check
	/expected-report-libssl3.so.txt, cmd/addbuiltin/addbuiltin.c,
	cmd/lib/secutil.c, gtests/softoken_gtest/manifest.mn,
	gtests/softoken_gtest/softoken_gtest.gyp,
	gtests/softoken_gtest/softoken_nssckbi_testlib_gtest.cc,
	lib/certdb/certdb.c, lib/certdb/certt.h, lib/ckfw/builtins/README,
	lib/ckfw/builtins/certdata.txt, lib/ckfw/builtins/manifest.mn,
	lib/ckfw/builtins/nssckbi.h, lib/ckfw/builtins/testlib/Makefile,
	lib/ckfw/builtins/testlib/builtins-testlib.gyp,
	lib/ckfw/builtins/testlib/certdata-testlib.txt,
	lib/ckfw/builtins/testlib/config.mk,
	lib/ckfw/builtins/testlib/manifest.mn, lib/ckfw/builtins/testlib
	/nssckbi-testlib.rc,
	lib/ckfw/builtins/testlib/testcert_err_distrust.txt,
	lib/ckfw/builtins/testlib/testcert_no_distrust.txt,
	lib/ckfw/builtins/testlib/testcert_ok_distrust.txt,
	lib/ckfw/manifest.mn, lib/nss/nss.def, lib/pki/pki3hack.c,
	lib/softoken/sdb.c, lib/util/pkcs11n.h, nss.gyp, tests/cert/cert.sh:
	Bug 1465613 - Created two new fields for scheduled distrust from
	builtins and updated support commands. r=jcj,kjacobs,mt

	Added two new fields do scheduled distrust of CAs in
	nssckbi/builtins. Also, created a testlib to validate these fields
	with gtests.

	[52024949df95]

2019-10-14  Martin Thomson  <martin.thomson@gmail.com>

	* lib/ssl/tls13con.c:
	Bug 1588557 - Fix debug statement, r=jcj

	[0f563a2571c3]

2019-10-15  Dana Keeler  <dkeeler@mozilla.com>

	* gtests/mozpkix_gtest/pkixder_universal_types_tests.cpp,
	lib/mozpkix/include/pkix/pkixder.h, lib/mozpkix/lib/pkixcert.cpp:
	bug 1579060 - fix handling of issuerUniqueID and subjectUniqueID in
	mozilla::pkix::BackCert r=jcj

	According to RFC 5280, the definitions of issuerUniqueID and
	subjectUniqueID in TBSCertificate are as follows:

	 issuerUniqueID [1] IMPLICIT UniqueIdentifier OPTIONAL,
	subjectUniqueID [2] IMPLICIT UniqueIdentifier OPTIONAL,

	where UniqueIdentifier is a BIT STRING.

	IMPLICIT tags replace the tag of the underlying type. For these
	fields, there is no specified class (just a tag number within the
	class), and the underlying type of BIT STRING is "primitive" (i.e.
	not constructed). Thus, the tags should be of the form CONTEXT
	SPECIFIC | [number in class], which comes out to 0x81 and 0x82,
	respectively.

	When originally implemented, mozilla::pkix incorrectly required that
	the CONSTRUCTED bit also be set for these fields. Consequently, the
	library would reject any certificate that actually contained these
	fields. Evidently such certificates are rare.

	[c50f933d37a5]

2019-10-14  Deian Stefan  <deian@cs.ucsd.edu>

	* lib/softoken/pkcs11c.c:
	Bug 1459141 - Rewrite softoken CBC pad check to be constant time.
	r=kjacobs,jcj
	[474d62c9d0db]

2019-10-11  J.C. Jones  <jjones@mozilla.com>

	* .hgtags:
	Added tag NSS_3_47_BETA1 for changeset 93245f5733b3
	[f60dbafbc182]

Differential Revision: https://phabricator.services.mozilla.com/D49470

--HG--
extra : moz-landing-system : lando
2019-10-16 19:12:50 +00:00