clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter.
extensions/spellcheck/src/mozSpellChecker.cpp:532:54 [-Wcomma] possible misuse of comma operator here
MozReview-Commit-ID: 3GnKVvx8Nu4
--HG--
extra : rebase_source : 0ceaaad16e3d701e24029e431a9d577e9636d626
extra : source : ceb864752cc324d629118d44f22a01d9594b26fd
clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements.
dom/svg/SVGGeometryElement.h:117:21 [-Wcomma] possible misuse of comma operator here
dom/svg/SVGGeometryElement.h:117:41 [-Wcomma] possible misuse of comma operator here
dom/svg/SVGGeometryElement.h:128:14 [-Wcomma] possible misuse of comma operator here
dom/svg/SVGGeometryElement.h:128:23 [-Wcomma] possible misuse of comma operator here
MozReview-Commit-ID: CfNOsfcJTEp
--HG--
extra : rebase_source : a9cda16923d853b4b9fd26d796ba1a6739e85383
extra : source : 91d3b4d038285c034294ea3164c4e55e300e4823
clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements or to call a function for side effects within an expression.
This warning indicates that nsXMLFragmentContentSink::CloseElement() has been calling aContent->IsHTMLElement() but not using its return value to determine whether to call PreventExecution(). This was a regression from bug 1134280 back in 2015.
dom/base/nsGlobalWindow.cpp:9344:55 [-Wcomma] possible misuse of comma operator here
dom/xml/nsXMLFragmentContentSink.cpp:227:50 [-Wcomma] possible misuse of comma operator here
MozReview-Commit-ID: DontBxeHqGI
--HG--
extra : rebase_source : a48455dd7a38bf7dd5f3aa58954b7cbe9ac8f831
extra : source : d7d072099c332af4c05564abb9cce10489ee99e1
The patch adds a missing |delete|. (This leak only occurred when the
"mainthreadio" feature was enabled, which is not the default.)
The patch also makes the unregistering of the interpose observer conditional on
there being one in the first place, avoiding a harmless but useless
unregistering of |nullptr|.
--HG--
extra : rebase_source : 7cc3679192e3effa8d86edad5374643d2e2b8948
We probably don't want to tackle these issues since httpclientandroidlib is already deprecated,
and we have more pressing infer issues in the main app. (We can always reenable if needed,
but this means we can more rapidly get to a state of 0 infer reports, allowing use of infer
to catch newly introduced issues in the core app.)
MozReview-Commit-ID: 2jMlrh68kOE
--HG--
extra : rebase_source : 73e75eb0fb4a5eece242d64a624cfe80916208ca
When rewriting in the rule view, the rewriter quotes unmatched open
parens to avoid some edits affecting the rest of the style sheet. This
was bug 1321970. However, that change didn't correctly handle the case
of a function token, where the paren in question appears at the end, not
the start, of the token.
MozReview-Commit-ID: GjA40M2KsvX
--HG--
extra : rebase_source : 0dec92ca958d20f02da5c7c4163ad971b2529920
This filtering is no longer necessary now that the fix for Bug 1338897 has landed and has gotten rid of the CRLF behaviour.
MozReview-Commit-ID: 9OKmrtQN3Cq
--HG--
extra : transplant_source : %C2%CD%AC%F6j%F5%D0%00%7E%AC%D2j%ACW%83%60%3B%F0%ED%CC
