Commit Graph

680655 Commits

Author SHA1 Message Date
Jed Davis
4992ca410f Bug 1545504 - Strengthen bounds check in WebRTC PhysicalSocketServer. r=jesup
PhysicalSocketServer isn't currently used by Mozilla's WebRTC
integration, but just in case, let's make sure that this array index is
bounds-checked in actual use, not just in debug builds (which tend to
never see realistic test conditions).

Differential Revision: https://phabricator.services.mozilla.com/D52745

--HG--
extra : moz-landing-system : lando
2019-11-17 03:40:50 +00:00
Jed Davis
c8b77dbe74 Bug 1545504 - Use poll() instead of select() on the X11 socket. r=stransky
These are single-fd polls of the X server socket, which in practice will
be much smaller than FD_SETSIZE, but it's cleaner to just not have the
fixed-size array in the first place.

Differential Revision: https://phabricator.services.mozilla.com/D52744

--HG--
extra : moz-landing-system : lando
2019-11-19 10:09:35 +00:00
Makoto Kato
2fa6c3bce0 Bug 1549394 - Part 2. Set IS_PRIVATE input scope in private browsing. r=masayuki
Microsoft IME on Windows 10 20H1 (build 19025+) supports IME private mode by
input scope. Although previous Windows version uses undocumented API for
Edge and IE only, next Windows will use public API for it.

So let's use IS_PRIVATE input scope in private browsing mode.

Depends on D53917

Differential Revision: https://phabricator.services.mozilla.com/D53918

--HG--
extra : moz-landing-system : lando
2019-11-20 05:08:09 +00:00
Makoto Kato
f0c9b65329 Bug 1549394 - Part 1. Clean up input scope support for IMM32. r=masayuki
Use AutoTArray to set input scope.

Differential Revision: https://phabricator.services.mozilla.com/D53917

--HG--
extra : moz-landing-system : lando
2019-11-20 05:05:37 +00:00
Makoto Kato
d6c4b79621 Bug 1595425 - Don't flush layout when setting empty string on Chrome. r=masayuki
This is a regression by bug 1568996. Although editor uses nsFrameSelection to
move caret, if frame is dirty, nsFrameSelection returns error.
So by bug 1568996, we flush layout before calling nsFrameSelection. But we
should stop flushing layout when we don't use nsFrameSelection.

Differential Revision: https://phabricator.services.mozilla.com/D53919

--HG--
extra : moz-landing-system : lando
2019-11-20 05:09:18 +00:00
Kashav Madan
649ac773f7 Bug 1596462 - Make browser_aboutnewtab_process_selection.js Fission-compatible, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53036

--HG--
extra : moz-landing-system : lando
2019-11-21 00:17:00 +00:00
Māris Fogels
1d657c8499 Bug 1448349 - Warn about autoconf $PATH problems on win32 r=firefox-build-system-reviewers,chmanchester
Detect if Unix utilities on win32 are being picked up from a foreign
installation of MinGW, such as the tools packaged with Git for Windows.
If autoconf dies during `./mach configure` and foreign tools are found
in $PATH then warn the user that their $PATH may need to change to fix
the problem.

Differential Revision: https://phabricator.services.mozilla.com/D52960

--HG--
extra : moz-landing-system : lando
2019-11-21 00:20:56 +00:00
Brad Werth
566e87fdab Bug 1391994 Part 3: Expand devtools tests to verify interactive style edits work on pages with CSP restrictions. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D41321

--HG--
extra : moz-landing-system : lando
2019-11-20 22:50:39 +00:00
Brad Werth
f6f97abc9b Bug 1391994 Part 2: Use the new SetAttributeDevtools methods in callsites where devtools modifies a node it hasn't just created. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D41319

--HG--
extra : moz-landing-system : lando
2019-11-20 22:50:37 +00:00
Brad Werth
59271a70be Bug 1391994 Part 1: Add new methods to Element to set attributes via devtools. r=bzbarsky
This expands Element with chrome-only setAttribute methods that give devtools
callers an ExtendedPrincipal with a CSP with a flag set to allow changes to
inline styles. This gives devtools the ability to modify documents with a
Content-Security-Policy.

Differential Revision: https://phabricator.services.mozilla.com/D41313

--HG--
extra : moz-landing-system : lando
2019-11-21 01:45:51 +00:00
Ian Moody
abb52d0d7f Bug 1592801 - Update Twemoji Mozilla to 0.5.0 (twemoji 12.1.3). r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D51190

--HG--
extra : moz-landing-system : lando
2019-11-20 23:01:14 +00:00
wartmanm
d30d028c18 Bug 1478665 - Follow source maps when viewing custom element definition r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D50016

--HG--
extra : moz-landing-system : lando
2019-11-20 22:57:47 +00:00
Ting-Yu Lin
73021bb855 Bug 1598132 - Add GetPrevContinuationOrIBSplitSibling() and improve GetNextContinuationOrIBSplitSibling() in nsLayoutUtils. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54037

--HG--
extra : moz-landing-system : lando
2019-11-20 22:31:31 +00:00
Dzmitry Malyshau
1e8edf9e02 Bug 1597319 - Use rounded rect FAST_PATH more agressively r=gw
Differential Revision: https://phabricator.services.mozilla.com/D53999

--HG--
extra : moz-landing-system : lando
2019-11-21 00:53:00 +00:00
Daniel Holbert
571fd2eafe Bug 1578586: Don't let the "percentages-can-resolve-against-ancestor" quirk apply to percentages in flex/grid items. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D44583

--HG--
extra : moz-landing-system : lando
2019-11-20 23:50:32 +00:00
Narcis Beleuzu
2738d493c6 Backed out 2 changesets (bug 1595656) for xpcshell failures on test_load_all_api_modules.js . CLOSED TREE
Backed out changeset 061c92c4b95c (bug 1595656)
Backed out changeset ef8d5090979a (bug 1595656)
2019-11-21 03:22:06 +02:00
Narcis Beleuzu
4305bf1a25 Backed out changeset ab47a4eac76c (bug 1597319) for WR bustages on perspective-box-shadow.yaml . CLOSED TREE 2019-11-21 02:34:15 +02:00
Narcis Beleuzu
46f83924c1 Backed out changeset c7b4e89f5ee6 (bug 1594577) for xpcshell failures on test_watchdog_hibernate.js . CLOSED TREE 2019-11-21 02:22:32 +02:00
Molly Howell
0aadc17b15 Bug 1592968 Followup 2 - Only clean installer pref registry values that are pref names. r=agashlin
The previous patch writes the registry value correctly, but the Firefox
InstallerPrefs module deletes it during startup because it's in the
same key where the actual pref values go and the module unconditionally
deletes every value there. So making it only delete values that are
recognizably actual prefs should fix this.

Differential Revision: https://phabricator.services.mozilla.com/D53693

--HG--
extra : moz-landing-system : lando
2019-11-20 23:47:55 +00:00
Chris Manchester
60fcabc3d4 Bug 1598157 - Do not check mozilla-inbound during artifact builds. r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D54057

--HG--
extra : moz-landing-system : lando
2019-11-20 23:50:34 +00:00
Aaron Klotz
aefddbeebf Bug 1596564: ParamTraits for CombinedStacks and ProcessedStack; r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D53086

--HG--
extra : moz-landing-system : lando
2019-11-19 17:20:02 +00:00
Dzmitry Malyshau
3a063c9858 Bug 1597319 - Use rounded rect FAST_PATH more agressively r=gw
Differential Revision: https://phabricator.services.mozilla.com/D53999

--HG--
extra : rebase_source : 4bde6755f4fa92d85300888dc286b9fd97100c90
extra : source : d65ded00cb51c7c5e3e1a23145b2a8bf15e5e52e
2019-11-20 18:48:50 +00:00
Matthew Noorenberghe
9eb7704800 Bug 1595656 - Only clear user-facing passwords with the browsingData API. r=rpl
FxA/Sync stores a credential in login storage but this is no longer user-facing so users shouldn't expect it to be cleared. Users can still diconnect Sync properly from about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D53834

--HG--
extra : moz-landing-system : lando
2019-11-20 15:07:32 +00:00
Matthew Noorenberghe
4ee2233074 Bug 1595656 - isUserFacingLogin should only exclude the FxA one, not legacy extension ones. r=sfoster
We shouldn't hide data saved by legacy extensions, the user should remain in control of them since they may contain credentials they want to delete.

Differential Revision: https://phabricator.services.mozilla.com/D53833

--HG--
extra : moz-landing-system : lando
2019-11-20 22:55:12 +00:00
Drew Willcoxon
523d1576b3 Bug 1596980 - Copy browser.experiments.urlbar.engagementTelemetry from top sites experiment to our mozilla-central experiment files r=mak,mixedpuppy
Original code by Marco Bonardo <mbonardo@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D53311

--HG--
extra : moz-landing-system : lando
2019-11-20 22:51:19 +00:00
prathiksha
8914c167f1 Bug 1388674 - Only prompt to save logins if a login field was modified by the user. r=MattN
Depends on D51718

Differential Revision: https://phabricator.services.mozilla.com/D24556

--HG--
extra : moz-landing-system : lando
2019-11-20 22:44:20 +00:00
Sam Foster
2831a02039 Bug 1388674 - Update tests to use setUserInput, ensuring we get an input event for field modifications. r=MattN
Depends on D53055

Differential Revision: https://phabricator.services.mozilla.com/D51718

--HG--
extra : moz-landing-system : lando
2019-11-20 22:44:18 +00:00
Sam Foster
0150488e14 Bug 1388674 - Use document state to track generated password fields, not just the event handlers. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D53055

--HG--
extra : moz-landing-system : lando
2019-11-20 22:44:15 +00:00
Edwin Takahashi
d7dd37c96e Bug 1595982 - fix incorrect import in python3 codepath inside mozharness/base/python.py r=aki
I mistakenly attempted to `import urllib.urlparse` instead of `urllib.parse`, which caused a bunch of tests running under python3.5 tox to be blocked on this.

This correction allows tox on python3.5 to run all 167 tests, allowing me to cross-check further python3 conversion work.

Differential Revision: https://phabricator.services.mozilla.com/D54041

--HG--
extra : moz-landing-system : lando
2019-11-20 22:44:27 +00:00
Mike Conley
0e1e31ae4e Bug 1597689 - Update Picture-in-Picture image assets. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D53819

--HG--
extra : moz-landing-system : lando
2019-11-20 22:29:47 +00:00
Shane Caraveo
1c6b57f5bb Bug 1410412 implement browser setting onChange event r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D51324

--HG--
extra : moz-landing-system : lando
2019-11-20 01:22:38 +00:00
Brindusan Cristian
f8cfa641a5 Backed out changeset efb782988830 (bug 1596479) for wrench bustage (KeyError: 'region'). CLOSED TREE 2019-11-21 00:45:18 +02:00
Chris Manchester
fa505637e2 Bug 1597836 - Update sccache in-tree to the current master r=dmajor,firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D53903

--HG--
extra : moz-landing-system : lando
2019-11-20 22:22:20 +00:00
David Parks
4dc38ba6aa Bug 1577336: Part 7 - Move DXGI async plugin operations to compositor process r=jmathies,mattwoodrow,sotaro,mccr8
Previously, we created TextureD3D11 objects in the content process to back surfaces created for the plugin process.  Those objects were then composited by the async ImageBridge.  In order to remove Win32 kernel operations from content (including DX/GDI operations), this patch bounces the requests from content to the compositor process.  The compositor process maintains 2 textures to be used for all plugin composition -- one for the plugin process and one for display.  The plugin process can freely write to its texture and request composition when it is done, which triggers a blit to the display texture.  This mirrors pre-existing behavior.

Differential Revision: https://phabricator.services.mozilla.com/D46086

--HG--
extra : moz-landing-system : lando
2019-11-20 21:49:35 +00:00
David Parks
18e50987a5 Bug 1577336: Part 6 - Make SurfaceDescriptorGPUVideo a union that contains SurfaceDescriptorRemoteDecoder r=mattwoodrow,jolin
SurfaceDescriptorGPUVideo, which currently only represents RemoteDecoder video, switches from being a struct to a union that holds a SurfaceDescriptorRemoteDecoder struct.  SurfaceDescriptorRemoteDecoder is a new name for the old SurfceDescriptorGPUVideo.  This is done so that we can later add SurfaceDescriptorPlugin as another type of SurfaceDescriptorGPUVideo.

Differential Revision: https://phabricator.services.mozilla.com/D52400

--HG--
extra : moz-landing-system : lando
2019-11-20 21:55:06 +00:00
David Parks
35515bd4e7 Bug 1577336: Part 5 - Create IGPUVideoSurfaceManager for shared parts of RemoteDecoderManagerChild r=mattwoodrow
IGPUVideoSurfaceManager is an interface that the ImageBridgeChild uses to perform GPUVideoImage operations.  RemoteDecoderManagerChild is one.  We define another for plugins later in this patch series.

Differential Revision: https://phabricator.services.mozilla.com/D52397

--HG--
extra : moz-landing-system : lando
2019-11-20 21:33:59 +00:00
David Parks
78fbd97e70 Bug 1577336: Part 4 - Refactor some things in RemoteDecoderManager r=mattwoodrow,jolin
In anticipation of the rest of this patch series, we make 2 changes to the RemoteDecoderManager:
1. Rename RemoteDecoderManagerChild::DeallocateSurfaceDescriptorGPUVideo to DeallocateSurfaceDescriptor
2. Move call to RemoteDecoderManager::GetSource() from GPUVideoTextureClient to RemoteVideoDecoder.

Differential Revision: https://phabricator.services.mozilla.com/D52396

--HG--
extra : moz-landing-system : lando
2019-11-20 21:53:28 +00:00
David Parks
446170c593 Bug 1577336: Part 3 - Fetch Windows plugin async graphics capabilities from gpu or main process r=jmathies,mattwoodrow,froydnj
These operations report whether certain async plugin drawing modes are supported on the host architecture.  They use kernel graphics operations to decide this so they need to be removed from the content process for sandboxing.  We just bounce the requests to the gpu process (or main process on systems without a GPU process).

Differential Revision: https://phabricator.services.mozilla.com/D46085

--HG--
extra : moz-landing-system : lando
2019-11-20 21:33:55 +00:00
David Parks
beb56ea7bc Bug 1577336: Part 2 - Add pref to disble Windows DXGI async plugin surfaces r=jmathies
Use this pref to disable NPDrawingModelAsyncWindowsDXGISurface mode, which will force compatible plugins (Flash) to use NPDrawingModelAsyncBitmapSurface.

Differential Revision: https://phabricator.services.mozilla.com/D46084

--HG--
extra : moz-landing-system : lando
2019-11-20 21:32:24 +00:00
David Parks
6cb9c34c4c Bug 1577336: Part 1 - Remove win32k use from NPDrawingModelAsyncBitmapSurface r=jmathies
This fallback drawing mode primarily uses in-memory textures in the content process (via Readback) but uses gfxPlatform to establish the GPU texture type.  On Windows, this is always Win32 so we can avoid the gfxPlatform call (which uses Win32k heavily).  I believe that this removes all Win32 operations involved in this drawing mode in a content process.

Differential Revision: https://phabricator.services.mozilla.com/D46083

--HG--
extra : moz-landing-system : lando
2019-11-20 21:32:07 +00:00
Geoff Lankow
ada7694a92 Bug 1595696 - Shift artifact namespace transformation to the job class definition. r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D52631

--HG--
extra : moz-landing-system : lando
2019-11-20 19:01:26 +00:00
Gregory Mierzwinski
9d477bcb3a Bug 1597975 - Fix manifestparser in python 3 r=ahal
This patch fixes a minor issue with manifestparser when it is used in python 3. The problem was that dict.items() returns a generator in python 3 instead of a list.

Differential Revision: https://phabricator.services.mozilla.com/D53953

--HG--
extra : moz-landing-system : lando
2019-11-20 20:33:23 +00:00
Andrew McCreight
57b6c8b02b Bug 1598075 - Reuse Fission content processes in reader mode tests. r=Gijs
There are frequent shutdown hangs in this directory. Making us reuse
content processes when Fission is enabled has papered over the
shutdown hangs from reader mode tests in other directories, so
hopefully it will help here, too.

Differential Revision: https://phabricator.services.mozilla.com/D54012

--HG--
extra : moz-landing-system : lando
2019-11-20 20:44:35 +00:00
Nan Jiang
6914a98c54 Bug 1597697 - Stop sending AS heartbeat ping to Tiles data pipeline. r=thecount
This turns off the telemetry to Tiles in m-c. Activity Stream related telemetry to Tiles will be handled separately.

Differential Revision: https://phabricator.services.mozilla.com/D53875

--HG--
extra : moz-landing-system : lando
2019-11-20 21:30:43 +00:00
Emma Malysz
273aab2e2a Bug 1596884, replace remaining .xul files in layout/tools with .xhtml r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D53898

--HG--
rename : layout/tools/layout-debug/ui/content/layoutdebug.xul => layout/tools/layout-debug/ui/content/layoutdebug.xhtml
rename : layout/tools/recording/recording.xul => layout/tools/recording/recording.xhtml
rename : layout/tools/reftest/reftest.xul => layout/tools/reftest/reftest.xhtml
extra : moz-landing-system : lando
2019-11-20 20:40:32 +00:00
Perry Jiang
7215838dc1 Bug 1575092 - don't spawn Shared/Service Workers in "web COOP+COEP" processes r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D50815

--HG--
extra : moz-landing-system : lando
2019-11-20 20:02:23 +00:00
Perry Jiang
25638418f9 Bug 1575092 - add "web COOP+COEP" process type helpers r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D50814

--HG--
extra : moz-landing-system : lando
2019-11-20 19:45:14 +00:00
Honza Bambas
50f49afa20 Bug 1592628 - Propagate network.http.proxy.respect-be-conservative to the http connection manager at startup properly, r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D54002

--HG--
extra : moz-landing-system : lando
2019-11-20 18:22:08 +00:00
Doug Thayer
87634aef93 Bug 1594577 - Record hangs which precede forced shutdowns r=froydnj
In short - if a user forcibly terminates the browser because it seems
to be permanently hung, we currently do not get a change to record the
hang. This is unfortunate, because these likely represent the most
egregious hangs in terms of user frustration. This patch seeks to
address that.

If a hang exceeds 8192ms (the current definition of a "permahang" in
existing BHR terms), then we decide to immediately persist it to disk,
in case we never get a chance to return to the main thread and
submit it. On the next start of the browser, we read the file from
disk on a background thread, and just submit it using the normal
mechanism.

Regarding the handling of the file itself, I tried to do the simplest
thing I could - as far as I can tell there is no standard simple
serialization mechanism available directly to C++ in Gecko, so I just
serialized it by hand. I didn't take any special care with endianness
or anything as I can't think of a situation in which we really care
at all about these files being transferable between architectures. I
directly used PR_Write / PR_Read instead of doing something fancy
like memory mapping the file, because I don't think performance is a
critical concern here and it offers a simple protection against
reading out of bounds.

Differential Revision: https://phabricator.services.mozilla.com/D52566

--HG--
extra : moz-landing-system : lando
2019-11-20 20:40:22 +00:00
shindli
f1c84ddb25 Backed out changeset d65ded00cb51 (bug 1597319) for causing wrench bustages CLOSED TREE 2019-11-20 22:37:01 +02:00