Because of alignment issues due to the system glibc when running the
SSE2 gcov code generated during the PGO profile gen phase, Firefox
crashes when running the PGO profile. We work around the issue by
disabling SSE2 when building mozjemalloc during that phase. That
shouldn't affect the coverage data anyways, which is bound to the
original C++ code, and the profile-use code generation will still emit
SSE2 based on the coverage data if it needs to.
--HG--
extra : rebase_source : 3596fdc795cdef0789f3a2dd8f10b42cde00430f
Code changes will land separately in github[1], and will be exported to
Firefox in a separate commit.
[1] https://github.com/mozilla-services/screenshots/pull/3711
MozReview-Commit-ID: 91sA1vqN1Il
--HG--
extra : rebase_source : af3409ab56d4d9a7470c748cc6a2ce89a6f63659
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#18997 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: fa319170ebb34afcdfc120b7c3e47fe5b1c21210
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 2a5d1cd283156c691e475d88bda21d4fdb6392b2
- This IPC is no longer used and can be removed to simplify
the PVRManager protocol.
MozReview-Commit-ID: Kno5CHkI17K
--HG--
extra : rebase_source : 227e36b00bc2d6a3b83b48d80fbfdfe35196057d
I'm able to produce a build failure with this changeset on one of
my machines. I guess the checks weren't as redundant as I thought...
CLOSED TREE
--HG--
extra : amend_source : 564add1404e09ca023c3347f3ce20be407dffa82
CLOSED TREE
--HG--
extra : amend_source : 3565fdd8a509e11547b0788364ef68e633018bc4
extra : histedit_source : 83c6614b751cedd0af05404d45ef51ad0f58c764%2C1e117ef60548884384a2043a06427788b28c56df
These targets no longer exist in client.mk. I'm not sure when they
were removed. But this is obviously dead code.
A target in rules.mk pointing back to this target in client.mk has
also been removed.
MozReview-Commit-ID: 5v1MOOTP3qq
--HG--
extra : rebase_source : b90f0788b074330b45005223f41c804589d13163
I /think/ the only scenario where we wouldn't be able to evaluate
a config environment after configure was the case where
MOZ_BUILD_PROJECTS was in play. Since we removed support for that
feature, let's drop support for treating the config environment
as optional.
MozReview-Commit-ID: 4sz9dOwaA3y
--HG--
extra : rebase_source : 44c0d5d51238cdcb0b311f205a9faf306bb18b19
The config.guess file is checked into source control. I'm not sure
under what conditions we wouldn't fail to find this file. So the
$(wildcard) shouldn't be necessary.
MozReview-Commit-ID: KCctPFW3Eab
--HG--
extra : rebase_source : 2b9f674bdffc95ac4e1999f9a5d8b7ffa13e8d74
So the file can be more easily consumed without this variable defined.
MozReview-Commit-ID: DF3ASwx4SZP
--HG--
extra : rebase_source : 7d760a71c8f0fa389c2f31f1b383a1f298220545
This likely became unused with the port to moz.configure.
MozReview-Commit-ID: FoIDg6Q2K4J
--HG--
extra : rebase_source : 1dd55aebaeae9d9e7d4704d13c86c4a545a72165
moz.configure invokes autoconf to generate old-configure. As part of this
it checks mtimes of dependencies. The logic in client.mk is old and
redundant. So remove it.
MozReview-Commit-ID: FG2lWiIjKqV
--HG--
extra : rebase_source : 779a7ffb076ce15a76fe2e675695943d43c5c454
We don't want to encourage people to use client.mk.
MozReview-Commit-ID: 53uLrINdHJE
--HG--
extra : rebase_source : ad96b67e867d7574f54475599a0c744df7eaa5e0
While we're here, also move the low-level code to invoke configure
to a proper Python module.
We needed to muck around with the log manager because the underlying
logger for output changed from "mach" (which is registered by default)
to something under the "mozbuild" hierarchy.
MozReview-Commit-ID: 4rlCxOwcVu1
--HG--
extra : rebase_source : e6c824a88fcfdbdeae31a7a94f33571f150e7690
The goal is to move this lower-level code somewhere where it can be
reused.
The only meaningful code change as part of the move was handling
of the mach context. Before, we could access self._mach_context.
After, we need to pass it as an argument. This also uncovered a bug
where "telemetry_handler" could be None but we called it
unconditionally. We now guard this call with an "if."
MozReview-Commit-ID: FWw4l6H1ayS
--HG--
extra : rebase_source : f6bf25eb8c52df2d09e4d5eddd5b85b38502e661
In general, we shouldn't have so much business logic in mach_commands.py
files.
I'd like to move more of the low-level "perform a build" logic out of
mach_commands.py to facilitate some future work. That code makes use of
this output processing code. So as the first step in moving the build
code, we move its dependencies.
As part of this, I also cleaned up some random unused imports around
lines that were touched.
No meaningful code changes were performed as part of the code move.
MozReview-Commit-ID: 96mGWUJ7oLb
--HG--
extra : rebase_source : 04c3865d5bcc44777749f3ab6a65e31bb1d13689
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are apart of #19015 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 1e0fd7da3050208621dd08044bb202570638fb3e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 11e30e17839a10dbfda8f88055392c025652c722
client.mk hasn't been well-supported for years. Stop recommending it.
MozReview-Commit-ID: KWFhAQPIXWu
--HG--
extra : rebase_source : dafb307d82f1f0a3141d077102fd2fe21add65b4
