Commit Graph

700351 Commits

Author SHA1 Message Date
Kristen Wright
4a3747126f Bug 1626388 - Convert layout.framevisibility.numscrollportwidths/heights to static prefs r=njn
Converts layout.framevisibility.numscrollportwidths and layout.framevisibility.numscrollportheights to static prefs.

Differential Revision: https://phabricator.services.mozilla.com/D69615

--HG--
extra : moz-landing-system : lando
2020-04-06 20:16:38 +00:00
Kristen Wright
05a7022978 Bug 1626388 - Convert dom.select_events.textcontrols.enabled to static pref r=njn
Converts dom.select_events.textcontrols.enabled to a static pref.

Differential Revision: https://phabricator.services.mozilla.com/D69614

--HG--
extra : moz-landing-system : lando
2020-04-06 23:30:18 +00:00
Kristen Wright
b0a2f87323 Bug 1626388 - Convert layout.testing.overlay-scrollbars.always-visible to static pref. r=njn
Converts `layout.testing.overlay-scrollbars.always-visible` to a static pref.

Differential Revision: https://phabricator.services.mozilla.com/D69611

--HG--
extra : moz-landing-system : lando
2020-04-06 20:18:58 +00:00
Kristen Wright
d433a32b2d Bug 1626388 - Convert two prefs in nsDocumentViewer to static pref r=njn
Converts `dom.disable_beforeunload` and `dom.require_user_interaction_for_beforeunload` to static pref.

Differential Revision: https://phabricator.services.mozilla.com/D69600

--HG--
extra : moz-landing-system : lando
2020-04-06 19:57:01 +00:00
Kristen Wright
37d15858db Bug 1626388 - Convert layout.framevisibility.enabled to a static pref r=njn
Converts `layout.framevisibility.enabled` to a static pref.

Differential Revision: https://phabricator.services.mozilla.com/D69598

--HG--
extra : moz-landing-system : lando
2020-04-06 19:55:07 +00:00
Logan Smyth
3f76247abc Bug 1598309 - Part 2: Avoid leaking memory for sourcemap loading. r=jlast
Depends on D69930

Differential Revision: https://phabricator.services.mozilla.com/D69931

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:15 +00:00
Logan Smyth
083033cd6c Bug 1598309 - Part 1: Update bundles with recent Boolean changes. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D69930

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:38 +00:00
David Major
8aae4415b9 Bug 1628036 - Use linux64-binutils in the mac instrumented build r=glandium
This is needed so we have a workable ld for building host libraries. Prior to my patch in bug 1326486, we had been getting an ld in the clang package by accident, since 1-stage builds had the wrong value of `is_final_stage` here: https://searchfox.org/mozilla-central/rev/4d2a9d5dc8f0e65807ee66e2b04c64596c643b7a/build/build-clang/build-clang.py#162-170

Since the build-clang comment says "we expect any consumers of the newly-built toolchain to provide an appropriate ld themselves", I'm doing so in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D70054

--HG--
extra : moz-landing-system : lando
2020-04-07 22:34:40 +00:00
Mike Hommey
4e228dc5f5 Bug 1627873 - Always unbuffer python output when invoking python commands from mach. r=firefox-build-system-reviewers,rstewart
When the build is stalled for some random reason, and mach executed a
python subcommand (this may or may not be limited to python 3, I'm not
sure, and it doesn't really matter since it's a problem on python 3,
which matters most), the subcommand may not have actually sent its last
bits of output before the stall because its output is a pipe and in that
case python uses buffered outputs.

Now, when your build is completely stalled and you ctrl+C, you end up
without these bits of output, and in some cases, those bits of output
can contain actual information, like... tracebacks.

A real life example of this is bug 1624670 when running mach build or
mach configure with the patches from bug 1627163 applied, and configure
stalls without printing out the ValueError message at all.

Differential Revision: https://phabricator.services.mozilla.com/D69925

--HG--
extra : moz-landing-system : lando
2020-04-07 15:52:00 +00:00
Mike Hommey
a83c3a6e86 Bug 1624670 - Cap ProcessPoolExecutor's max_workers to 60 on Windows. r=firefox-build-system-reviewers,rstewart
See https://bugs.python.org/issue26903#msg365886.

Differential Revision: https://phabricator.services.mozilla.com/D69921

--HG--
extra : moz-landing-system : lando
2020-04-07 15:55:09 +00:00
Logan Smyth
d256d771ed Bug 1607559 - Part 2: Avoid perf issue with data: URLs for inlined source-maps. r=jlast
Depends on D69933

Differential Revision: https://phabricator.services.mozilla.com/D69934

--HG--
extra : moz-landing-system : lando
2020-04-07 17:06:56 +00:00
Logan Smyth
b8acb33b40 Bug 1607559 - Part 1: Do not replace the global URL with whatwg-url. r=jlast
By loading whatwg-url like this, we replace the worker global URL property
(among others), which means that code that uses `URL` and expects it to be the
version that is built into Firefox may not get what they expect.

Differential Revision: https://phabricator.services.mozilla.com/D69933

--HG--
extra : moz-landing-system : lando
2020-04-07 16:46:37 +00:00
Razvan Maries
95bcfbaafd Backed out changeset 32871d284eef (bug 1622978) for perma failures on test_distribution.js. CLOSED TREE 2020-04-08 02:34:51 +03:00
Scott
6d42c8f893 Bug 1627317 - Ensure collections are also disabled, if newtab stories are disabled. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D69609

--HG--
extra : moz-landing-system : lando
2020-04-06 21:43:31 +00:00
Stefan Hindli
3b135390cf Backed out changeset 717f97c0d871 (bug 1611310) for causing mass build bustages CLOSED TREE 2020-04-08 01:46:32 +03:00
Stefan Hindli
21c4b1ce50 Backed out 5 changesets (bug 1617023, bug 1627141, bug 1626812) for causing being related to Bug 1611310 CLOSED TREE
Backed out changeset b975de50682b (bug 1627141)
Backed out changeset 481325c44e80 (bug 1626812)
Backed out changeset 546b90fd1689 (bug 1617023)
Backed out changeset f54ac49bbc0a (bug 1617023)
Backed out changeset 1ebf382e7133 (bug 1617023)
2020-04-08 01:45:47 +03:00
Daosheng Mu
bc1f3fa9ea Bug 1627141 - Implement XRInputSourcesChangeEvent. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D69483

--HG--
extra : moz-landing-system : lando
2020-04-07 21:26:54 +00:00
Daosheng Mu
7efbfa3c65 Bug 1626812 - Dispatch XRSessionEvent end when exiting XRSession. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D69296

--HG--
extra : moz-landing-system : lando
2020-04-07 21:26:46 +00:00
Daosheng Mu
673fd01dae Bug 1617023 - Part 3: Implement XR controller selection and squeeze actions. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D67433

--HG--
extra : moz-landing-system : lando
2020-04-07 21:30:53 +00:00
Daosheng Mu
e4b13d6e39 Bug 1617023 - Part 2: OpenVR/Oculus controller XR mode. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D67432

--HG--
extra : moz-landing-system : lando
2020-04-07 21:30:02 +00:00
Daosheng Mu
184166d359 Bug 1617023 - Part 1: Integrating Gamepad with XRInputSource. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D67431

--HG--
extra : moz-landing-system : lando
2020-04-07 22:24:43 +00:00
Tim Nguyen
8036e4c68a Bug 1627568 - Make css-grid-with-xul-item-1.xhtml test more resilient to failures. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D69750

--HG--
extra : moz-landing-system : lando
2020-04-07 21:21:20 +00:00
Nika Layzell
09988936b7 Bug 1616353 - Part 13: Don't create an extra BrowsingContext when opening a new tab from content, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D68045

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:59 +00:00
Nika Layzell
7031bc0da0 Bug 1616353 - Part 12: Remove or fix tests which try to set OriginAttributes too late, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67059

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:57 +00:00
Nika Layzell
d9dd824ff3 Bug 1616353 - Part 10.2: Remove tests for window.open in mozbrowser, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67216

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:54 +00:00
Nika Layzell
f1286979d8 Bug 1616353 - Part 10.1: Remove special handling of window.open in mozbrowser, r=kmag
There are no remaining users of mozbrowser in our tree, so this patch removes
the logic which used to exist for handling window.open differently within
mozbrowser frames.

Differential Revision: https://phabricator.services.mozilla.com/D67057

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:52 +00:00
Nika Layzell
7b00bed2dd Bug 1616353 - Part 9: Ensure the correct OriginAttributes are set on opened TabContext, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67215

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:49 +00:00
Nika Layzell
f036c4e342 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:47 +00:00
Nika Layzell
349de0b692 Bug 1616353 - Part 7.7: Remove window initialization properties which are redundant with nsOpenWindowInfo, r=kmag
These properties used to be passed to newly created content windows in many
different ways, but are now unified under nsOpenWindowInfo. This patch cleans up
the remaining properties.

Differential Revision: https://phabricator.services.mozilla.com/D67056

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:44 +00:00
Nika Layzell
ff629a72ba Bug 1616353 - Part 7.6: Pass nsOpenWindowInfo through the single-site browser, r=Gijs
The interface changes which ssb.jsm is being updated for are performed in
earlier parts. This patch just covers the required changes to frontend code to
propagate this information down to the nsFrameLoader when it is created.

Differential Revision: https://phabricator.services.mozilla.com/D67055

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:42 +00:00
Nika Layzell
0799ca4e5c Bug 1616353 - Part 7.5: Pass nsOpenWindowInfo through Geckoview, r=geckoview-reviewers,esawin,agi
The interface changes which GeckoViewNavigation.jsm is being updated for are
performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67054

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:39 +00:00
Nika Layzell
b99cf8f798 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:37 +00:00
Nika Layzell
3fee0903f1 Bug 1616353 - Part 7.3: Use nsOpenWindowInfo for initializing xul:browser elements, r=kmag
This patch adds a `openWindowInfo` XPCOM attribute to the `nsIBrowser` interface
supported by the browser custom element. This attribute is then read by
`XULFrameElement`, and passed to `nsFrameLoader` to ensure the relevant flags
are used for newly opened windows.

This patch does not add support for passing openWindowInfo into mozbrowser
elements.

Differential Revision: https://phabricator.services.mozilla.com/D67052

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:34 +00:00
Nika Layzell
17acacfbf5 Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag
This patch builds on top of part 7.1 by creating this object within
nsWindowWatcher and ContentParent to carry the relevant information through
provider interfaces when creating new content windows. The nsOpenWindowInfo
object is not created for new chrome windows.

This patch does not propagate these flags all of the way through to the
nsFrameLoader. That change is performed in later parts to keep each part
smaller.

Differential Revision: https://phabricator.services.mozilla.com/D67051

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:32 +00:00
Nika Layzell
9f32ad2bfe Bug 1616353 - Part 7.1: Introduce a new nsOpenWindowInfo type, r=Gijs,kmag
This type replaces the individual properties, like nextRemoteTabId and
presetOpenerWindow, which were passed around by frontend code for window opening
requests performed by Gecko. This new type is intentionally native-only to make
it easier to pass more information down to newly created windows in the future.

Differential Revision: https://phabricator.services.mozilla.com/D67050

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:24 +00:00
Nika Layzell
b40af4dcf3 Bug 1616353 - Part 6.5: Assert nsILoadContext attributes are correctly set when opening windows, r=smaug
This is necessary as, by this point, the BrowsingContext has already been
attached, and can no longer have its nsILoadContext flags updated.

Differential Revision: https://phabricator.services.mozilla.com/D67049

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:22 +00:00
Nika Layzell
e7223ffada Bug 1616353 - Part 6.4: Delay loading chrome window URIs until docshell has been configured, r=smaug
Previously, a load of the URI within a chrome docshell would start before the
chrome docshell has had a chance to be configured. This could cause problems, as
the load would be configured incorrectly.

After these changes, starting the load is delayed until after nsILoadContext
configuration is complete.

Differential Revision: https://phabricator.services.mozilla.com/D67048

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:19 +00:00
Nika Layzell
35001ec24d Bug 1616353 - Part 6.3: Replace many nsILoadContext mutators with assertions, r=smaug
Many of these setters are redundant, and duplicate work done elsewhere. As it is
no longer correct to set nsILoadContext attributes at these times, they're being
replaced with assertions.

Differential Revision: https://phabricator.services.mozilla.com/D67047

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:16 +00:00
Nika Layzell
98528edbf2 Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:14 +00:00
Nika Layzell
570fcda0e2 Bug 1616353 - Part 6.1: Implement nsILoadContext on BrowsingContext, r=smaug
This also moves nsDocShell's implementation of nsILoadContext to be based on its
BrowsingContext.

This patch does not, by itself, fix all places which try to mutate
`nsILoadContext`. Those are fixed by the other parts of this patch stack.

Differential Revision: https://phabricator.services.mozilla.com/D67045

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:12 +00:00
Nika Layzell
146e915363 Bug 1616353 - Part 5: Always set the opener for chrome windows late, r=kmag
This is OK, as all chrome BrowsingContext instances are always in the same
BrowsingContextGroup, so we don't need to have the initial opener avaliable when
creating the BrowsingContext to determine its BrowsingContextGroup.

This is used in part 7.2 to avoid propagating the opener window around when
creating chrome windows.

Differential Revision: https://phabricator.services.mozilla.com/D67044

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:09 +00:00
Nika Layzell
85be5590f7 Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag
This could cause issues, as we could incorrectly override the decision made by
nsWindowWatcher, and then override the decision again after the method returns.
This could cause the initial content browser to be configured incorrectly.

Differential Revision: https://phabricator.services.mozilla.com/D67043

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:07 +00:00
Nika Layzell
dd1ef62596 Bug 1616353 - Part 3: Use an attribute to set geckoViewUserContextId on a browser, r=geckoview-reviewers,esawin
This is necessary to avoid the use of setOriginAttributesBeforeLoading, which is
being removed in this patch set.

Differential Revision: https://phabricator.services.mozilla.com/D67042

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:04 +00:00
Nika Layzell
dd58bf3df5 Bug 1616353 - Part 2: Remove the isPrivate flag from ParentShowInfo, r=kmag
This flag tries to change nsILoadContext flags late during browser creation,
which won't be possible after this patch stack.

Differential Revision: https://phabricator.services.mozilla.com/D67041

--HG--
extra : moz-landing-system : lando
2020-04-07 21:38:56 +00:00
Nika Layzell
bf755bc6c4 Bug 1616353 - Part 1: Remove unused aIsPreallocated flag from NotifyTabContextUpdated, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67040

--HG--
extra : moz-landing-system : lando
2020-04-07 21:38:54 +00:00
Daosheng Mu
e2b211270f Bug 1611310 - Implement XRInputSource module. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D67430

--HG--
extra : moz-landing-system : lando
2020-04-07 21:26:01 +00:00
Nicholas Nethercote
8f6eed94e5 Bug 1626272 - Disable stack fixing on Windows awsy-dmd jobs. r=erahm,perftest-reviewers,sparky
Unfortunate, but it gets us back to where we were before `fix_stacks.py` came
along, and getting it working isn't worth the effort right now.

Differential Revision: https://phabricator.services.mozilla.com/D69928

--HG--
extra : moz-landing-system : lando
2020-04-07 21:19:52 +00:00
Razvan Maries
3b66f5f729 Backed out changeset b86e8f2cc5db (bug 1496578) for build bustages on nsDocShell.cpp. CLOSED TREE 2020-04-08 01:16:33 +03:00
Eric Rahm
73c5285b22 Bug 1627391 - Add missing includes and namespaces to xpcom/threads. r=xpcom-reviewers,sg
Also moves `nsThreadShutdownContext` to `nsThread.h` so it can be used by `nsThreadPool`.

Differential Revision: https://phabricator.services.mozilla.com/D69657

--HG--
extra : moz-landing-system : lando
2020-04-07 22:10:29 +00:00
Marco Bonardo
7457a384f2 Bug 1496578 - convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre
Differential Revision: https://phabricator.services.mozilla.com/D66579

--HG--
extra : moz-landing-system : lando
2020-04-07 21:55:24 +00:00