Amend several test files for triggering eval() assertion through simpletest.js
Differential Revision: https://phabricator.services.mozilla.com/D30474
--HG--
extra : moz-landing-system : lando
This patch doesn't port all of the existing tests because some of them
do not pass yet and some others need more work to be ported. This will
happen in follow-up bugs.
Differential Revision: https://phabricator.services.mozilla.com/D30401
--HG--
rename : toolkit/components/antitracking/test/browser/storageprincipal_head.js => toolkit/components/antitracking/test/browser/dynamicfpi_head.js
extra : moz-landing-system : lando
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.
Differential Revision: https://phabricator.services.mozilla.com/D29742
--HG--
extra : moz-landing-system : lando
This StorageAccess code tells callers that they must partition third-party
storage, or deny storage access if that is not possible.
Differential Revision: https://phabricator.services.mozilla.com/D29740
--HG--
extra : moz-landing-system : lando
The policy that this patch implements in the antitracking backend is to treat
third-party trackers exactly the same way as BEHAVIOR_REJECT_TRACKER, and
additionally partition all third-party contexts as well.
Differential Revision: https://phabricator.services.mozilla.com/D29738
--HG--
extra : moz-landing-system : lando
This error code indicates the specific case where the antitracking backend
rejects a particular access request because the resource is third-party and
the cookie policy mandates that third-party resources must be partitioned.
Differential Revision: https://phabricator.services.mozilla.com/D29737
--HG--
extra : moz-landing-system : lando
This new code designates our new cookie policy for blocking cookies and
storage access from third-party trackers and partitioning the cookie jar
of the rest of third-party resources.
Differential Revision: https://phabricator.services.mozilla.com/D29736
--HG--
extra : moz-landing-system : lando
Try to further reduce flicker by increasing the time we keep stale results visible.
Differential Revision: https://phabricator.services.mozilla.com/D30502
--HG--
extra : moz-landing-system : lando
The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.
See the comment for more details; the fix will be part of bug 1537933
Differential Revision: https://phabricator.services.mozilla.com/D30001
--HG--
extra : moz-landing-system : lando
- Fill stars based on whether the rating is within the 0.5 range of a
0.5-multiple, rather than checking whether the rating is at least as
large as the 0.5-multiple. This follows the boundaries at:
bb9277eeff/src/ui/components/Rating/index.js (L139-L140)
- Use a review star rating instead of re-using the bookmark star.
This is not necessarily to be more consistent with AMO's stars,
but to prevent the stars from becoming non-stars if we ever change
the bookmark icon. The SVG icon is based on the path at:
bb9277eeff/src/ui/components/IconStar/index.js (L19)
- Turn it into a custom element to make re-use easier.
Differential Revision: https://phabricator.services.mozilla.com/D29480
--HG--
extra : moz-landing-system : lando
Require `extensions.htmlaboutaddons.discover.enabled` to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.
Differential Revision: https://phabricator.services.mozilla.com/D29478
--HG--
extra : moz-landing-system : lando
Simply moved the callback from the icon to the button and updated the test.
Differential Revision: https://phabricator.services.mozilla.com/D30339
--HG--
extra : moz-landing-system : lando
As I said over bug 1549593, the eventual goal is to use ArcSlice in all
inherited properties. But this seemed like a good first candidate that doesn't
require me to move around a lot more code, since we were already using cbindgen
for the path commands.
Differential Revision: https://phabricator.services.mozilla.com/D30134
--HG--
extra : moz-landing-system : lando
We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.
Differential Revision: https://phabricator.services.mozilla.com/D30133
--HG--
extra : moz-landing-system : lando
This enables destructors for tagged unions in cbindgen, implemented in:
* https://github.com/eqrion/cbindgen/pull/333
Which allow us to properly generate a destructor for the cbindgen-generated
StyleBasicShape (which now contains an OwnedSlice).
For now, we still use the glue code to go from Box<BasicShape> to
UniquePtr<BasicShape>. But that will change in the future when we generate even
more stuff and remove all the glue.
I could add support for copy-constructor generation to cbindgen for tagged
enums, but I'm not sure if it'll end up being needed, and copy-constructing
unions in C++ is always very tricky.
Differential Revision: https://phabricator.services.mozilla.com/D29769
--HG--
extra : moz-landing-system : lando
Passing these by value won't be ok of course, but that's fine.
I plan to combine this with https://github.com/eqrion/cbindgen/pull/333 to
actually be able to share representation for ~all the things, this is just the
first bit.
Box<T>, Atom and Arc<T> will be much easier since cbindgen can understand them
without issues.
It's boxed slices the only ones I should need something like this. I could avoid
it if I rely on Rust's internal representation, which we can per [1], but then I
need to teach cbindgen all about slices, which is generally hard, I think.
[1]: https://github.com/rust-lang/unsafe-code-guidelines/blob/master/reference/src/layout/pointers.md
Differential Revision: https://phabricator.services.mozilla.com/D29768
--HG--
extra : moz-landing-system : lando
It's not worth dying on this hill. Both Blink and WebKit pass the tests.
(Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules
are not the same JS object, WebKit returns a new rule list. I'll file)
Spec PR in https://github.com/w3c/csswg-drafts/pull/3900.
Differential Revision: https://phabricator.services.mozilla.com/D30348
--HG--
extra : moz-landing-system : lando
The "Make default browser" setting is now just a button, part of the "General" settings.
We'll remove the layout for 2-pane settings and the now unused String.
Depends on D30468
Differential Revision: https://phabricator.services.mozilla.com/D30469
--HG--
extra : moz-landing-system : lando
