Commit Graph

5051 Commits

Author SHA1 Message Date
Corey Farwell
4c18146242 servo: Merge #8320 - Expand tidy to lint parts of /tests/wpt (from frewsxcv:expand-tidy); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: b098339f92a6d8351786686fb80aaaa76532ccb6
2015-11-04 15:14:28 +05:01
David Zbarsky
075284e51a servo: Merge #8202 - Allow retrieving width/height for non-positioned elements (from dzbarsky:getComputedStyle); r=pcwalton
This was causing a bunch of tests in tests/wpt/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes* to fail.  They were returning "auto" instead of the correct size. They still fail because the returned size is off by a few pixels, not sure why yet. But this is more correct and may fix other failing tests.

Source-Repo: https://github.com/servo/servo
Source-Revision: b6850853da5fc677ecfa15d273159371a909ac6c
2015-11-04 13:03:15 +05:01
David Zbarsky
ed7fd17b12 servo: Merge #8305 - Get rid of a bunch of explicit derefs (from dzbarsky:roots); r=Ms2ger,
Source-Repo: https://github.com/servo/servo
Source-Revision: 4b9fa13f2f6a1aa38d180367426498f01f6414c9
2015-11-04 10:34:54 +05:01
Matt Brubeck
e52999f7a9 servo: Merge #8317 - Fix unused import warning in headless builds (from mbrubeck:glutin-warning); r=saneyuki
Source-Repo: https://github.com/servo/servo
Source-Revision: 488459f80196a9d080dff9a57bfe0899c4c4ee68
2015-11-04 09:05:24 +05:01
Glenn Watson
11639f24e6 servo: Merge #8306 - Change overflow calculation to be calculated after compute_absolute_position (from glennw:fix-abd-overflow); r=pcwalton
Also include absolutely positioned elements in the overflow rect calculation.

Fixes #7797.

Source-Repo: https://github.com/servo/servo
Source-Revision: ca56ebbb09f3c258d10e7a7fa276d42fe258d893
2015-11-04 07:46:58 +05:01
Martin Robinson
92570bfa5e servo: Merge #8266 - Mix stacking contexts into the positioned content list (from mrobinson:stacking-context-mix); r=pcwalton
Sometimes positioned content needs to be layered on top of stacking
contexts. The layer synthesis code can do this, but the current design
prevents it because stacking contexts are stored in a separate struct
member. In order to preserve tree order, mix stacking contexts into the
positioned content list, by adding a new StackingContextClass
DisplayItem. Such items do not have a base DisplayItem.

In some ways this simplifies the code, because we no longer have to
have a separate code path in the StackingContextLayerCreator.

Source-Repo: https://github.com/servo/servo
Source-Revision: 86e3add8fdc35fc6980bb63695781925607437b8
2015-11-04 06:53:43 +05:01
Patrick Walton
9ddbcb6897 servo: Merge #8299 - Fix several bugs causing the page to reflow on every mouse move event (from pcwalton:dont-reflow-on-hover); r=mbrubeck
After all these changes are applied, Hacker News and GitHub only repaint and reflow nodes that actually have hover styles applied when the mouse moves over them.

r? @mbrubeck

cc @bholley

Source-Repo: https://github.com/servo/servo
Source-Revision: 36c5dd4c8c543ed6767fe9dd367281b292d68dba
2015-11-04 05:59:46 +05:01
Florian Merz
f4f9652bda servo: Merge #8265 - add get_raw_layout_value (HTMLInputElementHelpers) (from fiji-flo:password_caret); r=eefriedman
This resolves #8107
Previously the index of the insetion point for a password input was
calculated using the scrambled string based on the edit point in the
raw string. That could lead to a wrong position of the caret. This
commit changes this behavior to calculate the insertion point using
the raw string.

Source-Repo: https://github.com/servo/servo
Source-Revision: e91169c0e2cfe37b1a2d0feb3aab50b72c816ffc
2015-11-04 05:00:59 +05:01
rohan.prinja
e8b504412b servo: Merge #8221 - move modules around (from ajnirp:8130-reorganise); r=jdm
for #8130

Source-Repo: https://github.com/servo/servo
Source-Revision: daad09d44245228fba9118316937add71bec7c58
2015-11-04 02:27:02 +05:01
Nova Fallen
5d3a37181e servo: Merge #8303 - Refactor code dealing with headers of requests and responses #6638 (from nfallen:6638-http_loader); r=eefriedman
Extract the code in load in http_loader.rs that specifically deals with modifying the headers for a request into a separate function. Extract the code that deals with processing the headers for a response into a separate function. This will enable use by websocket code when starting a websocket connection is refactored out of the content process.

Source-Repo: https://github.com/servo/servo
Source-Revision: bb911d772eb075d57a45a39dddd89905a0437166
2015-11-03 23:52:29 +05:01
Matt Brubeck
4b6e081f7b servo: Merge #8232 - Correct event dispatching for multiple simultaneous touch points (from mbrubeck:glutin-touch); r=glennw
Instead of just converting the mouse into a single "touch" input, Servo can now listen for multi-touch events from Glutin, maintain a list of active touch points, and dispatch events for all of them.

r? @glennw (for the compositor changes) and @jdm (for the DOM changes)

Source-Repo: https://github.com/servo/servo
Source-Revision: 3fdaa6e3f32f6996c416e75119177b98d404adb2
2015-11-03 22:16:21 +05:01
Gilles Leblanc
91208857f8 servo: Merge #8111 - Compute value of float according to position value (from gilles-leblanc:issue-8002); r=SimonSapin
According to CSS2 Section 9.7, if 'position' has a value of 'absolute'
or 'fixed' the computed value of 'float' should be 'none'.

This changes the float to a single_keyword_computed which checks the
positioned value of the element to compute the float value.

Fixes #8002

Source-Repo: https://github.com/servo/servo
Source-Revision: 5070c873d03ef62a66f18596ccdf8a030107efd6
2015-11-03 21:10:32 +05:01
Alan Jeffrey
690f25f37c servo: Merge #8087 - Removced unncessary call to dirty() in Document::node_and_heritage_ch… (from asajeffrey:dont_dirty_twice); r=pcwalton
Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

Source-Repo: https://github.com/servo/servo
Source-Revision: 23efa0a36f22bc1ba06023892d7cb292f5899275
2015-11-03 20:35:39 +05:01
Martin Robinson
d989852fdd servo: Merge #8223 - Make executing synthesized pinch zoom more similar to zoom (from mrobinson:pinch-zoom-2); r=pcwalton
Synthesized pinch zoom was removed in #8121 so that this combination of
mouse wheel and key press can be handled by the page. I mistakenly
re-implemented it #8215. In order to preserve synthesized pinch zoom,
which is very useful for testing on desktop computers, have it work
similarly to page zoom except with the ALT key pressed.

Source-Repo: https://github.com/servo/servo
Source-Revision: 526a3c8df3882c83a0512dbb341cf7f1781ac402
2015-11-03 18:53:38 +05:01
Patrick Walton
b21eb76306 servo: Merge #8300 - layout: Avoid flooding the compositor with animation state changes if there are no animations running and no new animations were added (from pcwalton:avoid-animation-state-flooding); r=glennw
Avoids compositor jank during scroll.

r? @glennw

Source-Repo: https://github.com/servo/servo
Source-Revision: 27fb2ed26d0a9dca624ac26cd378a14ac0ea8678
2015-11-03 17:56:33 +05:01
Ms2ger
bc120e03a7 servo: Merge #8295 - Various cleanup (from Ms2ger:cleanup); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 1794e5875a1d1e61f00f7d0d0592fc5f7cd278d7
2015-11-03 15:59:14 +05:01
Ms2ger
0df5833603 servo: Merge #8239 - Remove unused code around ScriptReflow (from Ms2ger:ScriptReflow); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 9a800becdf7f6b3b3524d204485cb7c593b506f5
2015-11-03 15:00:17 +05:01
Eli Friedman
3d84958c1f servo: Merge #8056 - Fix the implementation of JSTraceable for RefCell (from eefriedman:trace-refcell); r=jdm
The existing implementation could panic; make sure that doesn't
happen by requiring that the contents of a RefCell are trivially
traceable (i.e. the value don't contain any traceable objects).

I'm not sure whether the TriviallyJSTraceable trait is actually
worthwhile; maybe we should just never use RefCell in the DOM.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4f51710ed387baa1ad0a6e4cdb0fc5eee44093d5
2015-11-03 06:38:40 +05:01
Ms2ger
2e551ff777 servo: Merge #8294 - Remove RawLayoutHTMLInputElementHelpers (from Ms2ger:layout-input); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 5c11c88e92ccbc3013501096d5625778774c9fee
2015-11-02 19:15:51 +05:01
Emilio Cobos Álvarez
8641baaa51 servo: Merge #8291 - Add destructors to some WebGL objects, remove duplicated glutin dependency and try to enable the webgl reftests (from emilio:webgl-drop); r=jdm
The first commit allows to cleanup the gl resources of the webgl task earlier if they aren't being used.
Right now all resources were cleaned up when the context was destroyed, so I think this is
a slightly better approach.

The second commit bumps rust-offscreen-rendering-context to remove the duplicated glutin dependency.

The third one tries to reenable the webgl reftests.
Since the errored builds are deleted, It's the only way I can try to troubleshoot it.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3282174a9941ec1f8d8821dfac44b850b77e7668
2015-11-02 18:23:33 +05:01
Eli Friedman
86179d45d6 servo: Merge #8245 - Use attribute getter/setter macros for misc DOM attributes (from eefriedman:misc-attribute-fixes); r=nox
This fixes a few minor bugs.

Source-Repo: https://github.com/servo/servo
Source-Revision: 50d51bab7faa5ce52e9f345eee3d49886433289f
2015-11-02 14:45:32 +05:01
David Zbarsky
5deb83534e servo: Merge #7400 - Allow more valid use of calc expressions (from dzbarsky:angle); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: e72bd1437c667d5429f2e288701ae99aac5c4b4e
2015-11-02 12:17:43 +05:01
David Zbarsky
625a98b708 servo: Merge #8193 - Use an Atom for Event.type (from dzbarsky:event_type); r=nox
Depends on https://github.com/servo/string-cache/pull/113

Source-Repo: https://github.com/servo/servo
Source-Revision: 35b452660bf0759d222e8f2ac4b8c57f75529443
2015-11-02 05:28:28 +05:01
nxnfufunezn
72d5e9f8e2 servo: Merge #8192 - Accept Brotli-compressed HTTP responses #8156 (from nxnfufunezn:brotli-decompressor); r=jdm
r? @jdm

Source-Repo: https://github.com/servo/servo
Source-Revision: 2e4454a42356c0ea9edf67f96922ac96e4d52900
2015-11-01 22:44:21 +05:01
Corey Farwell
26720ce882 servo: Merge #7965 - Implement 'labels' attribute on 'labelable elements' (from frewsxcv:labelable-elements-label-attribute); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 0e70a1f8a88fb1962e4ada447479b4228d09d724
2015-11-01 20:22:18 +05:01
Olivia Nordquist
5a05de931c servo: Merge #8290 - Un-boxed ScriptReflow (from itsmeolivia:store-script-reflow); r=Ms2ger
As per #8238 I changed `layout_interface::Msg::Reflow` to store `ScriptReflow` rather than `Box<ScriptReflow>`

I ran the tests and believe everything passed but this is my first commit to the project so sorry if I messed up the protocol!

Source-Repo: https://github.com/servo/servo
Source-Revision: 601169c0e5b0207805bb316b21e556f5ab67df9b
2015-11-01 14:21:17 +05:01
Bobby Holley
767285b863 servo: Merge #8274 - Implement state-based restyle hints (from bholley:state_restyle_hints); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 959ae86bd0435bf67626d3203a220c0e9f2eea40
2015-11-01 06:54:51 +05:01
Eli Friedman
d7844657ee servo: Merge #8287 - Fix unused variable warnings (from eefriedman:label-unused-var); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 1add1185ab338709082981f226e8227cabfac866
2015-11-01 05:50:03 +05:01
Eli Friedman
b5beb9c8b0 servo: Merge #8037 - Consistently use content-type sniffing with all protocols (from eefriedman:net-send-sniff); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 4cf49d4d0917a5784a54f2a26b138516dfcdc2bc
2015-11-01 03:21:29 +05:01
KALPESH KRISHNA
a1f978d9a6 servo: Merge #8260 - Implementing activation behavior for <label> (from martiansideofthemoon:my-code-fix); r=Manishearth
Attempt to resolve #8179
@Manishearth , could you give me some resources having more information about what each function in `Activatable` does? The code compiles on my machine but I guess a lot more is needed

Source-Repo: https://github.com/servo/servo
Source-Revision: 53d8f04ac4894480aa8bc7a6a79fb5e02ae050d1
2015-10-31 21:56:27 +05:01
Gökberk Yaltıraklı
d2159ca391 servo: Merge #7956 - Made binary files show an info message instead of garbled text (from gkbrk:binary_mime); r=jdm
Content-types with the TopLevel "Application" such as

* application/octet-stream
* application/pdf

now show an info message instead of trying to view binary data as html.

Source-Repo: https://github.com/servo/servo
Source-Revision: f432c3c49f9fb10de12feb17329984aa66a2848d
2015-10-31 21:01:52 +05:01
Ms2ger
22148e83d8 servo: Merge #8282 - Cleanup Document::handle_mouse_move_event a bit (from Ms2ger:handle_mouse_move_event); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 912359fcbd74ddfdfa7aaf11f28cc8c2cfbd0eac
2015-10-31 18:28:31 +05:01
nxnfufunezn
cba28409a5 servo: Merge #8262 - Removed JS::root #8251 (from nxnfufunezn:Remove_JS_root); r=Ms2ger
Fixes #8251

r? @Ms2ger

Source-Repo: https://github.com/servo/servo
Source-Revision: 37c03c78165fbb77eb024f2c3376d5e33cd7e446
2015-10-31 17:55:23 +05:01
Bobby Holley
5db6816cd0 servo: Merge #8162 - Centralize event states in rust-selectors (from bholley:centralize_event_states); r=pcwalton
This still needs a rev bump on rust-selectors once https://github.com/servo/rust-selectors/pull/55 gets merged.

Source-Repo: https://github.com/servo/servo
Source-Revision: 521a87180a85709f8f704df33537f79bd131bf71
2015-10-31 09:36:45 +05:01
Nova Fallen
ebbe16a2ae servo: Merge #8114 - Implement DOMStringMap::SupportedPropertyNames and NamedNodeMap::SupportedPropertyNames #7695 (from nfallen:7695); r=eefriedman
Here is a draft for issue #7695 with web platform tests.
Thanks for reviewing!
https://dom.spec.whatwg.org/#namednodemap
https://html.spec.whatwg.org/multipage/infrastructure.html#domstringmap

Source-Repo: https://github.com/servo/servo
Source-Revision: 7512aa69c034767cfb41206180bec50b020b2b0f
2015-10-31 07:35:08 +05:01
Corey Farwell
9e37827713 servo: Merge #8279 - Fix some rust-clippy violations (from frewsxcv:clippy-fixes); r=eefriedman
Source-Repo: https://github.com/servo/servo
Source-Revision: 913ac568750502087a7f1693b3657a24cefd2460
2015-10-31 06:22:47 +05:01
Martin Robinson
fcd7ccb3e0 servo: Merge #8276 - Snap fragment scroll points to pixel boundaries (from mrobinson:fragment-ticks); r=mbrubeck
These don't match hardware pixels, but work well enough when the device
pixel ratio is a whole number.

Source-Repo: https://github.com/servo/servo
Source-Revision: 84bf368c3bb8ec3550fe158a874e68e02bb0d2be
2015-10-31 05:19:00 +05:01
Connor Imes
0520aa1bd3 servo: Merge #8254 - Read params from a file on Android (from connorimes:android-params-file); r=larsbergstrom
Source-Repo: https://github.com/servo/servo
Source-Revision: 2d0d9ca04054eefcc094e2643e6388ed57919e84
2015-10-31 04:18:22 +05:01
Eli Friedman
8b4bb62780 servo: Merge #8257 - Attempt to fix webfont-related intermittent test failures (from eefriedman:reorder-webfont-check); r=mbrubeck
I'm not completely sure the race condition outlined in this patch is
actually the race condition causing failures... but it's a possibility.

(I plan to run this through try a couple of times to see if it actually helps.)

Source-Repo: https://github.com/servo/servo
Source-Revision: cff9a5456915403cc9559b14f1353adf3f8504f6
2015-10-31 03:14:54 +05:01
Michael Wu
8458798f2d servo: Merge #8273 - Minor cleanups for DOM (from michaelwu:cleanups); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c887aaf6943c3945aed391e6fbbc23c709a4517f
2015-10-31 01:00:25 +05:01
Ms2ger
4c8234b842 servo: Merge #8267 - Various improvements (from Ms2ger:cleanup); r=frewsxcv
Source-Repo: https://github.com/servo/servo
Source-Revision: 1dfc0481efd4687658ab34e68c883caeadd8b20f
2015-10-30 23:26:34 +05:01
nxnfufunezn
40fb652360 servo: Merge #8176 - Added support for using --features argument with --android (from nxnfufunezn:features-argument); r=mbrubeck
Fixes #8173
r? @mbrubeck

Source-Repo: https://github.com/servo/servo
Source-Revision: d8cb2762af389309ff9684f04194e4773ce33c3e
2015-10-30 22:24:40 +05:01
Corey Farwell
bf6b560a23 servo: Merge #8261 - Use 'atom!' macro for known static strings (from frewsxcv:atom-macro-static-str); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: f85f22c04fcd32c8fc3b02032a8ab62285992bd0
2015-10-30 18:51:25 +05:01
Ms2ger
84e4adc0d4 servo: Merge #8187 - Introduce a Layoutnode::new function and use it (from Ms2ger:layoutnode-new); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 6cc8186481110370205e7979f3942ad005889a30
2015-10-30 13:14:17 +05:01
Connor Imes
a6521e4324 servo: Merge #8253 - Heartbeats and energy profiling support for Android (from connorimes:android-energy-profiling); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: f9d79600c9399c6f804cfdce4a42fc118a1bdb47
2015-10-30 11:57:10 +05:01
Corey Farwell
741243bea5 servo: Merge #8255 - Remove struct field for <font> 'face' attribute (from frewsxcv:rm-font-face-attribute-field); r=eefriedman
Part of #7863

Source-Repo: https://github.com/servo/servo
Source-Revision: a1939b0c6f9dfddccfa5a7fff192a4e9db285e20
2015-10-30 11:00:29 +05:01
Matt Brubeck
59b831caee servo: Merge #8252 - Remove some unused code on Android (from mbrubeck:android-unused); r=mbrubeck
r? @larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: 4ad6eba69be10941fcde8cdb809654548dfdf44f
2015-10-30 08:36:06 +05:01
Ms2ger
29fae8b21b servo: Merge #8248 - Remove the Zeroable definition for Finite<T> (from Ms2ger:finite-zero); r=jdm
I have no idea why it was added, and it appears to be unused.

Source-Repo: https://github.com/servo/servo
Source-Revision: 851e7098c93a354fdf04808e7935f1bb3721e82b
2015-10-30 06:52:57 +05:01
rohan.prinja
258086b9fa servo: Merge #8250 - remove get_rooted() and replace all references to it with references … (from ajnirp:8246-remove-get-rooted); r=Ms2ger
…to get()

for #8246

Source-Repo: https://github.com/servo/servo
Source-Revision: 00b60b93860d32e1c5aaf0f9b4a2ce5110880652
2015-10-30 06:08:44 +05:01
Ms2ger
fad7f9bff1 servo: Merge #8212 - Remove SharedLayoutContext::reflow_root (from Ms2ger:reflow-root); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: b6bcccb204f710665482fa8098084a30126a3bac
2015-10-30 04:53:54 +05:01