Commit Graph

652808 Commits

Author SHA1 Message Date
Mathieu Leplatre
4d1fdc1226 Bug 1517475 - Execute recipe runner on Remote Settings "sync" event r=mythmon
Differential Revision: https://phabricator.services.mozilla.com/D30513

--HG--
extra : moz-landing-system : lando
2019-05-23 21:11:06 +00:00
Tom Ritter
6ac52e21b1 Bug 1471698 - Remove our binutils-corruption-avoiding workaround for mingw-clang r=froydnj
Depends on D31347

Differential Revision: https://phabricator.services.mozilla.com/D31349

--HG--
extra : moz-landing-system : lando
2019-05-22 13:40:36 +00:00
Andreea Pavel
21ad779f6a Backed out 3 changesets (bug 1551385) for breaking reftests at vtt_overlapping_time.html on a CLOSED TREE
Backed out changeset 4268e661e741 (bug 1551385)
Backed out changeset fb20dcf3c072 (bug 1551385)
Backed out changeset 883151b42d88 (bug 1551385)
2019-05-24 00:23:19 +03:00
Stone Shih
946b97b939 Bug 1370630 - Untrusted submit event shouldn't trigger form submission; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D28070

--HG--
extra : moz-landing-system : lando
2019-05-23 20:30:20 +00:00
Jeff Gilbert
047e98938e Bug 1536672 - Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot
Also disable clang-format for gfx/gl/GLConsts.h.

Differential Revision: https://phabricator.services.mozilla.com/D28168

--HG--
extra : moz-landing-system : lando
2019-05-23 20:48:21 +00:00
Edwin Gao
231ad45e42 Bug 1552563 - remove mochitest-media from whitelist not requiring compiz CLOSED TREE
Summary:
Changes:
- remove `mochitest-media` from the whiteslist - compiz is required.

Test Plan: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Csuperseded%2Cusercancel%2Cretry%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=f16b0ce4af9e575ef2ec877b405698c0b0c62f92

Reviewers: jmaher, gbrown

Bug #: 1552563

Differential Revision: https://phabricator.services.mozilla.com/D32383

--HG--
extra : rebase_source : 1d8b1ba401ab9b565258fd6be4c0de9975e1e4fd
extra : histedit_source : c53f405d98335228f3313abedb4dfd26fab4f9e2
2019-05-23 23:53:21 +03:00
Andreea Pavel
3c9b661125 Backed out changeset 52e365586577 (bug 1552563) for failing test_getUserMedia_basicScreenshare.html on a CLOSED TREE 2019-05-23 23:52:19 +03:00
Andreea Pavel
b6b841afb8 Backed out changeset 9b60f95e81da (bug 1547795) for breaking a11y at test_media.html on a CLOSED TREE 2019-05-23 23:47:50 +03:00
Sean Stangl
4c8b6930df Bug 1551339 - Update VIXL to recent Utils and Globals files. r=nbp
This is preliminary work to allowing encoding of JSCVTFP, the instruction that exists on new AArch64 devices that greatly speeds up websites that use floating-point math.

Differential Revision: https://phabricator.services.mozilla.com/D30997

--HG--
extra : moz-landing-system : lando
2019-05-23 20:26:52 +00:00
Kartikaya Gupta
833138cca0 Bug 1551648 - Record peak resident memory usage in telemetry. r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D32184

--HG--
extra : moz-landing-system : lando
2019-05-23 20:06:33 +00:00
Dzmitry Malyshau
d3f4d3cc1c Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj
Update rand version in u2fhid and xpcom

Differential Revision: https://phabricator.services.mozilla.com/D31669

--HG--
rename : third_party/rust/scopeguard/.cargo-checksum.json => third_party/rust/scopeguard-0.3.2/.cargo-checksum.json
rename : third_party/rust/scopeguard/Cargo.toml => third_party/rust/scopeguard-0.3.2/Cargo.toml
rename : third_party/rust/scopeguard/README.rst => third_party/rust/scopeguard-0.3.2/README.rst
rename : third_party/rust/scopeguard/examples/readme.rs => third_party/rust/scopeguard-0.3.2/examples/readme.rs
rename : third_party/rust/scopeguard/src/lib.rs => third_party/rust/scopeguard-0.3.2/src/lib.rs
extra : moz-landing-system : lando
2019-05-23 19:54:25 +00:00
alwu
0888e9c1ac Bug 1550633 - part17 : modify test 'browser_cache.js'. r=timhuang
As now we won't automatically load disabled text track, we have to mark track as `default` in order to trigger loading.

Differential Revision: https://phabricator.services.mozilla.com/D32359

--HG--
extra : moz-landing-system : lando
2019-05-23 17:58:40 +00:00
alwu
8657110169 Bug 1550633 - part16 : turn off the pref 'media.block-autoplay-until-in-foreground' in wpt. r=jgraham
Sometime wpt runs test even before the document becomes visible, which would delay `video.play()` and cause `play()` running in wrong order.

Differential Revision: https://phabricator.services.mozilla.com/D32079

--HG--
extra : moz-landing-system : lando
2019-05-23 17:58:40 +00:00
alwu
c96313eb80 Bug 1550633 - part15 : return error when we failed to create channel. r=jya
The channel might not be created correctly if we pass invaild url (eg. "invalid://url"), we should handle this error.

Differential Revision: https://phabricator.services.mozilla.com/D32038

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:08 +00:00
alwu
9fc4931d42 Bug 1550633 - part14 : add a test for 'honor user preferences for automatic text track selection'. r=bzbarsky
This test is used to ensure that we queue 'honor user preferences for automatic text track selection' as a marco task, not a mirco task.

In this test, we would trigger a media event before queuing a text track selection task, and check the text track's mode to know whether the text track selection runs after the task for media event.

Differential Revision: https://phabricator.services.mozilla.com/D31921

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:10 +00:00
alwu
f0b8fff7fc Bug 1550633 - part13.6 - refactor tests. r=jya
Refactor those tests' structure in order to make them more readable, and add the comment to show what the test purpose is for each test.

Differential Revision: https://phabricator.services.mozilla.com/D31914

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:12 +00:00
alwu
580e319c3d Bug 1550633 - part13.5 - wait text track element's 'load' event. r=jya
This patch do two things in order to trigger loading for track element and wait for correct event to check track's and cues' status after loading finished.

(1) listen track element's load event
There are some tests listening video's loadedmetadata, but it's wrong. The loading process of media element and track element are completely non-related.
If you would like to check track element's status, you should wait for track element's load event.

(2) enable track explictly
If the text track which has default attribute is added to the media element before the media element starts running automatic track selection [1], then it would be enable by the media element.
Otherwise, you have to enable track explicitly by changing its track mode.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-7

Differential Revision: https://phabricator.services.mozilla.com/D31913

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:14 +00:00
alwu
ca2b2b41e4 Bug 1550633 - part13.4 : don't use anonymous function. r=jya
Use named function for callback to reduce the indentation.

Differential Revision: https://phabricator.services.mozilla.com/D31912

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:16 +00:00
alwu
fa43c41e98 Bug 1550633 - part13.3 - create elements in HTML, not in JS. r=jya
Create test elements in HTML beforehand, which can remove unnecessary JS code and make test cleaner.

Differential Revision: https://phabricator.services.mozilla.com/D31911

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:18 +00:00
alwu
1c972a7e52 Bug 1550633 - part13.2 - no need to set pref "media.webvtt.regions.enabled". r=jya
These tests didn't use region at all, so we have no need to set the pref.

Differential Revision: https://phabricator.services.mozilla.com/D31910

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:21 +00:00
alwu
a1dfdc2964 Bug 1550633 - part13.1 - remove unnecessary elements. r=jya
These elemenets are useless and we can run tests without them.

Differential Revision: https://phabricator.services.mozilla.com/D31909

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:23 +00:00
alwu
05d99aa6d5 Bug 1550633 - part12 : enable wpts. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D31561

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:25 +00:00
alwu
84ef4e1182 Bug 1550633 - part11.1 - modify 'track-element-src-change-error.html'. r=jya
According to spec [1], if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we need to change the text track readiness state to`failed to load` and dispatch `error`.

So we now only fire `error` if `src` is removed during loading, but if the track element has finished loading before removing `src`, we won't dispatch `error` for it.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3

Differential Revision: https://phabricator.services.mozilla.com/D31915

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:29 +00:00
alwu
307f759685 Bug 1550633 - part11 : modify wpt 'track-element-src-change.html' and 'track-element-src-change-error.html'. r=jya
According to the spec [1], the text track list of cues is initially empty. It is dynamically modified when the referenced file is parsed.

Therefore, after reset the track element's url, the number of cues of the text track should be zero, until we start parsing resource and add cue into the list.

[1]
https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues
https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-list-of-cues-3

Differential Revision: https://phabricator.services.mozilla.com/D31560

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:27 +00:00
alwu
dde1d1908f Bug 1550633 - part10 : automatically capture and print the address of track element in debug log and add new log. r=jya
To reduce non-neccesary input, we can always capture `this` and print the address in the log, and use same log level for all of them.

Differential Revision: https://phabricator.services.mozilla.com/D31559

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:31 +00:00
alwu
4114ea44bb Bug 1550633 - part9 : capture 'this' in lambda. r=jya
There are too many `self` used in the lambda, we can just capture `this` to remove redudant `self`.

Differential Revision: https://phabricator.services.mozilla.com/D31558

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:33 +00:00
alwu
7e5bb0ce04 Bug 1550633 - part8 : no need to reload if the new url is the same. r=jya
Accoding to spec [1], after loading finished, the start the track processing model would stop at step12 and wait until the track URL changes to the URL which is not equal to the URL we have loaded before. That means, if we change track URL to the same URL we loaded before, we won't have to reload the resource.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:track-url-5

Differential Revision: https://phabricator.services.mozilla.com/D31557

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:35 +00:00
alwu
ab8de37693 Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya
`Failed to load` [1] indicates that the text track was enabled, but when the user agent attempted to obtain it, this failed in some way.

According to the spec [2], if fetching fails for any reason (network error, the server returns an error code, CORS fails, etc), or if URL is the empty string, then queue a task to first change the text track readiness state to `failed to load` and then fire an event named `error` at the track element. And spec [3] also mention that, if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we also need to change the text track readiness state to`failed to load` and dispatch `error`.

[1] https://html.spec.whatwg.org/multipage/media.html#text-track-readiness-state
[2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load
[3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3

Differential Revision: https://phabricator.services.mozilla.com/D31556

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:37 +00:00
alwu
da6ab8db25 Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku
According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src

Differential Revision: https://phabricator.services.mozilla.com/D31552

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:40 +00:00
alwu
957438151e Bug 1550633 - part5 : modify and enable test 'track-mode-not-changed-by-new-track.html'. r=jya
In `honor user preferences for automatic text track selection` [1], we would set `did-perform-automatic-track-selection` flag to true [2], and then we won't execute automatic track selection anymore [3].

It means that we would only do automatic track selection one time, and then user has to enable newly added track explicitly by changing its mode.

In this test, we have done the automatic track selection when we added the `metadata` track to media element's text track list, so we won't run it again, even if the newly added track has `default` attribute.

Therefore, we have to enable the `caption` track explicitly. In addition, add the missing `event` parameter for the function `trackAdded()`.


[1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection
[2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection-2
[3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:did-perform-automatic-track-selection

Differential Revision: https://phabricator.services.mozilla.com/D31375

--HG--
extra : moz-landing-system : lando
2019-05-23 09:03:42 +00:00
alwu
49164193d6 Bug 1550633 - part4 : no need to run text track selection in stable state. r=bzbarsky
According to spec [1], it doesn't mention that we have to run text track selection in stable state, it just said "the user agent must queue a task to run the following steps".

[1] https://html.spec.whatwg.org/multipage/media.html#honor-user-preferences-for-automatic-text-track-selection

Differential Revision: https://phabricator.services.mozilla.com/D31374

--HG--
extra : moz-landing-system : lando
2019-05-23 09:04:58 +00:00
alwu
3482cd7776 Bug 1550633 - part3 : add debug log to show track's kind. r=jya
Showing track's kind in debug log is helpful.

Differential Revision: https://phabricator.services.mozilla.com/D31373

--HG--
extra : moz-landing-system : lando
2019-05-23 09:05:00 +00:00
alwu
47597aeb6b Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya
According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31372

--HG--
extra : moz-landing-system : lando
2019-05-23 09:05:02 +00:00
alwu
7ba57e42c0 Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya
According to the spec step2 [1], we should not load resource for the track element which text track is disabled.

[1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31371

--HG--
extra : moz-landing-system : lando
2019-05-23 09:05:04 +00:00
Kartikaya Gupta
5f30b8c664 Bug 1549776 - Add taskcluster jobs for running wrench on Android. r=jrmuizel
Also docs for running the same thing locally.

Differential Revision: https://phabricator.services.mozilla.com/D32015

--HG--
extra : moz-landing-system : lando
2019-05-23 19:31:06 +00:00
Kartikaya Gupta
d35c6b3268 Bug 1549776 - Add a script to run wrench reftests on an Android emulator. r=gbrown
This adds an android_emulator_wrench.py script that uses mozharness to
control the Android emulator, and run the wrench reftests. It has an
associated wrench.py config script which is similar to existing android
config scripts.

The android_emulator_wrench script is structured a little differently
from other android mozharness scripts, mostly for two reasons:

1) I tried hard to make it locally runnable by developers, using
   ./mach python. This allows develpers to more easily reproduce the
   setup that runs in automation, and does so without duplicating a lot
   of code.

2) I also tried to make the script use fewer of what I consider to be
   "opaque" mozharness features, like the actions list which can run
   hard-to-find preflight and postflight functions. Instead of treating
   mozharness like a framework and filling in some functions for it to
   invoke as part of it's grand plan, I treat it more like a library and
   specifically the functions I want in the order that I want, which
   makes it easier for novice developers to debug problems.

As part of writing this script I extracted a few helper functions and made
some minor changes to existing android/adb mozharness machinery, but these
are all simple refactorings and should introduce no functional change.

Differential Revision: https://phabricator.services.mozilla.com/D32014

--HG--
extra : moz-landing-system : lando
2019-05-23 17:02:49 +00:00
Kartikaya Gupta
8cf7462c57 Bug 1549776 - Disable more reftests due to failures on Android. r=gw
Differential Revision: https://phabricator.services.mozilla.com/D32013

--HG--
extra : moz-landing-system : lando
2019-05-23 15:30:22 +00:00
Kartikaya Gupta
d98f966468 Bug 1549776 - Disable some reftests on debug Android. r=gw
These tests cause panics in debug mode because of the extra GL error
checking. Tests that are disabled are annotated with the failing
GL call.

Differential Revision: https://phabricator.services.mozilla.com/D32012

--HG--
extra : moz-landing-system : lando
2019-05-23 15:30:18 +00:00
Kartikaya Gupta
7b3a5c9560 Bug 1549776 - Disable some reftests on Android. r=gw
Differential Revision: https://phabricator.services.mozilla.com/D32011

--HG--
extra : moz-landing-system : lando
2019-05-23 15:30:08 +00:00
Kartikaya Gupta
14af7bef4d Bug 1549776 - Ensure debug wrench aborts on panic. r=gw
This makes it so that when running reftests, wrench actually terminates
after a panic rather than just hanging. Termination is detectable and so
we can clean up properly instead of waiting until some other layer hits
a timeout.

Differential Revision: https://phabricator.services.mozilla.com/D32010

--HG--
extra : moz-landing-system : lando
2019-05-23 15:30:04 +00:00
Kartikaya Gupta
4a3ea068e9 Bug 1549776 - Fix path to artifact. r=gw
Typo when I first landed this, but nothing relied on it so it didn't matter.

Differential Revision: https://phabricator.services.mozilla.com/D32009

--HG--
extra : moz-landing-system : lando
2019-05-23 15:29:55 +00:00
Joel Maher
b5f7a11b2c Bug 1553845 - turn on all talos/raptor jobs for osx 10.14. r=gbrown
turn on all talos/raptor jobs for osx 10.14.

Differential Revision: https://phabricator.services.mozilla.com/D32334

--HG--
extra : moz-landing-system : lando
2019-05-23 15:23:47 +00:00
Mike Conley
9eb1aeadb9 Bug 1547795 - Hide Picture-in-Picture toggle on videos where its probably more annoying than not. r=JSON_voorhees
This makes our video controls bindings check on loadedmetadata events whether or not to display
the toggle.

Differential Revision: https://phabricator.services.mozilla.com/D32365

--HG--
extra : moz-landing-system : lando
2019-05-23 18:49:10 +00:00
Kevin Jacobs
7234bae169 Bug 1492305 - Fix LibSecret unlocking & NSS return values r=keeler,MattN
This fixes issues with the NSS and LibSecret keystore not correctly rejecting unlocking of the key store.

Updated for dynamic loading of LibSecret and a bug workaround added elsewhere (updated green try below)

Depends on D9969.

Differential Revision: https://phabricator.services.mozilla.com/D7713

--HG--
extra : moz-landing-system : lando
2019-05-22 18:25:59 +00:00
Rob Lemley
d19172b2de Bug 1552422 - correct Balrog scope for comm-esrXX branches. r=tomprince
Copying fix from THUNDERBIRD_60_VERBRANCH on mozilla-esr60.
eae0435135

Differential Revision: https://phabricator.services.mozilla.com/D31584

--HG--
extra : moz-landing-system : lando
2019-05-21 21:16:57 +00:00
Zibi Braniecki
9e3c527610 Bug 1546432 - Move DocumentL10n to use mozILocalization. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D31554

--HG--
extra : moz-landing-system : lando
2019-05-21 19:22:36 +00:00
Zibi Braniecki
da44becb55 Bug 1546432 - Add basic Mutations tests. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D31553

--HG--
extra : moz-landing-system : lando
2019-05-21 19:22:29 +00:00
Zibi Braniecki
2a9aacbacb Bug 1546432 - Add roots management to Mutations. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D31337

--HG--
extra : moz-landing-system : lando
2019-05-23 19:01:35 +00:00
Zibi Braniecki
2ee19983ae Bug 1546432 - Migrate DocumentL10n to use dom::l10n::Mutations. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D28981

--HG--
extra : moz-landing-system : lando
2019-05-21 19:46:32 +00:00
Zibi Braniecki
fbc6e0304a Bug 1546432 - Introduce mozilla::dom::l10n::Mutations. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D28979

--HG--
extra : moz-landing-system : lando
2019-05-21 19:21:54 +00:00