Commit Graph

714743 Commits

Author SHA1 Message Date
Kris Maglione
4f021f549e Bug 1645862: Part 2 - Get rid of ContentProcessSingleton. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D79871
2020-06-24 17:33:52 +00:00
Kris Maglione
977f86fb80 Bug 1645862: Part 1 - Split TelemetryController into parent and content modules. r=chutten
Most of TelemetryController is only used in the parent process, but is
currently loaded in all processes, where it needlessly consumes tens of KB of
memory. This patch splits the parent- and content-specific parts, and only
loads each in the processes where they're needed.

Differential Revision: https://phabricator.services.mozilla.com/D79870
2020-06-24 17:33:49 +00:00
Daosheng Mu
16ae869cfe Bug 1636011 - Remove FxR PC installation probes. r=kip,thomasmo,chutten
We don't need these telemetry in Gecko now because we are working on it with Glean.

Differential Revision: https://phabricator.services.mozilla.com/D80116
2020-06-24 17:29:45 +00:00
Rob Wu
b84e5f4143 Bug 1635781 - Fully replace the web page's CSP if modified by add-on r=mixedpuppy
The original addition of CSP to `headersAlreadySet` in bug 1462989 was
to make sure that CSP response headers from different extensions are
merged as expected. The logic did however not take into account that
unconditionally merging modified headers means that the header would be
merged with the original CSP from the web page, which prevented add-ons
from relaxing a CSP from the web page.

This commit fixes the bug by tracking the CSP status on the
`ResponseHeaderChanger` instance, which is shared by all webRequest
handlers of a single request.

Differential Revision: https://phabricator.services.mozilla.com/D80761
2020-06-24 17:17:08 +00:00
Rob Wu
89ab97b36b Bug 1635781 - Improve initialization and documentation of test_ext_webRequest_mergecsp.js r=mixedpuppy
- Expand comment on the meaning of the parameters in `test_csp`.

- `sendMessage` is not async, properly await the result.

- Unload extensions before checking assertions, to avoid unhelpful error
  messages about extensions not having been unloaded at the end of the
  test.

- Report which test case is being run to make debugging easier.

Differential Revision: https://phabricator.services.mozilla.com/D80760
2020-06-24 17:04:21 +00:00
Mitchell Hentges
a16c5f70d6 Bug 1644553: Don't enable profile use for artifact builds r=glandium,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D80565
2020-06-24 16:57:36 +00:00
Agi Sferro
1c95002d18 Bug 1644561 - Verify that mCapturePixelsResults is not empty. r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D80757
2020-06-24 17:07:03 +00:00
Jason Orendorff
1b921cff65 Bug 1646317 - Fix Assertion failure: errorObj->type() == JSEXN_AGGREGATEERR, at builtin/Promise.cpp:3896. r=jwalden.
Differential Revision: https://phabricator.services.mozilla.com/D80721
2020-06-24 14:06:05 +00:00
Tom Tung
3e754f2b5c Bug 1645943 - Override xFullPathname to avoid the use of GetFullPathNameW; r=janv,asuth
Differential Revision: https://phabricator.services.mozilla.com/D80202
2020-06-24 16:08:45 +00:00
Andrew Creskey
1670be2396 Bug 1646987 - Increase browsertime-iterations for the app-link tests to 14 r=tarek
We are seeing a pretty broad distribution of results for the applink tests.
This bug increases the number of browsertime iterations from 10 to 14.

Differential Revision: https://phabricator.services.mozilla.com/D80363
2020-06-24 15:30:41 +00:00
Chris H-C
c1a1045511 Bug 1635255 - Don't compile FOG IPC layer and tests if not MOZ_GLEAN r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D80722
2020-06-24 16:16:48 +00:00
Chris H-C
269e1833eb Bug 1635255 - Adapt to get_AppInfoService removal r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D80516
2020-06-24 16:16:39 +00:00
Chris H-C
0f5f388a16 Bug 1635255 - Test child-process counter metrics r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D79898
2020-06-24 16:16:37 +00:00
Chris H-C
5a90b156f6 Bug 1635255 - Implement the Rust <-> C++ ffi for FOG IPC r=janerik
Bringing it all together.

Differential Revision: https://phabricator.services.mozilla.com/D79747
2020-06-24 16:16:29 +00:00
Chris H-C
a622fa625c Bug 1635255 - Skeleton IPC impl for Counter r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D79746
2020-06-24 16:16:27 +00:00
Chris H-C
61ff9175f3 Bug 1635255 - Document FOG's IPC r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D79745
2020-06-24 16:16:20 +00:00
Chris H-C
6f5695446e Bug 1635255 - Build glean crate conditionally on Gecko symbols r=janerik
Introduces a gkrust Cargo feature `glean_with_gecko` and `with_gecko` on fog
and glean. This feature signifies the presence of gecko symbols in the build.

Use this feature to implement needs_ipc() which asks Gecko which process type
we're running as.

Differential Revision: https://phabricator.services.mozilla.com/D79744
2020-06-24 16:16:17 +00:00
Chris H-C
afc734d4c0 Bug 1635255 - Add skeleton FOG IPC GTests r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D79743
2020-06-24 16:16:10 +00:00
Chris H-C
b661a96155 Bug 1635255 - Flesh out FOG IPC one additional layer r=janerik
Introducing FOGIPC, the central clearinghouse for the C++ layer between
PContent and FOG's Rust impl.

Gotta add tests.

Differential Revision: https://phabricator.services.mozilla.com/D79742
2020-06-24 16:16:07 +00:00
Chris H-C
086780a93b Bug 1635255 - Sketch out StringMetric ipc support r=janerik
This isn't 100% of a solution yet as the main process has no way of turning
a MetricId into a StringMetric (we're gonna a need a table. Maybe several.)
which we'll need before we can replay.

Also, there's no serialization or communication yet, which I guess is a bigger
deal.

Oh, and no detection of which process we're even on.

Differential Revision: https://phabricator.services.mozilla.com/D79741
2020-06-24 16:15:57 +00:00
Chris H-C
f177f29a3f Bug 1635255 - Add FOG IPC to PContent r=janerik
Temporarily on PContent instead of managed by PBackground, there's one
parentbound message for occasionally uplifting Glean data from child processes
and one childbound message for forcing the immediate flush of Glean data in the
async return.

Can't write gtests for this as ContentChild and ContentParent include things
that aren't present in gtest.

Differential Revision: https://phabricator.services.mozilla.com/D78077
2020-06-24 16:15:50 +00:00
Hubert Boma Manilla
21ef456a07 Bug 1647625 - Undo check for id or reason for block requests r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D80679
2020-06-24 12:01:27 +00:00
Hubert Boma Manilla
bc56a33f92 Bug 1645748 - Add the MDN link for status code r=Honza
- Added the MDN link for status codes
- Fixed tooltip for the enhanced protection tracking MDN link

Differential Revision: https://phabricator.services.mozilla.com/D80831
2020-06-24 15:51:51 +00:00
Gijs Kruitbosch
380e9f04f1 Bug 1631991 - stop wasting minutes of infra time waiting for the startup cache in gtests, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D80765
2020-06-24 16:00:32 +00:00
Andrea Marchesini
1a01cb3d74 Bug 1646136 - Improve the comments in the preload/prefetch tests for network state isolation, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D80903
2020-06-24 16:16:00 +00:00
Jared Wein
7639e4f712 Bug 1643093 - Remove references to 'whitelist' in browser/components/urlbar. r=jaws
Depends on D78124

Differential Revision: https://phabricator.services.mozilla.com/D78122
2020-06-24 15:59:04 +00:00
Sebastian Hengst
e9fd271cc7 Bug 1645663 - adjust expectations for RTCRtpSender-replaceTrack.https.html on Windows 7 debug. r=test-only DONTBUILD CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D80901
2020-06-24 17:58:38 +02:00
Andrea Marchesini
7c0f7e892c Bug 1646136 - Isolate preload channels per first-party when privacy.partition.network_state is set to true, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D80047
2020-06-24 15:34:33 +00:00
Andrea Marchesini
2753380aaa Bug 1646136 - Isolate prefetch channels per first-party when privacy.partition.network_state is set to true, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D80046
2020-06-24 15:31:31 +00:00
Emilio Cobos Álvarez
d725223bc4 Bug 1647871 - Remove nsIWidget::GetCompositionSize(). r=kats
No longer called. This was done as an optimization for OOP iframes, but
it affects the scrollport so it's clearly not sound (the visible rect
shouldn't affect the layout scroll port).

If very tall OOP iframes are a problem somehow, it's something that we
need to deal with in another place. It was, in fact, removed for
top-level remote iframes because of bug 1554861 and other regressions.

Depends on D80731

Differential Revision: https://phabricator.services.mozilla.com/D80732
2020-06-24 13:30:45 +00:00
Emilio Cobos Álvarez
2948ee6b8c Bug 1647871 - Remove AutoResizeReflowSquasher. r=kats
After the above, I don't think this is needed anymore, because we
shouldn't be looking at the widget size from layout.

It also shouldn't cause more reflows on desktop at least, because of the
early out in ResizeReflowIgnoreOverride before calling
SimpleResizeReflow().

Differential Revision: https://phabricator.services.mozilla.com/D80731
2020-06-24 13:29:18 +00:00
Emilio Cobos Álvarez
24e9f0cd8e Bug 1647871 - Fix a typo in a dynamic toolbar unit test. r=geckoview-reviewers,agi
No behavior change actually (as instant is the default behavior), but I
just noticed it while debugging these.

Depends on D80723

Differential Revision: https://phabricator.services.mozilla.com/D80724
2020-06-24 13:18:50 +00:00
Emilio Cobos Álvarez
9972401d14 Bug 1647871 - Simplify content viewer composition size code. r=kats,hiro
This should be equivalent because:

 * Content viewer size and widget size should eventually be the same always
   (modulo mid-resize, see bug 1645954).

 * Only the root content document has a widget on android (the puppet widget).

 * Only the root content document has a dynamic toolbar.

 * We were only calling this on the root document, which has no parent pres
   context (at least with e10s). Without e10s we could have a chrome
   prescontext (not sure it that ends up being a parent in the pres context
   chain), but we should never change the resolution of that one, so I think
   aScaleContentViewerSize is just useless.

This avoids having two sources of truth by always checking the content viewer
size without subtracting the dynamic toolbar max size.

Differential Revision: https://phabricator.services.mozilla.com/D80723
2020-06-24 14:46:40 +00:00
Ricky Stewart
d44b1b67a3 Bug 1647873 - Remove "mach bootstrap is not fully implemented in MozillaBuild" message r=nalexander
This message dates from bug 1177128, the commit where this bootstrapper was added. At the time of writing that was certainly true, but today it doesn't appear to be true in any meaningful way. There's certainly an expectation that installing MozillaBuild and running `mach bootstrap` will get your machine ready to build Firefox; or at least, if it doesn't, it prints out some error messages telling you to do extra stuff, like we see in bug 1644794 for example. Therefore, I don't see how this message is relevant at all any more.

Differential Revision: https://phabricator.services.mozilla.com/D80730
2020-06-24 02:47:43 +00:00
Gijs Kruitbosch
b4623ffd8b Bug 1647787 - remove use of whitelist/blacklist from front-end performance tests, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D80697
2020-06-24 14:23:49 +00:00
Florin Strugariu
075132ec5d Bug 1520458 - Update Raptor to run on python 3 r=perftest-reviewers,davehunt
Differential Revision: https://phabricator.services.mozilla.com/D77315
2020-06-24 14:33:12 +00:00
Steve Fink
d11d7fad9a Bug 1647118 - Throw error on short read in readTransferMap r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D80554
2020-06-23 22:03:06 +00:00
Jon Coppeard
065f106d88 Bug 1638764 - Make the incremental marking validator check that all chunks are found in its map r=sfink
I still don't know why this is happening, but this should make the problem a release mode assertion failure rather than an illegal memory access.

Differential Revision: https://phabricator.services.mozilla.com/D80866
2020-06-24 14:04:39 +00:00
Paul Adenot
25c8980495 Bug 1645416 - Fix the TracePayload layout on 32bits and re-enable the static assert that check the struct has a size that is a power of two. r=achronop
Differential Revision: https://phabricator.services.mozilla.com/D80696
2020-06-24 14:31:07 +00:00
Michael Kaply
c244c9c2ea Bug 1639945 - Add support for session cookies in policy. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D79902
2020-06-24 14:26:21 +00:00
Mihai Alexandru Michis
fe89d1f20e Backed out 11 changesets (bug 1635255) for causing bustages in FOGIPC.cpp
CLOSED TREE

Backed out changeset d3e93edb1c76 (bug 1635255)
Backed out changeset 27df18486bff (bug 1635255)
Backed out changeset 4675772344eb (bug 1635255)
Backed out changeset 4d0c4beb910e (bug 1635255)
Backed out changeset 9b79c8208144 (bug 1635255)
Backed out changeset cb54f7a3177d (bug 1635255)
Backed out changeset d0591dc8d5a1 (bug 1635255)
Backed out changeset 5fc5e1070d4d (bug 1635255)
Backed out changeset bfcfda9cb19d (bug 1635255)
Backed out changeset 49447f10ad6e (bug 1635255)
Backed out changeset 0862a33399cf (bug 1635255)
2020-06-24 17:21:10 +03:00
moz-wptsync-bot
04519cf254 Bug 1647884 - [wpt-sync] Update web-platform-tests to e32f3a1e058335c5f4ad705b208f8e4610ad7b6c, a=testonly
MANUAL PUSH: wpt sync bot

wpt-head: e32f3a1e058335c5f4ad705b208f8e4610ad7b6c
wpt-type: landing
2020-06-24 14:11:30 +00:00
moz-wptsync-bot
2384612164 Bug 1647163 [wpt PR 24267] - Update wpt metadata, a=testonly
wpt-pr: 24267
wpt-type: metadata
2020-06-24 14:11:29 +00:00
Mattias Buelens
a772eda118 Bug 1647163 [wpt PR 24267] - Streams: fix IDL tests, a=testonly
Automatic update from web-platform-tests
Streams: fix IDL tests

The new idlharness tests for Streams (#22982) did not correctly instantiate all tested interfaces. This PR fixes them.
--

wpt-commits: e32f3a1e058335c5f4ad705b208f8e4610ad7b6c
wpt-pr: 24267
2020-06-24 14:11:29 +00:00
James Graham
802ddf9305 Bug 1647713 [wpt PR 24310] - Split wdspec tasks into two chunks, a=testonly
Automatic update from web-platform-tests
Split wdspec tasks into two chunks

--

wpt-commits: 541a7da7aeed636ccdcfe6b8f682af82ec7c526c
wpt-pr: 24310
2020-06-24 14:11:28 +00:00
James Graham
e608b03167 Bug 1647659 [wpt PR 24307] - Update vendored html5lib to 1.1, a=testonly
Automatic update from web-platform-tests
Update vendored html5lib to 1.1

--

wpt-commits: e08f471c732b4cd518541939b3f420764a8fea34
wpt-pr: 24307
2020-06-24 14:11:28 +00:00
moz-wptsync-bot
cef99b4cba Bug 1647337 [wpt PR 24287] - Update wpt metadata, a=testonly
wpt-pr: 24287
wpt-type: metadata
2020-06-24 14:11:27 +00:00
Rob Buis
a24e3ef5f8 Bug 1647337 [wpt PR 24287] - [mathml] Improve mathml/relations/html5-tree/dynamic-childlist-00*.html results, a=testonly
Automatic update from web-platform-tests
[mathml] Improve mathml/relations/html5-tree/dynamic-childlist-00*.html results

These tests add children to mspace, but mspace does not allow children. Nevertheless the internal framework, using Element.getBoundingClientRect, assert based on these disallowed children which get bounding boxes that are empty rects.
To fix this, special case mspace and only check size and that the children are empty and positioned at (0, 0).

Bug: 6606
Change-Id: Ic78720547f7e4909cf63ceeb92b3bfbf22d7e15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256212
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781296}

--

wpt-commits: a3c3821c5083d2fda1d00fa2a2fc577a2e2ec66e
wpt-pr: 24287
2020-06-24 14:11:27 +00:00
CYBAI
d8f13b9a86 Bug 1647312 [wpt PR 24284] - Fix nested modules while imported under more than 3 levels, a=testonly
Automatic update from web-platform-tests
Test imports under more than 3 levels in different modules

--

wpt-commits: db6a91fe60f12f16540dff758abb20ee00be9d89
wpt-pr: 24284
2020-06-24 14:11:26 +00:00
Clemens (Hammacher) Backes
059660822d Bug 1647661 [wpt PR 24308] - Fix endianness problem in wasm-module-builder.js, a=testonly
Automatic update from web-platform-tests
Fix endianness problem in wasm-module-builder.js

--

wpt-commits: 5a8e4a343124e9ab4e9424b9ef096d7ae345080f
wpt-pr: 24308
2020-06-24 14:11:26 +00:00