Also, while I'm here, add in some now-required fields to modernize the
probe definition.
MozReview-Commit-ID: L0Jk1Q2nMrV
--HG--
extra : rebase_source : 7c1b96953d9d0ccb7d27de0715de2d1ad52d1843
Tests copied directly from older versions and adapted for React 16.
React source downloaded from https://github.com/facebook/react/releases/tag/v16.2.0
MozReview-Commit-ID: 80zwHIK16Cz
--HG--
extra : rebase_source : 0329b8407e38cf5757281456c62ff42c3846d8b2
With the request to shutdown the browser, a given amount of time
has to be waited to allow the process to shutdown itself. Only
if the process is still running afterward it has to be killed.
Firefox has an integrated background monitor which observes
long running threads during shutdown, and kills those after
65s. To allow Firefox to shutdown on its own, geckodriver
has to wait that time, and some additional seconds.
MozReview-Commit-ID: 4LRLQE0jZzw
--HG--
extra : rebase_source : c33c163d4d06768ea6616b97a25f986f5ea37e5d
When Escape key is pressed, nsAutoCompleteController needs to restore last
string which was default value of the input or typed by the user. However,
somebody may change the value, e.g., an event listener which handles
Escape key. In this case, nsAutoCompleteController shouldn't restore the
last string.
Unfortunately, when JS sets input value, DOM "input" event won't be fired.
Therefore, nsAutoCompleteController doesn't have a chance to modify
mSearchString in this case. Therefore, nsAutoCompleteController needs to
store expected input string for checking if somebody modified the input value.
For solving this issue, this patch adds a new member, mSetValue which is
modified when the input value is modified by nsAutoCompleteController itself
or mSearchString is modified.
Even with this patch, if user temporarily selects an item of the popup and
JS sets same value as the selected item from JS, nsAutoCompleteController
restores the input value with mSearchString. However, this must be rare
case and I don't have idea to fix this issue with simple patches.
MozReview-Commit-ID: lig8c7xvD7
--HG--
extra : rebase_source : 787dbfb35bc70d27fb09ec93861164e7a5165be3
There is no /lib64 on Debian. OTOH, one doesn't need to give the full
path to a system library in LDFLAGS, so just use -l syntax instead.
--HG--
extra : rebase_source : b795f97ab209499824afa5ef1aee9da52657ceb9
There was an exception thrown by the netProviderEnhancer because it
retrieves the networkMessageUpdate and access a property on it.
On non-network message, the networkMessageUpdate is undefined, and
accessing the property throws.
We fix this by simply checking if message is not falsy before accessing
the property.
A couple of tests were added to make sure we don't regress this case. This
required changing the setupStore helper a bit to pass a hud stub to the
createStore function (the net enhancer is called only if the hud has a proxy
object). This made some test fail because they weren't dispatching enough
argument to the networkMessageUpdate action.
MozReview-Commit-ID: 7h35ebHSdbF
--HG--
extra : rebase_source : 089dce93d1de60e4b44936b514627803aa2c5100
SetState() will delete the current state object and UAF will happen if members
are accessed after this call. However, sometimes it is not obvious if SetState()
is called indirectly as we do in MaybeFinishSeek().
To make it less error-prone, we will keep the old state object alive for a bit
longer and set mMaster to null to catch potential UAF.
MozReview-Commit-ID: Aqxj92ETjti
--HG--
extra : rebase_source : 21b4a0b6df2b1723eed01b6c9d58b33b8dcc6405
Summary:
Add support for PublicKeyCredentialRequestOptions.userVerification. For now
this basically means that we'll abort the operation with NotAllowed, as we
don't support user verification yet.
Pass PublicKeyCredentialDescriptor.transports through to the token manager
implementations. The softoken will ignore those and pretend to support all
transports defined by the spec. The USB HID token will check for the "usb"
transport and either ignore credentials accordingly, or abort the operation.
Note: The `UserVerificationRequirement` in WebIDL is defined at https://w3c.github.io/webauthn/#assertion-options
Reviewers: jcj, smaug
Reviewed By: jcj, smaug
Bug #: 1406467
Differential Revision: https://phabricator.services.mozilla.com/D338
--HG--
extra : amend_source : 314cadb3bc40bbbee2a414bc5f13caed55f9d720
Added another Telemetry::Accumulate function that takes a histogram id and an array of samples as arguments.
As of this patch, adding multiple samples to keyed and categorical histograms is not supported.
--HG--
extra : rebase_source : e84c53d23c9d2a6fc07f57b626e76e09c61c3bee
Message icons now get the aria-live="off" attribute.
This stops screen readers from automaticaly reading icon descriptions, which might be interesting to read later but make things inefficient when automatically reading new output.
MozReview-Commit-ID: BQOUnTRVkBE
--HG--
extra : rebase_source : 47f1df96910a92961fc739582ffb49956735fdb3
Commands entered by the user now get the aria-live="off" attribute.
This stops screen readers from echoing commands the user typed, which is redundant and inefficient.
MozReview-Commit-ID: GJXiBPMe0W5
--HG--
extra : rebase_source : 9fac3b14115a9f2f54bc8180bed6c0442e0da3f0
Replace `loader.lazyGetter` pattern with normal variable assignment
MozReview-Commit-ID: JJTXKgXRgBZ
--HG--
extra : rebase_source : 91e63d7515573a3c55756fd04811fe61515b3cf8
The test was failing because it still had pending request to the server while shutting
down the toolbox. This request was probably the one to retrieve the properties of the
object we put in the sidebar.
By waiting the object properties to be fully loaded when opening the sidebar, we should
make the intermittent go away.
MozReview-Commit-ID: 7tY8hvbDVRp
--HG--
extra : rebase_source : cc5479f21c91df1fc0967900fb1022e3ec6dff3d
AutoMoveNodeSelNotify doesn't allow container is null. So we should reject
that parent of moving node is null.
MozReview-Commit-ID: DGNCicLJxuK
--HG--
extra : rebase_source : eea203f16d0296c74d0727f34b6ddc5c165f9092
