None of the C++ callers of RemoveSelectionListener care about whether the
listener was already-added, and the only JS caller is in a test and knows the
listener was added. So the behavior change to no-op instead of throwing when
trying to remove a nonexistent listener is OK. Furthermore, the removal is
null-safe, so there's no point to explicitly failing if null is passed (which
it never is).
Since content can't directly add selection listeners, we can just use an
infallible append instead of returning errors callers don't check for anyway.
Also, no one passes null to AddSelectionListener, so we don't have to worry
about that part.
This way we don't have to deal with QI to get a Selection out of a weakref.
mfbt weakrefs don't have a SizeOfOnlyThis. In any case, the memory used by the
weakref itself is pretty minor...
This reestablishes the separtion between wptserve and the rest of web-platform-tests.
It moves the parts of the configuration that are specific to wpt out into the
serve.Config class. It also removes the default.config.json file and just puts
the default configuration directly into the code since there it is able to use
things like runtime paths without difficulty.
MozReview-Commit-ID: FXAClJ8JJof
--HG--
rename : testing/web-platform/tests/tools/sslutils/__init__.py => testing/web-platform/tests/tools/wptserve/wptserve/sslutils/__init__.py
rename : testing/web-platform/tests/tools/sslutils/pregenerated.py => testing/web-platform/tests/tools/wptserve/wptserve/sslutils/pregenerated.py
Automatic update from web-platform-testsFile API: lastModifiedDate has been obsolete for a while
--
wpt-commits: 95127fa5adb1d9953899561c152c518c552e4ed0
wpt-pr: 10821
Automatic update from web-platform-testsHook up logging for websocket server
Use warning as the default level to avoid large amounts of debug spew.
--
wpt-commits: f4dfd5fb5f8dda5ba6974c791d153d968edf0aa3
wpt-pr: 10804
Automatic update from web-platform-testsImprove color use in background-clip-content-box-001.html. (#10814)
Originally submitted as <https://github.com/w3c/web-platform-tests/pull/6226>.
Some additional changes by Ms2ger.
--
wpt-commits: b5befcbe4803b7de1a758142a675a1eae60c1bac
wpt-pr: 10814
Automatic update from web-platform-testsReset writing mode for media controls.
Use horizontal-tb on UA stylesheet to make sure the controls look the
same in all writing modes.
Bug: 839142
Change-Id: I7c84afb4f1eef2cf741196b6a8639845aa72066c
Reviewed-on: https://chromium-review.googlesource.com/1041025
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555670}
--
wpt-commits: 7a7d2e13deccb4d68a084446f837410b0cd909f9
wpt-pr: 10809
Automatic update from web-platform-testsFix timing allow check algorithm for service workers
This CL uses the OriginalURLViaServiceWorker() in the timing allow check
algorithm if the response WasFetchedViaServiceWorker(). This way, if a
service worker changes a same origin request to become cross origin,
then the timing allow check algorithm will still fail.
resource-timing-worker.js is changed so it avoids an empty Response,
which is an odd case in terms of same origin checks.
Bug: 837275
Change-Id: I7e497a6fcc2ee14244121b915ca5f5cceded417a
Reviewed-on: https://chromium-review.googlesource.com/1038229
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555476}
--
wpt-commits: 7e9e0aed09557bf971cdea5fabe8872aeed3e0f3
wpt-pr: 10745
Automatic update from web-platform-testsMerge pull request #10446 from w3c/ffs-descriptor
test the @font-face font feature settings descriptor (property already tested)
--
wpt-commits: f9924ae9ab71b715af273e50a9f7256bff8140e4
wpt-pr: 10446
Automatic update from web-platform-testsHTML: document.open() and the document's encoding
For https://github.com/whatwg/html/pull/3661.
--
wpt-commits: f7fd9fa9515a8fe6f0de3c0da08aad1a077784e5
wpt-pr: 10756
Automatic update from web-platform-tests[KeyboardLock] Ensure API is called from a top-level browsing context
This change adds some checks to the keyboard lock API to ensure it was
called from within a supported context, otherwise it now rejects the
promise.
BUG=680809
Change-Id: I3d127422c640d16e43c22adb14755b65eb2cdc6a
Reviewed-on: https://chromium-review.googlesource.com/1038888
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555417}
--
wpt-commits: 90e225b4f5b37986c06f29bd305b0291a30e4867
wpt-pr: 10753
