Commit Graph

702006 Commits

Author SHA1 Message Date
Edgar Chen
54f3ab7f74 Bug 1519226 - Wait for the bookmarked status to finish updating before starting test; r=Gijs CLOSED TREE DONTBUILD
The Bookmark page button ignores activation if there is pending update. Thus,
the test must wait for the update to be finished before synthesizing mouse
actions.

Differential Revision: https://phabricator.services.mozilla.com/D71114
2020-04-16 13:41:05 +00:00
Andreea Pavel
081dff373d Backed out changeset 5c1092771230 (bug 1519226) for landing with wrong bug number on a CLOSED TREE 2020-04-16 22:49:18 +03:00
Andreea Pavel
c5b21b8328 Bug 1628788 - update valid-with-semicolon.https.html expectancy for mac shippable r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D71018
2020-04-15 16:01:44 +00:00
Ting-Yu Lin
4f7c48a6a2 Bug 1627125 Part 8 - Make nsFlexContainerFrame static-analysis warning free. r=dholbert
1. Fixed "warning: use 'using' instead of 'typedef'" for OrderState.

2. Removed `FlexItem* item` to fix the "warning: Value stored to 'item'
   is never read".

Differential Revision: https://phabricator.services.mozilla.com/D69486
2020-04-16 05:38:12 +00:00
Ting-Yu Lin
71de052a6a Bug 1627125 Part 7 - Add reftests for flex containers with "box-decoration-break: clone" and unbreakable children. r=dholbert
These reftests are copied from flexbox-unbreakable-child-1-*.html and
flexbox-unbreakable-child-1-*-wrap.html with "box-decoration-break:
clone" added to the flex container.

Note that flexbox-unbreakable-child-3-ref.html is redesigned. It is not
copied from flexbox-unbreakable-child-1-ref.html with
"box-decoration-break: clone" added because the bottom border doesn't
show up in sub-test 3 & 4. (bug 1564726 perhaps?)

Differential Revision: https://phabricator.services.mozilla.com/D69475
2020-04-16 19:24:03 +00:00
Ting-Yu Lin
9414e316e9 Bug 1627125 Part 6 - Redesign the logic that computes flex container's final size with "box-decoration-break: clone" considered. r=dholbert
By passing unconstrained aAvailableBSizeForContent to DoFlexLayout, we
can get the flex container's desired content-box size as if there's no
pagination. We could then use this content-box size and
maxBlockEndEdgeOfChildren to rewrite the logic to determine flex
container's final size.

I still maintain the compatibility with block frame that if the flex
container is running out of block-size, it can still become incomplete
and request an zero block-size continuation. One comment in block frame
feels this is wrong, but fixing it is not in the scope of this bug.
https://searchfox.org/mozilla-central/rev/4ccefc3181f9d237ef4ca8bd17b4e7c101ddf7b5/layout/generic/nsBlockFrame.cpp#7715-7718

Differential Revision: https://phabricator.services.mozilla.com/D69474
2020-04-16 19:10:32 +00:00
Ting-Yu Lin
fdfebf0eb9 Bug 1627125 Part 5 - Make ReflowChildren() output children's max block-end edge and completeness. r=dholbert
The two variable will be used in ComputeFinalSize in a later part.

I follow the C++ Core Guidelines to return multiple value via std::tuple.
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f21-to-return-multiple-out-values-prefer-returning-a-struct-or-tuple

Differential Revision: https://phabricator.services.mozilla.com/D69473
2020-04-16 05:37:59 +00:00
Ting-Yu Lin
2a7c035ced Bug 1627125 Part 4 - Run DoFlexLayout only in first-in-flow, and store SharedFlexData in it. r=dholbert
We want mContentBoxMainSize and mContentBoxCrossSize in SharedFlexData
to be the final content-box without regards to pagination, but it is not
correct yet. A later part will pass NS_UNCONSTRAINEDSIZE as
availableBSizeForContent so that DoFlexLayout can calculate the correct
size.

Differential Revision: https://phabricator.services.mozilla.com/D69472
2020-04-16 05:37:57 +00:00
Ting-Yu Lin
48d7a393cf Bug 1627125 Part 3 - Add aColumnWrapThreshold to DoFlexLayout. r=dholbert
In a later part, we want to use NS_UNCONSTRAINEDSIZE for
aAvailableBSizeForContent.

Differential Revision: https://phabricator.services.mozilla.com/D69471
2020-04-16 05:37:55 +00:00
Ting-Yu Lin
8e83d6166f Bug 1627125 Part 2 - Add a helper to compute available size for flex items, and pass the information to ReflowChildren. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D69470
2020-04-16 05:37:47 +00:00
Ting-Yu Lin
474e6992c6 Bug 1627125 Part 1 - Allow ReflowFlexItem to take available size as an input, and output reflow status. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D69469
2020-04-16 05:37:45 +00:00
Dave Townsend
97ea0f945d Bug 1588113: Only consider the major version part when checking for downgrades. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D70245
2020-04-16 19:12:50 +00:00
Kannan Vijayan
ab80e24ca6 Bug 1592105 - Part 1 - Add a reference to CompilationInfo within TokenStream. r=mgaudet
Differential Revision: https://phabricator.services.mozilla.com/D70893
2020-04-16 19:23:56 +00:00
Chris H-C
5ed141e8c5 Bug 1527656 - Don't throw on recordEvent an unknown event r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D71189
2020-04-16 16:03:24 +00:00
Emilio Cobos Álvarez
b69a3cb639 Bug 1630676 - Fix two regressions from the previous patches.
MANUAL PUSH: Review information for upstream patches would get lost otherwise.
2020-04-16 21:17:50 +02:00
Emilio Cobos Álvarez
2be2ef7470 Bug 1630676 - Reformat recent changes, various build fixes, and tidy fixes. 2020-04-16 21:17:50 +02:00
Josh Matthews
1f61fd94da Bug 1630676 - Refactor some Servo-only animations code. 2020-04-16 21:17:44 +02:00
Anthony Ramine
e0efb285ff Bug 1630676 - Rearrange FontLanguageOverride. r=emilio
Creating one from a u32 should be unsafe because we rely on the fact that the
value is a valid &str.
2020-04-16 21:17:43 +02:00
Anthony Ramine
cd9ba34b12 Bug 1630676 - Replace ScopedTLS::unsafe_get by ScopedTLS::into_slots. r=emilio
We only ever look at the slots after we are done with the thread pool,
so we don't need to expose any unsafety to inspect the slots.
2020-04-16 21:17:42 +02:00
Anthony Ramine
26b6ee1d3a Bug 1630676 - Don't use transmute to create PaintOrder values. r=emilio
I checked that rustc optimises the code just as well as with the transmute.

https://rust.godbolt.org/z/w6UJN4
2020-04-16 21:17:41 +02:00
Anthony Ramine
40593d91fb Bug 1630676 - Don't expose any AtomicRefCell directly from style traits.
This lets us experiment with how we store this data on the DOM side.
2020-04-16 21:17:41 +02:00
Tipowol
538f9d20c8 Bug 1630676 - Update Servo's attribute length parsing code to match spec. 2020-04-16 21:17:40 +02:00
Martin Robinson
51ad515388 Bug 1630676 - Cherry-pick some layout-2020 changes. 2020-04-16 21:17:39 +02:00
Josh Matthews
785ded933e Bug 1630676 - Update ipc-channel and crossbeam-channel in Servo. 2020-04-16 21:17:39 +02:00
Simon Sapin
0158f5c65e Bug 1630676 - Fix some errors and formatting changes when updating rustc to 1.43.0-nightly (5d04ce67f 2020-02-13). 2020-04-16 21:17:38 +02:00
Jeff Muizelaar
50c4715de4 Bug 1630371 - Disable DirectComposition when we have a scaled resolution and no hardware stretching. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D71089
2020-04-16 14:54:17 +00:00
JulianWels
631b9ce311 Bug 1627206 - Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb,jcj,dragana
Differential Revision: https://phabricator.services.mozilla.com/D69983
2020-04-16 18:58:43 +00:00
Tim Nguyen
55d9542872 Bug 1630615 - Remove duplicate settings icons. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71185
2020-04-16 18:48:33 +00:00
Mihai Alexandru Michis
a82a710fd6 Bug 1626425 - Disable multiple tests on win and macos debug for causing crashes. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D70969
2020-04-15 15:04:02 +00:00
Ciure Andrei
aec781a233 Backed out 11 changesets (bug 1630676) for causing multiple failures CLOSED TREE
Backed out changeset c1fbe364b76c (bug 1630676)
Backed out changeset 629970c8f0b7 (bug 1630676)
Backed out changeset 1530f4a9aef2 (bug 1630676)
Backed out changeset a5b60fb5a0e1 (bug 1630676)
Backed out changeset a6e1a31c3e0d (bug 1630676)
Backed out changeset 4df9717e28f0 (bug 1630676)
Backed out changeset c76b0b0e503b (bug 1630676)
Backed out changeset 3c89aec57d0a (bug 1630676)
Backed out changeset 369cf504584d (bug 1630676)
Backed out changeset d7eff4acb616 (bug 1630676)
Backed out changeset 1d47c9354eeb (bug 1630676)
2020-04-16 21:45:51 +03:00
jayati
076967aa38 Bug 1571412 - Update addon manager browser tests to use pushPrefEnv where appropriate. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D70404
2020-04-16 17:38:14 +00:00
David Walsh
038e813683 Bug 1459175 - Introduce UI for Options drop down menu in Network panel r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D70885
2020-04-16 15:50:21 +00:00
David Walsh
b9a2cdbdc0 Bug 1630449 - Avoid refreshing editor on selectedFrame change r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D71131
2020-04-16 01:32:20 +00:00
Gijs Kruitbosch
8e9361fe24 Bug 1614468, r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D71078
2020-04-16 18:00:49 +00:00
David Major
a6a4043334 Bug 1630661 - Fix webaudio querystring to autostart for PGO r=padenot
One of the recent changes made it so that the test doesn't start on its own unless the URL has "raptor".

I've confirmed that this
- Does not swamp out the profdata file
- Does not regress displaylist-mutate
- Improves the webaudio score

Differential Revision: https://phabricator.services.mozilla.com/D71197
2020-04-16 16:48:07 +00:00
Tom Schuster
aafa33aa8e Bug 1629569 - Warp: Support IONFLAGS=logs. r=jandem
Depends on D70872

Differential Revision: https://phabricator.services.mozilla.com/D71065
2020-04-16 11:40:43 +00:00
Itiel
6c66d531b4 Bug 1626661 - Don't make the about:logins searchbox more opaque on focus r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D69223
2020-04-16 17:36:06 +00:00
Dão Gottwald
cd98b52a59 Bug 1630510 - Clean up .bookmark-item max-width rules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71143
2020-04-16 17:20:33 +00:00
Ricky Stewart
a68fb761e8 Bug 1630668 - Fix incompatible type signatures in subclasses of Repository r=dmajor
Differential Revision: https://phabricator.services.mozilla.com/D71200
2020-04-16 17:07:19 +00:00
Bob Owen
261ddce4a8 Bug 1630521: Allow CanvasDrawEventRecorder to control surface destruction recording, so it can be done on the main thread. r=jrmuizel
The recording by CanvasDrawEventRecorder into the ring buffer is not thread-safe
and so must all occur on the same (main) thread.
In addition to that it sometimes needs to send IPC messages via the PCanvas
protocol, which also can only be done on the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D71174
2020-04-16 17:13:16 +00:00
Ciure Andrei
9e73e9c766 Backed out changeset 376986092fe4 (bug 1627206) for causing browser_console_logging.js to fail CLOSED TREE 2020-04-16 20:48:48 +03:00
Emilio Cobos Álvarez
a891140d96 Bug 1630676 - Fix a typo introduced earlier in this bug.
MANUAL PUSH: orange

CLOSED TREE
2020-04-16 19:25:26 +02:00
Andreea Pavel
3cd455d5ca Backed out changeset 7749765974c1 (bug 1630615) for failing browser_primaryUI.js on a CLOSED TREE 2020-04-16 20:12:17 +03:00
Valentin Gosu
f3ca5aa03c Bug 1625749 - Make sure PartiallySeekableInputStream initializes all its members. r=kershaw
Depends on D70919

Differential Revision: https://phabricator.services.mozilla.com/D70926
2020-04-14 19:52:13 +00:00
Valentin Gosu
0b2e4bafd9 Bug 1625749 - Make sure SlicedInputStream initializes all its members. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D70919
2020-04-14 18:04:13 +00:00
Alexandre Poirot
626e9d52be Bug 1615412 - Disable IPv6 when connecting to remote runtime. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D71058
2020-04-16 15:42:17 +00:00
Emilio Cobos Álvarez
694173c605 Bug 1630676 - Reformat recent changes, various build fixes, and tidy fixes.
MANUAL PUSH: Review information for upstream patches would get lost otherwise.
2020-04-16 18:38:02 +02:00
Josh Matthews
0bff3e6dfd Bug 1630676 - Refactor some Servo-only animations code. 2020-04-16 18:37:52 +02:00
Anthony Ramine
878b6338d1 Bug 1630676 - Rearrange FontLanguageOverride. r=emilio
Creating one from a u32 should be unsafe because we rely on the fact that the
value is a valid &str.
2020-04-16 18:37:51 +02:00
Anthony Ramine
0f5b32207e Bug 1630676 - Replace ScopedTLS::unsafe_get by ScopedTLS::into_slots. r=emilio
We only ever look at the slots after we are done with the thread pool,
so we don't need to expose any unsafety to inspect the slots.
2020-04-16 18:37:50 +02:00