Commit Graph

672085 Commits

Author SHA1 Message Date
Aaron Klotz
5690759b5c Bug 1542830: Part 2 - Modify launcher process blocklist to collect information about untrusted module loads; r=mhowell
* We refactor the blocklist code. Code that may possibly run before
  initialization of the Win32 subsystem and the CRT is contained within the
  `freestanding` library.
* The `freestanding` library's static initializers are placed in their own
  section so that they may be manually invoked separately from the remaining
  initializers in the binary.
* `CheckBlockInfo` and `IsDllAllowed` are modified to return a `BlockAction`
  enum instead of a `bool`. This will be used more extensively in the future for
  LSP blocking.
* The launcher process now hooks `LdrLoadDll` in addition to
  `NtMapViewOfSection`. This is necessary so that we can collect timing
  information.
* Telemetry recorders must implement the `LoaderObserver` interface.
* `ModuleLoadFrame` is a RAII class that collects the information about the
  DLL load and dispatches the information to `LoaderObserver`s.
* The launcher process exposes an implementation of the `LoaderAPI` interface
  that may be called by either the launcher process blocklist or the legacy
  blocklist in `mozglue`.
* During startup, the launcher process implements its own `LoaderObserver`.
  Once mozglue is running, it connects its `LoaderObserver` to the launcher
  process, receives a vector containing the module load events, and then
  stores and forwards them into XUL.

Depends on D43155

Differential Revision: https://phabricator.services.mozilla.com/D43156

--HG--
rename : browser/app/winlauncher/DllBlocklistWin.cpp => browser/app/winlauncher/DllBlocklistInit.cpp
rename : browser/app/winlauncher/DllBlocklistWin.h => browser/app/winlauncher/DllBlocklistInit.h
rename : browser/app/winlauncher/DllBlocklistWin.cpp => browser/app/winlauncher/freestanding/DllBlocklist.cpp
rename : browser/app/winlauncher/DllBlocklistWin.h => browser/app/winlauncher/freestanding/DllBlocklist.h
rename : browser/app/winlauncher/moz.build => browser/app/winlauncher/freestanding/moz.build
extra : moz-landing-system : lando
2019-09-23 20:17:10 +00:00
Aaron Klotz
c27d5345fc Bug 1542830: Part 1 - Updates to NativeNt.h; r=mhowell
This patch adds the following:

* The `AllocatedUnicodeString` class which encapsulates a `UNICODE_STRING` and
  owns its buffer. The buffers are null-terminated so that they may be used as
  C-style strings without modification.
** We do not allow either creation or copying within XUL
* `RtlGetCurrentThreadId` and a test to validate it, so that we may obtain the
  current thread ID directly from the `TEB` when we do not yet have access to
  kernel32.
* An implementation of `SRWLock` that uses Rtl instead of Win32 so that we may
  use them before we have access to Win32 DLLs.
* A memory allocation policy that uses Rtl heap functions so that we may use
  MFBT `Vector` in code that might not yet have access to Win32 heap functions.

Differential Revision: https://phabricator.services.mozilla.com/D43155

--HG--
extra : moz-landing-system : lando
2019-09-23 20:16:51 +00:00
Lee Salzman
523a527e84 Bug 1578075 - Increase stack size of paint threads on macOS Catalina to 1MB. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D46834

--HG--
extra : moz-landing-system : lando
2019-09-23 20:02:17 +00:00
Boris Zbarsky
37bab0bd83 Bug 1582196 part 4. Get rid of NS_ERROR_RANGE_ERR. r=peterv
The two remaining consumers don't seem to depend on actually using this
specific nsresult in any way.

Differential Revision: https://phabricator.services.mozilla.com/D46462

--HG--
extra : moz-landing-system : lando
2019-09-23 19:14:33 +00:00
Boris Zbarsky
33acac0a74 Bug 1582196 part 3. Stop using NS_ERROR_RANGE_ERR and NS_ERROR_TYPE_ERR in payments code. r=edenchuang
The changes to the return type of MerchantValidationEvent::init are because
Result doesn't allow having an ErrorResult (or any other type without a copy
constructor) as its error type.  Plus we would have had the impedance mismatch
between Result<Ok, nsresult> (which is what URL resolution on the document
returns) and Result<Ok, ErrorResult> anyway.

Differential Revision: https://phabricator.services.mozilla.com/D46461

--HG--
extra : moz-landing-system : lando
2019-09-19 23:53:14 +00:00
Boris Zbarsky
e2d4045ce1 Bug 1582196 part 2. Stop using NS_ERROR_RANGE_ERR in SVGTransform. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D46460

--HG--
extra : moz-landing-system : lando
2019-09-19 13:13:58 +00:00
Boris Zbarsky
ccc114b512 Bug 1582196 part 1. Stop using NS_ERROR_RANGE_ERR in createImageBitmap. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D46459

--HG--
extra : moz-landing-system : lando
2019-09-19 15:35:07 +00:00
Harry Twyford
d20b4a18cb Bug 1582329 - Correct promises in browser_urlbar_resultSpan.js. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D46791

--HG--
extra : moz-landing-system : lando
2019-09-23 19:51:37 +00:00
Timothy Nikkel
05d45ca5d2 Bug 1582918. Make sure that async-scrollbar* reftests don't pass because they draw nothing. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D46699

--HG--
extra : moz-landing-system : lando
2019-09-23 14:58:46 +00:00
Byron Campen [:bwc]
e429b89b10 Bug 1582646: Cancel proxy lookup when socket closes. r=mjf
Also, since OnProxyAvailable always happens on main regardless of the target we
set, don't bother setting the target.

Differential Revision: https://phabricator.services.mozilla.com/D46603

--HG--
extra : moz-landing-system : lando
2019-09-20 15:13:44 +00:00
Jonathan Watt
c5ffdfd9e0 Bug 1574137. Re-enable layout/svg/tests/test_filter_crossorigin.html for Fission. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D46819

--HG--
extra : moz-landing-system : lando
2019-09-23 18:15:58 +00:00
Botond Ballo
a66c81bfae Bug 1567448 - Disable helper_overscroll_behavior_bug1425573.html until we track down the memory leak it's causing. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D46804

--HG--
extra : moz-landing-system : lando
2019-09-23 19:48:06 +00:00
Ehsan Akhgari
b234809417 Bug 1582053 - Disable the remote settings database creation instead of the server in web extension xpcshell tests; r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D46664

--HG--
extra : moz-landing-system : lando
2019-09-23 19:28:12 +00:00
Ehsan Akhgari
78123454f5 Bug 833723 - Make test_bug455311.js pass locally on Linux by resolving symlinks; r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D46816

--HG--
extra : moz-landing-system : lando
2019-09-23 19:08:39 +00:00
Bogdan Tara
dbcecb5e8a Bug 1566843 - Disabling test_ext_proxy_socks.js on linux & windows debug r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D46812

--HG--
extra : moz-landing-system : lando
2019-09-23 18:00:30 +00:00
Gabriel Luong
c6ffcbb611 Bug 1583278 - Upgrade CodeMirror to 5.49.0. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D46826

--HG--
extra : moz-landing-system : lando
2019-09-23 18:47:42 +00:00
Dana Keeler
3d10b528b0 bug 1581986 - fix undefined shift behavior in md4 implementation r=kjacobs
Using left shift on a uint8_t promotes it to a signed integer. If the shift is
large enough that the sign bit gets affected, we have undefined behavior. This
patch fixes this by first casting to uint32_t.

Differential Revision: https://phabricator.services.mozilla.com/D46820

--HG--
extra : moz-landing-system : lando
2019-09-23 19:17:52 +00:00
Emilio Cobos Álvarez
e8cd2193b5 Bug 1579585 - Use fallible allocation for stylesheet invalidation. r=jwatt
If the sets get too big we cannot allocate anything else, we'll just empty them
and invalidate the whole document.

Differential Revision: https://phabricator.services.mozilla.com/D46828

--HG--
extra : moz-landing-system : lando
2019-09-23 19:08:22 +00:00
Emilio Cobos Álvarez
678c18063d Bug 1583203 - Annotate nsINode::OwnerDoc() as MOZ_NONNULL_RETURN. r=smaug
People keep adding useless null-checks and it was not clear what the consensus
was from bug 1441165, but this should be unobjectionable I guess.

Differential Revision: https://phabricator.services.mozilla.com/D46781

--HG--
extra : moz-landing-system : lando
2019-09-23 18:12:19 +00:00
Florens Verschelde
58e3682952 Bug 1512513 - Set the short toolbar height to 24px (25px with border) instead of 23px; r=Honza,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D43961

--HG--
extra : moz-landing-system : lando
2019-09-23 18:37:36 +00:00
philipp
e517ca80d9 Bug 1576728 - Add crashing dlls from chinese unzipping tools to the blocklist. r=aklotz
--HG--
extra : rebase_source : b8eda4974164e350fa6e1df9bcf79c5f9baa966a
2019-09-23 21:19:02 +03:00
Jonathan Watt
47b996559f Bug 1568968. Re-enable existing print telemetry for nightly, beta and release. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D43435

--HG--
extra : moz-landing-system : lando
2019-09-23 18:18:08 +00:00
longsonr
e48a579229 Bug 1582991 - Check the validity of the DrawTarget before using it, in nsFilterInstance::Render r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D46716

--HG--
extra : moz-landing-system : lando
2019-09-23 18:14:12 +00:00
Henri Sivonen
b5140cd3ca Bug 1583169 - Enable test_bug871161.html in Fission. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D46770

--HG--
extra : moz-landing-system : lando
2019-09-23 12:05:02 +00:00
Toshihito Kikuchi
1cc025cecd Bug 1578895 - Compare NT paths if NtOpenFile failed with STATUS_OBJECT_PATH_NOT_FOUND. r=aklotz
We compare two file ids to check the current process is launched from the same
executable.  However, our telemetry showed a number of Win7 users failed to open
a file handle of the parent process with STATUS_OBJECT_PATH_NOT_FOUND even
though we opened a process handle and retrieved a module path of the parent
process successfully.  We don't have data to explain how this happens or why
this happens only on Win7, Win10 10240, and 10586.

To mitigate this situation, this patch introduces a logic to compare NT path
strings.  The benefit from doing this is 1) we don't have to open a file handle
of a parent process executable and 2) when we get an NT path, a network drive
or a symbolic link is already solved.

This new logic is much faster, but we still compare file ids on the first
attempt to minimize the impact.  We fall back to the new logic only if we
detect the STATUS_OBJECT_PATH_NOT_FOUND failure.

Differential Revision: https://phabricator.services.mozilla.com/D45476

--HG--
extra : moz-landing-system : lando
2019-09-23 17:59:42 +00:00
Florens Verschelde
e14c6283b1 Bug 1578017 - Clip FontOrigin title attribute for very long strings; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D44304

--HG--
extra : moz-landing-system : lando
2019-09-23 18:02:56 +00:00
Noemi Erli
728928781e Backed out changeset 195e629a7877 (bug 1582459) for causing wrench bustages CLOSED TREE 2019-09-23 21:07:24 +03:00
Nicolas Silva
ff7cdb1b4e Bug 1582459 - Improve the clipping and segment documentation. r=kvark
Adds a module documentation in segment.rs giving an overview of the role of primitive segments and how they interact with clipping. Also reformatted the clip.rs documentation to play well with rustdoc.

Differential Revision: https://phabricator.services.mozilla.com/D46472

--HG--
extra : moz-landing-system : lando
2019-09-23 15:04:19 +00:00
Tom Schuster
10bb1ec461 Bug 1337564 - Don't use JSON behavior for __proto__ with eval. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D45381

--HG--
extra : moz-landing-system : lando
2019-09-23 17:21:36 +00:00
Ryan VanderMeulen
3778a57619 Bug 1582724 - Update pdf.js to version 2.3.183. r=bdahl
Differential Revision: https://phabricator.services.mozilla.com/D46592

--HG--
extra : moz-landing-system : lando
2019-09-23 17:07:39 +00:00
Cosmin Sabou
5ba1c3f18f Backed out changeset 098d87f4abbc (bug 1580923) for browser chrome failures on browser_openTabAndSendCertInfo.js. CLOSED TREE 2019-09-23 20:15:29 +03:00
Cosmin Sabou
ec3dff4a7f Backed out changeset 215d17a0eeb5 (bug 1566527) for devtools failures on browser_webconsole_network_messages_openinnet.js 2019-09-23 20:12:58 +03:00
Geoff Brown
66b180e290 Bug 1577037 - Stop running all Fennec performance tests; r=perftest-reviewers,stephendonner,sparky,Bebe
Stop running all Raptor tests that run against Fennec. Raptor tests running
against geckoview and geckoview products continues.

Differential Revision: https://phabricator.services.mozilla.com/D44511

--HG--
extra : moz-landing-system : lando
2019-09-23 16:49:29 +00:00
Emilio Cobos Álvarez
23d89f211d Bug 1582585 - Test autoscroll for scrollable and non-scrollable iframes. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D46733

--HG--
extra : moz-landing-system : lando
2019-09-23 16:32:47 +00:00
Emilio Cobos Álvarez
f8fa8e5cea Bug 1582585 - Make AutoScrollController not scroll non-scrollable windows. r=botond
That is, avoid scrolling <iframe>s that have scrolling="no", for example.

Differential Revision: https://phabricator.services.mozilla.com/D46731

--HG--
extra : moz-landing-system : lando
2019-09-23 16:05:11 +00:00
Emilio Cobos Álvarez
2e2227708b Bug 1582585 - Factor out a bit more code from AutoScrollController.jsm. r=botond
Also an idempotent change.

Differential Revision: https://phabricator.services.mozilla.com/D46730

--HG--
extra : moz-landing-system : lando
2019-09-23 15:54:19 +00:00
Emilio Cobos Álvarez
243aae81a3 Bug 1582585 - Use flattenedTreeParentNode in AutoScrollController.jsm. r=botond
This makes it work with both Shadow DOM and XBL.

Differential Revision: https://phabricator.services.mozilla.com/D46729

--HG--
extra : moz-landing-system : lando
2019-09-23 15:52:55 +00:00
Emilio Cobos Álvarez
4c429b8f4e Bug 1582585 - Factor out a bit of the logic in AutoScrollController.jsm. r=botond
No behavior change intended.

Differential Revision: https://phabricator.services.mozilla.com/D46728

--HG--
extra : moz-landing-system : lando
2019-09-23 15:39:48 +00:00
Alexander Surkov
bd7c7db7eb Bug 1515591 - Remove support for the newlines attribute from the textbox binding r=dao
Differential Revision: https://phabricator.services.mozilla.com/D46620

--HG--
extra : moz-landing-system : lando
2019-09-20 17:21:20 +00:00
Carolina
1ea5f188a8 Bug 1580923 - Fixes problem when opening a certificate from downloadcert.xul.r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46054

--HG--
extra : moz-landing-system : lando
2019-09-23 15:08:42 +00:00
lloan
6112f19409 Bug 1582440 - Test time out when merging Gecko 71 to Beta. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D46750

--HG--
extra : moz-landing-system : lando
2019-09-23 15:52:35 +00:00
Vincent Lequertier
5f95539e2d Bug 1566527 - Hide the waterfall column when the netmonitor sidebar is opened;r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D45139

--HG--
extra : moz-landing-system : lando
2019-09-23 15:51:21 +00:00
Lee Salzman
30af0c2548 Bug 1582749 - try to load only the advance width from FreeType when possible. r=jfkthame
During metrics initialization we load a few uncached glyph widths which can occasionally
show up in a profile. This should reduce the overhead of that somewhat.

Differential Revision: https://phabricator.services.mozilla.com/D46786

--HG--
extra : moz-landing-system : lando
2019-09-23 15:17:04 +00:00
Dan Mosedale
cb082e96f2 Bug 1581545 - Make New Tab docs reference bug to enable mach test, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D46039

--HG--
extra : moz-landing-system : lando
2019-09-23 15:05:36 +00:00
Andreea Pavel
7d9c945b30 Backed out 3 changesets (bug 1583203) build bustages on a CLOSED TREE
Backed out changeset ca89485fedf8 (bug 1583203)
Backed out changeset 8bc17415ff25 (bug 1583203)
Backed out changeset 3e3eebe862e5 (bug 1583203)
2019-09-23 18:16:49 +03:00
Emilio Cobos Álvarez
b4f89cf524 Bug 1583203 - followup: Remove another silly null-check.
CLOSED TREE

MANUAL PUSH: red
2019-09-23 17:00:47 +02:00
Emilio Cobos Álvarez
d40510e58a Bug 1583203 - followup: Remove some silly null-checks.
CLOSED TREE

MANUAL PUSH: red
2019-09-23 16:49:44 +02:00
Jason Laster
9ea2d08c1c Bug 1579768 - Debugger paused overlay is too obtrusive and cant be disabled. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D46494

--HG--
extra : moz-landing-system : lando
2019-09-23 14:35:31 +00:00
Geoff Brown
1f16f58fec Bug 1582970 - Increase max-run-time for linux64 ccov browser-chrome; r=marco
The recent increase was not quite enough: Allow another 30 minutes for linux64
ccov browser-chrome.

Differential Revision: https://phabricator.services.mozilla.com/D46787

--HG--
extra : moz-landing-system : lando
2019-09-23 14:27:31 +00:00
Kershaw Chang
aae1400b3c Bug 1546816 - Part 1-5: Add AuthCertificateSetResults helper function r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D45023

--HG--
extra : moz-landing-system : lando
2019-09-18 09:53:37 +00:00