Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-31 06:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
521,670 Commits 615 Branches 98 Tags 6 GiB
584224e8cd
Commit Graph

24 Commits

Author SHA1 Message Date
Michael Comella
2f85846508 Bug 1258789 - Remove allowEmptyLoops I added previously to simplify things. r=grisha 
MozReview-Commit-ID: 7iL8VjkMSTh

--HG--
extra : rebase_source : 2677a416fabf5672d3fc259ed85424a1b2e96b6f
 2016-04-13 11:22:41 -07:00
Michael Comella
26ea5a1f85 Bug 1258789 - Remove WhitespaceAround tokens filter and fix lcurly issues. r=grisha 
Some issues remain.

MozReview-Commit-ID: 3vWQ3z5mnba

--HG--
extra : rebase_source : caacb08f22c88048f9f845a8c5a76a8d57a6e340
 2016-04-13 11:17:55 -07:00
Michael Comella
f28c02b827 Bug 1258789 - Add div* token for WhitespaceAround. r=grisha 
Fix some cast issues while I was at it.

MozReview-Commit-ID: 53ANWpnIGwk

--HG--
extra : rebase_source : 57c8e8c764f5f8fc4f0eb3e2880d741904f34a0d
 2016-04-13 11:15:00 -07:00
Michael Comella
746406d02b Bug 1258789 - Add rcurly and fix {} issues. r=grisha 
MozReview-Commit-ID: m2dF4mPC1u

--HG--
extra : rebase_source : 6797dc55ab478d310f43a77badc83eabcedd0d6d
 2016-04-13 10:51:26 -07:00
Michael Comella
b110b39473 Bug 1258789 - Add passing tokens to WhitespaceAround. r=grisha 
MozReview-Commit-ID: ANbUHFNzE7W

--HG--
extra : rebase_source : 17d1c516fc4a52622615f82a930cddfbfe680435
 2016-04-12 18:44:18 -07:00
Michael Comella
3f8a975e44 Bug 1258789 - Add plus operator to WhitespaceAround and fix. r=grisha 
MozReview-Commit-ID: 419NkkMHWCG

--HG--
extra : rebase_source : da4ccbacf82ac546cbcd79f0ad26a26f0305f230
 2016-04-12 18:42:40 -07:00
Michael Comella
70af5a5d77 Bug 1258789 - Add star to WhitespaceAround and fix. r=grisha 
MozReview-Commit-ID: 3FY8m1qPj8V

--HG--
extra : rebase_source : 52395f96af35872f3f06edcedd7f3bbef44eab82
 2016-04-12 18:36:28 -07:00
Michael Comella
82a1b5f82d Bug 1258789 - Add shift operators to WhitespaceAround & fix. r=grisha 
MozReview-Commit-ID: 9sCtvvUYixh

--HG--
extra : rebase_source : 4cfb3d835d2fc17471c227f6f9c9ed8699b2ec85
 2016-04-12 18:29:58 -07:00
Michael Comella
0d235c902a Bug 1258789 - Add a few more to WhitespaceAround and fix. r=grisha 
MozReview-Commit-ID: AkJEXhlp3Rf

--HG--
extra : rebase_source : 1bda7fa0a606feff4adfc565524e125b3dbe8312
 2016-04-12 18:27:20 -07:00
Michael Comella
91cab209eb Bug 1258789 - Add while to WhitespaceAround. r=grisha 
MozReview-Commit-ID: HhbBCjojNiC

--HG--
extra : rebase_source : 27e7eab179cf26fbf877f15d7d4dc70ffb3a9725
 2016-04-12 18:21:45 -07:00
Michael Comella
536223b0e1 Bug 1258789 - Add synchronized & non-failing try to WhitespaceAround. r=grisha 
MozReview-Commit-ID: EBnxF8j2eeY

--HG--
extra : rebase_source : e5f79e706f7ba63b484baf5b339581cdbeee626d
 2016-04-12 18:20:51 -07:00
Michael Comella
b7ca9be873 Bug 1258789 - Add switch for whitespaceAround. r=grisha 
MozReview-Commit-ID: 167JoSl5go5

--HG--
extra : rebase_source : 551818e264794e34c4701ee53953489fc5554b4b
 2016-04-12 18:19:14 -07:00
Michael Comella
ee32f11bed Bug 1258789 - Add if & return for WhitespaceAround. r=grisha 
MozReview-Commit-ID: HcWrFHy2CeP

--HG--
extra : rebase_source : c687476ab0ee6fb1054e507cb50495e55e856725
 2016-04-12 18:18:02 -07:00
Michael Comella
df95be9bdf Bug 1258789 - Add literal catch & a few others that don't break for WhitespaceAround. r=grisha 
MozReview-Commit-ID: 1En0xuxT4md

--HG--
extra : rebase_source : e387c2bce427e33185c4dabdec7b169ef5133de8
 2016-04-12 18:16:16 -07:00
Michael Comella
6ea08620c8 Bug 1258789 - Add binary logic operators for WhitespaceAround. r=grisha 
MozReview-Commit-ID: 12BUCUmassJ

--HG--
extra : rebase_source : c414f36187da86390b633357232c883668f9afe1
 2016-04-12 18:10:55 -07:00
Michael Comella
30fdaa2a6c Bug 1258789 - Add WhitespaceAround for ASSIGN token. r=grisha 
MozReview-Commit-ID: 6IOIatuHuYW

--HG--
extra : rebase_source : af95f21ba76cf1ceb4f935d1d9947c9f2a9187f2
 2016-04-12 18:07:33 -07:00
Michael Comella
5396926b28 Bug 1263056 - Add TODO for CAST check in WhitespaceAfter. r=sebastian 
MozReview-Commit-ID: 5ZRSnGylCnJ

--HG--
extra : rebase_source : a88bed32638ef44b93b8ba9d1682793588593614
 2016-04-07 18:23:54 -07:00
Michael Comella
70a0ef8e25 Bug 1263056 - Add WhitespaceAfter comma & fix issues. r=sebastian 
Fixed via:
 gsed -i"" -e "s/,\([^[:space:]\"']\)/, \1/g" **/*.java

And hand curation.

MozReview-Commit-ID: DHaXJbW4plY

--HG--
extra : rebase_source : fc708f6fac7b7245a1da6541c4ff44d8e231b879
 2016-04-07 18:07:29 -07:00
Michael Comella
f397cb45d3 Bug 1263056 - Add WhitespaceAfter for semi-colons & fix warnings. r=sebastian 
MozReview-Commit-ID: FWujl1XuxgR

--HG--
extra : rebase_source : 106f9ce8ec75d024ccb68af95129f1ef6f08de16
 2016-04-07 17:53:55 -07:00
Michael Comella
90ec31ddaa Bug 1258794 - Add trailing whitespace checkstyle check & fix issues. r=nalexander 
MozReview-Commit-ID: IUslNabcTHO

--HG--
extra : rebase_source : 2981fa4d68dfde41159ab5f987dfcab0b28ef0ec
 2016-04-06 10:08:46 -07:00
Michael Comella
669f79e139 Bug 1258794 - Pre: Add GenericWhitespace and fix single issue. r=nalexander 
MozReview-Commit-ID: DVO9zFQCRzZ

--HG--
extra : rebase_source : 039b10bfc53dd5fa4130d73a3cb09fb1ad6f9437
 2016-04-06 09:57:26 -07:00
Michael Comella
d0a151fdf5 Bug 1258769 - Add checkstyle gradle task. r=nalexander 
Run checkstyle via:
 ./mach gradle app:checkstyle

This is intended to be added to automation in bug 1258787 and made more robust
in bug 1261486.

For the addition of future checks, it's worth noting Google's config is
available:
  3e4367941c/src/main/resources/google_checks.xml

And this version contains links with descriptions of each of the tasks:
  http://checkstyle.sourceforge.net/google_style.html

MozReview-Commit-ID: 5HvtQsyY2JQ

--HG--
extra : rebase_source : ea45bcfb88ec302e9f6e6526d9afdbf2c9c93f01
 2016-04-01 14:20:45 -07:00
Michael Comella
140701c868 Bug 1258769 - Backed out changeset fe11700b6cdf. 
MozReview-Commit-ID: Jxz5RK8o4n4

--HG--
extra : rebase_source : 5737fdddfe1a46011ba9977490958e2383d6537f
 2016-03-25 13:53:58 -07:00
Michael Comella
b5ed0403e2 Bug 1258769 - Use soter to add checkstyle gradle task with simple checks. r=nalexander 
Run checkstyle via:
 ./mach gradle app:checkstyle

This is intended to be added to automation in bug 1258787.

Concerns with this patch:
  1) I don't have a maven-metadata-local.xml. However, I didn't take the
snapshotted version and [1] seems to indicate it's unnecessary for my
particular build.

For the addition of future checks, it's worth noting Google's config is
available:
  3e4367941c/src/main/resources/google_checks.xml

And this version contains links with descriptions of each of the tasks:
  http://checkstyle.sourceforge.net/google_style.html

[1]: https://maven.apache.org/ref/3.3.3/maven-repository-metadata/

MozReview-Commit-ID: ID3X9ZA27b0

--HG--
extra : rebase_source : ad8d3d5255e366362db5cc19985434e5ab5f9559
extra : histedit_source : b0bc07b572f7010c3f15ee76d52619ff5d76ab52
 2016-03-25 09:52:15 -07:00