On my machine this test takes ~5200 ms with the anonymous content style
caching pref disabled, and ~1000 ms with it enabled.
Differential Revision: https://phabricator.services.mozilla.com/D36139
--HG--
extra : moz-landing-system : lando
This effectively avoids the mkdir failures I see with the 29.0.11 emulator
on packet.net with Android 7.0 x86_64. I hate to add this sort of complication
but it really helps clear the way for an otherwise useful upgrade.
Differential Revision: https://phabricator.services.mozilla.com/D34740
--HG--
extra : moz-landing-system : lando
From the CSSOM View spec[1];
The scroll-behavior property of the HTML body element is not propagated to
the viewport.
The reason why this change fixes the test case in this commit is that we don't
have two different scrollable frames for <html> and <body> respectively if we
don't propagate scroll-behavior property from <body> to <html> so that we can
properly find the `flow root` of sticky position elements.
In other words, in the case where both of <html> and <body> have properties
that are propagated from <body> but they are different we have two scrollable
frames as a candidate of the 'flow root' for the sticky position element in
the test case, one is the scrollable frame for <html> and the other is the
scrollable frame for <body>. That means that
nsLayoutUtils::GetNearestScrollableFrame doesn't return what we want in some
places, for example we have a pretty similar issue in case of
overscroll-behavior which is bug 1561107.
Note that the test position-sticky-root-scroller-with-scroll-behavior.html is
almost copy-and-pasted from
/css/css-position/position-sticky-root-scroller.html [2] in wpt, the reason why
we put the test in /css/cssom-view is that there is a handy function to wait
for async scroll completion.
[1] https://drafts.csswg.org/cssom-view/#propdef-scroll-behavior
[2] https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/testing/web-platform/tests/css/css-position/position-sticky-root-scroller.html
Differential Revision: https://phabricator.services.mozilla.com/D35739
--HG--
extra : moz-landing-system : lando
On my machine this test takes ~5200 ms with the anonymous content style
caching pref disabled, and ~1000 ms with it enabled.
Differential Revision: https://phabricator.services.mozilla.com/D36139
--HG--
extra : moz-landing-system : lando
This allows for easy support for HEAD requests without any code on our
side.
Differential Revision: https://phabricator.services.mozilla.com/D34631
--HG--
extra : moz-landing-system : lando
This has different behaviour from the regular update in a couple of
ways:
* It doesn't try to preserve existing conditionals that didn't match
anything in the results
* It removes subtests that are no longer present in the data set.
As such this is an appropriate mode to use when you have a try push
covering all the possible platforms, or when you are confident there
are no per-platform differences.
As part of this work, the code for updating the conditionals was
refactored to be clearer, and a bunch of tests were added to ensure
that it continues to work correctly.
Differential Revision: https://phabricator.services.mozilla.com/D34735
--HG--
extra : moz-landing-system : lando
Previously the wpt metadata update code generated rather conservative
conditionals, simply inclusing every possible condition unless all the
tests had the same outcome or similar. This isn't very nice to read
and makes the metadata rather fragile to changes in the configuration.
A better approach is to build a decision tree from the metadata,
choosing the properties to split on using a simple greedy algorithm,
as follows:
* Given a set of test results, associated run_info_properties and
properties that we want to use, partition the test results by each
property we are using in turn.
* For each partition, generate a score for how uniform the results
are in each subset after partition. The score should be good if the
partition results in small numbers of groups with mostly uniform
test results and bad if it results in a large number of groups or
groups with a mix of test results. For this we adopt a metric based
on the Shannon entropy.
* Chose the partition resulting in the best score, and use that as a
condition in the tree.
* Recursively reapply the algorithm to each group that's been
created.
Differential Revision: https://phabricator.services.mozilla.com/D34734
--HG--
extra : moz-landing-system : lando
Looks like onload event is not enough, so we still have intermittents.
Based on the suggestion in html spec:
https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode
We decode the image in parallel, and only inserting it into the DOM (and thus
causing it to be painted) once the decoding process is complete.
Because the decode() method attempts to ensure that the decoded image data is
available for at least one frame, it can be combined with the
requestAnimationFrame() API. This means it can be used with coding styles or
frameworks that ensure that all DOM modifications are batched together as
animation frame callbacks.
Hope this could reduce the occurrence rate of this intermittent.
Differential Revision: https://phabricator.services.mozilla.com/D35732
--HG--
extra : moz-landing-system : lando
Correctly handle clamping to 1 behavior of grayscale(),
invert(), opacity() and sepia().
Differential Revision: https://phabricator.services.mozilla.com/D35509
--HG--
extra : moz-landing-system : lando
This restores our previous and per-spec behavior. Comparing only ratios was not
correct in the case one of the dimensions was zero and thus not scaled.
Differential Revision: https://phabricator.services.mozilla.com/D35571
--HG--
extra : moz-landing-system : lando
This test is known intermittent on windows. It's already annotated to be
disabled for some categories of Windows testers, but that annotation was overly
specific.
I've already fixed the "upstream" version of this test (the version in
layout/reftests), so the intermittent failure will stop once that fix has been
synchronized around. But in the meantime, let's adjust the annotation so that
it includes Win10 64-bit testers, so we don't get intermittent failures for
those testers.
--HG--
extra : amend_source : c815ae1200e6a615f932ddf36fba6f8a7a039500
This patch produces the following serialization:
```
input | computed value
------------------------------
1. "auto" "auto"
2. "auto auto" "auto"
3. "15px auto" "15px"
4. "15px" "15px"
```
i.e. If the second value is 'auto', then it's omitted from our serialization,
because it's implied.
Besides, we update the wpt to address this spec issue:
https://github.com/w3c/csswg-drafts/issues/2574
Differential Revision: https://phabricator.services.mozilla.com/D35510
--HG--
extra : moz-landing-system : lando
This test is supposed to check CSS property support, but using
hasOwnProperty() is causing a lot of false positive because
hasOwnProperty() doesn't go up the proto chain even if the property
is actually supported.
Differential Revision: https://phabricator.services.mozilla.com/D35512
--HG--
extra : moz-landing-system : lando
Add `SameObject` and `PutForwards=cssText` to style attribute.
It's ok to add SameObject directly because we always return the same
data member after creating.
Besides, there is no need to manually update cpp function to support
PutForwards, so this update should be fine.
Differential Revision: https://phabricator.services.mozilla.com/D35583
--HG--
extra : moz-landing-system : lando
Added support for the new known_intermittent test field in mozlog.structured to the WptreportFormatter
class. A test was added to check this field is recognised. The mozlog version was updated in the
requirements.txt for wpt. Capture was added to the mozlog init file, so that the module can be used
by mozlog consumers, such as wpt.
Differential Revision: https://phabricator.services.mozilla.com/D33673
--HG--
extra : moz-landing-system : lando
This is required so that crashes on import don't block updating tests.
It makes that change from 1539449 only apply to non-wpt suites, which is
not ideal but no worse than the previous setup.
Differential Revision: https://phabricator.services.mozilla.com/D35218
Automatic update from web-platform-tests
Don't show |cursor: pointer| on unclickable <area>s
The HTML spec says:
"The href attribute on a and area elements is not
required; when those elements do not have href
attributes they do not create hyperlinks."
Background:
Chrome already excludes unclickable <area>s, <area>s
without a href attribute, from the tab order.
Problem:
Unclickable <area>s still show a "click me" hint.
Solution:
Mimick Firefox. Only show the pointer for actual
<area> links.
Note:
Found during crrev.com/c/1632231. We don't want
unclickable <area>s to act navigable.
Bug: 972556
Change-Id: I9214171290659b8b800db3e462478e2a1327c832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#668409}
--
wp5At-commits: dcac708930b6e73bf3e7629908b6467e7644cff9
wpt-pr: 17267
Automatic update from web-platform-tests
NG/DL: Implement size containment (and display lock) for NG fieldset algo
This patch adds size containment implementation for fieldsets in
LayoutNG.
Tested with LayoutNGFieldset feature flag.
Along with the new tests,
external/wpt/css/css-contain/contain-size-fieldset-001.html and
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
are also passing.
R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org
Bug: 958975
Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660866}
--
Add colliding ref names to lint.whitelist
See also https://github.com/web-platform-tests/wpt/pull/17289 which
was discovered when preparing this change.
--
wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d
wpt-pr: 16858
Automatic update from web-platform-tests
Revert "Active Processing for ConvolverNode"
This reverts commit 499976c54a2b086bbde54ae137d0ac4adb3cd427.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 668149 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDk5OTc2YzU0YTJiMDg2YmJkZTU0YWUxMzdkMGFjNGFkYjNjZDQyNww
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/15474
Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6
Sample Flaky Test: external/wpt/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https.html
Original change's description:
> Active Processing for ConvolverNode
>
> The ConvolverNode should output a single channel of silence when it is not
> actively processing. Active processing is already supported and just needed
> to have the convolver output a single channel of silence when it is
> constructed, before anything is connected to it.
>
> Bug: 971389
> Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668149}
Change-Id: Ie7fedee332ca167c3dfd4fd99142de89234ff03a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 971389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653924
Cr-Commit-Position: refs/heads/master@{#668243}
--
wp5At-commits: 2477f79f3c0757225d06762aeb1d3b1eea6eb52a
wpt-pr: 17288
Automatic update from web-platform-tests
Worker: Modernize worker-interception.https.html
This CL modernizes worker-interception.https.html using new ES features like
async/await and arrow functions.
This is a preparation to add more test, for example, for shared workers.
Bug: n/a
Change-Id: I65ebe309358b8b680b9b173916d6aa1d477b1d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654673
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668316}
--
wp5At-commits: 16f941927fe2ce5abb5bc54ab02af5f15c501c1a
wpt-pr: 17284
Automatic update from web-platform-tests
ChannelMergerNode supports active processing
When a ChannelMergerNode is not actively processing its inputs, the
number of channels in its output is one, instead of the number of
inputs.
Just need to disable outputs when the node is created. Connections to
the node will adjust the number of channels appripriately, and when
inputs are no longer actively processing, the number of output
channels becomes one, as required.
Bug: 925046
Test: the-channelmergernode-interface/active-processing.https.html
Change-Id: I08e5fd2fe9c99b75af177eb85212162ecf39efd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645478
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668159}
--
wp5At-commits: bfb037131941940b9f7efa16cb1ec0829a2461cb
wpt-pr: 17273
Automatic update from web-platform-tests
[css-flexbox] Make sure to layout overflow:auto elements
For overflow: auto, we need to layout before running the flex algorithm
if layout is dirty, so we can up-to-date scrollbar information, because
scrollbar size is included in the intrinsic size.
Bug: 972227
Change-Id: I58b5c0590575c5babc505b2927d8464f3f540775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652198
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668199}
--
wp5At-commits: 562e24f280cc12acbbe0f2b0b136dd319c2604b3
wpt-pr: 17270
Automatic update from web-platform-tests
Active Processing for ConvolverNode
The ConvolverNode should output a single channel of silence when it is not
actively processing. Active processing is already supported and just needed
to have the convolver output a single channel of silence when it is
constructed, before anything is connected to it.
Bug: 971389
Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668149}
--
wp5At-commits: 6531eab802391a24dabca973cc4329abbeadd896
wpt-pr: 17233
