Commit Graph

615516 Commits

Author SHA1 Message Date
Tim Huang
5b0ad75d1c Bug 680300 - Part 3: Make the client.navigate() not to reference the baseURL if it navigates to a view-source URL r=asuth
The suppressing of the error NS_ERROR_UNKNOWN_PROTOCOL will break the
web-platform-test 'windowclient-navigate.https.html' since navigating
to an invalid view-source url through the client API won't receive
any error due to the suppressing. So the test will time-out since it
waits for an error.

While navigating to an invalid view-source url with its inner url as
relative, this will pass the validity check we have right now and
do the navigation because of it takes account the baseURL while doing
the check. The invalid view-source url will be resolved into a valid
view-source url in the case. Fortunately, we won't encounter any issue
in the test in the past since the docShell will block this loading
because it's loading a view-source url inside an iframe and reports a
NS_ERROR_UNKNOWN_PROTOCOL error. But, we should faild with a
NS_ERROR_MALFORMED_URI error when doing the URL validity check.

For addressing this, this patch makes the client.navigate to not take
the baseURL into account if it is a view-source URL.

Differential Revision: https://phabricator.services.mozilla.com/D6587

--HG--
extra : moz-landing-system : lando
2018-09-24 18:22:26 +00:00
Tim Huang
b0d9c3aa78 Bug 680300 - Part 2: Add a test case for ensuring no error reporting when loading an unknown protocol. r=smaug
This test case will try to navigate an iframe to an unknown protocol and
check whether no errors been reported.

Differential Revision: https://phabricator.services.mozilla.com/D3493

--HG--
extra : moz-landing-system : lando
2018-09-23 22:24:05 +00:00
Tim Huang
22b72f2e9b Bug 680300 - Part 1: Stopping reporting errors when loading an unknown external protocol. r=smaug
This patch makes the docshell not to report an error if it is a unknown
protocol error. However, we will still display the error page in this
case.

Differential Revision: https://phabricator.services.mozilla.com/D3492

--HG--
extra : moz-landing-system : lando
2018-09-25 07:50:28 +00:00
Gabriele Svelto
1b38644136 Bug 1493365 - Reduce the amount of memory consumed when reading symbol files r=ted
When reworking the script each entry holding a function name was replaced by a
dictionary holding both the function name and its size. This significantly
increased memory consumption as using a full-fledged dictionary for only two
fields is very space inefficient. This patch uses a named tuple instead of a
dictionary for every entry, reducing memory consumption by almost four times.

Differential Revision: https://phabricator.services.mozilla.com/D6603

--HG--
extra : moz-landing-system : lando
2018-09-24 20:43:37 +00:00
Emilio Cobos Álvarez
939fb708fe Bug 1493710 - Don't apply containing shadow-host rules to NAC. r=mats
This is a regression from bug 1487856.

Differential Revision: https://phabricator.services.mozilla.com/D6700
2018-09-25 09:21:23 +02:00
Andrew Swan
344c8c7036 Bug 1484325 Go back to chrome.manifest for formautofill locale registration r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6690

--HG--
extra : moz-landing-system : lando
2018-09-25 06:03:20 +00:00
Julian Descottes
26887111d9 Bug 1489434 - Add i18n for DeviceSidebarItemAction component;r=birtles
Depends on D6614

Differential Revision: https://phabricator.services.mozilla.com/D6615

--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:52 +00:00
Julian Descottes
b246d48d96 Bug 1489434 - Add i18n for ConnectPage component;r=birtles
Depends on D6613

Differential Revision: https://phabricator.services.mozilla.com/D6614

--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:13 +00:00
Julian Descottes
641123a0a4 Bug 1489434 - Add i18n for NetworkLocationsForm component;r=birtles
Depends on D6612

Differential Revision: https://phabricator.services.mozilla.com/D6613

--HG--
extra : moz-landing-system : lando
2018-09-25 06:37:19 +00:00
Julian Descottes
e22e59e285 Bug 1489434 - Add i18n for NetworkLocationsList component;r=birtles
Depends on D6611

Differential Revision: https://phabricator.services.mozilla.com/D6612

--HG--
extra : moz-landing-system : lando
2018-09-25 06:35:23 +00:00
Julian Descottes
8b8f412ae2 Bug 1489427 - Add i18n for WorkerDetail component;r=birtles
Depends on D6610

Differential Revision: https://phabricator.services.mozilla.com/D6611

--HG--
extra : moz-landing-system : lando
2018-09-25 06:09:09 +00:00
Dorel Luca
5e538e879e Backed out changeset eae95de0eabe (bug 1480104) for spidermonkey failure 2018-09-25 09:17:02 +03:00
Ehsan Akhgari
1909662130 Bug 1493682 - Part 3: Add tests for the new prefs r=baku
The image cache tests didn't follow the previous naming convention
in order to make it clearer how the tests are set up using the
naming conventions of the files.

These tests should be unified into a single file soon.

Depends on D6748

Differential Revision: https://phabricator.services.mozilla.com/D6749

--HG--
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache1-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache1-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache12.js => toolkit/components/antitracking/test/browser/browser_imageCache10-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache12.js => toolkit/components/antitracking/test/browser/browser_imageCache10-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache12.js => toolkit/components/antitracking/test/browser/browser_imageCache11-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache12.js => toolkit/components/antitracking/test/browser/browser_imageCache11-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache15.js => toolkit/components/antitracking/test/browser/browser_imageCache13-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache15.js => toolkit/components/antitracking/test/browser/browser_imageCache13-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache15.js => toolkit/components/antitracking/test/browser/browser_imageCache14-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache15.js => toolkit/components/antitracking/test/browser/browser_imageCache14-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache2-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache2-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache4-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache3.js => toolkit/components/antitracking/test/browser/browser_imageCache4-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache5-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache5-2.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache6-1.js
rename : toolkit/components/antitracking/test/browser/browser_imageCache7.js => toolkit/components/antitracking/test/browser/browser_imageCache6-2.js
extra : moz-landing-system : lando
2018-09-25 05:40:16 +00:00
Ehsan Akhgari
1522f71329 Bug 1493682 - Part 2: Fix the image cache tests r=baku
The first line which this patch is fixing was clobbering the object
that the tests were setting up, so all these tests were testing was
the blocking callback of the default runTest() path before this
patch.

Depends on D6747

Differential Revision: https://phabricator.services.mozilla.com/D6748

--HG--
extra : moz-landing-system : lando
2018-09-25 05:40:14 +00:00
Ehsan Akhgari
4ad659ac56 Bug 1493682 - Part 1: Introduce two new prefs for controlling whether the content blocking allow list would be honoured r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6747

--HG--
extra : moz-landing-system : lando
2018-09-25 05:40:12 +00:00
Denis Palmeiro
484340a143 Bug 1480104: Provide an API for the gecko profiler, introduce a string hash table to remove duplicate data, and add necessary locks and changes to support the profiler start/stop routines r=sfink
There are a number of changes involved here which I'll try to summarize below:
1.  Provide API calls to start & stop the tracelogger.  These will enable and disable a set of events to trace.
2.  Provide API calls to reset the tracelogger.  This will empty the data structures used by the trace logger so that a new tracing session can occur without previous data corrupting it.
3.  Provide API calls to write out the trace logger data in JSON.  This will write out an array of strings which acts as the trace logger event dictionary, and an array of events with timestamps.
4.  Implement a new way of storing the event strings.  Previously, all strings were saved in the format "script:line:column".  However, this led to a lot of duplication because many events would use the same script at different locations.  Instead, we now save only the script string into a vector, and then hash it and save that into a table for reuse.  The line and column will be saved as part of the text id payloads.  Overall, this saves us about 100-150 MB of data for about a 10 second trace.
5.  Add some necessary locks for when the gecko profiler calls some of the API routines from another thread.

Differential Revision: https://phabricator.services.mozilla.com/D5219

--HG--
extra : moz-landing-system : lando
2018-09-23 21:51:44 +00:00
Ehsan Akhgari
6cdbf2a372 Bug 1491047 - Add a telemetry probe for measuring how many browsing sessions have had a private window opened in them; data-review=francois r=jdm
Differential Revision: https://phabricator.services.mozilla.com/D6063

--HG--
extra : moz-landing-system : lando
2018-09-25 04:53:40 +00:00
Andi-Bogdan Postelnicu
d3f9b58b9e Bug 1493641 - embed the libLLVM.dylib into clang-tidy artifact on macOS. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D6697

--HG--
extra : moz-landing-system : lando
2018-09-24 20:44:27 +00:00
Csoregi Natalia
5b32dd158a Backed out changeset 3dace40ce193 (bug 1492669) for build bustage on Result.h:308. CLOSED TREE 2018-09-25 07:11:39 +03:00
Marcos Cáceres
d8a1368253 Bug 1493052 - MerchantValidationEvent.complete() must throw InvalidStateError.
Spec conformance

Differential Revision: https://phabricator.services.mozilla.com/D6602

--HG--
extra : moz-landing-system : lando
2018-09-24 05:39:55 +00:00
Robin Templeton
a0d327b13b bug 1492669 - Implement BigInt support for relational comparison operators. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D6558

--HG--
extra : moz-landing-system : lando
2018-09-25 02:18:09 +00:00
Csoregi Natalia
b968b0a4ff Backed out 2 changesets (bug 1491889) for bustages on Logging.h:262. CLOSED TREE
Backed out changeset cb9048ebfec3 (bug 1491889)
Backed out changeset f8c53e2fdc7a (bug 1491889)
2018-09-25 06:53:10 +03:00
Bryce Van Dyk
86b7d71d5b Bug 1491889 - Update ChromiumCDMChild to hold a promise to track CDM init. r=cpearce
This changeset extends the async initialize functionality added in the prior
changeset by wrapping the Initialize resolver in a promise. This allows us to
use familiar promise machinery to handle async init of the CDM. We do this by
creating the promise and setting up handling when we receive the init message on
the ChromiumCDMChild, but resolving the promise in the `OnInitialized` callback
from the CDM to the ChromiumCDMChild.

We still only support CDM9 as of this changeset. As such, we now manually call
`OnInitialized` to make sure the ChromiumCDMParent is notified that the CDM has
initialized. When we implement the CDM10 interface, these manual calls will be
moved to the CDM9 compat layer, and Widevine CDM10+ can perform its own
callback.

This changeset adds a failure path to initialization, as the `OnInitialized`
interface we implement allows for failure. However, since we manually call into
this path for CDM9 we shouldn't get any such failures. Once CDM10 is fully
implemented its possible that the init callback could indicate failure, and the
handling here would be invoked.

Depends on D6061

Differential Revision: https://phabricator.services.mozilla.com/D6066

--HG--
extra : moz-landing-system : lando
2018-09-25 02:43:55 +00:00
Bryce Van Dyk
2fe058b38b Bug 1491889 - Update chromium CDM interface to accommodate async init. r=cpearce
Starting at the Widevine CDM10 interface, the CDM is expected to make a callback
to an `OnInititalized` function to signal initialization has taken place. Prior
to this, it was sufficient to call the init function on the CDM, with no waiting
for a callback.

This changeset puts in place the IPDL to support async init, as well as the
handling for the ChromiumCDMParent and ChromiumCDMProxy. The code is not fully
updated to handle CDM10, so CDM9 is the only compatible CDM. Because CDM9 does
not perform the init callback, we immediately call our IPDL to signal init has
taken place. This also accommodates the clearkey case, which uses the CDM9
interface.

Further changesets will put in place more elaborate handling to accommodate the
possible failure of init, as well as implementing the handling `OnInitialized`
function explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D6061

--HG--
extra : moz-landing-system : lando
2018-09-25 02:42:26 +00:00
Karl Tomlinson
03ab113d02 Bug 1493811 remove obsolete reference to TakeOwnershipOfErrorReporting() r=bzbarsky
Obsolete since https://hg.mozilla.org/mozilla-central/rev/a45a6cde6558

Differential Revision: https://phabricator.services.mozilla.com/D6707

--HG--
extra : moz-landing-system : lando
2018-09-25 01:49:18 +00:00
Csoregi Natalia
4a5dd87283 Backed out changeset 73a8628576e4 (bug 1493710) for failures on layout/reftests/forms/input/shadow-rules.html. CLOSED TREE 2018-09-25 03:57:36 +03:00
Karl Tomlinson
eed1f3fdf3 Bug 1492014 replace WorkletLoadInfo::mDumpEnabled with StaticPrefs r=baku
Depends on D6382

Differential Revision: https://phabricator.services.mozilla.com/D6383

--HG--
extra : moz-landing-system : lando
2018-09-24 17:19:09 +00:00
Karl Tomlinson
e6d5b031cb Bug 1492014 test Console::mInnerID instead of mGlobal when needing a window id r=baku
No behavior change intended.

Differential Revision: https://phabricator.services.mozilla.com/D6382

--HG--
extra : moz-landing-system : lando
2018-09-24 17:19:14 +00:00
Karl Tomlinson
b4ae5484b7 Bug 1492014 add AudioWorkletImpl/PaintWorkletImpl subclasses r=baku
This will be useful for AudioWorklet-specific storage and behavior.

PaintWorkletImpl is in layout/style, because it will be referenced
from CSS.cpp in the same directory.

Depends on D6108

Differential Revision: https://phabricator.services.mozilla.com/D6109

--HG--
extra : moz-landing-system : lando
2018-09-20 11:34:01 +00:00
Karl Tomlinson
18b9edd04f Bug 1492014 remove now-unused WorkletThread::mWorkletLoadInfo r=baku
Depends on D6107

Differential Revision: https://phabricator.services.mozilla.com/D6108

--HG--
extra : moz-landing-system : lando
2018-09-18 09:28:28 +00:00
Karl Tomlinson
1bbf3f704b Bug 1492014 get WorkletLoadInfo from global instead of thread in Console r=baku
Depends on D6106

Differential Revision: https://phabricator.services.mozilla.com/D6107

--HG--
extra : moz-landing-system : lando
2018-09-18 09:29:15 +00:00
Karl Tomlinson
49a69c3443 Bug 1492014 store global as nsIGlobalObject on Console so that this may be used for Worklets also r=baku
Depends on D6105

Differential Revision: https://phabricator.services.mozilla.com/D6106

--HG--
extra : moz-landing-system : lando
2018-09-20 11:29:20 +00:00
Karl Tomlinson
b35848bfc0 Bug 1492014 remove unused Console::GetParentObject() r=baku
WebIDL bindings do not need this method because console is a namespace.
All methods are static.

Depends on D6104

Differential Revision: https://phabricator.services.mozilla.com/D6105

--HG--
extra : moz-landing-system : lando
2018-09-18 09:32:11 +00:00
Karl Tomlinson
56d7a21566 Bug 1492014 get WorkletLoadInfo from global rather than thread in WorkletGlobalScope r=baku
We'll need to support multiple worklets sharng a single execution thread for
AudioWorklet.

Depends on D6103

Differential Revision: https://phabricator.services.mozilla.com/D6104

--HG--
extra : moz-landing-system : lando
2018-09-20 11:27:25 +00:00
Karl Tomlinson
be45c2c15d Bug 1492014 reference WorkletImpl from WorkletGlobalScope r=baku
Depends on D6102

Differential Revision: https://phabricator.services.mozilla.com/D6103

--HG--
extra : moz-landing-system : lando
2018-09-18 09:33:49 +00:00
Karl Tomlinson
e02575f37a Bug 1492014 document WorkletLoadInfo thread safety and relax destructor thread assertion r=baku
Depends on D6101

Differential Revision: https://phabricator.services.mozilla.com/D6102

--HG--
extra : moz-landing-system : lando
2018-09-18 09:34:11 +00:00
Karl Tomlinson
89c6ae2a56 Bug 1492014 introduce WorkletImpl as an object to identify a worklet from parent and execution threads r=baku
Depends on D6100

Differential Revision: https://phabricator.services.mozilla.com/D6101

--HG--
rename : dom/worklet/Worklet.cpp => dom/worklet/WorkletImpl.cpp
rename : dom/worklet/Worklet.h => dom/worklet/WorkletImpl.h
extra : moz-landing-system : lando
2018-09-18 09:36:38 +00:00
Karl Tomlinson
b1571dd6e0 Bug 1492014 remove unused aWorkletLoadInfo parameter to ExecutionRunnable() r=baku
Depends on D6099

Differential Revision: https://phabricator.services.mozilla.com/D6100

--HG--
extra : moz-landing-system : lando
2018-09-18 09:36:41 +00:00
Karl Tomlinson
5ca777a6b5 Bug 1492014 remove declaration for non-existant WorkletThread::GetWorkerPrincipal() r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6099

--HG--
extra : moz-landing-system : lando
2018-09-18 09:36:44 +00:00
Karl Tomlinson
f8377b2dc9 Bug 1493362 Remove obsolete "all wrappers are constructable if they are callable" comment r=edgar
The comment is no longer accurate since
https://hg.mozilla.org/mozilla-central/rev/26b1ee21f365#l2.20

I've left the same behavior because checking that the caller has permission to
access the unwrapped constructor still seems sensible.

The JS::IsConstructor() check could be performed on |constructor| but I
guess it is a touch more efficient on constructorUnwrapped.

Differential Revision: https://phabricator.services.mozilla.com/D6564

--HG--
extra : moz-landing-system : lando
2018-09-24 07:56:13 +00:00
Emilio Cobos Álvarez
2375a01424 Bug 1493710 - Don't apply containing shadow-host rules to NAC. r=mats
This is a regression from bug 1487856.

Differential Revision: https://phabricator.services.mozilla.com/D6700

--HG--
extra : moz-landing-system : lando
2018-09-24 21:32:59 +00:00
Mike Hommey
b487ebbc58 Bug 1493093 - Allow to relax MOZ_NON_TEMPORARY_CLASS for some specific constructors r=andi
Differential Revision: https://phabricator.services.mozilla.com/D6566

--HG--
extra : moz-landing-system : lando
2018-09-24 22:47:12 +00:00
Sam Foster
fc8ac20d5a Bug 1486165 - Refactor DnsOverHTTPs tests; re-enable on ccov r=jaws
* Re-use about:preferences tab and just open sub-dialog for each test
* Add some instrumentation to provide some insight into any test timeouts.
* Re-enable for ccov

Differential Revision: https://phabricator.services.mozilla.com/D5485

--HG--
extra : moz-landing-system : lando
2018-09-24 21:32:34 +00:00
Aaron Klotz
5dc8e2a672 Bug 1493000: Ensure that mach gtest passes --wait-for-browser to firefox when launcher process is enabled; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D6440

--HG--
extra : moz-landing-system : lando
2018-09-24 21:29:37 +00:00
alwu
b0130df3e1 Bug 1493027 - part2 : add test. r=cpearce
Differential Revision: https://phabricator.services.mozilla.com/D6541

--HG--
extra : moz-landing-system : lando
2018-09-23 22:12:43 +00:00
Mark Striemer
2b0aaa8c2d Bug 1483591 - Treat built-in webextension page actions as built-in r=adw
Differential Revision: https://phabricator.services.mozilla.com/D6329

--HG--
extra : moz-landing-system : lando
2018-09-21 21:50:26 +00:00
alwu
415fb653ea Bug 1493027 - part1 : access permissions without creating MediaManager. r=cpearce
If a site had been granted persistent permissions, but hasn't accessed navigator.mediaDevices yet.
Then, we can't read the permission because MediaManager hasn't be created yet.

We should read these permissions without loading MediaManager.

In addition, I noticed that even user only requests 'screen' permission, we would also add the 'camera'
and 'microphone' permission in the nsIPermissionManager. That makes us no way to print the log to distinguish
what actually permission user granted.

Differential Revision: https://phabricator.services.mozilla.com/D6540

--HG--
extra : moz-landing-system : lando
2018-09-23 22:11:06 +00:00
Jared Wein
d783e3ca71 Bug 1476852 - Implement keyboard selection for multiselect tabs. r=Gijs,Jamie
To use this (Windows/Linux instructions), press Ctrl+L to give focus to the location bar. Shift+Tab to move focus backwards to the tab.
Ctrl+Left/Ctrl+Right to change which tab is focused
Ctrl+Space to add/remove a tab from the multiselection
Moving a tab has been changed from Ctrl+Left/Ctrl+Right to Ctrl+Shift+Left/Ctrl+Shift+Right, respectively.

Differential Revision: https://phabricator.services.mozilla.com/D4670

--HG--
extra : moz-landing-system : lando
2018-09-24 20:36:59 +00:00
Gabriele Svelto
ac8cdd6759 Bug 1127855 - Handle title highlighting properly in all locales r=nalexander
This patch uses a case-insensitive matcher to highlight the title of a history
entry that's been typed by the user. Previously the matching substring was
calculated manually as lowercase assuming that it's representation would have
the same number of characters as the original mixed case. In some locales
howerver this assumption is wrong leading to out-of-bound exceptions when
highlighting part of the title.

Differential Revision: https://phabricator.services.mozilla.com/D6661

--HG--
extra : moz-landing-system : lando
2018-09-24 20:37:01 +00:00
Emilio Cobos Álvarez
462df0be75 Bug 1493708 - Handle split frames properly in FrameParticipatesIn3DContext. r=mattwoodrow
We're traversing primary frames, which are first continuations, so we can't
start from a continuation and expect to get to it. Add an assertion that would
catch further fishyness.

Differential Revision: https://phabricator.services.mozilla.com/D6672

--HG--
extra : moz-landing-system : lando
2018-09-24 20:07:39 +00:00