alexei.volkov.bugs%sun.com
5713a8afaf
[Bug 337326] Leak in nsslowcert_UpdateSubjectEmailAddr (security/nss/lib/softoken/pcertdb.c). r=nelson
2006-05-17 20:46:47 +00:00
alexei.volkov.bugs%sun.com
e1b759198c
[Bug 337009] OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList". r=nelson
2006-05-17 20:38:59 +00:00
alexei.volkov.bugs%sun.com
ef6e49c6b2
[Bug 337332] Leak in OpenNewDB (security/nss/lib/softoken/keydb.c). r=nelson
2006-05-17 17:56:32 +00:00
alexei.volkov.bugs%sun.com
4fe8d81c2b
[Bug 336485] coverity thinks that nssPKIObject_GetInstances could return null which would lead to a crash [@ listCertsCallback]. r=nelson
2006-05-16 23:47:43 +00:00
julien.pierre.bugs%sun.com
b0d4b44133
Fix for bug 335036. certutil tries to shutdown NSS even if it didn't initialize . r=wtchang, nelson
2006-05-16 02:16:25 +00:00
wtchang%redhat.com
844f45261e
Bugzilla Bug 337025: removed more unused or trivially used variables.
...
r=alexei.volkov,nelson.bolyard.
2006-05-16 01:57:04 +00:00
wtchang%redhat.com
942eb77419
Bug 305835: Remove NSS_ENABLE_ECC ifdefs in libssl. r=wtc,nelsonb
2006-05-16 01:14:43 +00:00
wtchang%redhat.com
49a4fc689f
Bugzilla Bug 298506: a first cut at Solaris auditing. The patch is
...
contributed by Glen Beasley of Sun. r=wtc.
Modified Files:
cmd/platlibs.mk lib/softoken/config.mk lib/softoken/fipstokn.c
2006-05-16 01:04:05 +00:00
julien.pierre.bugs%sun.com
42f2f41bff
Fix for bug 335036 . NSS_Shutdown() does not check that NSS is initialized. r=nelson, alexei
2006-05-16 00:10:04 +00:00
julien.pierre.bugs%sun.com
5ea61ffe76
Fix for bug 337789 . PK11_FindKeyByAnyCert doe snot work if softoken is in FIPS140-2 mode. r=wtchang, rrelyea, nelson
2006-05-15 23:51:01 +00:00
alexei.volkov.bugs%sun.com
6b1e6d3bf2
[Bug 336482] crash or hopefully deadcode [@ crmf_copy_poposigningkey]
...
because Pointer "destPopoSignKey" dereferenced before NULL check. r=nelson
2006-05-15 21:05:13 +00:00
alexei.volkov.bugs%sun.com
5940997e85
Patch contributed by jonsmirl@yahoo.com
...
[Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. r=wtchang
2006-05-15 20:58:10 +00:00
alexei.volkov.bugs%sun.com
968bb1125f
Patch contributed by jonsmirl@yahoo.com
...
[Bug 337086] Coverity 446, dead code in mozilla/security/nss/lib/certhigh/ocsp.c. r=wtchang
2006-05-15 20:52:01 +00:00
alexei.volkov.bugs%sun.com
7b49a9fc5a
Patch contributed by jonsmirl@yahoo.com
...
[Bug 337085] Coverity 447, dead code in mozilla/security/nss/lib/certhigh/ocsp.c
. r=wtchang
2006-05-15 20:44:46 +00:00
alexei.volkov.bugs%sun.com
02307faea5
Patch contributed by timeless@bemail.org
...
[Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c. r=nelson
2006-05-15 20:39:38 +00:00
alexei.volkov.bugs%sun.com
b2eede4173
Patch contributed by timeless@bemail.org
...
[Bug 336992] crash [@ pk11_DoKeys] "arg" Pointer dereferenced before NULL check. r=nelson
2006-05-13 00:46:51 +00:00
alexei.volkov.bugs%sun.com
39db992bd1
Patch contributed by timeless@bemail.org
...
[Bug 336972] OOM crash [@ PK11_ImportDERPrivateKeyInfoAndReturnKey] "pki" Pointer allocated by PORT_NewArena dereferenced without NULL check. r=nelson
2006-05-13 00:41:16 +00:00
alexei.volkov.bugs%sun.com
4176224c5b
Patch contributed by timeless@bemail.org
...
[Bug 336466] oom crash [@ CERT_DecodeAuthKeyID]. r=nelson
2006-05-13 00:33:09 +00:00
alexei.volkov.bugs%sun.com
0d612a798a
Patch contributed by jonsmirl@yahoo.com
...
[Bug 336935] Coverity 172, dead code in mozilla/security/nss/lib/softoken/keydb.c. r=nelson, r=alexei.volkov.bugs
2006-05-13 00:27:22 +00:00
julien.pierre.bugs%sun.com
a172cbe397
Fix for bug 336477. Memory leak in CERT_UncacheCRL . r=nelson
2006-05-13 00:27:12 +00:00
alexei.volkov.bugs%sun.com
d76295c913
Patch contributed by jonsmirl@yahoo.com
...
[Bug 336932] Coverity 163, dead code in mozilla/security/nss/lib/ssl/ssl3con.c. r=nelson
2006-05-13 00:15:43 +00:00
alexei.volkov.bugs%sun.com
73626f65a8
Patch contributed by timeless@bemail.org
...
[Bug 336481] oom crash [@ crmf_copy_cert_req_msg]
2006-05-13 00:03:12 +00:00
nelson%bolyard.com
28a533ac47
Bug 337093. Remove dead code at label loser in function dbs_readBlob
...
Patch by Jon Smirl <jonsmirl@yahoo.com>, r=wtchang. Coverity bug
2006-05-12 23:37:58 +00:00
wtchang%redhat.com
2a00f3c4d2
Bugzilla Bug 336521: we should search the build tree (${DIST}/${OBJDIR})
...
before /bin and /usr/bin. r=slavomir.katuscak
2006-05-12 20:50:53 +00:00
wtchang%redhat.com
68093029ef
Bugzilla Bug 336934: removed ununsed variable ck_id. The patch is
...
contributed by Jon Smirl <jonsmirl@yahoo.com>. r=nelsonb,wtc.
2006-05-12 20:42:13 +00:00
wtchang%redhat.com
4e43ea1d0a
Bugzilla Bug 336937: removed a test that is guaranteed to be true. The
...
patch is contributed by Jon Smirl <jonsmirl@yahoo.com>. r=nelsonb,wtc.
2006-05-12 20:33:47 +00:00
wtchang%redhat.com
cddae0bdc9
Bugzilla bug 336938: removed a test that is guaranteed to be false. The
...
patch is contributed by Jon Smirl <jonsmirl@yahoo.com>. r=wtc.
2006-05-12 16:49:07 +00:00
wtchang%redhat.com
321cb8386e
Bugzilla Bug 298506: Do not log the token name (so the declaration of
...
sftk_getDefTokName in pkcs11i.h and the previous change to sftk_SlotFromID
weren't necessary). Use Linux's audit subsystem if available. r=relyea.
Modified files: fipstokn.c pkcs11.c pkcs11i.h
2006-05-10 21:33:11 +00:00
wtchang%redhat.com
90e7d73574
Bugzilla Bug 298522: implemented ECDSA power-up self-test. The patch was
...
written by Glen Beasley of Sun. r=wtc.
2006-05-08 18:20:28 +00:00
wtchang%redhat.com
16146af129
Bugzilla Bug 333925: added a comment to paraphrase an obscure if statement.
2006-05-05 23:54:05 +00:00
wtchang%redhat.com
580b97817e
Bugzilla Bug 333925: worked around AES test failures of code compiled by
...
Forte 6 update 2 by using the old optimization flags used in NSS 3.10.
r=relyea.
2006-05-05 23:39:29 +00:00
wtchang%redhat.com
836e0c0b9c
Bugzilla Bug 334679: removed a duplicate line in ec_GF2m_validate_point.
...
r=douglas.stebila.
2006-05-05 23:08:50 +00:00
wtchang%redhat.com
798e8d1bc1
Added/removed blank lines to eliminate the diffs between the trunk and the
...
NSS_3_11_BRANCH.
Modified files: pkcs11.c pkcs11c.c
2006-05-05 20:31:30 +00:00
wtchang%redhat.com
01891a9574
Bugzilla Bug 298506: implemented FIPS 140-2 Security Level 2 audit
...
requirements. r=glen.beasley.
Modified Files:
fipstokn.c pkcs11.c pkcs11c.c pkcs11i.h softoken.h softoknt.h
2006-05-05 20:02:47 +00:00
julien.pierre.bugs%sun.com
ba58910b9e
Fix for bug 336335 . Plug leak of a temporary bignum in modular exponentiation . r=wtchang
2006-05-05 01:22:59 +00:00
julien.pierre.bugs%sun.com
1964aace2e
Fix for bug 336335 - memory leaks in ECC code. r=wtchang
2006-05-04 01:05:04 +00:00
julien.pierre.bugs%sun.com
7015af0983
Fix for bug 219932 . NISCC test script enhancements. Patch submitted by Jason Reid (jason.m.reid@sun.com) . r=slavomir.katuscak@sun.com,julien.pierre@sun.com
2006-05-01 22:52:32 +00:00
julien.pierre.bugs%sun.com
d15ad02799
Fix for bug 335021. Add SEC_ASN1_CONSTRUCTED to S/MIME EKP template. r=relyea
2006-04-29 00:18:42 +00:00
rrelyea%redhat.com
5f24a2a77c
Attachment #215739 : Use SSE2 multiply instructions on intel processors. for bug #326482
...
r=nelson r=wtc
2006-04-28 17:06:22 +00:00
christophe.ravel.bugs%sun.com
a8e64c65ca
[Bug 334843] Add rpath for HP-UX on pa-risc
...
r+ neil.williams.
2006-04-27 23:36:20 +00:00
alexei.volkov.bugs%sun.com
143f21193c
[Bug 334274] double free in CRMF_EncryptedKeyGetEncryptedValue. r=nelson
2006-04-27 22:09:28 +00:00
alexei.volkov.bugs%sun.com
f5f5d893ff
[Bug 334326] DecodeV4DBCertEntry: Variable "(entry)->nickname" tracked as NULL was passed to a function that dereferences it. r=rrelyea
2006-04-27 18:35:24 +00:00
alexei.volkov.bugs%sun.com
20919d892f
[Bug 334454] Variable "(key)->pkcs11Slot" tracked as NULL was passed to a function that dereferences it. [@ SECKEY_CopyPrivateKey - SSL_ConfigSecureServer]. r=nelson
2006-04-26 19:40:56 +00:00
alexei.volkov.bugs%sun.com
49cb46e26c
[Bug 333389] sftk_NewAttribute should not crash when so is NULL [@ sftk_NewAttribute]. r=nelson
2006-04-26 19:18:00 +00:00
alexei.volkov.bugs%sun.com
c353bf9e7b
[Bug 334522] pk12util crash in SEC_PKCS12DecoderValidateBags. r=nelson
2006-04-26 06:47:30 +00:00
nelson%bolyard.com
b9c189458d
Disable AMD64 assembly optimizations. Bug 334057. r=nelson
2006-04-25 05:51:23 +00:00
nelson%bolyard.com
249561bf3b
Bug 294537: ssltap should display ASCII CA names from cert request message
...
r=alexei.volkov
2006-04-25 04:58:45 +00:00
nelson%bolyard.com
f02321e973
Backout the last change, undoing the fix for bug 320336 and bug 333405.
2006-04-25 04:39:24 +00:00
alexei.volkov.bugs%sun.com
7fc553fcf8
[Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea
2006-04-25 02:33:58 +00:00
alexei.volkov.bugs%sun.com
97c78b7911
[Bug 334276] double free in [@ SECKEY_CopyPublicKey]. r=nelson
2006-04-25 02:23:52 +00:00
wtchang%redhat.com
085b36691e
Bugzilla Bug 320336: SECITEM_AllocItem should return a NULL pointer if the
...
allocation of its 'data' buffer fails. r=nelson. This checkin fixed bug
333405 as a byproduct.
Modified files: secitem.c secitem.h
2006-04-24 22:50:13 +00:00
nelson%bolyard.com
dbe80e7489
Remove call to printf in ecl/ecp_224.c Bug 334448. r=wtchang
2006-04-24 21:27:38 +00:00
nelson%bolyard.com
dafe77ce6c
Display TLS hello extensions and alerts. Display ECC cipher suites.
...
Bug 333600 and bug 334314. r=Alexei.Volkov
2006-04-24 06:11:41 +00:00
nelson%bolyard.com
1930ea6074
Put nss.def file sections in numeric order, and alphabetical order
...
within sections.
2006-04-24 05:08:04 +00:00
nelson%bolyard.com
0c05899fa2
Bug 323350. sr=rrelyea. This patch makes 3 changes:
...
1) it adds a new ifdef which enables SSL to limit itself to the 3 Suite B
curves.
2) it corrects the creation and parsing of the Supported Curve extension to
conform with the lastest definition, by using 2 bytes to encode the list
length,
3) it changes the algorithm that picks the curve for ECDHE to choose a curve
that is at least as strong as the "weakest link", is mutually supported
by client and server, and is the fastest for its size.
2006-04-23 00:17:18 +00:00
julien.pierre.bugs%sun.com
ff004c3373
Fix for bug 335039. Declare nssCKFWCRyptoOperation_UpdateCombo. r=wtchang
2006-04-22 05:30:18 +00:00
julien.pierre.bugs%sun.com
0a709d0578
Fix red tree on Windows.
2006-04-22 05:18:20 +00:00
alexei.volkov.bugs%sun.com
fc87dbb2fe
[Bug 334183] Double free on error because CERT_FindCertIssuer unexpectedly calls CERT_DestroyCertificate. r=alexei
2006-04-22 02:09:09 +00:00
julien.pierre.bugs%sun.com
1d134e6b56
Fix for bug 331413 . replace signal with sigaction; fix logging. r=wtchang
2006-04-22 01:28:14 +00:00
alexei.volkov.bugs%sun.com
76a9749ba0
Patch contributed by timeless@bemail.org
...
[Bug 334449] oom Crash in crmf_template_copy_secalg. r=nelson
2006-04-22 01:25:57 +00:00
alexei.volkov.bugs%sun.com
d4f39e6449
Patch contributed by timeless@bemail.org
...
[Bug 334436] nsslowcert_UpdateSubjectEmailAddr doesn't consistently use emailAddrs as a guard of nemailAddrs guarding emailAddrs[0]. r=nelson
2006-04-22 01:19:41 +00:00
alexei.volkov.bugs%sun.com
aea5eb0f12
Patch contributed by timeless@bemail.org
...
[Bug 334328] nsspkcs5_PKCS12PBE: Variable "A" tracked as NULL was dereferenced. r=nelson
2006-04-22 01:13:15 +00:00
alexei.volkov.bugs%sun.com
86494ef39a
[Bug 334275] double free in [@ PK11_ListPublicKeysInSlot]. r=nelson
2006-04-22 01:08:17 +00:00
alexei.volkov.bugs%sun.com
9c061b607a
[Bug 334273] double free in SECKEY_DecodeDERSubjectPublicKeyInfo. r=nelson
2006-04-22 01:03:18 +00:00
alexei.volkov.bugs%sun.com
5f88dfbdaa
[Bug 334240] double free in nsslowkey_ConvertToPublicKey if SECITEM_CopyItem or SECITEM_CopyItem fail. r=nelson
2006-04-22 00:59:13 +00:00
alexei.volkov.bugs%sun.com
8feb62dbd0
[Bug 334236] double free in PK11_ListPrivKeysInSlot if keys allocation fails. r=nelson
2006-04-22 00:55:29 +00:00
wtchang%redhat.com
e8b0114d09
Bugzilla Bug 333932: fixed Solaris SPARC GCC build failures.
...
r=christophe.ravel
2006-04-22 00:13:29 +00:00
alexei.volkov.bugs%sun.com
5f22914b4a
[Bug 334234] PK11_NewSlotInfo returns freed objects if lock allocations fail. r=nelson
2006-04-21 23:29:37 +00:00
wtchang%redhat.com
6f1bd4dc40
Bugzilla Bug 334533: in getPQseed we always set the most significant bit of
...
SEED to 1 to make NIST CMVP's PQG parameter validation tool happy. In
PQG_ParamGenSeedLen we require the length of SEED be at least 20 bytes.
r=nelson.
2006-04-21 17:48:30 +00:00
wtchang%redhat.com
37a7e6c417
Bugzilla Bug 298522: changed RSA modulus size to 1024 bits and added known
...
answer tests for RSA SHA1, SHA256, SHA384, and SHA512 signatures. The
patch is written by Glen Beasley. r=wtc.
2006-04-21 17:13:50 +00:00
wtchang%redhat.com
d0604ba735
Bugzilla Bug 236245: Use a stack buffer for ec_params.data in
...
ssl3_SendECDHServerKeyExchange. r=nelson.
2006-04-21 16:19:48 +00:00
wtchang%redhat.com
333657e660
Bugzilla Bug 334553: fixed the comments because mp_digit is actually 64-bit
...
(unsigned long or unsigned long long). r=nelson.
2006-04-21 16:13:02 +00:00
rrelyea%redhat.com
5cd56974be
Performance tests for ec curves. Test's freebl and pkcs11 interfaces.
2006-04-21 01:40:48 +00:00
wtchang%redhat.com
432ccc0173
Bugzilla Bug 326754: checked the change back in. We failed the NIST DSA
...
PQGGen test for some other reason (bug 334533).
2006-04-20 21:55:24 +00:00
nelson%bolyard.com
fe04651c77
Bug 80092: SSL write indicates all data sent when some is buffered.
...
SSL now follows NSPR socket semantics and never returns a short write
count on a blocking socket. On a blocking socket, it returns either
the full count or -1 (with an error code set).
For non-blocking sockets, SSL no longer returns a full write count
when some of the data remains buffered in the SSL record layer.
Instead it returns a number is that always at least 1 byte short of a
full write count, so that the caller will keep retrying until it is done.
SSL makes sure that the first byte sent by the caller in the retry
matches the last byte previously buffered. r=rrelyea.
Modified Files: ssl3con.c sslcon.c ssldef.c sslimpl.h sslsecur.c
2006-04-20 08:46:34 +00:00
nelson%bolyard.com
43a7c5e950
Fix buffer overflow regression. Bug 236245. sr=wtchang
2006-04-20 06:57:54 +00:00
alexei.volkov.bugs%sun.com
b67f75bc05
Patch contributed by timeless@bemail.org
...
[Bug 334459] Variable "cipherName" tracked as NULL was passed to a
function that dereferences it. [@ PORT_Strdup - SSL_SecurityStatus]. r=nelson
2006-04-20 00:20:45 +00:00
alexei.volkov.bugs%sun.com
0f639ba66a
Patch contributed by timeless@bemail.org
...
[Bug 334446] oom Crash in nssCKFWFindObjects_Create. r=nelson
2006-04-20 00:03:33 +00:00
alexei.volkov.bugs%sun.com
60674bc568
Patch contributed by timeless@bemail.org
...
[Bug 334443] oom Crash in nssCKFWSession_Create. r=nelson
2006-04-19 23:50:43 +00:00
alexei.volkov.bugs%sun.com
3a8f586a3c
Patch contributed by timeless@bemail.org
...
[Bug 334438] oom Crash in ReadDBCertEntry. r=nelson
2006-04-19 23:43:10 +00:00
alexei.volkov.bugs%sun.com
ff6fa1f51c
Patch contributed by timeless@bemail.org
...
[Bug 334442] Incorrect use of realloc oom Crash in secmod_ReadPermDB;r=nelson
2006-04-19 22:53:45 +00:00
alexei.volkov.bugs%sun.com
c501854878
Patch contributed by nelson@bolyard.com.
...
[Bug 334327] pk11_CreateNewContextInSlot: Variable "(context)->key" tracked as NULL was passed to a function that dereferences it. r=alexei
2006-04-19 22:32:30 +00:00
wtchang%redhat.com
fcca57e69e
Bugzilla bug 334553: use the ULL suffix with unsigned long long constants.
...
r=douglas.stebila.
Modified files: ecl/ecp_256.c mpi/mp_gf2m.c
2006-04-19 22:19:09 +00:00
wtchang%redhat.com
2c62bf1d13
Bugzilla bug 334683: removed extraneous semicolons. r=alexei.volkov.
...
Modified files: cmd/certutil/certutil.c lib/pki/pkistore.h
2006-04-19 19:04:23 +00:00
julien.pierre.bugs%sun.com
b41066e368
Fix for bug 331413. Don't set SO_LINGER in the Win95 build to workaround NSPR bug 332348. r=wtchang
2006-04-18 22:56:44 +00:00
wtchang%redhat.com
0a3bf353d3
Bugzilla Bug 333917: the non-x86 code in at least the DES_CBCEn and
...
DES_EDE3CBCEn functions violates ANSI C's aliasing rules. So we compile
this file with strict aliasing rules turned off. r=nelsonb.
2006-04-18 17:33:56 +00:00
nelson%bolyard.com
fa09229848
Don't add 3 to the user-supplied number of validity months. Bug 333679.
...
r=neil.williams
2006-04-15 01:00:11 +00:00
julien.pierre.bugs%sun.com
8eb43e8ec2
Fix for bug 262375 . Add clobber_dbm and clobber_nspr targets, as well as nss_clean_all . r=nelson
2006-04-14 22:48:31 +00:00
nelson%bolyard.com
b39425fcfa
big cleanup of error codes returned by pkcs12 library.
...
No longer returns SEC_ERROR_NO_MEMORY for every possible error code.
Bug 321584. r=neil.williams
2006-04-14 18:34:44 +00:00
nelson%bolyard.com
efdb126901
Fix broken optimized builds, caused by last checkin. Bug 236245.
2006-04-14 00:43:19 +00:00
nelson%bolyard.com
c4fb4fa280
Implement TLS Hello extensions for ECC. Bug 236245. r=rrelyea.
...
This patch has a known problem, choosing ephemeral ECDH curves
according to the wrong (suboptimal, non-FIPS) criteria.
Modified Files: ssl3con.c ssl3ecc.c sslimpl.h
2006-04-13 23:08:18 +00:00
nelson%bolyard.com
1cfdf61890
Add and use new -2 option for strsclnt to disable SSL2 compatible client
...
hellos, so we can stress test TLS hello extensions. Bug 333559.
r=julien.pierre,rrelyea
2006-04-13 22:43:31 +00:00
wtchang%redhat.com
b95ecf558f
Bugzilla Bug 330114: corrected the checks for the PKCS #1 v1.5 padding
...
string and the length of the data (hash). r=nelsonb,relyea.
2006-04-13 22:12:17 +00:00
julien.pierre.bugs%sun.com
6493a984f5
Fix for 333657 . Increase maximum RSA key size to 8192 bits in freebl. r=nelson
2006-04-12 05:37:52 +00:00
alexei.volkov.bugs%sun.com
258c59ba66
[Bug 332272] add core detection functionality to all.sh; r=nelson
2006-04-12 01:14:27 +00:00
wtchang%redhat.com
90d708c409
Bugzilla Bug 331413: assert that the worker threads empty the jobQ before
...
they terminate. Fix a socket leak when the SSL_ImportFD call in
handle_connection fails. r=nelson.bolyard.
2006-04-11 21:12:28 +00:00
nelson%bolyard.com
c65c61b8c5
Implement new API for registering and deregistering shutdown callback functions.
...
Patch by Bob Relyea and Nelson Bolyard. r=rrelyea,nelson Bug 326482.
2006-04-08 05:11:55 +00:00
nelson%bolyard.com
424fabe58a
Bug 333090: CKM_DH_PKCS_KEY_PAIR_GEN always fails. r=nelson, sr=rrelyea
...
Patch contributed by Andreas.Sterbenz@sun.com
2006-04-08 05:05:01 +00:00
nelson%bolyard.com
bbd7fa2247
WORKAROUND: disable all the ECDH_RSA cipher suites tests, since all those
...
tests require a cert with an EC public key and an RSA signature, and the
test scripts do not presently generate such a cert.
This workaround can be backed out when the real fix is available.
Bug 332222. r=neil.williams
2006-04-08 04:28:32 +00:00
kaie%kuix.de
1c0c7bbeb8
bug 331648, signed/unsigned bug submitting CRMF cert requests
...
r=rrelyea, sr=nelson
2006-04-07 11:41:18 +00:00