- gtk_window_get_transient_for() fails to return correct toplevel window as the toplevel window changes
when popup is moved in popup hierarchy. So store the toplevel given at nsWindow::Create() and
use it instead.
- Remove some redundat NS_WARNING() from wayland code
- Attach "moved-to-rect" signal handler to GdkWindow only once a update
NativeMoveResizeWaylandPopupCallback() loging.
- Add more logging to Wayland popup related code.
Differential Revision: https://phabricator.services.mozilla.com/D39347
--HG--
extra : moz-landing-system : lando
The test was supposed to pass custom values to waitFor (for
the number of tries and the interval), but what we end up
using in the webconsole is the waitFor function from the
debugger helper, which is loaded via loadSubScript.
Since the debugger waitFor doesn't allow to pass custom
maxTries nor interval, we are not waiting long enough
for all the messages to be displayed on slow machines.
The quickfix here is to allow debugger waitFor to have
custom maxTries and interval.
A better fix would be to actually not load the waitFor
from the debugger, for example by avoiding loadSubScript
and using modules instead.
Differential Revision: https://phabricator.services.mozilla.com/D40163
--HG--
extra : moz-landing-system : lando
We were hiding these labels by setting the "hidden" attribute by default and then, in CSS,
negating the effect of "hidden" by using `display: unset;`. Turns out this isn't a great
idea because doing this won't remove the "hidden" attribute, which some code relies on
to figure out whether the element is hidden. Like in this case PanelMultiview:
https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/browser/components/customizableui/PanelMultiView.jsm#1402
Here it tries to find elements to process as part of descriptionHeightWorkaround,
and that skips this technically visible element because it still has the hidden attribute.
Luckily that's easy to fix.
Differential Revision: https://phabricator.services.mozilla.com/D40552
--HG--
extra : moz-landing-system : lando
For many browser-chrome (bc) tests is does not matter what the
document is, as long as it is does not cause state to bleed over
from the previous test.
For these cases this patch introduces a shorthand, setup(), which
calls setupForURL(url) with an empty document generated by toDataURL("").
Differential Revision: https://phabricator.services.mozilla.com/D40216
--HG--
extra : moz-landing-system : lando
Per the URL standard, we should avoid talking about URIs (and indeed
URI, URN, et al.) since the term only serves to mislead.
Differential Revision: https://phabricator.services.mozilla.com/D40215
--HG--
extra : moz-landing-system : lando
The file only manages the browser console, so we're
making its name reflect what it does.
Differential Revision: https://phabricator.services.mozilla.com/D40441
--HG--
rename : devtools/client/webconsole/hudservice.js => devtools/client/webconsole/browser-console-manager.js
extra : moz-landing-system : lando
For many browser-chrome (bc) tests is does not matter what the
document is, as long as it is does not cause state to bleed over
from the previous test.
For these cases this patch introduces a shorthand, setup(), which
calls setupForURL(url) with an empty document generated by toDataURL("").
Differential Revision: https://phabricator.services.mozilla.com/D40216
--HG--
extra : moz-landing-system : lando
Per the URL standard, we should avoid talking about URIs (and indeed
URI, URN, et al.) since the term only serves to mislead.
Differential Revision: https://phabricator.services.mozilla.com/D40215
--HG--
extra : moz-landing-system : lando
Some local adaptions have been made, but this is mostly functionally
equivalent.
Differential Revision: https://phabricator.services.mozilla.com/D39687
--HG--
extra : moz-landing-system : lando
Introduces helper function, toDataURL(), that takes a document
extract and produces a data URL with the necessary properties for
Gecko to recognise it as an HTML document with the correct media type.
This has the benefit that HTML fragments and tags such as < and > are
encoded correctly, which is an obvious safety-win, and subsequently
that documents can be created on-the-fly with minimal code.
It will be possible to extend this function for other document types,
such as XHTML, XML, and even binary formats, as needed in the future.
Differential Revision: https://phabricator.services.mozilla.com/D39686
--HG--
extra : moz-landing-system : lando
The patch changes the color of the separator after the shield to use
variable '--urlbar-separator-color' instead of the variable
'--lwt-background-tab-separator-color'. And it removes the opacity.
Differential Revision: https://phabricator.services.mozilla.com/D40600
--HG--
extra : moz-landing-system : lando
If the popup is a regular menu but GetParentMenuWidget() returns
nullptr, it's connected non-menu parent (bookmark toolbar for instance).
In this case use a parent given at nsWindow::Create() and don't attach it
to latest active popup as it has a real parent.
Depends on D39347
Differential Revision: https://phabricator.services.mozilla.com/D39348
--HG--
extra : moz-landing-system : lando
- gtk_window_get_transient_for() fails to return correct toplevel window as the toplevel window changes
when popup is moved in popup hierarchy. So store the toplevel given at nsWindow::Create() and
use it instead.
- Remove some redundat NS_WARNING() from wayland code
- Attach "moved-to-rect" signal handler to GdkWindow only once a update
NativeMoveResizeWaylandPopupCallback() loging.
- Add more logging to Wayland popup related code.
Differential Revision: https://phabricator.services.mozilla.com/D39347
--HG--
extra : moz-landing-system : lando
In Context 0.1, Huffman keys are represented with a bit order that is the reverse of the bitstream. This
patch ensures that Huffman tables reverse the bit order of their keys upon initialization, so as to allow
fast comparison later in the code.
Differential Revision: https://phabricator.services.mozilla.com/D38979
--HG--
extra : moz-landing-system : lando
The security UI receives an about:blank load when navigating to or from
about: pages, which causes it to try and render security indicators before
showing the "real" security indicators for the next site. It shouldn't do that.
The solution is a bit cheap, we simply ignore all about:blank and other loads
that will receive a pageproxystate="invalid" state in the URL bar and thus
hide the identity block. This takes care of our problem and also avoids
some work when loading the home page.
Differential Revision: https://phabricator.services.mozilla.com/D40515
--HG--
extra : moz-landing-system : lando
This method & the chunkCountLimit_ variable are unnecessary. The maximum
permitted nursery size is tracked in the GCSchedulingTunables class.
Differential Revision: https://phabricator.services.mozilla.com/D39285
--HG--
extra : moz-landing-system : lando
The new variable, 'newMinNurseryBytes' is more in-line with the other
'newMaxNurseryBytes'.
Differential Revision: https://phabricator.services.mozilla.com/D39284
--HG--
extra : moz-landing-system : lando
We used to calculate the nursery's maximum size in chunks, and track the
maximum number of chunks permitted. This could lead to some unexpected
behaviour with a larger nursery than requested. Calculating it in bytes is
simpler, avoids this problem, and is more in-line with other calculations.
Differential Revision: https://phabricator.services.mozilla.com/D39281
--HG--
extra : moz-landing-system : lando
Nursery::exists() behaved exactly the same as Nursery::isEnabled() so use
the latter.
Differential Revision: https://phabricator.services.mozilla.com/D39280
--HG--
extra : moz-landing-system : lando
Rather than make re-enabling the nursery work correctly (because there's
various ways to disable it and we'd need to make sure we're enabling it for
the right reason). It's simplier just to not disable it for a
gcMaxNurseryBytes of 0, and instead return an error.
Differential Revision: https://phabricator.services.mozilla.com/D39988
--HG--
extra : moz-landing-system : lando
Original regression was by bug 1362858, and bug 1418629 wasn't enough to fix.
By bug 1362858, we use `CHAR_CLASS_SEPARATOR` in additional to DOM word separator. But some characters such as single quote, `@` and etc are `CHAR_CLASS_SEPARATOR`, so we may check spell by incomplete word.
We shouldn't separate word by characters that is email part, URL part or conditional punctuation.
And I also update test cases for this situation. `<textarea>` is better for spell checking since it can has multiple anonymous text nodes.
Differential Revision: https://phabricator.services.mozilla.com/D39829
--HG--
extra : moz-landing-system : lando
