The diff jobs currently take a Firefox package and compares against the
one from another build. When that fails, it also makes the diff of the
generated files, which can be useful when there are differences, but
can also be useful on its own. Also, because sometimes, like right now,
there are differences in generated files that have no impact on Firefox
itself, when differences do show up for Firefox, the differences in
generated files are added noise that sheriffs can't work around.
Differential Revision: https://phabricator.services.mozilla.com/D67113
--HG--
extra : moz-landing-system : lando
The fork server is not launched as expected with the
preference. This patch fix the issue.
Differential Revision: https://phabricator.services.mozilla.com/D65930
--HG--
extra : moz-landing-system : lando
The produce the same outcome as originally done in bug 1487797. However, we only do so on the last block ever retrieved.
Ideally, we should calculate the start time based on the number of frames previously returned. It would avoid such inconsistency and while we had one file presenting such symptom, I'm not sure we can always rely for the frame_or_sample_num value to be valid in reference to the first frame block size.
Depends on D66989
Differential Revision: https://phabricator.services.mozilla.com/D66990
--HG--
extra : moz-landing-system : lando
It didn't take into account that there could be a mixture of variable block size and fixed block size and could use the start time of an invalid block to determine the end of the previous frame as the code relied on Frame::FindNext() to have always returning a valid frame; but this isn't always the case.
We also want to keep the scope of each classes separate, so that it is up to the FrameParser to correct a Frame should it be invalid or not set properly.
Differential Revision: https://phabricator.services.mozilla.com/D66989
--HG--
extra : moz-landing-system : lando
`clone_from_bag` lets Rust code create a thread-safe `HashPropertyBag`
from any kind of `nsIPropertyBag` by cloning its contents. This is
important when you want to use a property bag that's passed to an XPIDL
method off the main thread. An `nsIPropertyBag` passed from JS isn't
thread-safe, since it's cycle-collected, and its properties are
`XPCVariant`s. But a Rust `HashPropertyBag` is, because it's backed by
a non-cycle collected `nsHashPropertyBag`, and the only supported
properties are thread-safe storage variants.
It also marks `HashPropertyBag` as `Send + Sync`, given that the only
way to construct one is through `HashPropertyBag::new`, and
`VariantType` is only implemented for storage variants.
Finally, it adds more type tags for string (narrow and wide) variants,
and changes the `VariantType for nsCString` getter to use
`GetAsAUTF8String`, since that's what mozStorage implements for its
text variant, not `GetAsACString`.
Differential Revision: https://phabricator.services.mozilla.com/D67075
--HG--
extra : moz-landing-system : lando
OSKeyStore doesn't need its own thread and can use the background thread pool instead.
Differential Revision: https://phabricator.services.mozilla.com/D66692
--HG--
extra : moz-landing-system : lando
When the signature verification fails after retry we don't want to apply the changes, and if possible we want to leave the local data as it was before sync.
Differential Revision: https://phabricator.services.mozilla.com/D67139
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Fix ci_resources_unittest (#22249)
Firefox has changed an error message recently, and the test is so
verbose that any change in output will cause failures.
--
wpt-commits: e19e45639560ff2a89a826c21bbe26d2bbee29df
wpt-pr: 22249
Automatic update from web-platform-tests
Add 'reftest-wait' class with timeout to reference pages for certain wpt
The reference pages for the 'embedded_style_media_queries*' tests
previously didn't wait to take a screenshot (as opposed to their
counterparts which wait 100ms to take a screenshot), causing them to be
a bit flaky. This CL fixes that.
Change-Id: Ie8dd12b3b4dd7f810d72b3ba94ae2e5cb3644fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103142
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#750509}
--
wpt-commits: 5f0d13915e4f46c7d25958f1a59155c200421a15
wpt-pr: 22251
Automatic update from web-platform-tests
[WPT/mixed-content] Add tests for SharedWorkers with no opt-in headers
Manual change: wpt/mixed-content/spec.src.json.
Previously, it omitted `http-rp/unset` tests because it expected
redundant tests `meta/unset`. However, in certain worker-related
tests, there are no `meta` tests, and thus `http-rp/unset` is
not redundant.
This CL enables generating such non-redundant `http-rp/unset` tests,
namely `sharedworker-{classic,module}.http-rp/unset`,
i.e. SharedWorkers served from HTTPS origin without no
opt-in CSP headers.
All other changes are mechanical.
Bug: 1061679, 1056500
Change-Id: Ib8c323cf06e1c6e0a0bdeae713bd13848335b95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103967
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750486}
--
wpt-commits: 370b686e596beb32e32a742e6c921bfdd84c35f0
wpt-pr: 22272
Automatic update from web-platform-tests
[WPT/common/security-features] Faster generator by less json.dumps()
Previously, dump_test_parameters() (which uses json.dumps())
was used to calculate the keys of `exclusion_dict`,
so that the keys of `exclusion_dict` include
all the fields of the selections.
However, this was slow.
This CL instead uses `excluded_selection_pattern % selection`
where excluded_selection_pattern incudes "`%(key)s`" for
all the keys of the selections, except for "expansion".
(The exclusion of "expansion" is probably good, as
differences in "expansion" fields shouldn't prevent
excluded test matching)
This CL improves the generator's performance about 5x.
This CL doesn't change the generated results or test behavior.
Bug: 906850
Change-Id: I67f2cf6e960d7867a9b409cb84bf8249ac1912c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100562
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750484}
--
wpt-commits: f64deda054dda4d72ad4d91f480ec584be6fb7e1
wpt-pr: 22271
Automatic update from web-platform-tests
[WPT/common/security-features] Remove spec_json.js from repository
`spec_json.js` are not used in WPT production runs.
This CL removes them, to omit `spec_json.js`-related diffs
in upcoming CLs.
This CL doesn't change the generated results or test behavior.
Bug: 906850
Change-Id: I1001286f2680294f1d8e747f23a25040f5bfd253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103728
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750483}
--
wpt-commits: 4568db58b5528eeb9edf931ab34d83fd6883600f
wpt-pr: 22265
Automatic update from web-platform-tests
[WPT/common/security-features] Replace name fields with inline comments
To remove special handling in the generator.
This CL doesn't change the generated results or test behavior.
Bug: 906850, https://github.com/web-platform-tests/wpt/issues/21708
Change-Id: Ibb6586d618a04dba96304ba4a21555034bd30d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102387
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750480}
--
wpt-commits: 10253dfa0ea5ec08995806418042de8c1c46f001
wpt-pr: 22266
Automatic update from web-platform-tests
Lazyload: Enable already-passing lazy load image tests
This CL removes two lazy load image tests from the TestExpectations file
since they are already passing. It also renames the two tests, since
there were typos in their filenames.
Bug: 626703
Change-Id: I0497342a7729ca3f551910b25bd14c17de83b65d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103009
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750459}
--
wpt-commits: f2bc9cdee9399d659d1eefd5034b5432ae7c5813
wpt-pr: 22263
--HG--
rename : testing/web-platform/tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-001.sub.html => testing/web-platform/tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub.html
rename : testing/web-platform/tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-ifame-002.sub.html => testing/web-platform/tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub.html
Automatic update from web-platform-tests
Reland "[ScrollTimeline] Support composited scroll-linked Web Animation"
This is a reland of 3254ad50926dbbd809cfa45b611d9081772ce7e8
The patch was reverted due to a test being flaky on debug build. It tests
the behavior that when an animation gets cancelled the other animation
that shares the same ScrollTimeline still work correctly. However, the
test is flaky even when no animation gets cancelled. Suspecting it's
related to how the test is written.
The only change from the original patch is adding the flaky test to
TestExpectation.
TBR=majidvp@chromium.org, bokan@chromium.org
Original change's description:
> [ScrollTimeline] Support composited scroll-linked Web Animation
>
> This patch integrates ScrollTimeline with cc::Animation. Major changes
> include:
> 1. blink::ScrollTimeline is able to create its compositor counterpart
> 2. cc::ScrollTimeline is attached to cc::AnimationHost upon creation
> 3. cc::AnimationHost ticks animations based on their timeline type
> 4. Remove scroll_timeline_ from cc::WorkletAnimation and use the unified
> animation_timeline_.
> 5. Added virtual/threaded/external/wpt/scroll-animations/.
>
> See [1] for more details.
> [1] https://docs.google.com/document/d/1RpJrYIDYHvtu0ia1vPv_EhBfan428QZ2sgsFhtnXb20/edit?usp=sharing
>
> To sheriffs: if any virtual tests become flaky, please add them to
> TestExpectation instead of reverting the change.
>
> Bug: 1023508
> Change-Id: Ib4aa853bda34ce9b2c0abc943be9f99ac81e799a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084088
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749389}
Bug: 1023508
Change-Id: Ic91414c192c519ca4943b58ea57f94f5b076dd0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103293
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750336}
--
wpt-commits: b250a8dade890029370b216997e41b598f13456f
wpt-pr: 22250
