Change loops over RDNs and AVAs to detect NULL pointers.
Change list of attribute type "keywords" to match RFCs and internet
drafts.
Quote attribute values strings that contain adjacent embedded blanks.
Don't quote hex string values.
Always use hex string values when type OID is unrecognized.
I took some time today to debug a problem in calendarManager.js related to the
handling of colors for events that are added to newly created calendars... in
essence they don't display with the background color because the calendar's
style rule was not being generated. New calendar objects didn't have an Id field
set which causes a fault in calendarColorStyleRuleUpdate.
Likewise I also changed the location of where calendarColorStyleRuleUpdate gets
called... it is now called in the 'ok' processing for the dialog(s), rather than
the last line in the launch dialog routines. This change was made so that we
don't call the function in the 'cancel' cases.
because it is a private function. Change the interface for this
function so that it returns a SECStatus, unambiguously indicating the
success or failure of the name constraints test. The function no
longer takes a list of cert subject names, instead, it takes a list
of cert pointers, and optionally outputs one of those pointers when
an error occurs. This eliminates a cert reference leak.
time when the list of cert names is being built and builds a GeneralName
out of it, just as if the rfc822 name had come from a subject alt name
extension. This way, no special handling is needed of either directory
names or rfc822 names in the name constraints code. The special "phase 1"
loop in cert_CompareNameWithConstraints disappears compmletely. And all
the cases in the (former phase 2) loop can now simply assert that the
name's type matches the constraint's type exactly.
This patch also factors out the code that creates new CERTGeneralNames and
that copies a single CERTGeneralName into new separate functions. This
eliminates a lot of duplicated code whose correctness required lengthy
inspection. Now these primitive operations are centralized.
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
mozilla/editor/libeditor/text/nsPlaintextEditor.cpp
- Fixed INTERFACE_MAP macros so that they call through to the class we inherit from.
r=brade@netscape.comsr=kin@netscape.com
nsWidget.cpp
- fixed the problem with context menus not showing up in the Mail&News client.
nsWindow.cpp
- fixed a problem with the PtRegion underneath the menus not being realized in some cases
( not related to the change in nsWidget.cpp ).