This patch adds the definitions of the RefPtr constructor and operator=.
It also refactors some stuff in AgileReference to make these objects easier
to use. Since it's just a bunch of C++ goop, I figured that you'd be fine to
review this. Let me know if you want to add a reviewer who is more familiar
with the COM nuances.
Depends on D5317
Differential Revision: https://phabricator.services.mozilla.com/D5318
--HG--
extra : moz-landing-system : lando
I'd like to add a constructor and operator= to RefPtr for mscom::AgileReference.
This patch is simply the forward declarations to allow for that.
Differential Revision: https://phabricator.services.mozilla.com/D5317
--HG--
extra : moz-landing-system : lando
I would like to migrate the update directory to use a version of the hash consistent with what our installer generates as part of the work already being done to migrate the update directory (Bug 1458314).
This patch is a bit of a shim to ensure that no one uses the newly-exposed nsXREDirProvider::GetInstallHash to get the *old* value before Bug 1458314 lands. This way new callers will get a value that is stable, but also consistent with the hash generated by the installer.
Differential Revision: https://phabricator.services.mozilla.com/D5334
--HG--
extra : moz-landing-system : lando
A XUL element within an HTML document should still follow the normal code
path for finding the tooltip element instead of always using the default
tooltip.
MozReview-Commit-ID: IBAmk1m4Zp0
Differential Revision: https://phabricator.services.mozilla.com/D5298
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-testsMerge pull request #12847 from mrego/css-contain-stacking-context
[css-contain] Containment and stacking contexts for inline elements
--
wpt-commits: 7d0d45d65796520f94eda3d4de3986b84e7173ab
wpt-pr: 12847
Automatic update from web-platform-testsMerge pull request #12823 from web-platform-tests/revert-12492-contain-support
Revert "[css-contain] Add support file in local directory"
--
wpt-commits: e54519b77a611d45d8f495a3344eca6a840d6fd3
wpt-pr: 12823
Automatic update from web-platform-testsPaymentRequest: Implement PaymentResponse.payerdetailchange event (#12846)
The event handler is triggered when the user changes payer information
such as payer name, payer email, or payer phone in the user interface.
Related spec change:
https://github.com/w3c/payment-request/pull/724
Test:
payment-request/payment-response/onpayerdetailchange-attribute.https.html
payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html
Bug: 861704
Change-Id: Ia5d63f53874abd7c76014bf35379a71a0eead622
--
wpt-commits: 3c6c9350988f98c8fac94fab8174bc4729cd6755
wpt-pr: 12846
Automatic update from web-platform-tests[cookies] Correct utility function and tests (#12835)
* [cookies] Fail on exceptional circumstance
Some tests which use the `credFetch` utility include assertions only for
the absence of cookies. Because `fetch` does not reject the returned
promise for valid HTTP responses outside of the 2XX range, these tests
could be satisfied by querying non-existent URLs. This is not an issue
in any existing tests, but it has the potential to hide problems in
future patches.
Update the `credFetch` function to report unsuccessful requests as
failures.
* [cookies] Correct utility function and tests
The `cookie-helper.sub.js` utility script includes
`set_prefixed_cookie_via_http_test`, a function that defines sub-tests
using the `promise_test` API. Previously, it included the following
code:
promise_test(t => {
var postDelete = _ => {
// (elided)
};
if (!options.origin) {
return postDelete;
} else {
// (elided)
}
});
The `promise_test` function does not recognize return values which are
functions, so returning the `postDelete` method had no effect, and as a
result, the generated tests performed zero assertions. Because none of
the consumers of `set_prefixed_cookie_via_http_test` specified a value
for the `origin` option, all invocations were effected by this bug.
Correcting the problem surfaced a number of errors in the tests. In the
interest of atomicity, this patch attempts to address them all:
- The logic intended to defensively remove cookies prior to testing was
implemented using `document.cookie`. Because some tests create cookies
which include the `HttpOnly` attribute, the DOM API cannot remove
cookies in all cases. This patch refactors the solution to remove
such cookies via an HTTP request. It also assumes the environment is
initially clean and instead expresses the concern via an asynchronous
"cleanup" function. (This change necessitated an extension to the
`set.py` script so that it could be used to expire cookies.)
- The test name `__secure.header.html` incorrectly asserted that a
cookie set with the `Secure` attribute could be observed in a
non-secure context. This patch corrects the expectation.
- The test named `__secure.header.https.html` incorrectly asserted that
a cookie set with a foreign `Origin` attribute could be observed from
the current origin. This patch corrects the expectation.
--
wpt-commits: 88d4f4cc118320c4e02003ffc1ba2c5ee81b1753
wpt-pr: 12835
Automatic update from web-platform-tests[LayoutNG] Add LayoutBox::PercentageResolutionLogicalHeight.
This function allows LayoutNG to correctly query the percentage
resolution block_size in quirks mode. (see test case for an example of
where this happened).
We call this as we are crossing a legacy->LayoutNG boundary while
creating the constraint space from a LayoutObject.
The function will also be used in the CSS Layout API to provide the
correct percentage resolution size.
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I295145996f2460de1b25f85ff3784df6d6edbd30
Reviewed-on: https://chromium-review.googlesource.com/1194072
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589074}
--
wpt-commits: a806d658df3bcc3f05675ad8d08a6e109177c6b0
wpt-pr: 12855
Automatic update from web-platform-testsFix cases where setValueCurveAtTime was not throwing errors
Catch more cases where we should throw errors if a new
setValueCurveAtTime overlaps an existing setValueCurveAtTime event.
Add some additional tests for more coverage. Also, some of the
existing tests were using incorrect expected error types so fix them.
Remove test expectations file since we pass now.
Bug: 879767
Test: the-audioparam-interface/audioparam-setValueCurve-exceptions.html
Change-Id: I14a7a7c9ab36955b7e084ca9148495860b661111
Reviewed-on: https://chromium-review.googlesource.com/1205719
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589059}
--
wpt-commits: 9f63e45e03bb836556466ba43082c4a1c464b14e
wpt-pr: 12837
Automatic update from web-platform-testsThrow errors for invalid rolloffFactor and coneOuterGain
The WebAudio spec says we must throw errors for a negative
rolloffFactor and for a coneOuterGain outside the interval [0,
1]. Make it so.
Also add some additional tests to ctor-panner.html to verify that a
rolloffFactor of 0 or 100 do not throw errors and that a
coneOuterGain of 0 or 1 do not throw errors.
Remove invalid tests from panner-rolloff-clamping.html because
negative rolloffFactor now throws an error.
Finally remove text expectation for ctor-panner.html test, which
passes now.
Bug: 879845
Test: the-pannernode-interface/ctor-panner.html, the-pannernode-interface/panner-rolloff-clamping.html
Change-Id: Ie90e9fe13e82fd3cc955060dc9e77266ef4ff591
Reviewed-on: https://chromium-review.googlesource.com/1205099
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589045}
--
wpt-commits: 7b9c733915fab4723a453e03d692f9c396a8c6fb
wpt-pr: 12834
Automatic update from web-platform-tests[wptrunner] Reject tests that almost time out
In stability check (wpt run --verify), reject tests that almost time
out, i.e. take more than 80% of the timeout allowed to run). These tests
will be listed in a new section, "slow tests", in the output.
Fixes#9972.
--
Take timeout_multiplier into account
--
Longest duration for each status of each test
Previously we record the longest duration of all tests. However, each
test can have different timeout. Besides, test runs with different
results should be considered differently; runs that time out should be
ignored.
Therefore, we now keep track of the longest duration for each result
status of each test.
Also add a unit test.
--
Fix ci/check_stability.py
--
wpt-commits: 20f4a6dcec93d3ea65a8dd5c3b3a3dbe30476ae6, 0ccdf9b766875ae82000aa88c6c011c6cbd08430, 5a540d04ef8d14f77e0afa9f139788a45c7a65d3, 69717e2cdc71420593c3eedf6d370cb397b5b621
wpt-pr: 11570
