This matches UWP apps like Settings on Windows 11, and what we do for other
desktop platforms too.
The system colors match the ones from Win32 otherwise, but using UIUtils we can
access the accent color pallete from UWP apps.
Add a pref just to be safe in any case.
Differential Revision: https://phabricator.services.mozilla.com/D149905
It'd be weird otherwise, as in platforms where use-theme-accent is false
(Windows), form controls would be blue (the default accent color) but
the AccentColor color would be the system accent color still.
Differential Revision: https://phabricator.services.mozilla.com/D149877
The link was missing an event listener, that we add in this patch.
A test case is added to make sure the link does work.
Differential Revision: https://phabricator.services.mozilla.com/D149953
Automatic update from web-platform-tests
Properly handle floats leaving an inline formatting context.
Revert all code changes from CL:3613771 and replace with this. The bad
CL just did SetIsInLayoutNGInlineFormattingContext(false), which would
leave fragment items behind pointing to layout objects. When such a
layout object would later on be deleted, the fragment items wouldn't be
notified, since IsInLayoutNGInlineFormattingContext was false.
Notify the fragment items that layout object becoming in-flow
non-floated will be "moved", to properly clear the association. There
was already code for this when going out-of-flow, but we also need this
when becoming in-flow non-floated.
Bug: 1331189
Change-Id: I888d81495627952b75ec33a83edce165f6a3ad01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714111
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016000}
--
wpt-commits: d0cc6394218081bea51fc0352cd521fbf1fc1f47
wpt-pr: 34498
Automatic update from web-platform-tests
[TableFragmentation] Nested repeated table headers
If a table header was nested inside of another, we would end up
breaking forever. This happened because we would set if the header
ConstraintSpace IsRepeated() based on its parent's ConstraintSpace.
Because the parent's ConstraintSpace had IsRepeated() set to true in
this case, the inner header would never terminate repeating itself,
even when RelayoutAsLastTableBox() was called.
To fix this, don't rely on the parent ConstraintSpace to set this.
Also consider what repeat_mode is set to for the current header.
Once this was fixed, we also ran into an issue when cloning these
nested headers (because they were already repeated). To get this
working, NGFragmentRepeater::GetClonableLayoutResult() needed to be
updated to consider if the repeated break token was the result of
a different fragmentation context than the current header being
cloned.
Bug: 1336683
Change-Id: I13e7af8ce91144e4c3c22eca6dc2a45a0f1a9b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710528
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1015548}
--
wpt-commits: 73380548ab5f7f6fe47ece278005b500e45f8c4d
wpt-pr: 34475
Automatic update from web-platform-tests
Reland "Implementing grid-template-columns/rows interpolation support"
This is a reland of commit b266b143ec994a7a97349cd2d54e18f52bf9534f
It was reverted due to failures in MSAN builds: https://crrev.com/c/3704863. The variable |progress_| in InterpolableGridTrackList was uninitialized, resulting in crashes in Add(...) and RawClone().
Original change's description:
> Implementing grid-template-columns/rows interpolation support
>
> This CL adds new interpolation types to represent grid track lists and
> their track sizes, allowing interpolation of grid-template-columns and
> grid-template-rows. A more detailed explanation of the design can be
> found in this doc: https://docs.google.com/document/d/1byO4UU-gFRNrqAEuhL3AKgUuFprz4ZQYNEeXSF9T6w0/edit?usp=sharing
>
> Bug: 759665
> Change-Id: Iecef825cd843c60bf6268cdbfc2f9180c884f853
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3403003
> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1013983}
Bug: 759665
Change-Id: I71aba0c2be7e4cd56aa92521b9b0008ab25c0ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3705054
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1015433}
--
wpt-commits: 97330944a2b19338d3f58955adb3250cf4b5279e
wpt-pr: 34480
Automatic update from web-platform-tests
May need paint invalidation on cache hit inside fragmentation.
When block-fragmented, LayoutBox stores the location in the flow thread
coordinate space, not the actual visual location. This means that we may
miss location changes, if the flow thread offset remains unchanged (if
the fragmentainer size changes without needing to re-lay out the
object).
Explicitly mark direct flow thread children for a paint invalidation
check, in case the cache was hit.
Bug: 1336180
Change-Id: I66342c80f2e6cb6478eff6f06d103a9a9c8ecd12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3706987
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015412}
--
wpt-commits: 8b9da29d2d6907de99c080562fdd9c69cda698f1
wpt-pr: 34470
Automatic update from web-platform-tests
Breaking before a float
In the added test case, the second float is processed in an earlier
fragmentainer than the first (nested) float. If the first float
ends up breaking before, we may try to break before the second
float, as well, even though it had already broken.
Instead, check if a float has broken previously before attempting to
add a break before it.
Bug: 1336847
Change-Id: Ic9231f3d93fbebae3bbf022641082c2b78829db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710174
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015370}
--
wpt-commits: 22d425520a0de4af40b56b5a35bc18b07cd9996c
wpt-pr: 34472
Automatic update from web-platform-tests
[intersection-observer] Add a test for clip-path being accounted for.
From https://w3c.github.io/IntersectionObserver/#calculate-intersection-rect-algo
step 3.3:
> If container has a content clip or a css clip-path property, update
> intersectionRect by applying container’s clip.
--
wpt-commits: d3d0aa492ab758a9b0ab55a27bd3957301071644
wpt-pr: 34400
Automatic update from web-platform-tests
Fix popup animation bug, and add more testing of animations
Primarily, this CL adds a test of popup animations for these two cases:
1. descendant elements have an animation: make sure "hide" waits for it
2. there are already-running animations: make sure "hide" doesn't wait
These were follow-up action items from [1].
While writing this test, I found and fixed a corner case bug: if there
are *only* pre-existing animations, a popup would never be hidden.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3688871
Bug: 1307772
Change-Id: I133f4d682bb8081b137fb23675137b06e6a15565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708115
Reviewed-by: Robert Flack <flackr@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015056}
--
wpt-commits: 93a98d6ac4785d3c78b57845d91c78e2bf12c6eb
wpt-pr: 34454
Automatic update from web-platform-tests
[intersection-observer] Allow to write promise-tests.
And port display-none.html to that.
--
wpt-commits: ec0a8769149aaf77d3520360ceb1277e9af43a22
wpt-pr: 34397
Automatic update from web-platform-tests
Remove phase from animation timeline IDL.
This patch removes phase from the IDL for animation timeline. Phase
is still used internally, but will be phased out over a series of
followup patches.
Spec resolution can be found here:
https://github.com/w3c/csswg-drafts/issues/7240
The test for animation effect phases was updated to avoid use of
scroll offsets, which are also being removed from scroll timelines.
Offsets will be exclusively used in view timelines (details still being
worked out).
Bug: 1336260
Change-Id: I282d947510d50ea67de7351c8a29ab83734c641d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702747
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014933}
--
wpt-commits: 44420251fd9449cccb8b22893c0919f3dafca4b8
wpt-pr: 34431
Automatic update from web-platform-tests
Escape metadata heading contents in Chromium log formatter (#34435)
Some subtests contain a closing square bracket literal in its name
(']'). Because the Chromium formatter did not escape those characters,
it could write an unparseable expectation manifest. The parser
interpreted the unescaped character as an end-of-heading marker.
--
wpt-commits: 0e9e6936ce918fbd31c737a727d7db7c244e75dd
wpt-pr: 34435
Automatic update from web-platform-tests
Capability Delegation: add sender error checks and corresponding WPTs
This patch adds error checks and WPT for delegating:
- an unsupported capability,
- to targetOrigin=*, and
- without user activation.
These covers all except one ("allowed-to-use") error checking in the
proposed algorithm:
https://wicg.github.io/capability-delegation/spec.html#monkey-patch-to-html-initiating-delegation
Bug: 1327003, 1326575
Change-Id: I12e2e87779509498bb90f77730a107ddd24fa6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687314
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014958}
--
wpt-commits: 479dc94e67f63cded1d8ac17416d39f49370c512
wpt-pr: 34378
Automatic update from web-platform-tests
[webauthn] WPT for autocomplete="webauthn"
Add a web platform test for the "webauthn" autocomplete detail token.
Drive-by fix to the "contact category" bit of the test. The test
intended to exceed the maximum number of tokens for an autofill field
type of category "contact" [1], but used the field name "name" which
is of category "normal". Change "name" to "tel" which actually is of
category "contact".
See https://github.com/whatwg/html/pull/8006
[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill-processing-model
Bug: 1171985
Change-Id: Idfdee8447c5eaa6b4d5ab34249dee2c46b82ecec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704319
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014943}
--
wpt-commits: 57933a8edb4f01c8b63435d7f08cbd8ba4efd32b
wpt-pr: 34410
Automatic update from web-platform-tests
Apply inline-size containment for replaced elements
- <audio> cases are still failing, because width/height:auto isn't
working for <audio>. (crbug.com/985623)
- The <img src=broken> cases were adjusted to drop the expectations
on the non-contained axes, because the fallback contents used in
that case is UA-specific (e.g. 24 in Gecko, but 18 in Blink).
Fixed: 1322881
Change-Id: Iedf01cb7c934228b58ad0724a398e7369f4d5fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3666976
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014887}
--
wpt-commits: ffc4684f61be292947d61672487a4864cab59b33
wpt-pr: 34197
Automatic update from web-platform-tests
Split testing CSS transitions before load vs. load event behavior when changing <img>.src
The test css/css-transitions/before-load-001.html relies on loading an image where the load is set to 100 seconds such that the window `load` event dispatch is delayed until a CSS Transition is ran. At that point, the image's source is set to the empty string to stop the image load and have the window `load` event dispatched.
Safari has an issue where an <img> pointing to a long-loading resource will continue delaying dispatch of the `load` event on the window even when the image source has been reset. This issue is tracked by https://bugs.webkit.org/show_bug.cgi?id=241676.
As a result, css/css-transitions/before-load-001.html causes a harness timeout in Safari even though the ability to run a CSS Transition before the window `load` event has been dispatched works correctly and the test assertions pass.
We work around that issue by lowering the load duration for the image to 1 second instead of 100. This doesn't changed the functionality that this test is explicitly testing. And to explicitly test that resetting a long-loading image source no longer delays the dispatch of the window `load` event, a new dedicated test is added, which will itself cause a timeout in Safari, but that is what is expected.
Addresses https://github.com/web-platform-tests/wpt/issues/34444.
--
wpt-commits: 644aba8746b83668d5d9033cda16ae3f8bba0b3d
wpt-pr: 34463
Automatic update from web-platform-tests
Fix streaming upload tests
- Streaming upload is disabled on HTTP/1.1. Move some tests to the
h2 file.
- Explicitly test that streaming upload is blocked on HTTP/1.1.
421 handling hasn't been implemented yet.
Also fix the implementation which blocked CORS requests unintentionally.
Change-Id: I8da8ea411ae6d55e2d7dfddc34f3da529651aa7f
Bug: 1234368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3699531
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014859}
--
wpt-commits: d387101095115f28446dbf2da77fb64dea697815
wpt-pr: 34418
