Commit Graph

201 Commits

Author SHA1 Message Date
justdave%syndicomm.com
50f9d20669 Fix for bug 92263: Don't output SQL commands before the footer when syncshadowdb fails (only affects Bugzillas that are running shadow databases)
r= bbaetz, gerv
2002-03-31 22:56:41 +00:00
gerv%gerv.net
e4bc59e823 Bug 104589 - prevent user closing window from terminating Bugzilla scripts. Patch by Gerv <gerv@mozilla.org>, r=justdave, myk 2002-03-28 07:57:05 +00:00
bbaetz%student.usyd.edu.au
28a2172401 Bug 131521 - Set $::ENV{PATH} so that we don't get bogus 15 line warnings
from perl 5.6.1's Cwd.pm on every system() call.
r=mattyt, justdave
2002-03-23 03:51:05 +00:00
myk%mozilla.org
b488beb502 Fix for bug 103778: Rewrites and templatizes buglist.cgi.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2002-03-12 13:55:07 +00:00
bbaetz%student.usyd.edu.au
0d9fe82f40 Backing out a bit I didn't mean to check in as part of bug 119657. Oops. 2002-03-02 02:44:51 +00:00
bbaetz%student.usyd.edu.au
676a581bc8 Bug 127318 - push UserInGroup to templates
r=jake x 2
2002-03-01 06:01:12 +00:00
bbaetz%student.usyd.edu.au
ae797d18e3 Bug 119657 - template error checking
r=gerv, justdave
2002-03-01 05:57:43 +00:00
gerv%gerv.net
b1d1b04044 Bug 115369 - templatise long_list.cgi. 2002-02-19 23:22:24 +00:00
justdave%syndicomm.com
065a93f81a Fix for bug 125516: the recent fix for emails truncating when a period occurred on a line by itself broke Exim because it
needs the -t and -i as separate parameters instead of stacked (the original patch had -ti)
Patch by Tobias Burnus <burnus@gmx.de>
r= justdave, gerv
2002-02-17 08:22:31 +00:00
bbaetz%student.usyd.edu.au
bb41d6ee37 Bug 110013 - templatize describecomponents.cgi
r=gerv, afranke
2002-02-14 01:25:25 +00:00
justdave%syndicomm.com
a89d3b4448 Backing out checkin for bug 115369, it's busted on Perl 5.00503. 2002-02-13 17:25:02 +00:00
justdave%syndicomm.com
013e12ec00 Fix for bug 115369: Templatization of long_list.cgi
Patch by Gervase Markham <gerv@mozilla.org>
r= bbaetz, dkl
2002-02-13 15:34:36 +00:00
bbaetz%student.usyd.edu.au
fdfcfb96fd Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke
2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
b798365389 Bug 100094 - use generic template handling code
r=mattyt, afranke
2002-02-13 02:27:24 +00:00
justdave%syndicomm.com
a4a033f5d4 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
12965a910a Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko
2002-02-04 12:23:05 +00:00
myk%mozilla.org
b6fa253e93 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko
2002-02-03 09:28:48 +00:00
myk%mozilla.org
aba1aab698 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko
2002-01-30 14:14:12 +00:00
bbaetz%student.usyd.edu.au
d9d0617952 Bug 121074 - taint error after changing bug
r=daa@distributed.net,jake
2002-01-22 15:12:11 +00:00
bbaetz%student.usyd.edu.au
ab40697509 Bug 98368 - dbi connect doesn't use db_port option.
Patch by gene.stuckey@tellabs.com, r=bbaetz,justdave
2002-01-22 06:49:22 +00:00
justdave%syndicomm.com
e24c04e22a Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave
2002-01-20 01:44:52 +00:00
zach%zachlipton.com
e4ba5888ef Fix for bug 113646, midair when changing assignee gives error. Fix changes sub trim() in globals.pl not to use $_ so as not to conflict with $_ values allready
set.

Patch by myk@mozilla.org, r1=bbaetz, r2=dave.
2001-12-17 01:29:52 +00:00
matty%chariot.net.au
8cd4f2a450 Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
Patch by Christoper Aillon <caillon@returnzero.com>.
2001-11-17 10:29:55 +00:00
bbaetz%cs.mcgill.ca
befb702df6 Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
Quote manually rather than using qw to get arround this
2001-11-17 07:57:25 +00:00
bbaetz%cs.mcgill.ca
a4ce4d1898 Bug 101560 - clear some more env vars so that system calls will run in
taint mode. The perforce integration stuff needs this.

r=gerv,mattyt
2001-11-17 07:19:46 +00:00
jake%acutex.net
07e2f4e3ac Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
r= mattyt, gerv
2001-11-12 13:43:59 +00:00
bbaetz%cs.mcgill.ca
ac3ee32727 Fixed "used only once" warning coming from my patch for bug 97469. The
warning was hidden from the tests by bug 106424.

r=Jake, no 2nd review needed.
2001-10-24 20:33:49 +00:00
bbaetz%cs.mcgill.ca
543d7e522a Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave
2001-10-23 15:44:53 +00:00
jake%acutex.net
816b5dd385 Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net, gerv@mozilla.org, justdave@syndicomm.com
2001-10-20 13:03:14 +00:00
jake%acutex.net
8a7f3a8457 Backing out previous change, the wrong patch got checked in. 2001-10-20 12:59:57 +00:00
gerv%gerv.net
46fd032ece Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv. 2001-10-20 01:06:59 +00:00
jake%acutex.net
b6e9432e59 Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net
2001-10-19 23:49:37 +00:00
gerv%gerv.net
a7ddb1c069 Bug 57819 - change the size of the bit we print in the large error case. r=justdave. 2001-10-14 01:34:08 +00:00
justdave%syndicomm.com
93a2f50358 Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com
e6fe9a6c8b Backing out Gerv's checkin for bug 71840. Per the bug report, it did not have proper review first, and myk objected to what
got landed on irc.
2001-10-12 03:03:00 +00:00
gerv%gerv.net
f5c157f6d7 Bug 71840 - Make comments referenceable. Patch by gerv; r=myk, jake (ish :-). 2001-10-11 23:07:54 +00:00
gerv%gerv.net
1b446a2a5d Bug 57819 - cut down large mysql error strings. Patch by n_hibma@qubesoft.com, r=gerv. 2001-10-11 21:58:07 +00:00
justdave%syndicomm.com
2d5eda33b3 Fix for bug 82809: comments in bugs no longer have &#013; where the linefeeds should be.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless@mac.com (no 2nd review needed)
2001-10-03 07:49:19 +00:00
jake%acutex.net
f1aceec2a8 Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
r= myk@mozilla.org, zach@zachlipton.com
2001-09-14 21:50:08 +00:00
jake%acutex.net
860d363d2e Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, caillon@returnzero.com
2001-08-31 23:51:35 +00:00
justdave%syndicomm.com
7446d8aadb Bumping version to 2.15 for development 2001-08-29 21:41:50 +00:00
justdave%syndicomm.com
2b551274fa moving version to 2.14 (golden) to roll the tarball. 2001-08-29 19:52:13 +00:00
justdave%syndicomm.com
35e86efb26 All code patches targetted for 2.14 have been checked in. Bumping version
number to 2.14rc to indicate release candidate status.
2001-08-26 23:06:45 +00:00
jake%acutex.net
f07afdfc54 Fix for bug 95634 - Improvements to Param('voteremovedmail')
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-25 00:12:12 +00:00
myk%mozilla.org
5bb8c229f9 Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
regular expression meta-characters.  Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org,justdave@syndicomm.com
2001-08-19 18:26:21 +00:00
justdave%syndicomm.com
3ddb472e69 Fix for bug 92593: Changing a bugs product will no longer remove the votes from that bug unless the number of votes for a given user is beyond what is allowed per-bug on the new product. Only the per-bug vote count is checked. If the user is beyond the per-product vote limit for the new product, it is left alone, on the theory that it's better to preserve the votes on the bug. The user will be forced to reduce their votes to fit the product limit the next time they try to vote on something.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-16 02:46:15 +00:00
justdave%syndicomm.com
bd4c17a26e Re-fix for bug 95082: allow syncshadowdb to continue to make queries while Bugzilla is shut down.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-15 02:38:02 +00:00
jake%acutex.net
0b2b25c6a4 Fix for bug 95082 - Param('shutdownhtml') doesn't completely shut down bugzilla.
r= justdave@syndicomm.com
2001-08-13 19:11:35 +00:00
justdave%syndicomm.com
b5d9a45521 Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-11 01:51:05 +00:00
zach%zachlipton.com
1ecf08a901 fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo! 2001-08-11 01:18:24 +00:00
jake%acutex.net
ed69b4acf1 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
6b3b75de75 Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
babcf8d29e Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com
a8d4f31ac9 removing "Use Carp" and "sub die_with_dignity" that I was supposed to remove from the previous patch before checking it in. 2001-07-04 05:28:39 +00:00
justdave%syndicomm.com
a713e052fd Fix for bug 59349: Processmail now runs in taint (perl -T and $db->{Taint}=1) mode. Hooks also added to globals.pl to make converting other files in Bugzilla to run in Taint mode easier.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-04 04:41:27 +00:00
justdave%syndicomm.com
1597e271bd Fix for bug 87596: improper definition of $::components in globals.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-01 02:00:56 +00:00
justdave%syndicomm.com
6fe1144587 Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
r= tara
2001-06-10 17:15:56 +00:00
justdave%syndicomm.com
7ca1d33f14 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
336d245aa5 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
450514d585 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
justdave%syndicomm.com
bb1c25a4d0 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 2001-06-01 02:14:23 +00:00
jake%acutex.net
7d7408335b Bug 71552 - Remove oldemailtech from Bugzilla
r= justdave@syndicomm.com
2001-05-24 03:10:49 +00:00
justdave%syndicomm.com
c3637c7ac6 Fix for bug 80045: 500 Server Error in IE (but not Netscape or Mozilla) on errors looking up email addresses.
Patch by <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-10 18:16:51 +00:00
justdave%syndicomm.com
4f193d1f18 rolling version number to 2.13 for development 2001-04-27 19:36:20 +00:00
tara%tequilarista.org
b9aa9e56ce Tara is a bucket head. Floating version to 2.12 ship for tag and stripe 2001-04-25 15:45:27 +00:00
dave%intrec.com
d73de2a27a Re-re-fix for bug 71550. This will quite likely fix a number of bugs in other places. The DBID<->Name conversion routines in globals.pl were not pushing/popping the SQL state around their SQL calls, which could result in lost data if called from inside a loop which is handling other SQL data. 2001-03-19 21:03:52 +00:00
endico%mozilla.org
cee9d0e301 Checking in Jake's <jake@acutex.net> interim patches from bug 30694. Bugzilla was showing bug summaries to everyone, even if they didn't have permission to view the bug. Jake's quick solution is to not display the bug at all if it is in a group no matter who is viewing it. The correct solution would be display the summary if the viewer had the proper permissions. 2001-03-12 22:35:51 +00:00
gerv%gerv.net
6be85b4e34 Bug 66149 - nicer wording for the most common Bugzilla error message. 2001-03-07 23:59:15 +00:00
cyeh%bluemartini.com
a35064d1ee fix for 9302: Would be nice if attachment + number was a link too.
patch submitted by afranke@ags.uni-sb.de (Andreas Franke)
thanks for the patch. Now can reference attachments in other bugs as an HTML
link.
2001-02-20 21:49:59 +00:00
dave%intrec.com
aaa9c4bc2c Fix for bug 66149: better error message on connection failures. Patch by shie9022@msmailhub.oulan.ou.edu (Alan Shields) 2001-02-02 03:29:26 +00:00
dave%intrec.com
ae5aeaa50f Fix for bug 30694: adds title attributes to bug links with bug status and description. Patch by jake@acutex.net 2001-01-24 22:24:06 +00:00
dmose%mozilla.org
a1b8c789f4 changes from jake@acutex.net to make it possible to toggle the default value of newemailtech for new profiles, this is set by default to be turned on (the old default was off) ; r=dmose@mozilla.org. changes from me to make newemailtech the default in all new installations, and update the verbiage in various spots to make it clear that newemailtech is now considered the one true way and the old tech will be going away. r=endico@mozilla.org,cyeh@bluemartini.com 2000-12-22 23:01:30 +00:00
dmose%mozilla.org
2fbcabc6c8 add a stack to save the current global SQL state so that queries can be nested. used this mechanism to fix the 62618 regression. r=encido@mozilla.org 2000-12-12 03:47:40 +00:00
dmose%mozilla.org
fc71168a37 patch from Jake <jsteenhagen@novagate.com> to fix bug 59515; adds a title attribute containing status and short description to various bug links. In some browsers (most Mozilla builds, at least) this makes the status and short description available as a tooltip, so it is no longer necessary to click through to see it. r=dmose@mozilla.org 2000-12-07 03:04:32 +00:00
tara%tequilarista.org
eaf8a0ac91 correcting scope 2000-10-30 19:17:43 +00:00
cyeh%bluemartini.com
b11c2767ae front end fix for 31456: Editing a superuser clears their access flags
patch by jmrobin@tgix.com
2000-09-15 22:20:55 +00:00
cyeh%bluemartini.com
b2de760455 fix for 51520: Missing uses of Param('emailsuffix')
patch submitted by john.beranek@pace.co.uk (John Beranek)
2000-09-13 17:45:48 +00:00
cyeh%bluemartini.com
2e62d1d1d3 fix for 51299: RemoveVotes email should use the 'sendmailnow' Param. patch by dave@intrec.com 2000-09-12 16:29:38 +00:00
terry%mozilla.org
0a3195381c Don't lowercase the entries in legal_keywords. 2000-07-14 15:31:43 +00:00
endico%mozilla.org
e26bf6bc85 change '@::legal_resolution_no_dup' to '@::settable_resolutions'. This a list of resolutions which a bug may be changed to in the bug form and consists of all legal resolutions except 'MOVED' and 'DUPLICATE', since setting a bug to those resolutions requires a special process. 2000-07-14 03:20:17 +00:00
terry%mozilla.org
169d4e8eeb Keywords were already enforced to never differ only in capitalization. So, changed the code so that case no longer matters when typing in the name of a keyword. 2000-07-13 20:04:15 +00:00
cyeh%bluemartini.com
c73d27038c fix for DBI compatibility 2000-06-26 23:04:40 +00:00
cyeh%bluemartini.com
400300bbf9 remove dependency on Mysql, use DBI instead. Patch submitted by
sstock@iconnect-inc.com, reworked slightly by cyeh@bluemartini.com
to update it to the tip
2000-05-20 01:22:07 +00:00
cyeh%bluemartini.com
b7bbb79ff7 rolling version to 2.11 for development 2000-05-08 21:26:53 +00:00
cyeh%bluemartini.com
9f042326ec rolling version number to latest release of 2.10 2000-05-08 19:46:22 +00:00
cyeh%bluemartini.com
84999f1146 fix warnings on DBID_to_real_or_loginname. thanks to endico@mozilla.org 2000-05-08 18:23:55 +00:00
cyeh%bluemartini.com
b154eacd88 better implementation of realnames support. remove overhead of two sql
calls from bug_form.
2000-04-26 01:44:28 +00:00
cyeh%bluemartini.com
cecf444182 Add conditional support to display users real name in bug reports if user
entered in that information. Thanks to
Chris Baldwin <cbaldwin@redback.com>
for providing the patch.
2000-04-21 18:45:55 +00:00
dmose%mozilla.org
2b87d1539e removing ShowCCList from globals.pl, as it is no longer used 2000-03-29 01:34:00 +00:00
dmose%mozilla.org
ffaaebea3c allow users to watch the bugs of other users 2000-03-28 21:31:24 +00:00
terry%mozilla.org
1ddd301d14 Wasn't working right if usetargetmilestone was off. 2000-03-24 00:43:40 +00:00
terry%mozilla.org
c49fc801bc Patch by "Matt Masson" <matthew@zeroknowledge.com> -- allow definition
of different target milestones by product.
2000-03-21 16:47:06 +00:00
terry%mozilla.org
2a818047a9 Make it so that we can (hopefully!) rebuild the shadow db without
busting other people trying to use the system.
2000-03-20 18:48:59 +00:00
terry%mozilla.org
cf8092c7e4 Whoops; left out the "mailto:" part of a mailto link. 2000-03-10 18:26:23 +00:00
terry%mozilla.org
fe49673050 Italicize the "Additional Comments From" stuff, so that you can tell
the difference between new comments and people copying stuff in from
old comments.
2000-03-10 18:01:32 +00:00
terry%mozilla.org
7b49e812c3 Patch by Joe Robins <jmrobins@tgix.com> -- allow automatic definition
of a group per project, and automatically put new bugs against that
project into that group, thus allowing entire projects to be protected
against viewing by unauthorized users.  This is all optional,
controlled by new parameters.
2000-03-10 16:25:03 +00:00
terry%mozilla.org
edcc54480b Cut down on the number of syncshadowdb processes we fork off. 2000-02-18 21:38:23 +00:00
terry%mozilla.org
3ab2815fc6 Check that we have defined a shadow db before trying to use it. 2000-02-18 19:33:42 +00:00
terry%mozilla.org
f16e1a83d9 Fixed some functions in buglist.cgi that won't work if we're hooked up
to the shadow database.
2000-02-18 00:50:25 +00:00
terry%mozilla.org
890e5ce7c0 Wasn't always tweaking LOCK TABLES commands correctly when shadowing. And finally fixed it to actually generate useful SQL error messages. 2000-02-18 00:43:56 +00:00