32202 Commits

Author SHA1 Message Date
Greg Tatum
7042c8f1c3 Bug 1520526 - Add categories to all profiler markers; r=mstange
This commit adds categories to all markers. This way the profiler's
marker categories and frame label categories agree. There are a few
duplicate category properties on some of the marker payloads, but
this could be cleaned up in a follow-up if needed.

Differential Revision: https://phabricator.services.mozilla.com/D16864

--HG--
extra : moz-landing-system : lando
2019-01-18 15:40:15 +00:00
James Willcox
92d41d761f Bug 1515689 - Fix initialization/destruction race in UiCompositorControllerParent r=botond
It looks like we can do initialization and destruction from the UI
thread before the bits that run on the Compositor thread have run. Avoid
this by synchronously waiting on the Compositor.

Differential Revision: https://phabricator.services.mozilla.com/D16596

--HG--
extra : moz-landing-system : lando
2019-01-17 19:37:32 +00:00
Margareta Eliza Balazs
ec14417cc3 Merge inbound to mozilla-central. a=merge 2019-01-18 11:40:07 +02:00
Bobby Holley
63b916b15b Bug 1520678 - Rename the *Resource* types to be more clearly about interning. r=kamidphish
Depends on D16781

Differential Revision: https://phabricator.services.mozilla.com/D16910
2019-01-17 22:21:50 -08:00
Bobby Holley
0d9b3416c9 Bug 1520678 - Simplify naming of interner and data_store instances. r=kamidphish
Depends on D16780

Differential Revision: https://phabricator.services.mozilla.com/D16781
2019-01-17 22:21:48 -08:00
Bobby Holley
95f00ec60f Bug 1520678 - Use macros to reduce boilerplate. r=kamidphish
Depends on D16779

Differential Revision: https://phabricator.services.mozilla.com/D16780
2019-01-17 22:21:45 -08:00
Bobby Holley
8120983fd7 Bug 1520678 - Declare intern-related types in a structured way. r=kamidphish
Differential Revision: https://phabricator.services.mozilla.com/D16779
2019-01-17 22:21:41 -08:00
Bogdan Tara
b93f9fb7c3 Backed out 4 changesets (bug 1520678) for build bustages complaining no field resources CLOSED TREE
Backed out changeset ad7c9c863c2e (bug 1520678)
Backed out changeset 64717bf7f849 (bug 1520678)
Backed out changeset 5fa2f414676e (bug 1520678)
Backed out changeset 1d2ae392021c (bug 1520678)
2019-01-18 04:05:26 +02:00
Bobby Holley
bad6a4b15e Bug 1520678 - Rename the *Resource* types to be more clearly about interning. r=kamidphish
Depends on D16781

Differential Revision: https://phabricator.services.mozilla.com/D16910

--HG--
extra : moz-landing-system : lando
2019-01-18 00:40:44 +00:00
Bobby Holley
1cc37c6e8c Bug 1520678 - Simplify naming of interner and data_store instances. r=kamidphish
Depends on D16780

Differential Revision: https://phabricator.services.mozilla.com/D16781

--HG--
extra : moz-landing-system : lando
2019-01-18 00:45:13 +00:00
Bobby Holley
f5b664ed7e Bug 1520678 - Use macros to reduce boilerplate. r=kamidphish
Depends on D16779

Differential Revision: https://phabricator.services.mozilla.com/D16780

--HG--
extra : moz-landing-system : lando
2019-01-18 00:45:27 +00:00
Bobby Holley
9dd944fbdf Bug 1520678 - Declare intern-related types in a structured way. r=kamidphish
Differential Revision: https://phabricator.services.mozilla.com/D16779

--HG--
extra : moz-landing-system : lando
2019-01-18 00:39:24 +00:00
Jeff Muizelaar
c87a6c66d7 Bug 1520651. Use a DataMutex around mWindowInfos instead of a standalone Mutex. r=mattwoodrow
This ensures that access is locked.

Differential Revision: https://phabricator.services.mozilla.com/D16760

--HG--
extra : moz-landing-system : lando
2019-01-16 23:25:35 +00:00
Emilio Cobos Álvarez
aa64e87398 Bug 1520851 - Fix wrench / reftests / examples.
This fixes stuff for both refence frame changes.

Differential Revision: https://phabricator.services.mozilla.com/D16883
2019-01-17 21:13:24 +01:00
Emilio Cobos Álvarez
2c1aaa2304 Bug 1520851 - Make a reference frame's transform not optional. r=kvark
No good reason for it to be an option.

Differential Revision: https://phabricator.services.mozilla.com/D16876
2019-01-17 21:13:15 +01:00
Emilio Cobos Álvarez
4a8ff157a5 Bug 1520664 - Cleanup ReferenceFrame so that each of them has a single matrix. r=kvark
The only thing using both was perspective, but that's not really needed with the current setup.

This more closely matches Gecko, too.

Differential Revision: https://phabricator.services.mozilla.com/D16764
2019-01-17 21:13:07 +01:00
Glenn Watson
42680d84e4 Bug 1520687 - Include root content clip rect in picture caching world bounds. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D16782

--HG--
extra : moz-landing-system : lando
2019-01-17 19:40:06 +00:00
Brindusan Cristian
ac9bb930c9 Backed out changeset bbc57e229df6 (bug 1520664) for webrender bustages. CLOSED TREE 2019-01-17 19:20:00 +02:00
Emilio Cobos Álvarez
3fe4fef309 Bug 1520664 - Bug 1498639 - Cleanup ReferenceFrame so that each of them has a single matrix. r=kvark
The only thing using both was perspective, but that's not really needed with the current setup.

This more closely matches Gecko, too.

Differential Revision: https://phabricator.services.mozilla.com/D16764

--HG--
extra : moz-landing-system : lando
2019-01-17 16:08:35 +00:00
Dzmitry Malyshau
1ab11075de Bug 1520301 - Fix scroll frame default positioning r=jrmuizel
When scroll frames are created, and no explicit parent is provided,
the old code used to take the ClipID from the c/s stack. The stack
has been removed on WR side, and this parent assignment got lost.

This change takes the SpatialID from the top of the stack on Gecko
side to replicate the old behavior.

Differential Revision: https://phabricator.services.mozilla.com/D16732

--HG--
extra : moz-landing-system : lando
2019-01-17 16:43:08 +00:00
Cosmin Sabou
d28e15a531 Backed out changeset d4b7dbc0379f (bug 1520301) for reftest failures on gfx/tests/reftest/1519754.html. 2019-01-17 02:40:32 +02:00
Bobby Holley
e12967b520 Bug 1520275 - Add primitive debug display. r=gw
Differential Revision: https://phabricator.services.mozilla.com/D16593
2019-01-16 15:25:25 -08:00
Brad Werth
628e787dd1 Bug 1504659 Part 5: Update Android reftest expectations. r=botond
The tests for Bug 1133905 all compare the visibility of scrollbars with
differently-sized css viewports. This patch has some affect on the
viewport sizing that I don't understand, and it causes some of the tests
to start passing and some to start failing.

The test for Bug 1242172 has elements sized to height 100% and checking
for the presence or absence of scrollbars. In this case the patch appears
to increase the css viewport height and decrease the width -- again for
reasons I don't understand -- and this affects the scrollbar sizes.

Differential Revision: https://phabricator.services.mozilla.com/D16078

--HG--
extra : moz-landing-system : lando
2019-01-16 21:58:27 +00:00
Dzmitry Malyshau
3e91ba682b Bug 1520645 - WR improved vector allocation recycler r=nical
The old vector recycler had a few problems:
  1. shrinking to fit would be inevitably followed by re-allocation, since it's unlikely that the consequent sizes are below the immediately followed frames
  2. shrinking before clearing means that the existing contents are copied over, which is a waste

The new code has more complicated logic for recycling, aimed at reducing heap allocations. It's also collecting the statistics.

Differential Revision: https://phabricator.services.mozilla.com/D16496

--HG--
extra : moz-landing-system : lando
2019-01-16 22:24:01 +00:00
Dzmitry Malyshau
ce39249b85 Bug 1520301 - Fix scroll frame default positioning r=jrmuizel
When scroll frames are created, and no explicit parent is provided,
the old code used to take the ClipID from the c/s stack. The stack
has been removed on WR side, and this parent assignment got lost.

This change takes the SpatialID from the top of the stack on Gecko
side to replicate the old behavior.

Differential Revision: https://phabricator.services.mozilla.com/D16732

--HG--
extra : moz-landing-system : lando
2019-01-16 21:00:05 +00:00
Cosmin Sabou
f621d8b160 Backed out 5 changesets (bug 1504659) for android reftest failures. CLOSED TREE
Backed out changeset 793e842be7f6 (bug 1504659)
Backed out changeset 229ed2090371 (bug 1504659)
Backed out changeset 0818e2b1f2c5 (bug 1504659)
Backed out changeset bd806b413342 (bug 1504659)
Backed out changeset 3e12097e2b60 (bug 1504659)
2019-01-16 21:23:39 +02:00
Cosmin Sabou
c5393102ee Backed out changeset 0b1911ea8b8b (bug 1520275) for qr wrench bustages. CLOSED TREE 2019-01-16 21:22:29 +02:00
Bobby Holley
7635435179 Bug 1520275 - Add primitive debug display. r=gw
Differential Revision: https://phabricator.services.mozilla.com/D16593
2019-01-16 10:55:11 -08:00
Brad Werth
5f076f7b17 Bug 1504659 Part 5: Update Android reftest expectations. r=botond
The tests for Bug 1133905 all compare the visibility of scrollbars with
differently-sized css viewports. This patch has some affect on the
viewport sizing that I don't understand, and it causes some of the tests
to start passing and some to start failing.

The test for Bug 1242172 has elements sized to height 100% and checking
for the presence or absence of scrollbars. In this case the patch appears
to increase the css viewport height and decrease the width -- again for
reasons I don't understand -- and this affects the scrollbar sizes.

Differential Revision: https://phabricator.services.mozilla.com/D16078

--HG--
extra : moz-landing-system : lando
2019-01-16 17:14:33 +00:00
Razvan Maries
f4a9b74ae2 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-01-16 19:06:30 +02:00
Razvan Maries
4c67bec411 Merge mozilla-inbound to mozilla-central a=merge 2019-01-16 19:00:15 +02:00
Olli Pettay
02cfa7910b Bug 1520294, make FilterPrimitiveDescription usage a tad less malloc heavy, r=mstange
--HG--
extra : rebase_source : 2bd3a10856eab5048f67235209b3cd977554e417
2019-01-16 12:27:04 +02:00
Sylvestre Ledru
47a5dd1fb8 Bug 1519636 - Reformat everything to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D16388

--HG--
extra : moz-landing-system : lando
2019-01-16 08:50:07 +00:00
Dzmitry Malyshau
90036e2a54 Bug 1519441 - WR fix scroll frame rectangle r=gw
This is a follow-up fix to https://github.com/servo/webrender/pull/3251
Accidentally, the reference frame relative offset was applied twice.

Differential Revision: https://phabricator.services.mozilla.com/D16658

--HG--
extra : moz-landing-system : lando
2019-01-16 14:49:59 +00:00
Daniel Varga
c4bdfad8bd Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-01-16 06:56:15 +02:00
Daniel Varga
55006aaaec Merge mozilla-inbound to mozilla-central. a=merge 2019-01-16 06:49:11 +02:00
Bobby Holley
e2dbdaa253 Bug 1506449 - Arc the glyph arrays for text runs. r=gw
Differential Revision: https://phabricator.services.mozilla.com/D16630
2019-01-15 20:38:18 -08:00
Bobby Holley
126679ec70 Bug 1506449 - Use an Option<T> instead of Item<T> in DataStore. r=gw
This does two things:
* Ensures that the T gets dropped when the item is removal, which is
  important for the TextRunKey case where it holds heap memory.
* Eliminates the epoch handling while still ensuring that we panic on
  stale lookups.

We also remove the Item usage for local_data, but don't bother with the
Option in that case.

Differential Revision: https://phabricator.services.mozilla.com/D16629
2019-01-15 20:38:18 -08:00
Glenn Watson
cd78518c1a Bug 1520384 - Fix an invalidation bug and improve display list correlation. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D16648

--HG--
extra : moz-landing-system : lando
2019-01-16 04:23:29 +00:00
Jeff Muizelaar
83096ed533 Bug 1520330. Split out NoVsync into two different scenarios. r=mattwoodrow
Currently there are two conditions where CONTENT_FRAME_TIME_REASON can
be NoVsync. Since, were getting an appreciable amount of these with
WebRender it makes sense to split out the telemetry so that we can
confirm which scenario we're hitting.

Differential Revision: https://phabricator.services.mozilla.com/D16611

--HG--
extra : moz-landing-system : lando
2019-01-15 22:33:25 +00:00
Dorel Luca
e1198e6651 Merge mozilla-central to autoland. CLOSED TREE
--HG--
extra : rebase_source : e6bda7efe552ef8e5c89c0395b18a73838f3f700
2019-01-16 00:22:00 +02:00
Jeff Muizelaar
079ff97c76 Bug 1519499. Only use a nsRegion when needing during ComputeGeometryChange clippedBounds. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D16597

--HG--
extra : moz-landing-system : lando
2019-01-15 21:15:32 +00:00
Lee Salzman
70ae3e33d1 Bug 1512010 - backing out local raster space text snapping change. r=jrmuizel
--HG--
extra : source : a3989f48b153d314c83478c0a157f66fe69f8eca
2019-01-15 13:32:39 -05:00
Jeff Muizelaar
a1d10d2d1f Bug 1520188. Use uppercase for func name. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D16567

--HG--
extra : moz-landing-system : lando
2019-01-15 17:40:34 +00:00
Matt Woodrow
09c22c28a0 Bug 1520319 - Store an array of pending transactions in LayerTransactionParent to avoid overwriting data when we get multiple. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D16603

--HG--
extra : moz-landing-system : lando
2019-01-15 23:55:37 +00:00
Dzmitry Malyshau
75e5c0c1d0 Bug 1505934 - WR: Don't establish a raster root in pictures with sufficiently large local bounds (take 2) r=jrmuizel
re-open of D16335, which got backed out due to Wrench test failing.
The test was failing because of different AA on a plane-splitting case, which isn't guaranteed anyway.
This revision updates the test.

Differential Revision: https://phabricator.services.mozilla.com/D16560

--HG--
extra : moz-landing-system : lando
2019-01-15 15:23:28 +00:00
Henri Sivonen
0a0cdafd2f Bug 1519793 - Avoid writing past the logical length of a string in OGLShaderProgram.cpp. r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D16440

--HG--
extra : moz-landing-system : lando
2019-01-15 00:58:55 +00:00
Botond Ballo
869afb0d73 Bug 1509575 - Restore the visual viewport offset from the main thread during a first paint. r=kats
During a "first paint" transaction, compositor-side state such as APZ's copy
of the visual viewport offset is overwritten. However, the scroll frame may
persist on the main thread, and in such a case we want to restore the visual
viewport offset stored in the scroll frame. This comes into play during e.g.
navigation back to a page.

Differential Revision: https://phabricator.services.mozilla.com/D16238

--HG--
extra : moz-landing-system : lando
2019-01-15 01:30:53 +00:00
Botond Ballo
e99815f1f0 Bug 1509575 - Extend the internal visual scroll API to allow specifying "restore" vs. regular priority. r=kats
The distinction is not exposed at the JS level which currently always uses
"restore", but it could be if necessary.

Differential Revision: https://phabricator.services.mozilla.com/D16346

--HG--
extra : moz-landing-system : lando
2019-01-15 01:30:43 +00:00
Botond Ballo
d5f06efae5 Bug 1509575 - Expose the isFirstPaint flag on LayerManager. r=kats
So that it's easily available during painting.

The flag is set based on nsIPresShell::mIsFirstPaint, but the pres shell
flag is cleared at the beginning of the paint, so we can't query it from
the pres shell during the paint.

Differential Revision: https://phabricator.services.mozilla.com/D16237

--HG--
extra : moz-landing-system : lando
2019-01-15 01:29:38 +00:00