Commit Graph

1100 Commits

Author SHA1 Message Date
Andrea Marchesini
fcc5266a9e Bug 1635193 - StoragePrincipalHelper::GetOriginAttributes instead of NS_GetOriginAttributes, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D73727
2020-05-05 20:56:04 +00:00
Andrea Marchesini
20e7f42224 Bug 1632853 - Remove the support for cookie.txt import, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D72392
2020-04-28 15:40:37 +00:00
Alex Catarineu
0b7a953f77 Bug 1633015 - Allow 'secure' cookies when set by .onion site r=baku
Allow secure cookies when set by a .onion site if
the pref dom.securecontext.whitelist_onions is set to true.
Most of the needed parts were introduced in bug 1618113, due
to the fact that the `IsPotentiallyTrustworthyOrigin()` check
also takes into account onion hostnames.

This adds one missing check, allowing a trustworthy origin
(e.g. onion site) to replace a secure cookie by an insecure
one, as well as adding some tests for the .onion case.

Differential Revision: https://phabricator.services.mozilla.com/D72486
2020-04-27 09:20:50 +00:00
MahakBansal
4650254df8 Bug 1622620 - Replace URIParams with nsIURI in PCookieService.ipdl.r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D67268
2020-04-25 19:10:00 +00:00
Andrea Marchesini
37a13f7df5 Bug 1632188 - Cleanup Cookie CTOR, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71972
2020-04-22 21:01:37 +00:00
Andrea Marchesini
c4a611be40 Bug 1631565 - setCookieStringFromHttp requires the nsIChannel argument, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71641
2020-04-21 10:41:21 +00:00
Andrea Marchesini
e80177ec06 Bug 1631565 - getCookieStringFromHttp requires the nsIChannel argument, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71642
2020-04-21 10:41:40 +00:00
Andrea Marchesini
1ba927f859 Bug 1631444 - Remove CookiePermission.cpp/h, r=dimi
Depends on D71594

Differential Revision: https://phabricator.services.mozilla.com/D71595
2020-04-21 10:41:40 +00:00
Andrea Marchesini
9259ee6959 Bug 1631444 - Cookies should follow the CookieJarSettings, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71594
2020-04-21 08:53:33 +00:00
Andrea Marchesini
ebc905d3f2 Bug 1631523 - Remove unused params in nsICookieService methods - setCookieStringFromHttp without first URI, r=dimi
Depends on D71611

Differential Revision: https://phabricator.services.mozilla.com/D71612
2020-04-20 18:58:28 +00:00
Andrea Marchesini
4eec356d45 Bug 1631523 - Remove unused params in nsICookieService methods - getCookieStringFromHttp without first URI, r=dimi
Depends on D71609

Differential Revision: https://phabricator.services.mozilla.com/D71611
2020-04-20 18:57:04 +00:00
Andrea Marchesini
66bb8c57df Bug 1631523 - Remove unused params in nsICookieService methods - setCookieStringFromHttp without serverTime, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71609
2020-04-20 18:56:25 +00:00
Andrea Marchesini
637fa9bcf5 Bug 1630865 - Implement nsICookieService::getCookieStringForPrincipal() - part 4 - remove nsICookieService::getCookieString(), r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D71278
2020-04-20 10:03:43 +00:00
Andrea Marchesini
4172d4a0f0 Bug 1630865 - Implement nsICookieService::getCookieStringForPrincipal() - part 3 - stop using nsICookieService::getCookieString(), r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D71277
2020-04-20 10:03:13 +00:00
Andrea Marchesini
d6580b1a3a Bug 1630865 - Implement nsICookieService::getCookieStringForPrincipal() - part 2 - implementation, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D71276
2020-04-20 10:02:38 +00:00
Andrea Marchesini
24fe2594ba Bug 1627653 - document.cookie should expose all the cookies, ignoring sameSite limitations - part 2 - extra cleanup in CookieServiceChild, r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D70845
2020-04-20 10:00:25 +00:00
Andrea Marchesini
8c8d7f8b4d Bug 1627653 - document.cookie should expose all the cookies, ignoring sameSite limitations - part 1 - implementation, r=ckerschb,mgoodwin,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D70844
2020-04-20 11:45:00 +00:00
Andrea Marchesini
1611112ee4 Bug 1629112 - Group console warnings about invalid sameSite cookie attributes, r=nchevobbe
Invalid sameSite cookie attributes generate console warning messages in the
wrong 'generic' category. In this patch, we put them under the 'sameSite'
category. We also rename the 'generic' category to 'oversize' because all the
remaining messages are about invalid cookie sizes.

Differential Revision: https://phabricator.services.mozilla.com/D70795
2020-04-17 07:56:45 +00:00
Kris Maglione
2b97c80ec2 Bug 1582318: Remove shutting-down processes from pool immediately. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69441

--HG--
extra : moz-landing-system : lando
2020-04-15 22:44:36 +00:00
Andrea Marchesini
cc9ceea0dc Bug 1620334 - Update sameSite MDN URL, r=fscholz
Differential Revision: https://phabricator.services.mozilla.com/D70850

--HG--
extra : moz-landing-system : lando
2020-04-14 13:27:11 +00:00
Razvan Maries
7b34a6593b Backed out changeset 001575dc6d78 (bug 1582318) for breaking bug 1628661. 2020-04-13 00:05:27 +03:00
Andrea Marchesini
9f0376cefe Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:30 +00:00
Andrea Marchesini
13481ea877 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-11 13:42:12 +00:00
Andrea Marchesini
d0bfec4f79 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-10 08:36:37 +00:00
Andrea Marchesini
9867dce537 Bug 1610373 - Introduce nsICookieManager::getCookieSince() - test, r=ewright a=reland CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D70056

--HG--
extra : source : 24b87cfe04ad9134bdc1f1ffc8b90e8f291b699d
extra : histedit_source : 47e8a93deb67db2f3e8c91f173f1a33114743d4a
2020-04-08 15:59:19 +00:00
Andrea Marchesini
c1ee01fb9d Bug 1610373 - Introduce nsICookieManager::getCookieSince(), r=ewright a=reland CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D70055

--HG--
extra : source : a984dfddd43d4156745481aef60493b45280c3cc
extra : histedit_source : d63d3d21a4c439524d56148c1d321176360f2585
2020-04-08 15:59:29 +00:00
Csoregi Natalia
3ebf837989 Backed out 2 changesets (bug 1610373) for causing bug 1629090. CLOSED TREE
Backed out changeset 24b87cfe04ad (bug 1610373)
Backed out changeset a984dfddd43d (bug 1610373)

--HG--
extra : rebase_source : 4118495b76de18b6a25e6b2e3902b16565921c5b
2020-04-10 21:21:50 +03:00
Razvan Maries
b74e338c98 Backed out 6 changesets (bug 1363541) for perma failures. CLOSED TREE
Backed out changeset a775f6e9eb41 (bug 1363541)
Backed out changeset 9212bfd89eca (bug 1363541)
Backed out changeset bf41b0c139f6 (bug 1363541)
Backed out changeset aa7c6668b249 (bug 1363541)
Backed out changeset 9f413a8a47bb (bug 1363541)
Backed out changeset 827a9a2866bd (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 11:31:20 +03:00
Andrea Marchesini
4adbfbb4d0 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-09 22:08:03 +00:00
Andrea Marchesini
b523b552a4 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Andrea Marchesini
2ab42cd711 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 22:08:02 +00:00
Coroiu Cristina
d37de5ed78 Backed out 6 changesets (bug 1363541) for browser-chrome failures at browser/base/content/test/performance/browser_startup_mainthreadio.js on a CLOSED TREE
Backed out changeset 947073be919f (bug 1363541)
Backed out changeset 1f397b686c11 (bug 1363541)
Backed out changeset d2ba944a47a3 (bug 1363541)
Backed out changeset 80d4d1f0c921 (bug 1363541)
Backed out changeset 9d6b9052f413 (bug 1363541)
Backed out changeset aeaa10789071 (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
2020-04-10 01:00:15 +03:00
Andrea Marchesini
3e892fdba4 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
2020-04-09 13:27:53 +00:00
Andrea Marchesini
8764c55c53 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
2020-04-09 13:27:35 +00:00
Andrea Marchesini
23b424cd70 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
2020-04-09 14:07:34 +00:00
Andrea Marchesini
b65f8ca3b9 Bug 1610373 - Introduce nsICookieManager::getCookieSince() - test, r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D70056

--HG--
extra : moz-landing-system : lando
2020-04-08 15:59:19 +00:00
Andrea Marchesini
4937793ee0 Bug 1610373 - Introduce nsICookieManager::getCookieSince(), r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D70055

--HG--
extra : moz-landing-system : lando
2020-04-08 15:59:29 +00:00
Kris Maglione
9e1706a554 Bug 1582318: Remove shutting-down processes from pool immediately. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69441

--HG--
extra : moz-landing-system : lando
2020-04-08 21:13:18 +00:00
Andrea Marchesini
34ef1537f3 Bug 1628298 - Nullify both Cookie storages (private and persistent) before calling Close(), r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D70192

--HG--
extra : moz-landing-system : lando
2020-04-08 14:25:34 +00:00
MahakBansal
ee093cd087 Bug 1582666 - Enable more ESLint rules for netwerk/. r=Standard8,valentin
Differential Revision: https://phabricator.services.mozilla.com/D69257

--HG--
extra : moz-landing-system : lando
2020-04-07 16:00:03 +00:00
Andreas Farre
25ca8d7890 Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.

DocGroups have also been moved to BrowsingContextGroup.

Depends on D67636

Differential Revision: https://phabricator.services.mozilla.com/D65936

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:47 +00:00
Andreas Farre
36eaf82163 Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
Depends on D67631

Differential Revision: https://phabricator.services.mozilla.com/D67632

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:33 +00:00
Andrea Marchesini
4391185b5c Bug 1562868 - Limit the amount of data shared between processes when document.cookie is set, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D68179

--HG--
extra : moz-landing-system : lando
2020-04-06 14:03:59 +00:00
Andrea Marchesini
bd0c1b0080 Bug 1624146 - Cookie code refactoring - part 16 - Modernize c++ code, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D68958

--HG--
extra : moz-landing-system : lando
2020-04-06 12:32:45 +00:00
Andrea Marchesini
3741528e0a Bug 1624146 - Cookie code refactoring - part 15 - Remove mozIStorage* from CookieStorage, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67777

--HG--
extra : moz-landing-system : lando
2020-04-06 12:33:56 +00:00
Andrea Marchesini
78a4aecdfd Bug 1624146 - Cookie code refactoring - part 14 - Fix the namespaces, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67763

--HG--
extra : moz-landing-system : lando
2020-04-06 12:33:45 +00:00
Andrea Marchesini
0f16f86d52 Bug 1624146 - Cookie code refactoring - part 13 - More functions in CookieCommons, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67762

--HG--
extra : moz-landing-system : lando
2020-04-06 12:27:28 +00:00
Andrea Marchesini
f6c7a629a9 Bug 1624146 - Cookie code refactoring - part 12 - Header cleanup, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67761

--HG--
extra : moz-landing-system : lando
2020-04-06 12:27:05 +00:00
Andrea Marchesini
38395b3e34 Bug 1624146 - Cookie code refactoring - part 11 - Separate files for CookiePrivateStorage and CookiePersistentStorage, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67760

--HG--
extra : moz-landing-system : lando
2020-04-06 12:26:42 +00:00
Andrea Marchesini
9bea58365a Bug 1624146 - Cookie code refactoring - part 10 - CookieService under mozilla::net, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67759

--HG--
rename : netwerk/cookie/nsCookieService.cpp => netwerk/cookie/CookieService.cpp
rename : netwerk/cookie/nsCookieService.h => netwerk/cookie/CookieService.h
extra : moz-landing-system : lando
2020-04-06 12:26:14 +00:00