Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
706,309 Commits 615 Branches 98 Tags 5.9 GiB
709d51cfa3
Commit Graph

1100 Commits

Author SHA1 Message Date
Andrea Marchesini
97c9328d8f Bug 1624146 - Cookie code refactoring - part 9 - DB handling in CookieDefaultStorage, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67758

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:25:44 +00:00
Andrea Marchesini
0fa65a1483 Bug 1624146 - Cookie code refactoring - part 8 - CookieStorage observers pref changes, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67757

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:25:36 +00:00
Andrea Marchesini
e444769cb0 Bug 1624146 - Cookie code refactoring - part 7 - CookiePrivateStorage and CookieDefaultStorage, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67756

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:25:34 +00:00
Andrea Marchesini
299696f535 Bug 1624146 - Cookie code refactoring - part 6 - CookieStorage, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67755

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:24:15 +00:00
Andrea Marchesini
eab1416209 Bug 1624146 - Cookie code refactoring - part 5 - Separate files for CookieStorage, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67754

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:23:48 +00:00
Andrea Marchesini
6107852338 Bug 1624146 - Cookie code refactoring - part 4 - DBState renamed CookieStorage, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67753

--HG--
extra : moz-landing-system : lando
 2020-04-06 12:23:25 +00:00
Andrea Marchesini
42df52a06f Bug 1624146 - Cookie code refactoring - part 3 - CookiePermission, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67752

--HG--
rename : netwerk/cookie/nsCookiePermission.cpp => netwerk/cookie/CookiePermission.cpp
rename : netwerk/cookie/nsCookiePermission.h => netwerk/cookie/CookiePermission.h
extra : moz-landing-system : lando
 2020-04-06 12:22:57 +00:00
Andrea Marchesini
aeba7dc82c Bug 1624146 - Cookie code refactoring - part 2 - CookieKey, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67751

--HG--
rename : netwerk/cookie/nsCookieKey.h => netwerk/cookie/CookieKey.h
extra : moz-landing-system : lando
 2020-04-06 12:22:29 +00:00
Andrea Marchesini
edb320168f Bug 1624146 - Cookie code refactoring - part 1 - Cookie, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67749

--HG--
rename : netwerk/cookie/nsCookie.cpp => netwerk/cookie/Cookie.cpp
rename : netwerk/cookie/nsCookie.h => netwerk/cookie/Cookie.h
extra : moz-landing-system : lando
 2020-04-06 12:22:01 +00:00
Narcis Beleuzu
b7325105ab Backed out changeset a0732358fb87 (bug 1582318) for assertion failures on ContentParent.cpp . CLOSED TREE 2020-04-04 04:15:00 +03:00
Kris Maglione
fca69c36bb Bug 1582318: Remove shutting-down processes from pool immediately. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D69441

--HG--
extra : moz-landing-system : lando
 2020-04-03 20:32:33 +00:00
Andrea Marchesini
0311b76022 Bug 1625568 - Add compatibility heuristics to third-party cookie blocking - part 2 - enable storageAccess API and heuristics, r=dimi,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69047

--HG--
extra : moz-landing-system : lando
 2020-04-02 15:30:57 +00:00
MahakBansal
a00e0bcebe Bug 1624286 - Notification for rejected cookies.r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D68444

--HG--
extra : moz-landing-system : lando
 2020-03-30 11:45:39 +00:00
Dimi Lee
0a5f211268 Bug 1612350 - Use CookieJarSetting in WindowContext when adding permission. r=timhuang,baku 
Differential Revision: https://phabricator.services.mozilla.com/D66375

--HG--
extra : moz-landing-system : lando
 2020-03-25 22:22:35 +00:00
Andrea Marchesini
898e5a24a7 Bug 1293067 - Implement a cookie limit warning - tests, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D67330

--HG--
extra : moz-landing-system : lando
 2020-03-25 13:00:20 +00:00
Tim Huang
1375fac6ac Bug 1612378 - Part 1: Add a boolean IsOnContentBlockingAllowList in the CookieJarSettings. r=dimi,baku 
In this patch, we add a IsOnContentBlockingAllowList boolean in the
CookieJarSettings. This boolean would be used to indicate whether the
top-level site in in the content blocking allow list.

Differential Revision: https://phabricator.services.mozilla.com/D66208

--HG--
extra : moz-landing-system : lando
 2020-03-25 13:20:21 +00:00
Andrea Marchesini
2f43df007a Bug 1293067 - Implement a cookie limit warning, r=mayhemer,flod 
Differential Revision: https://phabricator.services.mozilla.com/D67329

--HG--
extra : moz-landing-system : lando
 2020-03-25 11:30:45 +00:00
Cosmin Sabou
22c2e8d92c Backed out 2 changesets (bug 1293067) for failures on browser_oversize.js. 
CLOSED TREE

Backed out changeset 5df9d39b0b98 (bug 1293067)
Backed out changeset 8ed41aa3ed4f (bug 1293067)
 2020-03-25 13:24:19 +02:00
Andrea Marchesini
6a03963e65 Bug 1293067 - Implement a cookie limit warning - tests, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D67330

--HG--
extra : moz-landing-system : lando
 2020-03-25 10:39:03 +00:00
Andrea Marchesini
1c645731e5 Bug 1293067 - Implement a cookie limit warning, r=mayhemer,flod 
Differential Revision: https://phabricator.services.mozilla.com/D67329

--HG--
extra : moz-landing-system : lando
 2020-03-25 10:38:45 +00:00
Andrea Marchesini
400b195fb8 Bug 1437057 - Expose the origin of a cookie to JS - tests, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D67590

--HG--
extra : moz-landing-system : lando
 2020-03-24 17:52:41 +00:00
Andrea Marchesini
d7badaf4fb Bug 1623593 - Get rid of NECKO_COOKIES compilation flag, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D67451

--HG--
extra : moz-landing-system : lando
 2020-03-24 16:30:03 +00:00
Andrea Marchesini
23a1e408dc Bug 1623313 - disable cookie sameSite=laxByDefault for a list of hosts by pref, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D67305

--HG--
extra : moz-landing-system : lando
 2020-03-24 16:08:36 +00:00
Andrea Marchesini
4fa365563a Bug 1622306 - Group cookie console info/warning logs, r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D66890

--HG--
extra : moz-landing-system : lando
 2020-03-24 09:41:07 +00:00
Andrea Marchesini
afcfb5927f Bug 1623867 - Get rid of expired cookies telemetry IDs, r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D67610

--HG--
extra : moz-landing-system : lando
 2020-03-23 17:39:31 +00:00
Andrea Marchesini
53edc6acc8 Bug 1620179 - cookie sameSite=lax by default must have a 2 minute tolerance for unsafe HTTP methods, r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D66781

--HG--
extra : moz-landing-system : lando
 2020-03-20 07:51:26 +00:00
Ehsan Akhgari
5200d034f5 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65821

--HG--
rename : toolkit/components/antitracking/AntiTrackingCommon.cpp => toolkit/components/antitracking/ContentBlocking.cpp
rename : toolkit/components/antitracking/AntiTrackingCommon.h => toolkit/components/antitracking/ContentBlocking.h
extra : moz-landing-system : lando
 2020-03-09 23:36:39 +00:00
Ehsan Akhgari
8e46ea55d2 Bug 1620322 - Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65743

--HG--
extra : moz-landing-system : lando
 2020-03-09 23:36:37 +00:00
Narcis Beleuzu
0186cbe565 Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE 
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
 2020-03-09 22:18:36 +02:00
Ehsan Akhgari
5045d313c2 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65821

--HG--
rename : toolkit/components/antitracking/AntiTrackingCommon.cpp => toolkit/components/antitracking/ContentBlocking.cpp
rename : toolkit/components/antitracking/AntiTrackingCommon.h => toolkit/components/antitracking/ContentBlocking.h
extra : moz-landing-system : lando
 2020-03-09 18:12:40 +00:00
Ehsan Akhgari
78677f7812 Bug 1620322 - Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65743

--HG--
extra : moz-landing-system : lando
 2020-03-09 18:12:26 +00:00
Noemi Erli
a48fac9e3b Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE 
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
 2020-03-09 19:19:41 +02:00
Ehsan Akhgari
1195c302a4 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65821

--HG--
rename : toolkit/components/antitracking/AntiTrackingCommon.cpp => toolkit/components/antitracking/ContentBlocking.cpp
rename : toolkit/components/antitracking/AntiTrackingCommon.h => toolkit/components/antitracking/ContentBlocking.h
extra : moz-landing-system : lando
 2020-03-09 10:23:07 +00:00
Ehsan Akhgari
4bc71d0112 Bug 1620322 - Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65743

--HG--
extra : moz-landing-system : lando
 2020-03-09 10:16:54 +00:00
Andrea Marchesini
750d1a507f Bug 1454781 - SameSite policy logged in the console - part 5 - Console messages for beta, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65579

--HG--
extra : moz-landing-system : lando
 2020-03-09 09:42:45 +00:00
Andrea Marchesini
f710f5d5ef Bug 1454781 - SameSite policy logged in the console - part 4 - tests, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65313

--HG--
extra : moz-landing-system : lando
 2020-03-09 09:42:45 +00:00
Andrea Marchesini
371649e01e Bug 1454781 - SameSite policy logged in the console - part 3 - log invalid sameSite values, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65315

--HG--
extra : moz-landing-system : lando
 2020-03-05 03:41:50 +00:00
Andrea Marchesini
3d32ec99d9 Bug 1454781 - SameSite policy logged in the console - part 2 - Console messages, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65242

--HG--
extra : moz-landing-system : lando
 2020-03-06 17:21:51 +00:00
Andrea Marchesini
4d8ab701dd Bug 1454781 - SameSite policy logged in the console - part 1 - more data shown in MOZ_LOG, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65241

--HG--
extra : moz-landing-system : lando
 2020-03-05 11:04:44 +00:00
Cosmin Sabou
9ec8941cd4 Backed out 2 changesets (bug 1603703) for xpc failures on test_storage_aggregates.js. CLOSED TREE 
Backed out changeset 05dbbf7c379f (bug 1603703)
Backed out changeset a1e723439116 (bug 1603703)

--HG--
extra : rebase_source : 65d834f15b63fdd0ce5c90d2efd080e4841777aa
 2020-03-05 19:37:32 +02:00
Simon Giesecke
9e296ae57f Bug 1603703 - Part 2: Rename CreateFunction/RemoveFunction to RegisterFunction/UnregisterFunction. r=mak 
Depends on D57089

Differential Revision: https://phabricator.services.mozilla.com/D65504

--HG--
extra : moz-landing-system : lando
 2020-03-05 15:14:56 +00:00
Simon Giesecke
e6cae211c4 Bug 1603703 - Part 1: Change mozIStorageAsyncConnection::CreateFunction to accept a nsCOMPtr rather than a raw pointer. r=asuth,mak 
Differential Revision: https://phabricator.services.mozilla.com/D57089

--HG--
extra : moz-landing-system : lando
 2020-03-05 16:51:14 +00:00
Andrea Marchesini
9bc071f817 Bug 1619875 - Remove the remaining of the prompting code in the cookie-world, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65289

--HG--
extra : moz-landing-system : lando
 2020-03-04 21:25:33 +00:00
Tim Huang
5d0ba9975d Bug 1616570 - Part 3: Change the CookieJarSettings::CreateBlockingAll to be a singleton and rename it to GetBlockingAll(). r=Ehsan 
We don't need to create the blocking-all cookieJarSettings every time we
request it since it is basically the same. Instead, we should make it as
a singleton.

The patch makes this change the rename the
CookieJarSettings::CreateBlockingAll() to GetBlockingAll() which
reflects the fact that it is a singleton.

Differential Revision: https://phabricator.services.mozilla.com/D64564

--HG--
extra : moz-landing-system : lando
 2020-03-04 08:59:21 +00:00
Tim Huang
04d44bae12 Bug 1616570 - Part 1: Rename CookieSettings to CookieJarSettings. r=Ehsan 
Given that we are going to add ContentBlockingAllowList in
CookieSettings, so CookieSettings will be responsible for more stuff than the
cookie behavior and cookie permission. We should use a proper name to
reflect the purpose of it. The name 'CookieSettings' is misleading that
this is only for cookie related stuff. So, we decide to rename
'CookieSettins' to 'CookieJarSettings' which serves better meaning here.

Differential Revision: https://phabricator.services.mozilla.com/D63935

--HG--
rename : netwerk/cookie/CookieSettings.cpp => netwerk/cookie/CookieJarSettings.cpp
rename : netwerk/cookie/nsICookieSettings.idl => netwerk/cookie/nsICookieJarSettings.idl
extra : moz-landing-system : lando
 2020-03-04 08:59:08 +00:00
Andrea Marchesini
f1666a5ee9 Bug 1618113 - Allow 'secure' cookies when set by localhost, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D64290

--HG--
extra : moz-landing-system : lando
 2020-03-02 17:21:03 +00:00
Ehsan Akhgari
50ef8c407b Bug 1540810 - Part 1: Add a cookie settings API for partitioning third-party content; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D54572

--HG--
extra : moz-landing-system : lando
 2020-02-28 19:39:58 +00:00
Ehsan Akhgari
c8bd96de51 Bug 1577040 - Part 1: Remove the usages of nsIHttpChannel::IsTrackingResource() in the cookie service, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D63299

--HG--
extra : moz-landing-system : lando
 2020-02-20 07:27:24 +00:00
Andrea Marchesini
d9a4c8b19f Bug 1608384 - Implement sameSite lax-by-default 2 minutes tolerance for unsafe methods, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D62885

--HG--
extra : moz-landing-system : lando
 2020-02-19 17:43:52 +00:00
Andrea Marchesini
2665e4a062 Bug 1595661 - Cookie names and values must exclude NULL char, r=mayhemer,annevk 
Differential Revision: https://phabricator.services.mozilla.com/D63205

--HG--
extra : moz-landing-system : lando
 2020-02-19 12:52:38 +00:00
Andrea Marchesini
bd69c0127b Bug 1612476 - Introduce telemetry id COOKIE_SAMESITE_SET_VS_UNSET to count cookies without sameSite attribute, r=Ehsan,chutten 
Differential Revision: https://phabricator.services.mozilla.com/D61351

--HG--
extra : moz-landing-system : lando
 2020-02-12 14:47:57 +00:00
Ehsan Akhgari
84d84455c5 Bug 1614646 - Fix a data race in the cookie service initialization code; r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D62941

--HG--
extra : moz-landing-system : lando
 2020-02-17 11:52:06 +00:00
Ehsan Akhgari
4bdcfe0033 Bug 1615653 - Remove an unused variable; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D62943

--HG--
extra : moz-landing-system : lando
 2020-02-14 17:29:45 +00:00
Eric Rahm
2c08316c5d Bug 1610070 - Part 3: Convert the rest of netwerk/ to use UniquePtr. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D60341

--HG--
extra : moz-landing-system : lando
 2020-02-11 16:20:08 +00:00
Ehsan Akhgari
39a68b910d Bug 1322113 - Fix the implementation of the 'from visited' cookie policy in private browsing mode; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D61944

--HG--
extra : moz-landing-system : lando
 2020-02-07 10:02:50 +00:00
Ehsan Akhgari
eccae96ef4 Bug 1609176 - Remove the obsolete baseDomain field of the moz_cookies table; r=baku 
This change is backwards incompatible with the older cookies.sqlite
files, which means files saved from newer versions of Firefox will
no longer be possible to open in older versions of Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D60464

--HG--
rename : netwerk/test/unit/test_schema_3_migration.js => netwerk/test/unit/test_schema_10_migration.js
extra : moz-landing-system : lando
 2020-01-25 00:18:34 +00:00
Bogdan Tara
c9467840cd Backed out changeset 4cf57a5a3143 (bug 1609176) for test_cookies_async_failure.js related failures CLOSED TREE 2020-01-22 22:19:20 +02:00
Ehsan Akhgari
d0561affbf Bug 1609176 - Remove the obsolete baseDomain field of the moz_cookies table; r=baku 
This change is backwards incompatible with the older cookies.sqlite
files, which means files saved from newer versions of Firefox will
no longer be possible to open in older versions of Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D60464

--HG--
rename : netwerk/test/unit/test_schema_3_migration.js => netwerk/test/unit/test_schema_10_migration.js
extra : moz-landing-system : lando
 2020-01-22 17:01:55 +00:00
Ehsan Akhgari
8b642fb37e Bug 1609491 - Update the comment about differences with RFC2109/2616 
This is based on the recent changes in
https://github.com/httpwg/http-extensions/issues/159 and
https://github.com/httpwg/http-extensions/pull/1018.

Differential Revision: https://phabricator.services.mozilla.com/D60465

--HG--
extra : moz-landing-system : lando
 2020-01-21 00:13:18 +00:00
Coroiu Cristina
9490b63809 Backed out changeset b634b7b787d5 (bug 1609491) for wpt failures at /cookies/http-state/general-tests.html on a CLOSED TREE 2020-01-20 20:57:54 +02:00
Ehsan Akhgari
5a2d4ea5a4 Bug 1609491 - Stop accepting cookie name-value pairs without an equal sign; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D60040

--HG--
extra : moz-landing-system : lando
 2020-01-20 15:59:12 +00:00
Liang-Heng Chen
e5c5a46210 Bug 1587182 - add limitForeignContexts attribute to support dynamic FPI; r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D58426

--HG--
extra : moz-landing-system : lando
 2020-01-14 17:07:48 +00:00
Rob Wu
155bac71f8 Bug 1601499 - Compute baseDomain when cookies are read from the db r=Ehsan 
baseDomain is used as a key for cookies in a hashmap. For cookie
operations to work properly, the baseDomain generation must be stable.
This is however not the case, because the result can change by updates
to the public suffix list.

Since the stored baseDomain is not reliable, the value must be
recomputed when the database is read.

Differential Revision: https://phabricator.services.mozilla.com/D59430

--HG--
extra : moz-landing-system : lando
 2020-01-14 17:17:17 +00:00
Ehsan Akhgari
ae823cb5a3 Bug 1484315 - Refactor the third-party checks used in the cookie backend; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D58998

--HG--
extra : moz-landing-system : lando
 2020-01-08 10:25:44 +00:00
Chris Peterson
406763af7f Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj 
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440

--HG--
extra : moz-landing-system : lando
 2019-12-20 07:16:43 +00:00
Kris Maglione
295e55e227 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D53745

--HG--
extra : moz-landing-system : lando
 2019-12-13 20:36:37 +00:00
Kris Maglione
9853440599 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato 
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
 2019-12-13 20:36:24 +00:00
Kris Maglione
94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-13 20:36:16 +00:00
Tom Tung
83eb41d14a Bug 1474608 - P1 - Clear origin attributes directly for deleteDataFromOriginAttributesPattern if it's possible; r=asuth,baku 
The idea of this patch is to try to not use oberver mechanism as possible. To
achieve that, it introduces deleteByOriginAttributes() to cleaners. Different
from other methods, it would only be executed if it's implemented from a
cleaner.

It doesn't remove oberver mechanism entirely since some cleaners are still using
that for other deleteByXXX() functions. So, it only applies removing stuff to
PushService, QuotaManagerService, ServiceWorkerManager, nsPermissionManager,
nsApplicationCacheService, and nsCookieService.

Since the original issue is related to QuotaManagerService, it adds xpcshell
test under the dom/quota/test/unit/ to ensure the behavior won't be changed
accidentally in the future.

Differential Revision: https://phabricator.services.mozilla.com/D33758

--HG--
extra : moz-landing-system : lando
 2019-12-02 19:47:13 +00:00
shindli
91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE 
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
 2019-12-11 03:09:26 +02:00
Kris Maglione
37c15883a5 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D53745

--HG--
extra : moz-landing-system : lando
 2019-12-10 23:07:34 +00:00
Kris Maglione
3ca78ce8e3 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato 
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
 2019-12-10 23:07:21 +00:00
Kris Maglione
16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-10 23:07:13 +00:00
Noemi Erli
82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures 
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
 2019-12-07 22:26:43 +02:00
Kris Maglione
8c28f5ff8d Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D53745

--HG--
extra : moz-landing-system : lando
 2019-12-07 18:44:35 +00:00
Kris Maglione
fa3556c3fc Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato 
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
 2019-12-07 18:44:34 +00:00
Kris Maglione
910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-07 19:11:58 +00:00
Daniel Varga
84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE 
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
 2019-12-07 03:12:07 +02:00
Kris Maglione
6d5729ccb5 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D53745

--HG--
extra : moz-landing-system : lando
 2019-12-06 22:15:27 +00:00
Kris Maglione
b5238224ba Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato 
Differential Revision: https://phabricator.services.mozilla.com/D53741

--HG--
extra : moz-landing-system : lando
 2019-12-06 22:14:22 +00:00
Kris Maglione
20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-06 22:14:14 +00:00
Gabriele Svelto
5dc21d568c Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan 
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444

--HG--
extra : moz-landing-system : lando
 2019-12-06 09:17:57 +00:00
Gabriele Svelto
69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
 2019-12-06 09:16:44 +00:00
Ehsan Akhgari
d94f27a8d6 Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D52761

--HG--
extra : moz-landing-system : lando
 2019-12-03 17:08:25 +00:00
Ehsan Akhgari
6216893099 Bug 1599237 - Add a cookie manager API for deleting cookies by a time range, and use it in the clear data service; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D54646

--HG--
extra : moz-landing-system : lando
 2019-11-27 11:01:45 +00:00
Andreea Pavel
c81fb53e77 Bug 1582318 - disable correct browser_sharedWorker.js test case on fission r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D54895

--HG--
extra : moz-landing-system : lando
 2019-11-27 10:36:36 +00:00
Daniel Varga
f12c40c242 Backed out changeset afe80b4ff889 (bug 1595934) Requested by ehsan to see if it fixex bug 1597915. On a CLOSED TREE 2019-11-22 02:01:51 +02:00
Ehsan Akhgari
30cf316b38 Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D52761

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:21:14 +00:00
Nihanth Subramanya
2164478f1e Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh 
Differential Revision: https://phabricator.services.mozilla.com/D47427

--HG--
extra : moz-landing-system : lando
 2019-11-01 23:24:25 +00:00
Dorel Luca
b9074d53a1 Backed out 4 changesets (bug 1584479) for Browser-chrome failures in toolkit/components/antitracking/test/browser/browser_socialtracking.js 
Backed out changeset b0d9877bd8b0 (bug 1584479)
Backed out changeset d2c56bd61b08 (bug 1584479)
Backed out changeset 0edb22786545 (bug 1584479)
Backed out changeset 7e03b392edb3 (bug 1584479)
 2019-11-02 01:18:42 +02:00
Nihanth Subramanya
e7620d9a8c Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh 
Differential Revision: https://phabricator.services.mozilla.com/D47427

--HG--
extra : moz-landing-system : lando
 2019-11-01 21:02:09 +00:00
Kashav Madan
c39158719d Bug 1582531 - Update fission annotations for tests that pass, r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D50507

--HG--
extra : moz-landing-system : lando
 2019-10-30 21:51:22 +00:00
Ehsan Akhgari
d0732b6e03 Bug 1591813 - Make nsICookieManager.getCookiesFromHost() return an Array<nsICookie>; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D50750

--HG--
extra : moz-landing-system : lando
 2019-10-28 12:08:09 +00:00
Ehsan Akhgari
175d5c2671 Bug 1591812 - Make nsICookieManager.getCookiesWithOriginAttributes() return an Array<nsICookie>; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D50749

--HG--
extra : moz-landing-system : lando
 2019-10-28 12:07:39 +00:00
Jean-Yves Avenard
e6d0e7dfda Bug 1588899 - P1. Move classification flags related method to nsIClassifiedChannel. r=Ehsan,baku 
This is where it should have been in the first place. Those attributes belong there.

Differential Revision: https://phabricator.services.mozilla.com/D49577

--HG--
extra : moz-landing-system : lando
 2019-10-19 04:30:24 +00:00
Valentin Gosu
e2dc6249de Bug 1580750 - Enable browser_serviceWorker.js in fission-debug r=kershaw 
It was previously causing debug leaks in fission, but those appear to have been fixed.

Differential Revision: https://phabricator.services.mozilla.com/D49735

--HG--
extra : moz-landing-system : lando
 2019-10-18 14:01:25 +00:00
Cosmin Sabou
d9a4fb7dd3 Bug 1582318 - Disable browser_sharedWorker.js on fission. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D49211

--HG--
extra : moz-landing-system : lando
 2019-10-15 19:38:07 +00:00
Ehsan Akhgari
9a0578ff9c Bug 1575934 - Create the channels used to download and verify appcache entries with the cookie settings belonging to the document which created the appcache; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D49018

--HG--
extra : moz-landing-system : lando
 2019-10-15 17:32:54 +00:00
Coroiu Cristina
5e1f2653cf Backed out changeset bc3714b56887 (bug 1575934) for wpt failures at /html/browsers/offline/application-cache-api/api_update_error.https.html on a CLOSED TREE 2019-10-15 17:28:16 +03:00
Ehsan Akhgari
2eaec14333 Bug 1575934 - Create the channels used to download and verify appcache entries with the cookie settings belonging to the document which created the appcache; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D49018

--HG--
extra : moz-landing-system : lando
 2019-10-13 17:45:30 +00:00