Commit Graph

650774 Commits

Author SHA1 Message Date
alwu
70e585dd96 Bug 1548923 - part1 : abort 'TimeMarchesOn' algorithm during seeking. r=jya
In the spec [1], it doesn't mention that we should only run `TimeMarchesOn` after media has started. Therefore, we should remove this return condition in order to update cue's state correctly no matter the media starts or not.

In addition, according to the spec [2], `TimeMarchesOn` should be executed after seeking completed, we shouldn't not run it during seeking.

[1] https://html.spec.whatwg.org/multipage/media.html#time-marches-on
[2] https://html.spec.whatwg.org/multipage/media.html#seeking:time-marches-on

Differential Revision: https://phabricator.services.mozilla.com/D29882

--HG--
extra : moz-landing-system : lando
2019-05-08 17:33:36 +00:00
Noemi Erli
6430d23336 Backed out 12 changesets (bug 1547813) for failures in browser_partitionedIndexedDB.js CLOSED TREE
Backed out changeset 98989127264b (bug 1547813)
Backed out changeset f9d790139a26 (bug 1547813)
Backed out changeset a29f58cef022 (bug 1547813)
Backed out changeset c1288949de1c (bug 1547813)
Backed out changeset 8cad4fd197b1 (bug 1547813)
Backed out changeset 807ce59e7e6e (bug 1547813)
Backed out changeset 06943593738c (bug 1547813)
Backed out changeset 4ced8d49ddc3 (bug 1547813)
Backed out changeset 77a040f527e9 (bug 1547813)
Backed out changeset b4651cfaff30 (bug 1547813)
Backed out changeset 279c140a4d71 (bug 1547813)
Backed out changeset 0e0241f3d366 (bug 1547813)
2019-05-09 20:04:16 +03:00
David Walsh
33b9669f6a Bug 1547334 - Show logpoint icon in webconsole r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D29040

--HG--
extra : moz-landing-system : lando
2019-05-08 19:49:16 +00:00
Edwin Gao
1298ea44c8 Bug 1547135 - reduce tp6m test result jitter for Android (Pixel 2) r=jmaher,acreskey,rwood
All changes are reversible upon reboot, with exception of the animation setting which is restored to default settings once Raptor concludes testing.

All values are for Pixel 2. Motorola G5 patch will be available separately.

Changes:
- set cpu/gpu to `performance` mode, and override minimum frequency with the maximum available frequency
- tweak msm-bus related kernel settings
- set display to be permanently on when connected over USB
- disable animation for duration of test
- turn off thermal throttling

Differential Revision: https://phabricator.services.mozilla.com/D30116

--HG--
extra : moz-landing-system : lando
2019-05-09 16:35:27 +00:00
Clément ALLAIN
40e37fe471 Bug 1437446 : Make probe process choice more visible in about:telemetry r=chutten,flod
- Make process the second level menu of (Scalars, Keyed Scalars, Histograms, Keyed Histograms and Events)
  - Change the process dropdown to be a store dropdown
  - Main store is selected by default
  - Added a label before the store dropdown
  - Refactor a bit the code to avoid lot of duplications

Note: This revision should be way cleaner

Differential Revision: https://phabricator.services.mozilla.com/D29483

--HG--
extra : moz-landing-system : lando
2019-05-08 18:56:19 +00:00
Marco Bonardo
ca2c358730 Bug 1550025 - In Quantum Bar the restriction tokens should bypass the restriction prefs. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D30490

--HG--
extra : moz-landing-system : lando
2019-05-09 15:59:33 +00:00
Jonas Allmann
4b72fd9bba Bug 1549326 - Remove simpletest.js from eval()-whitelist, r=ckerschb
Amend several test files for triggering eval() assertion through simpletest.js

Differential Revision: https://phabricator.services.mozilla.com/D30474

--HG--
extra : moz-landing-system : lando
2019-05-09 16:02:49 +00:00
Ehsan Akhgari
f9ced6a3c6 Bug 1547813 - Part 12: Add some tests for partitioning third-party storage/messaging with dynamic FPI; r=baku
This patch doesn't port all of the existing tests because some of them
do not pass yet and some others need more work to be ported.  This will
happen in follow-up bugs.

Differential Revision: https://phabricator.services.mozilla.com/D30401

--HG--
rename : toolkit/components/antitracking/test/browser/storageprincipal_head.js => toolkit/components/antitracking/test/browser/dynamicfpi_head.js
extra : moz-landing-system : lando
2019-05-09 07:14:19 +00:00
Ehsan Akhgari
db2e485317 Bug 1547813 - Part 11: Add support for reporting breakage when the nsICookieService.BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN cookie policy is active; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D30120

--HG--
extra : moz-landing-system : lando
2019-05-08 19:38:12 +00:00
Ehsan Akhgari
31c7d14341 Bug 1547813 - Part 10: Add support for nsICookieService.BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN to the content blocking category pref; r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D30119

--HG--
extra : moz-landing-system : lando
2019-05-08 22:34:06 +00:00
Ehsan Akhgari
b9c7626390 Bug 1547813 - Part 9: Ensure the cookie service does third-party checks when the cookie policy is set to nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30118

--HG--
extra : moz-landing-system : lando
2019-05-08 19:38:08 +00:00
Ehsan Akhgari
c7cb5521d1 Bug 1547813 - Part 8: Introduce a CookieSettings API to query whether cookies from third-party trackers must be rejected and use it in Gecko; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30117

--HG--
extra : moz-landing-system : lando
2019-05-08 20:22:18 +00:00
Ehsan Akhgari
f33f21e80b Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-08 20:15:13 +00:00
Ehsan Akhgari
7889bc2edd Bug 1547813 - Part 6: Return StorageAccess::ePartitionForeignOrDeny from storage access APIs when the antitracking backend mandates that; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29741

--HG--
extra : moz-landing-system : lando
2019-05-08 20:13:23 +00:00
Ehsan Akhgari
2560dad048 Bug 1547813 - Part 5: Introduce StorageAccess::ePartitionForeignOrDeny; r=baku
This StorageAccess code tells callers that they must partition third-party
storage, or deny storage access if that is not possible.

Differential Revision: https://phabricator.services.mozilla.com/D29740

--HG--
extra : moz-landing-system : lando
2019-05-09 07:14:34 +00:00
Ehsan Akhgari
1b4236b4ee Bug 1547813 - Part 4: Rename StorageAccess::ePartitionedOrDeny to ePartitionTrackersOrDeny; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29739

--HG--
extra : moz-landing-system : lando
2019-05-08 19:37:52 +00:00
Ehsan Akhgari
aaa189b070 Bug 1547813 - Part 3: Modify the antitracking algorithms to work with nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
The policy that this patch implements in the antitracking backend is to treat
third-party trackers exactly the same way as BEHAVIOR_REJECT_TRACKER, and
additionally partition all third-party contexts as well.

Differential Revision: https://phabricator.services.mozilla.com/D29738

--HG--
extra : moz-landing-system : lando
2019-05-09 14:00:55 +00:00
Ehsan Akhgari
6b7e90e3e5 Bug 1547813 - Part 2: Introduce nsIWebProgressListener::STATE_COOKIES_PARTITIONED_FOREIGN; r=baku
This error code indicates the specific case where the antitracking backend
rejects a particular access request because the resource is third-party and
the cookie policy mandates that third-party resources must be partitioned.

Differential Revision: https://phabricator.services.mozilla.com/D29737

--HG--
extra : moz-landing-system : lando
2019-05-08 19:37:47 +00:00
Ehsan Akhgari
564ae33dab Bug 1547813 - Part 1: Introduce nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
This new code designates our new cookie policy for blocking cookies and
storage access from third-party trackers and partitioning the cookie jar
of the rest of third-party resources.

Differential Revision: https://phabricator.services.mozilla.com/D29736

--HG--
extra : moz-landing-system : lando
2019-05-08 19:37:40 +00:00
Marco Bonardo
582ea00aa6 Bug 1550480 - Increase the Quantum Bar stale rows removal timer. r=dao
Try to further reduce flicker by increasing the time we keep stale results visible.

Differential Revision: https://phabricator.services.mozilla.com/D30502

--HG--
extra : moz-landing-system : lando
2019-05-09 15:00:47 +00:00
Sean Feng
760251d1c3 Bug 1533861 - Add a telemetry to detect disk type r=chutten,froydnj,bdekoz
Differential Revision: https://phabricator.services.mozilla.com/D29383

--HG--
extra : moz-landing-system : lando
2019-05-08 15:30:07 +00:00
Dão Gottwald
24c3de356b Bug 1550423 - When a result's title or URL overflows, expose the full value in a tooltip. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D30470

--HG--
extra : moz-landing-system : lando
2019-05-09 13:06:53 +00:00
Rob Wu
ef01932b50 Bug 1546248 - Loosen Client-ID check in unit test r=rpl
The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.

See the comment for more details; the fix will be part of bug 1537933

Differential Revision: https://phabricator.services.mozilla.com/D30001

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:18 +00:00
Rob Wu
3964ab68f9 Bug 1546123 - Correct size calculation of theme previews r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D29482

--HG--
extra : moz-landing-system : lando
2019-05-08 23:36:31 +00:00
Rob Wu
9675eda2fa Bug 1546980 - Add ratings and user counts to discopane r=mstriemer,flod
Differential Revision: https://phabricator.services.mozilla.com/D29481

--HG--
extra : moz-landing-system : lando
2019-05-08 23:36:32 +00:00
Rob Wu
bb1e8193ce Bug 1542262 - Match AMO's rating logic in about:addons r=mstriemer,Pike
- Fill stars based on whether the rating is within the 0.5 range of a
  0.5-multiple, rather than checking whether the rating is at least as
  large as the 0.5-multiple. This follows the boundaries at:
  bb9277eeff/src/ui/components/Rating/index.js (L139-L140)

- Use a review star rating instead of re-using the bookmark star.
  This is not necessarily to be more consistent with AMO's stars,
  but to prevent the stars from becoming non-stars if we ever change
  the bookmark icon. The SVG icon is based on the path at:
  bb9277eeff/src/ui/components/IconStar/index.js (L19)

- Turn it into a custom element to make re-use easier.

Differential Revision: https://phabricator.services.mozilla.com/D29480

--HG--
extra : moz-landing-system : lando
2019-05-08 18:30:04 +00:00
Rob Wu
163dcef402 Bug 1546248 - Add attribution parameters to AMO links r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D29479

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:17 +00:00
Rob Wu
07b06b75fa Bug 1546248 - Put HTML discopane behind separate pref r=mstriemer
Require `extensions.htmlaboutaddons.discover.enabled` to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.

Differential Revision: https://phabricator.services.mozilla.com/D29478

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:17 +00:00
Rob Wu
006cf25259 Bug 1546248 - Add notice to discopane when TAAR is enabled r=mstriemer,flod
The `<message-bar>` custom element used in this patch will be
introduced by https://phabricator.services.mozilla.com/D27547

The notice text and SUMO link target were taken from
6d2de7e52a/src/disco/pages/DiscoPane/index.js (L211-L213)

Differential Revision: https://phabricator.services.mozilla.com/D29477

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
Rob Wu
a4d633137e Bug 1546248 - Change "Get Add-ons" to "Recommendations" r=mstriemer,flod
Differential Revision: https://phabricator.services.mozilla.com/D28936

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
Rob Wu
dd8df1ac64 Bug 1546248 - Add discopane to about:addons HTML view r=mstriemer,flod,aswan
The api_response.json test file is the response from
https://addons-dev.allizom.org/api/v4/discovery/?lang=en-US
It has not been modified, except for being prettified using `json_pp`.

Differential Revision: https://phabricator.services.mozilla.com/D28436

--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
Noemi Erli
1c65279044 Backed out changeset 38ce182f68ea (bug 1402530) for build bustages in nsMixedContentBlocker.cpp CLOSED TREE 2019-05-09 17:29:38 +03:00
David Walsh
e5afc68fb2 Bug 1515108 - Add DAMP test for project search r=jlast
Adds test for damp searches

Differential Revision: https://phabricator.services.mozilla.com/D30388

--HG--
extra : moz-landing-system : lando
2019-05-08 21:57:04 +00:00
James Graham
815ab6dd7d Bug 1504776 - Reenable tests that were disabled for a harness bug, r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D30376

--HG--
extra : moz-landing-system : lando
2019-05-09 14:07:14 +00:00
James Graham
24e220ca75 Bug 1504776 - Fix a test that tries to navigate the test window, r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D30375

--HG--
extra : moz-landing-system : lando
2019-05-09 13:53:37 +00:00
Sebastian Streich
db1660661f Bug 1402530 - Use IsOriginPotentiallyTrustworthy in ShouldLoad r=ckerschb,jkt
Differential Revision: https://phabricator.services.mozilla.com/D28870

--HG--
extra : moz-landing-system : lando
2019-05-07 18:08:19 +00:00
Raphael Pierzina
77e6f296b4 Bug 1546614 - Run telemetry-tests-client on macosx64, linux32, windows32 on CI; r=chutten,ahal
Differential Revision: https://phabricator.services.mozilla.com/D30481

--HG--
extra : moz-landing-system : lando
2019-05-09 13:39:39 +00:00
Jon Coppeard
75bfdb344c Bug 1549853 - Ignore associations of zero bytes of malloc memory with a GC thing r=sfink?
Differential Revision: https://phabricator.services.mozilla.com/D30355

--HG--
extra : moz-landing-system : lando
2019-05-08 17:46:02 +00:00
Jon Coppeard
94e50ef5a8 Bug 1549986 - Make all concrete implementations of JSTracer final to aid devirtualization r=sfink?
Differential Revision: https://phabricator.services.mozilla.com/D30362

--HG--
extra : moz-landing-system : lando
2019-05-09 08:39:23 +00:00
Julian Descottes
6d85f4e2fa Bug 1549940 - Close about:debugging messages when clicking anywhere on the close button r=Ola
Simply moved the callback from the icon to the button and updated the test.

Differential Revision: https://phabricator.services.mozilla.com/D30339

--HG--
extra : moz-landing-system : lando
2019-05-09 12:59:00 +00:00
Emilio Cobos Álvarez
f65bcfba56 Bug 1549559 - Add bindings for ArcSlice and ThinArc, and use them to reduce copies of SVG path data. r=heycam
As I said over bug 1549593, the eventual goal is to use ArcSlice in all
inherited properties. But this seemed like a good first candidate that doesn't
require me to move around a lot more code, since we were already using cbindgen
for the path commands.

Differential Revision: https://phabricator.services.mozilla.com/D30134

--HG--
extra : moz-landing-system : lando
2019-05-09 12:43:19 +00:00
Emilio Cobos Álvarez
f59bb7ae91 Bug 1549559 - Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam
We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.

Differential Revision: https://phabricator.services.mozilla.com/D30133

--HG--
extra : moz-landing-system : lando
2019-05-09 10:53:50 +00:00
ffxbld
6b6a4743bb No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D30488

--HG--
extra : moz-landing-system : lando
2019-05-09 12:41:52 +00:00
Emilio Cobos Álvarez
1de789c618 Bug 1549593 - Move OwnedSlice to style_traits. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D30126

--HG--
rename : servo/components/style/owned_slice.rs => servo/components/style_traits/owned_slice.rs
extra : moz-landing-system : lando
2019-05-09 10:49:50 +00:00
Emilio Cobos Álvarez
38065025d9 Bug 1548691 - Use the owned slice type for basic shape polygon coordinates. r=TYLin,heycam
This enables destructors for tagged unions in cbindgen, implemented in:

 * https://github.com/eqrion/cbindgen/pull/333

Which allow us to properly generate a destructor for the cbindgen-generated
StyleBasicShape (which now contains an OwnedSlice).

For now, we still use the glue code to go from Box<BasicShape> to
UniquePtr<BasicShape>. But that will change in the future when we generate even
more stuff and remove all the glue.

I could add support for copy-constructor generation to cbindgen for tagged
enums, but I'm not sure if it'll end up being needed, and copy-constructing
unions in C++ is always very tricky.

Differential Revision: https://phabricator.services.mozilla.com/D29769

--HG--
extra : moz-landing-system : lando
2019-05-09 11:24:57 +00:00
Emilio Cobos Álvarez
7d9dca2244 Bug 1548691 - Add an owned slice type which cbindgen can understand. r=heycam
Passing these by value won't be ok of course, but that's fine.

I plan to combine this with https://github.com/eqrion/cbindgen/pull/333 to
actually be able to share representation for ~all the things, this is just the
first bit.

Box<T>, Atom and Arc<T> will be much easier since cbindgen can understand them
without issues.

It's boxed slices the only ones I should need something like this. I could avoid
it if I rely on Rust's internal representation, which we can per [1], but then I
need to teach cbindgen all about slices, which is generally hard, I think.

[1]: https://github.com/rust-lang/unsafe-code-guidelines/blob/master/reference/src/layout/pointers.md

Differential Revision: https://phabricator.services.mozilla.com/D29768

--HG--
extra : moz-landing-system : lando
2019-05-09 10:49:22 +00:00
Emilio Cobos Álvarez
23b7a280bf Bug 1545823 - Implement non-standard CSSStyleSheet.rules, CSSStyleSheet.addRule and CSSStyleSheet.removeRule. r=bzbarsky
It's not worth dying on this hill. Both Blink and WebKit pass the tests.

(Well, WebKit actually fails one of the latest ones I wrote, cssRules and rules
are not the same JS object, WebKit returns a new rule list. I'll file)

Spec PR in https://github.com/w3c/csswg-drafts/pull/3900.

Differential Revision: https://phabricator.services.mozilla.com/D30348

--HG--
extra : moz-landing-system : lando
2019-05-09 12:32:52 +00:00
Florin Strugariu
70d07476cb Bug 1541041 Page timeouts are ignored during cold page-load test suites r=rwood,davehunt
Differential Revision: https://phabricator.services.mozilla.com/D26309

--HG--
extra : moz-landing-system : lando
2019-05-08 18:29:56 +00:00
diana.iacos
57aa3d1fab Bug 1547929 - Default browser preference cleanup on tablets; r=petru
The "Make default browser" setting is now just a button, part of the "General" settings.
We'll remove the layout for 2-pane settings and the now unused String.

Depends on D30468

Differential Revision: https://phabricator.services.mozilla.com/D30469

--HG--
extra : moz-landing-system : lando
2019-05-09 10:23:02 +00:00
diana.iacos
9fa264ed41 Bug 1547929 - [Tablet] Make default browser option not displayed on top of the Settings Menu; r=petru
Differential Revision: https://phabricator.services.mozilla.com/D30468

--HG--
extra : moz-landing-system : lando
2019-05-09 10:23:25 +00:00