Commit Graph

658181 Commits

Author SHA1 Message Date
Kartikaya Gupta
721a5dbcf4 Bug 1558598 - Ensure mozinfo correctly detects WebRender. r=ahal
I don't know if this covers all the things that use mozinfo (probably not)
but it covers all the suites that use mozinfo and have webrender conditions
in the test manifests (i.e. mochitest and wpt variants).

Differential Revision: https://phabricator.services.mozilla.com/D35869

--HG--
extra : moz-landing-system : lando
2019-06-29 09:51:14 +00:00
Kartikaya Gupta
276b570b4d Bug 1558598 - Add the --enable-webrender option to android HW unittests. r=ahal
This is not used yet but will be eventually so I'm just going to
add it now.

As of this patch, all the tests that we currently run on android HW do
accept the --enable-webrender flag and explicitly disable WR if it is
not provided.

Differential Revision: https://phabricator.services.mozilla.com/D35868

--HG--
extra : moz-landing-system : lando
2019-06-29 09:51:05 +00:00
Kartikaya Gupta
513bb04fa4 Bug 1558598 - Simplify the webrender flags in android_emulator_unittest.py. r=ahal
Instead of using --setenv to control WebRender being on or off, just propagate
the --enable-webrender flag to the downstream "remote" test harness. This
is more reliable than passing --setenv because not all harnesses support
the setenv flag, and it's easier to explicitly add support for --enable-webrender
to the harnesses that need it (i.e. the ones we want to run with WR enabled in
automation).

This also drops the --disable-webrender flag and asserts that lack of
enable-webrender implies WR will be disabled.

Differential Revision: https://phabricator.services.mozilla.com/D35867

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:56 +00:00
Kartikaya Gupta
286b1f72fd Bug 1558598 - Fix up webrender flag in desktop_unittest.py. r=ahal
Now that all the downstream test harnesses take the --enable-webrender
option and propagate it correctly, the desktop_unittest.py wrapper can
just pass it along to those harnesses.

Differential Revision: https://phabricator.services.mozilla.com/D35866

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:47 +00:00
Kartikaya Gupta
1298b01ce8 Bug 1558598 - Add ignored option for enable-webrender in jit_test harness. r=ahal
WebRender being on or off doesn't affect the JIT code, so the option is
not really useful in this harness. However, it is a downstream harness that
we'll be passing this flag to so for consistency we have it accept the
flag and silently eat it.

Differential Revision: https://phabricator.services.mozilla.com/D35865

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:43 +00:00
Kartikaya Gupta
b7f611ea16 Bug 1558598 - Fix up webrender options for the firefox-ui harness. r=ato,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D35864

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:34 +00:00
Kartikaya Gupta
7cac45c075 Bug 1558598 - Fix up webrender options for the AWSY harness. r=ato
AWSY is built on marionette, so it inherits the option by default, we mostly
just need to propagate it properly. This also drops the --disable-webrender
option as it is now implied if --enable-webrender is not provided.

Differential Revision: https://phabricator.services.mozilla.com/D35863

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:30 +00:00
Kartikaya Gupta
00ecade299 Bug 1558598 - Fix the enable-webrender option for the telemetry Marionette tests. r=ato
Differential Revision: https://phabricator.services.mozilla.com/D35862

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:27 +00:00
Kartikaya Gupta
90eea8e8e5 Bug 1558598 - Force WebRender on or off in the marionette harness. r=ato
Differential Revision: https://phabricator.services.mozilla.com/D35861

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:23 +00:00
Kartikaya Gupta
cb5d36cb8c Bug 1558598 - Force WebRender on or off in the xpcshell harness. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35860

--HG--
extra : moz-landing-system : lando
2019-06-29 09:50:20 +00:00
Kartikaya Gupta
bb83950948 Bug 1558598 - Force WebRender on or off in the cppunit harness. r=ahal
Also adds it to the mach command, which is a little weird, because the
mach command doesn't expose the option but does parse it via the cpp unit
argument parser. So I just exposed it on the mach command and after that
it Just Works for mach.

Differential Revision: https://phabricator.services.mozilla.com/D35859

--HG--
extra : moz-landing-system : lando
2019-06-29 09:49:23 +00:00
Kartikaya Gupta
ebe5ebc203 Bug 1558598 - Force WebRender on or off in the talos harness. r=perftest-reviewers,rwood
Differential Revision: https://phabricator.services.mozilla.com/D35858

--HG--
extra : moz-landing-system : lando
2019-06-29 09:49:14 +00:00
Kartikaya Gupta
c3de0e7d73 Bug 1558598 - Force WebRender on or off in the raptor harness. r=rwood
Differential Revision: https://phabricator.services.mozilla.com/D35857

--HG--
extra : moz-landing-system : lando
2019-06-29 09:49:00 +00:00
Kartikaya Gupta
14cf3a5147 Bug 1558598 - Force WebRender on or off in the WPT harness. r=ato
Differential Revision: https://phabricator.services.mozilla.com/D35856

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:53 +00:00
Kartikaya Gupta
32b53ae115 Bug 1558598 - Force WebRender on or off in the reftest harness. r=ahal
Covers both local and remote reftests.

Differential Revision: https://phabricator.services.mozilla.com/D35855

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:45 +00:00
Kartikaya Gupta
d1d6261d9f Bug 1558598 - Force WebRender on or off in the mochitest harness. r=ahal
This code covers both remote mochtiests and local mochitests.

Differential Revision: https://phabricator.services.mozilla.com/D35854

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:30 +00:00
Kartikaya Gupta
711c133f6d Bug 1558598 - Force WebRender on or off in the gtest harness. r=ahal
This covers the local and remote gtests, as well as the mach command.

Differential Revision: https://phabricator.services.mozilla.com/D35852

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:16 +00:00
Kartikaya Gupta
92b3588b88 Bug 1558598 - Force WebRender on or off in the junit harness. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35850

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:02 +00:00
Csoregi Natalia
67226aab44 Backed out changeset 789bacca1219 (bug 1556818) for web platform failures on module-error-reporting.html. 2019-06-29 12:11:33 +03:00
Ross Kirsling
f2daecfc95 Bug 1556818 - Throw early SyntaxError instead of ReferenceError for 0 = 0 r=khyperia
Differential Revision: https://phabricator.services.mozilla.com/D35298

--HG--
extra : moz-landing-system : lando
2019-06-28 03:04:45 +00:00
Kagami Sascha Rosylight
29904ec6bf Bug 1454622: Remove DOMQuad bounds attribute r=bzbarsky
The bounds attribute has been deprecated and shown zero use, and thus this change removes it.

Differential Revision: https://phabricator.services.mozilla.com/D36005

--HG--
extra : moz-landing-system : lando
2019-06-29 02:27:47 +00:00
Kagami Sascha Rosylight
8e0f5ebfdd Bug 1560658: Add SameValueZero to mfbt/FloatingPoint.h r=jwalden
Add ES-defined SameValueZero and replace existing code.

Differential Revision: https://phabricator.services.mozilla.com/D35596

--HG--
extra : moz-landing-system : lando
2019-06-28 23:57:13 +00:00
Carolina
091b6fe15a Bug 1557458 - Sends certificate information to about:certificate. r=johannh,keeler
Differential Revision: https://phabricator.services.mozilla.com/D34013

--HG--
extra : moz-landing-system : lando
2019-06-28 17:27:21 +00:00
Timothy Nikkel
6bb668b85e Bug 1562159. Restore second copy of test because pref is different second time.
I forgot that we run the tests twice in this file, once with the downscale pref on and once with it off. Restore the second time for the moz-icon tests. And adjust the fuzz because it can be lower now.

Differential Revision: https://phabricator.services.mozilla.com/D36415

--HG--
extra : moz-landing-system : lando
2019-06-29 00:17:30 +00:00
Rob Wu
2b97594781 Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js r=Gijs
The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.

Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D36185

--HG--
extra : moz-landing-system : lando
2019-06-28 23:48:06 +00:00
Chun-Min Chang
dc65a77a5b Bug 1561945 - P1: Copy sunaudio backend to cubeb. r=achronop
Differential Revision: https://phabricator.services.mozilla.com/D36215

--HG--
extra : moz-landing-system : lando
2019-06-27 16:59:00 +00:00
Dana Keeler
8a253dd58e bug 1559108 - remove unnecessary code in test_blocklist_onecrl.js that was causing unrelated failures r=KevinJacobs
Previously, OneCRL was part of the add-on blocklist system. Now that we use
kinto/remote settings, using AddonTestUtils in test_blocklist_onecrl.js is
unnecessary (and it was exposing a preexisting issue with how CacheObserver uses
prefs).

Differential Revision: https://phabricator.services.mozilla.com/D36377

--HG--
extra : moz-landing-system : lando
2019-06-28 23:06:20 +00:00
Ed Lee
990c293970 Bug 1562320 - Add Release discovery, AMO telemetry and bug fixes to Activity Stream r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D36389

--HG--
extra : moz-landing-system : lando
2019-06-28 22:48:38 +00:00
Rob Wu
8656cd8516 Bug 1561909 - Add test for WebSocket requests in proxy.onRequest r=mixedpuppy
The main purpose of this test is to verify that the `proxy.onRequest`
event captures WebSocket requests.

We also get the following additional coverage for free:

- actual requests with wss: scheme (the only other extension test
  that uses WebSocket, via ws:, is test_ext_webRequest_webSocket.js).

- intercepting requests of other extensions via the proxy API.

Differential Revision: https://phabricator.services.mozilla.com/D36199

--HG--
extra : moz-landing-system : lando
2019-06-27 19:35:42 +00:00
Narcis Beleuzu
dcc603a037 Backed out changeset 2719ba46ac12 (bug 1551601) for causing xpcshell failures. CLOSED TREE 2019-06-29 02:41:31 +03:00
Narcis Beleuzu
cc10ed7ce5 Backed out 2 changesets (bug 1553705) for causing Bug1562142 . CLOSED TREE
Backed out changeset fbb26a04ec1f (bug 1553705)
Backed out changeset dd6e7c0970d5 (bug 1553705)
2019-06-29 02:39:01 +03:00
Daosheng Mu
d655bca549 Bug 1556091 - Making dom.vr.enabled to be Live. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D35452

--HG--
extra : moz-landing-system : lando
2019-06-28 22:02:14 +00:00
Sam Foster
790aa6af69 Bug 1548391 - Add a contextmenu item to fill a password field with a generated password. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D35592

--HG--
extra : moz-landing-system : lando
2019-06-28 22:03:57 +00:00
Jared Wein
fc4c05eaae Bug 1562254 - Add favicon for about:logins page. r=_6a68
Differential Revision: https://phabricator.services.mozilla.com/D36391

--HG--
extra : moz-landing-system : lando
2019-06-28 22:00:17 +00:00
Kearwood "Kip" Gilbert
816af12bb5 Bug 1466702 - Refactor / reimplement gfxVRPuppet and VRServiceTest to use gfxVRExternal r=daoshengmu,thomasmo,bzbarsky
gfxVRPuppet will be replaced with a fully asynchronous puppet automation that runs in the VR process.

Differential Revision: https://phabricator.services.mozilla.com/D26263

--HG--
extra : moz-landing-system : lando
2019-06-28 21:19:54 +00:00
Ting-Yu Lin
c5048ca650 Bug 1562122 Part 4 - Return early in the overflow incomplete case, and add an assertion for the bound of final block size. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D36291

--HG--
extra : moz-landing-system : lando
2019-06-28 21:21:15 +00:00
Ting-Yu Lin
1524471e5a Bug 1562122 Part 3 - Delete the duplicate logic computing the final block size. r=dholbert
After the deleted logic

```
aFinalSize.BSize(wm) =
    std::max(aReflowInput.AvailableBSize(), aContentBSize);
```

aStatus changes to incomplete, so it computes the same thing again.

Differential Revision: https://phabricator.services.mozilla.com/D36290

--HG--
extra : moz-landing-system : lando
2019-06-28 21:21:06 +00:00
Ting-Yu Lin
a57bb370a3 Bug 1562122 Part 2 - Replace effectiveComputedBSize with computedBSizeLeftOver. r=dholbert
No need to call GetEffectiveComputedBSize() twice.

Also, calling aState.ConsumedBSize() instead of using
aState.mConsumedBSize directly because the accessor function caches
mConsumedBSize properly when it is called the first time.

Differential Revision: https://phabricator.services.mozilla.com/D36289

--HG--
extra : moz-landing-system : lando
2019-06-28 21:21:03 +00:00
Ting-Yu Lin
bf4acb9116 Bug 1562122 Part 1 - Move the logic after ComputeFinalBSize() into ComputeFinalBSize(). r=dholbert
This patch only moves the logic, and rename some variables. More
clean-up follows.

Note in the middle of ComputeFinalBSize(), ShouldAvoidBreakInside() can
do early return under the condition that aStatus is complete. The logic
moved in this patch is executed only when aStatus is *incomplete*, so no
behavior is changed after applying this change.

Differential Revision: https://phabricator.services.mozilla.com/D36288

--HG--
extra : moz-landing-system : lando
2019-06-28 21:20:54 +00:00
Jared Wein
9506c850a9 Bug 1559303 - Set the fill color of the Lockwise logo from CSS so it will be visible in light and dark mode. r=JSON_voorhees
Differential Revision: https://phabricator.services.mozilla.com/D36190

--HG--
extra : moz-landing-system : lando
2019-06-28 20:08:06 +00:00
Masayuki Nakano
15b95c47c4 Bug 1444847 - part 6: Make HTMLEditRules::PinSelectionToNewBlock() use StaticRange instead of nsRange for temporary use r=smaug
This patch makes `HTMLEditRules::PinSelectionToNewBlock()` use `StaticRange`
instead of `nsRange` for comparing a point and a range (i.e., the DOM tree
won't be changed during it's alive).  Unfortunately, we still have allocation
cost, but we can save the cost of registering and unregistering mutation
observer and computing common ancestor of the range.

Differential Revision: https://phabricator.services.mozilla.com/D35145

--HG--
extra : moz-landing-system : lando
2019-06-28 07:50:34 +00:00
jaril
6e05066510 Bug 1548369 - Render an SVG in the gap between the token and the preview where it shouldn't unrender the preview right away (WIP)
Still WIP

Differential Revision: https://phabricator.services.mozilla.com/D34910

--HG--
extra : moz-landing-system : lando
2019-06-28 21:17:51 +00:00
Boris Zbarsky
b9289cedad Bug 1560055 part 7. Remove now-unused percentage handling in ParseHTMLInteger. r=mccr8
All callers treat '%' being found the same as not having consumed all the input,
so we can just stop consuming it.

Differential Revision: https://phabricator.services.mozilla.com/D36214

--HG--
extra : moz-landing-system : lando
2019-06-28 17:39:52 +00:00
Boris Zbarsky
9abd9bd6cd Bug 1560055 part 6. Add a test for reflection of percentage values and fix our one failure there. r=mccr8
Our new behavior should align with the Blink/WebKit behavior and the current
spec, though I also filed https://github.com/whatwg/html/issues/4737 on the spec
for the fact that dimension attributes reflecting as integers is a bit weird

Differential Revision: https://phabricator.services.mozilla.com/D36130

--HG--
extra : moz-landing-system : lando
2019-06-28 21:01:35 +00:00
Boris Zbarsky
4530e9a97e Bug 1560055 part 5. Fix various reflection cases that should be using GetUnsignedIntAttr but are using GetIntAttr. r=mccr8
It mostly works out, because we return an int32_t then just cast it to uint32_t,
but it would be better to return the right thing to start with.

Differential Revision: https://phabricator.services.mozilla.com/D36129

--HG--
extra : moz-landing-system : lando
2019-06-28 20:57:44 +00:00
Boris Zbarsky
7719c7c3c4 Bug 1560055 part 4. Remove remaining uses of ParseSpecialIntValue. r=mccr8
We don't need to parse 'width' on <tr> because we never use the parsed value for
anything and neither does the spec.

We don't need to parse 'charoff' on <col> because we never use that for anything
either, and neither does the spec.

Differential Revision: https://phabricator.services.mozilla.com/D36128

--HG--
extra : moz-landing-system : lando
2019-06-28 21:00:15 +00:00
Boris Zbarsky
3dd95a2c8f Bug 1560055 part 3. Switch various "width" and "height" attributes on HTML elements to mostly follow the spec for parsing the attribute. r=mccr8
The spec allows non-integer values, but we don't have a good way to store them
in nsAttrValue yet.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1561440

HTMLTableCellElement::MapAttributesIntoRule can now call
MapImageSizeAttributesInto instead of manually mapping width and height, because
0 values (which it was excluding before) are now excluded at attribute parse
time.

For 'width' on HTMLTableElement I kept our old behavior for 0, which matches the spec
but not Safari or Chrome.

For 'height' on HTMLTableElement I kept our old behavior for 0, which matches
Safari and Chrome but not the spec.  https://github.com/whatwg/html/issues/4715
tracks a possible spec change.

Same thing for 'height' on HTMLTableRowElement.

Same thing for 'width' on HTMLTableColElement.

The ParseImageAttribute call in HTMLMediaElement is not needed, because
HTMLAudioElement does not map any of those to style and HTMLVideoElement only
maps width/height, which it already parses.

Differential Revision: https://phabricator.services.mozilla.com/D36127

--HG--
extra : moz-landing-system : lando
2019-06-28 20:56:55 +00:00
Boris Zbarsky
2e218ac638 Bug 1560055 part 2. Switch frame/iframe marginwidth/height parsing to follow the spec. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D36126

--HG--
extra : moz-landing-system : lando
2019-06-28 20:54:30 +00:00
Boris Zbarsky
a19c0f7558 Bug 1560055 part 1. Introduce a function to do what the HTML spec calls "parsing dimension values". r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D36125

--HG--
extra : moz-landing-system : lando
2019-06-28 20:49:48 +00:00
Valentin Gosu
8c3c48e159 Bug 1551601 - When performing a cross process redirect update the loadInfo to have the correct browsingContext r=nika
Differential Revision: https://phabricator.services.mozilla.com/D35839

--HG--
extra : moz-landing-system : lando
2019-06-28 21:10:13 +00:00