In the existing test, we also check expanding a node, as well as navigating
with the keyboard.
Differential Revision: https://phabricator.services.mozilla.com/D47272
--HG--
extra : moz-landing-system : lando
The actors weren't ever removed from the state,
which could lead to increased memory consumption
as well as attempt to release the actors a
second time in some cases.
We fix this by dispatching a new actions once
the actors are released, so we can remove them
from the state.
Depends on D47271
Differential Revision: https://phabricator.services.mozilla.com/D47411
--HG--
extra : moz-landing-system : lando
When using the ObjectInspector in an inspector extension sidebar,
document is not an HTMLDocument but a Sandbox, which means we
don't have access to the same properties than in a document.
Since the Tree and the ObjectInspector components do use `document`
and `window`, this means some interaction would lead to the sidebar
crashing.
To prevent this, we retrieve the document and/or the window from
a node reference instead.
Differential Revision: https://phabricator.services.mozilla.com/D47271
--HG--
extra : moz-landing-system : lando
Depends on D47051.
Without the trait, we keep calling the connect() wrapper on the actor, which is supposed to be deprecated
Differential Revision: https://phabricator.services.mozilla.com/D47053
--HG--
extra : moz-landing-system : lando
Depends on D47050. Trait was added in 2017, all servers should now have support this by default
Differential Revision: https://phabricator.services.mozilla.com/D47051
--HG--
extra : moz-landing-system : lando
This flips the default for security.tls.version.min to 3 (TLS 1.2) for the
Nightly channel.
Having had this pref at this level for the last year, I can confirm that this
does break the occasional site, but it is quite rare. The intent of this change
is to start making it more obvious when sites don't support TLS 1.2.
I'm asking for wider review because this is a disruptive change.
Differential Revision: https://phabricator.services.mozilla.com/D45627
--HG--
extra : moz-landing-system : lando
The last update of the CodeMirror library introduced new
CSS selectors in the css file with a greater specificity than
they used to, which means the color property we set in our
themes css files weren't applied.
We change the selectors in our theme files so they are more
specific than the ones in codemirror's css file.
Differential Revision: https://phabricator.services.mozilla.com/D47291
--HG--
extra : moz-landing-system : lando
In /devtools/client/storage/ui.js, handleChangedItems and handleDeletedItems should only JSON.parse string keys related to the indexedDB and Cache actors.
The string keys used by all the other storage actors are expected to be a simple string keys, and their valid values include strings that can be successfully parsed as JSON (e.g. "123" or "null" are both valid keys for the storage items related to the localStorage, extensionStorage etc.).
Differential Revision: https://phabricator.services.mozilla.com/D45197
--HG--
extra : moz-landing-system : lando
Bug 1553804 made opening a content page from a Chrome
document a no-op, which broke the deprecation warning
in the Scratchpad window.
We switch to a JS solution using openDocLink on link
click.
I tried playing with rel=noopener, but the opened link
was about:blank for some reason I can't explain.
Differential Revision: https://phabricator.services.mozilla.com/D47214
--HG--
extra : moz-landing-system : lando
Depends on D46584
The initial issue seems caused by inserting a test image in the top document of the browser.
This forces the toolbox to move upwards and shrinks the content page. Since one of the tests relies on taking full page screenshots and comparing their size with the size of the content page, this can lead to test failures.
To fix the issue, we will insert the image in the content page instead of inserting it in the browser's document.
Differential Revision: https://phabricator.services.mozilla.com/D46585
--HG--
extra : moz-landing-system : lando
Even though we still need to fix those awaits, this removes the need to use the pref in 3 tests.
We should ultimately investigate why our switchHost/createHost can sometimes resolve too early and make the tests fail.
Differential Revision: https://phabricator.services.mozilla.com/D46584
--HG--
extra : moz-landing-system : lando
Otherwise, what happens in documents like the webconsole is the theme file gets loaded before
global.css, which isn't the intended behavior and makes overriding the styles from global.css
more difficult. As an example, some buttons in the webconsole became stretched after Bug 1581914
changed some default styling in global.css. This patch restores the correct behavior by loading
the theme afer global.css.
global.css is currently loaded in devtools in docs that explicitly use XUL elements (such as storage inspector
and style editor), and in docs that need to be supported as top level windows (webconsole, toolbox, and
browser toolbox). Unless if we change how things like panels and context menus are styled, the latter
group will continue to need to load global.css even as XUL/XBL usage goes away (since they are styled
with global.css).
Differential Revision: https://phabricator.services.mozilla.com/D46530
--HG--
extra : moz-landing-system : lando
We need to attach the thread actor as soon as the toolbox start.
To:
* know when the thread is paused, even if the debugger isn't opened
* report paused state by changing the debugger icon
* switch to the debugger on pause
This will also fix some other code, like in the console, which
expect the Thread actor to be attached and already inspecting
the debugged target's globals.
Differential Revision: https://phabricator.services.mozilla.com/D44638
--HG--
extra : moz-landing-system : lando
Checking this browserloader is important in particular for the inspector, which uses it to load all its own react components.
Differential Revision: https://phabricator.services.mozilla.com/D46769
--HG--
extra : moz-landing-system : lando
