Commit Graph

17787 Commits

Author SHA1 Message Date
Brian Hackett
1cd0fb99fd Bug 1581418 - Include more properties when logging objects, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45961

--HG--
rename : devtools/client/webreplay/mochitest/browser_dbg_rr_console_warp-03.js => devtools/client/webreplay/mochitest/browser_rr_object_preview-01.js
extra : moz-landing-system : lando
2019-09-16 22:48:15 +00:00
Zibi Braniecki
e0cdd093e0 Bug 1581204 - Remove unused DTDs from devtools. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D45899

--HG--
extra : moz-landing-system : lando
2019-09-16 19:41:44 +00:00
Micah Tigley
c76a5272d4 Bug 1581155 - Fix flashing a CSS property from box-model link. r=gl
In this revision, mimic flashing a property element like in the markup view.

Differential Revision: https://phabricator.services.mozilla.com/D45884

--HG--
extra : moz-landing-system : lando
2019-09-16 14:07:04 +00:00
Gabriel Luong
4a1c59f251 Bug 1500142 - Remove inspector bindings from toolbox. r=yulia,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D40320

--HG--
extra : moz-landing-system : lando
2019-09-16 17:39:42 +00:00
Rob Wu
64ad4811f6 Bug 1570715 - Treat (deprecation) warnings as errors r=rpl
Add new preference `extensions.webextensions.warnings-as-errors` that
defaults to `true` in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

As part of the refactor, log entries for schema entries that contain
`"onError": "warn"` will now be prefixed by "Warning" instead of
"Error", to be consistent with the change from bug 1495908.

Differential Revision: https://phabricator.services.mozilla.com/D40548

--HG--
extra : moz-landing-system : lando
2019-09-16 16:35:59 +00:00
Nicolas Chevobbe
765b39cd6d Bug 1572980 - Fix browser_jsterm_autocomplete-properties-with-non-alphanumeric-names intermittent. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D46026

--HG--
extra : moz-landing-system : lando
2019-09-16 14:29:03 +00:00
Maxime Vaillancourt
19b3bd3cde Bug 1567859 - Add missing separator after computed style filter. r=gl
Add missing separator after computed style filter

Differential Revision: https://phabricator.services.mozilla.com/D45777

--HG--
extra : moz-landing-system : lando
2019-09-15 20:06:24 +00:00
Nicolas Chevobbe
8be561cece Bug 1577798 - Don't create a new Debugger instance in WebConsoleActor. r=ochameau,jlast.
Previously, when creating a new WebConsoleActor, we were
also creating a new Debugger instance.
The problem was that we would never call `enable` on it,
which is what allows to create debuggee for all existing
globals, and for the ones that will be created after.
This means that we had multiple workaround to get a
global debuggee, and in the case of function, would add
a global as a debuggee only to get its script location.

This patch remove the creation of the new Debugger,
and retrieve the parent actor Debugger instance instead.

This shuffles things around a bit, are the Debugger instance
was created by the ThreadActor, but is now by the target
actor (BrowsingContext, ContentProcess, ...).

We can then remove the now unused `getGlobalDebugObject`
hooks we were using in the Function previewer, as we
get a proper Debugger object, with the script location.

Differential Revision: https://phabricator.services.mozilla.com/D44480

--HG--
extra : moz-landing-system : lando
2019-09-16 12:12:22 +00:00
Ola Gasidlo
ea28744160 Bug 1580826 - Ensure awaiting on fetchManifest before closing tab, r=yulia
Intermittent devtools/client/application/test/browser/browser_application_panel_sidebar.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn2.child1/manifestActor19, type fetchCanonicalManifest failed

Differential Revision: https://phabricator.services.mozilla.com/D46001

--HG--
extra : moz-landing-system : lando
2019-09-16 11:55:50 +00:00
Noemi Erli
2c99088968 Bug 1581472 - ES lint fix CLOSED TREE 2019-09-16 13:45:49 +03:00
Sorin Davidoi
b7d09ae90b Bug 1580490 - Load search worker on demand. r=Honza
Load search worker on demand

Differential Revision: https://phabricator.services.mozilla.com/D45538

--HG--
extra : moz-landing-system : lando
2019-09-16 10:31:42 +00:00
Emilio Cobos Álvarez
8349d49124 Bug 1581472 - Only treat CSS parser errors as CSS errors. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45986

--HG--
extra : moz-landing-system : lando
2019-09-16 10:12:47 +00:00
Daisuke Akatsuka
7934273827 Bug 713106: Add test for visited element. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45807

--HG--
extra : moz-landing-system : lando
2019-09-16 09:53:32 +00:00
Daisuke Akatsuka
d2d8fffbd5 Bug 713106: Lock/unlock :visited pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45805

--HG--
extra : moz-landing-system : lando
2019-09-13 22:12:29 +00:00
Daisuke Akatsuka
409a2bc885 Bug 713106: Make :visited selector enabled to use from DevTools. r=pbro,emilio
Differential Revision: https://phabricator.services.mozilla.com/D45624

--HG--
extra : moz-landing-system : lando
2019-09-13 22:12:12 +00:00
Daisuke Akatsuka
ef36d9df93 Bug 713106: Show :visited rule while the pseudo is locked. r=pbro,emilio
Differential Revision: https://phabricator.services.mozilla.com/D45623

--HG--
extra : moz-landing-system : lando
2019-09-13 22:11:58 +00:00
Brian Hackett
c5861a20a0 Bug 1581434 - Convert new console message arguments into the proper format, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45967

--HG--
extra : moz-landing-system : lando
2019-09-16 03:18:11 +00:00
Brian Hackett
52bb5d1e45 Bug 1579654 - Use old set of scripts if reparsing for breakpoint positions fails, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45965

--HG--
extra : moz-landing-system : lando
2019-09-16 03:17:23 +00:00
Brian Hackett
b08a3cc809 Bug 1581013 - Support event logpoints when replaying, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45778

--HG--
extra : moz-landing-system : lando
2019-09-16 00:12:34 +00:00
Gurzau Raul
f195a247dd Backed out changeset 1bed7919ff1e (bug 1580890) frequently failing browser_dbg-debug-line.js (bug 1581026) 2019-09-15 03:21:27 +03:00
Brian Hackett
67035f9e70 Bug 1580104 - Send record/replay messages atomically, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45934

--HG--
extra : moz-landing-system : lando
2019-09-14 14:03:16 +00:00
Miriam
57718b6d7a Bug 1574192 - Initial watchpoints front end commit. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D43487

--HG--
extra : moz-landing-system : lando
2019-09-14 14:13:54 +00:00
Narcis Beleuzu
1cb9dbb638 Backed out 2 changesets (bug 1570715) for causing tp6m raptor failures
Backed out changeset e7364a10a663 (bug 1570715)
Backed out changeset 51824b1dda97 (bug 1570715)
2019-09-14 16:00:00 +03:00
Micah Tigley
c1ddfa4079 Bug 1581059 - Fix networking throttling dropdown menu UI. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45876

--HG--
extra : moz-landing-system : lando
2019-09-13 17:43:57 +00:00
Michael Ratcliffe
eb70def3e1 Bug 1579058 - [Inactive CSS] Remove invalidProperties from CSS validator r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D45852

--HG--
extra : moz-landing-system : lando
2019-09-13 14:12:52 +00:00
Julian Descottes
1dc087a788 Bug 1557083 - Emit actions from netmonitor store after requests are blocked/unblocked r=Honza
Depends on D45498
This makes the test run fine on top of the changes for the session history rewrite.

Differential Revision: https://phabricator.services.mozilla.com/D45499

--HG--
extra : moz-landing-system : lando
2019-09-13 13:38:03 +00:00
Julian Descottes
fa1aa153b3 Bug 1557083 - Webconsole actor should wait for block/unblock requests to be processed by netmonitors r=nchevobbe,Honza
Depends on D45497

Differential Revision: https://phabricator.services.mozilla.com/D45498

--HG--
extra : moz-landing-system : lando
2019-09-13 13:37:41 +00:00
Julian Descottes
bdb6e996db Bug 1557083 - Add thunk middleware to netmonitor; r=Honza
This middleware will be useful to wait for actions from tests

Differential Revision: https://phabricator.services.mozilla.com/D45497

--HG--
extra : moz-landing-system : lando
2019-09-13 13:37:22 +00:00
Jan Odvarko
8102c31740 Bug 1560421 - No frames are displayed for some WS connections r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D45164

--HG--
extra : moz-landing-system : lando
2019-09-13 12:55:43 +00:00
Belén Albeza
48e2a4a481 Bug 1566022 - Add "open json" link to the manifest r=Ola,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D45348

--HG--
extra : moz-landing-system : lando
2019-09-13 11:27:29 +00:00
Rob Wu
75fd473720 Bug 1570715 - Treat (deprecation) warnings as errors r=rpl
Add new preference `extensions.webextensions.warnings-as-errors` that
defaults to `true` in tests. Tests that expect warnings are modified
to briefly flip the pref for the specific part of the test that needs
an exception.

As part of the refactor, log entries forschema entries that contain
`"onError": "warn"` will now be prefixed by "Warning" instead of
"Error", to be consistent with the change from bug 1495908.

Differential Revision: https://phabricator.services.mozilla.com/D40548

--HG--
extra : moz-landing-system : lando
2019-09-12 21:39:51 +00:00
Ciure Andrei
a70e37b142 Backed out 3 changesets (bug 1557083) for causing browser_net_block.js to perma fail CLOSED TREE
Backed out changeset 82611a6d116f (bug 1557083)
Backed out changeset 576da2d2bf32 (bug 1557083)
Backed out changeset 613f24ecf1c3 (bug 1557083)
2019-09-13 12:49:35 +03:00
Michael Ratcliffe
e181ff7977 Bug 1552146 - [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44846

--HG--
extra : moz-landing-system : lando
2019-09-12 10:14:34 +00:00
Julian Descottes
d7dd56640d Bug 1557083 - Emit actions from netmonitor store after requests are blocked/unblocked r=Honza
Depends on D45498
This makes the test run fine on top of the changes for the session history rewrite.

Differential Revision: https://phabricator.services.mozilla.com/D45499

--HG--
extra : moz-landing-system : lando
2019-09-13 08:39:54 +00:00
Julian Descottes
b1aeba486c Bug 1557083 - Webconsole actor should wait for block/unblock requests to be processed by netmonitors r=nchevobbe,Honza
Depends on D45497

Differential Revision: https://phabricator.services.mozilla.com/D45498

--HG--
extra : moz-landing-system : lando
2019-09-13 08:14:19 +00:00
Julian Descottes
170c8259b5 Bug 1557083 - Add thunk middleware to netmonitor; r=Honza
This middleware will be useful to wait for actions from tests

Differential Revision: https://phabricator.services.mozilla.com/D45497

--HG--
extra : moz-landing-system : lando
2019-09-11 09:28:31 +00:00
Nicolas Chevobbe
2f8760ac4b Bug 1570476 - Don't fetch the request stacktrace in StackTracePanel's componentWillReceiveProps if the request won't change. r=Honza.
This was causing an intermittent in console test because
multiple requests were sent to the server, and sometimes,
some of them after the connection being closed, which
was making the test fail.
With this patch, we only try to fetch a new stacktrace
on componenetWillReceiveProps if the component will have
to deal with a new request.

Differential Revision: https://phabricator.services.mozilla.com/D45808

--HG--
extra : moz-landing-system : lando
2019-09-13 08:21:31 +00:00
Nicolas Chevobbe
90cc5901b8 Bug 1517411 - Add test cases for globalThis in js-property-provider test. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D45632

--HG--
extra : moz-landing-system : lando
2019-09-13 08:29:13 +00:00
Nicolas Chevobbe
d31e32951a Bug 1581033 - Fix browser_console_open_or_focus intermittent. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D45801

--HG--
extra : moz-landing-system : lando
2019-09-13 08:22:50 +00:00
Jason Laster
1a291f1700 Bug 1110276 - Log on Events. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45619

--HG--
extra : moz-landing-system : lando
2019-09-13 02:37:08 +00:00
Jason Laster
19d13244b1 Bug 1580529 - Force LTR the Outline panel contents in the Debugger (fix test) r=jlast. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D45760

--HG--
extra : rebase_source : 613e7725e5cbfa069dd86f7afb6788983329b094
extra : histedit_source : 758f1b90b07666f3f1c49a774f6b208e46752222
2019-09-13 02:11:50 +03:00
Itiel
3f7c740857 Bug 1580529 - Force LTR the Outline panel contents in the Debugger r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45554

--HG--
extra : moz-landing-system : lando
2019-09-12 21:54:49 +00:00
David Walsh
7eb854230e Bug 1580890 - Restructure inline-preview action for better performance r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45702

--HG--
extra : moz-landing-system : lando
2019-09-12 21:51:45 +00:00
Julian Descottes
73a8e158b7 Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D45448

--HG--
extra : moz-landing-system : lando
2019-09-12 19:57:44 +00:00
Micah Tigley
2107eab165 Bug 1363970 - Disable touch simulation when color picker is active. r=gl,rcaliman
This patch manually disables touch simulation in places where the color picker is enabled. Alternatively, doing this from InspectorActor's `pickColorFromPage` method requires that we get the associated RDM emulationActor for the tab, which turned out to be more complicated than I thought.

Getting and setting the picker state on the emulation factor retrieved via `getActorByID` does not match the emulationActor handling the touch events. So setting the picker state is indeed working it's just not setting it on the correct one. I'm unsure of how to go about this as the RDM emulationActor and the Inspector actor are entirely separate of each other.

So for now, we disable touch simulation in places where color picker is being enabled. Let me know what you think about this @pbro and @gl .

Differential Revision: https://phabricator.services.mozilla.com/D45593

--HG--
extra : moz-landing-system : lando
2019-09-12 18:20:39 +00:00
Brad Werth
6d3b2babbc Bug 1567310 Part 4: Add a test that whitespace frames are not created by opening the inspector. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45257

--HG--
extra : moz-landing-system : lando
2019-09-12 19:06:09 +00:00
Brad Werth
df189909f4 Bug 1567310 Part 3: Make all devtools callers of getBoxQuads include option to suppress whitespace frames. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45120

--HG--
extra : moz-landing-system : lando
2019-09-12 19:05:52 +00:00
Sorin Davidoi
4bb2a97856 Bug 1580485 - Start search worker on lazily. r=jlast
Took care to only call .task once. Maybe it would be nice to move this functionality inside `WorkerDispatcher`?

Differential Revision: https://phabricator.services.mozilla.com/D45534

--HG--
extra : moz-landing-system : lando
2019-09-12 18:41:51 +00:00
Coroiu Cristina
b7a3c598ec Backed out changeset 0a227ecdcca5 (bug 1580485) for debugger failure on a CLOSED TREE 2019-09-12 21:20:32 +03:00
Sorin Davidoi
f783c40e10 Bug 1579990 - Start pretty print worker lazily. r=jlast,Honza
Start pretty print worker only when pretty printing for the first time.

Differential Revision: https://phabricator.services.mozilla.com/D45241

--HG--
extra : moz-landing-system : lando
2019-09-12 16:40:36 +00:00
Sorin Davidoi
c9a76c17f4 Bug 1580485 - Start search worker on lazily. r=jlast
Took care to only call .task once. Maybe it would be nice to move this functionality inside `WorkerDispatcher`?

Differential Revision: https://phabricator.services.mozilla.com/D45534

--HG--
extra : moz-landing-system : lando
2019-09-12 16:31:38 +00:00
Logan Smyth
62539da15f Bug 1580645 - Ensure that node removal only removes mutation BPs in subtree. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44296

--HG--
extra : moz-landing-system : lando
2019-09-12 15:33:51 +00:00
David Walsh
d8814e5764 Bug 1580636 - Set inline preview left before injection r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45606

--HG--
extra : moz-landing-system : lando
2019-09-12 14:29:31 +00:00
Razvan Maries
197ecba57e Backed out changeset c7e276985276 (bug 1580636) for ES Lint failure. CLOSED TREE 2019-09-12 17:08:46 +03:00
David Walsh
8f28239f59 Bug 1580636 - Set inline preview left before injection r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45606

--HG--
extra : moz-landing-system : lando
2019-09-12 02:52:27 +00:00
Ola Gasidlo
caf9aff884 Bug 1565213 - Add routing for sidebar component, r=ladybenko
Add routing for sidebar component

Differential Revision: https://phabricator.services.mozilla.com/D43726

--HG--
extra : moz-landing-system : lando
2019-09-12 12:55:46 +00:00
Mark Banner
efc1831d10 Bug 1330148 - Remove no-iterator ESLint exclusions on devtools since there are no violations now. r=jdescottes
Depends on D45400

Differential Revision: https://phabricator.services.mozilla.com/D45401

--HG--
extra : moz-landing-system : lando
2019-09-12 08:02:40 +00:00
Gabriel Luong
039a070103 Bug 1580545 - Convert ResponsiveUI and ResponsiveUIManager to ES6 classes. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D45566

--HG--
extra : moz-landing-system : lando
2019-09-11 18:51:35 +00:00
jaril
240a0d48f8 Bug 1567966 - Add search to event listener breakpoints panel. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D42436

--HG--
extra : moz-landing-system : lando
2019-09-11 18:55:20 +00:00
Gabriel Luong
dcd3f3a19f Bug 1580312 - Refactor ResponsiveUI into its own module. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D45443

--HG--
rename : devtools/client/responsive/manager.js => devtools/client/responsive/ui.js
extra : moz-landing-system : lando
2019-09-10 21:36:07 +00:00
Jason Laster
43f6a1b816 Bug 1580362 - Rewinding while recording should rewind to the last breakpoint. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45473

--HG--
extra : moz-landing-system : lando
2019-09-11 04:16:15 +00:00
Jason Laster
6dd9c29f22 Bug 1579658 - Hovering on the console jump button should update the viewport. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45133

--HG--
extra : moz-landing-system : lando
2019-09-11 03:43:30 +00:00
Jason Laster
c91c3ac848 Bug 1578602 - Update buttons ux. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45131

--HG--
extra : moz-landing-system : lando
2019-09-11 15:58:22 +00:00
Yura Zenevich
92b64e718f Bug 1578494 - make MOUSE_INTERACTIVE_ONLY failure check less strict and only look at click action. r=nchevobbe
Depends on D45217

Differential Revision: https://phabricator.services.mozilla.com/D45218

--HG--
extra : moz-landing-system : lando
2019-09-11 08:04:40 +00:00
Yura Zenevich
1ed731d560 Bug 1578494 - ignore images inside anchors for semantic check as they get a propagated jump action. r=nchevobbe
Depends on D45216

Differential Revision: https://phabricator.services.mozilla.com/D45217

--HG--
extra : moz-landing-system : lando
2019-09-11 13:59:23 +00:00
Yura Zenevich
d7ee1a870c Bug 1578494 - ignore valid labels with "label for" relations as they are clickable. r=nchevobbe
Depends on D45215

Differential Revision: https://phabricator.services.mozilla.com/D45216

--HG--
extra : moz-landing-system : lando
2019-09-10 15:48:25 +00:00
Yura Zenevich
9e5e47e8ff Bug 1578494 - separate accessible roles into the ones that are expected to be interactive from keyboard accessible ones, better account for ARIA comboboxes and listboxes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45215

--HG--
extra : moz-landing-system : lando
2019-09-11 14:09:03 +00:00
Yura Zenevich
fa78314c8f Bug 1578494 - include ROLE_PARENT_MENUITEM (currently selected/visible menu item) into a set of interactive roles. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45214

--HG--
extra : moz-landing-system : lando
2019-09-10 14:14:52 +00:00
lloan
99deab0f74 Bug 1580188 - Not all search matches are highlighted. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D45483

--HG--
extra : moz-landing-system : lando
2019-09-11 08:24:58 +00:00
championshuttler
c3c60ddbbf Bug 1555022 - Remove unused methods on the Thread Actor. r=jdescottes,jlast
Differential Revision: https://phabricator.services.mozilla.com/D44957

--HG--
extra : moz-landing-system : lando
2019-09-10 22:01:36 +00:00
Andreea Pavel
6e69d0b776 Backed out changeset 977f72dc221a (bug 1578602) dt failures at browser_parsable_css on a CLOSED TREE 2019-09-11 05:43:33 +03:00
Razvan Maries
d12d589b73 Backed out changeset b93f753ddfe4 (bug 1579658) for ES Lint failure. CLOSED TREE 2019-09-11 04:50:58 +03:00
David Walsh
2abded43f8 Bug 1580006 - Make inline preview for exceptions look better r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45252

--HG--
extra : moz-landing-system : lando
2019-09-10 23:26:38 +00:00
Jason Laster
eac3fce446 Bug 1579658 - Hovering on the console jump button should update the viewport. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45133

--HG--
extra : moz-landing-system : lando
2019-09-11 00:04:03 +00:00
Brian Hackett
e66f14695f Bug 1580104 Part 1 - Fix various control logic bugs, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45464

--HG--
extra : moz-landing-system : lando
2019-09-10 22:14:16 +00:00
Jason Laster
2286b78600 Bug 1578602 - Update buttons ux. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45131

--HG--
extra : moz-landing-system : lando
2019-09-11 00:16:21 +00:00
Boris Chiou
4db87c1296 Bug 1574222 - Serialize getComputedStyle on text-decoration properly. r=emilio,dholbert
The wpt will be updated in
https://github.com/web-platform-tests/wpt/pull/18866.

Besides, there are some other test cases use text-decoration, so we
have to update them as well. The rule is: if the test case is not related to
old `text-decoration` longhand, we use `text-decoration-line` instead.
If the test case is for testing the change of `text-decoration` from
longhand to shorthand, we should use the correct serialization.

Differential Revision: https://phabricator.services.mozilla.com/D44909

--HG--
extra : moz-landing-system : lando
2019-09-10 21:52:26 +00:00
Jason Laster
7e368acde2 Bug 1580064 - Replace ObjectInspector symbol with better delimeter. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45286

--HG--
extra : moz-landing-system : lando
2019-09-10 22:47:42 +00:00
Razvan Maries
6d72ae6fae Backed out changeset 8695461482b4 (bug 1580006) for ES Lint failure. CLOSED TREE 2019-09-11 00:41:19 +03:00
Brian Hackett
5ac4e26c13 Bug 1577881 - Watch out for dead windows in getAllWindowDebuggees, r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D45114

--HG--
extra : moz-landing-system : lando
2019-09-10 19:11:15 +00:00
David Walsh
092a5bfa5d Bug 1580006 - Make inline preview for exceptions look better r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D45252

--HG--
extra : moz-landing-system : lando
2019-09-10 17:54:57 +00:00
Dorel Luca
18f6607ceb Bug 1557985 - Disable browser_orientationchange_event.js in Linux opt for frequent failures. r=gbrown
Type a message here

Differential Revision: https://phabricator.services.mozilla.com/D45314

--HG--
extra : moz-landing-system : lando
2019-09-10 15:35:43 +00:00
Jan Odvarko
e5d8c5ba59 Bug 1578215 - DAMP Perf regression in netmonitor har export test (+12%); r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D44437

--HG--
extra : moz-landing-system : lando
2019-09-10 12:04:51 +00:00
Sorin Davidoi
a74f789b09 Bug 1575413 - Implement sorting for Last-Modified and Content-Length response headers. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D45134

--HG--
extra : moz-landing-system : lando
2019-09-10 10:01:13 +00:00
Mihai Alexandru Michis
4941b2389f Merge mozilla-central to autoland. 2019-09-10 13:00:45 +03:00
Mihai Alexandru Michis
588814f2ed Merge inbound to mozilla-central. a=merge 2019-09-10 12:55:33 +03:00
lloan
ddca7eac70 Bug 1580030 - Inline highlights for search matches have too much padding. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D45277

--HG--
extra : moz-landing-system : lando
2019-09-10 09:52:48 +00:00
Gurzau Raul
dd736a1b8a Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-09-10 06:32:42 +03:00
Jason Laster
17db683395 Bug 1579576 - Fix browser_dbg_rr_breakpoints-07.js. r=bhackett
Reviewers: bhackett

Reviewed By: bhackett

Bug #: 1579576

Differential Revision: https://phabricator.services.mozilla.com/D45237

--HG--
extra : rebase_source : 0cd551281b3d161f6916420babdc208571c26a46
2019-09-10 03:52:39 +03:00
Miriam
01f4ef904a Bug 1574190 - Add watchpoints trait to browsingContextTargetPrototype and remove from RootActor r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45206

--HG--
extra : moz-landing-system : lando
2019-09-09 17:30:31 +00:00
Brian Hackett
e08826d6d1 Bug 1579562 - Take snapshots at frame entry when gathering pause data in the frame, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45145

--HG--
extra : moz-landing-system : lando
2019-09-09 16:28:25 +00:00
Jason Laster
a2304c7a65 Bug 1580033 - Fix saveAs. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D45265

--HG--
extra : moz-landing-system : lando
2019-09-09 23:28:36 +00:00
Brian Hackett
80421ff6e7 Bug 1579749 - Decouple checkpoints and snapshots, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45141

--HG--
extra : moz-landing-system : lando
2019-09-09 03:33:22 +00:00
David Walsh
d9ce406a8a Bug 1532139 - Add keyboard shortcut open debugger r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D41415

--HG--
extra : moz-landing-system : lando
2019-09-09 17:54:53 +00:00
David Walsh
3c257e4da5 Bug 1579951 - Clean up debugger footer CSS r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45226

--HG--
extra : moz-landing-system : lando
2019-09-09 19:41:31 +00:00
David Walsh
89b1aada0a Bug 1579913 - Use CodeMirror Operations to improve inline preview performance r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45212

--HG--
extra : moz-landing-system : lando
2019-09-09 19:04:18 +00:00
Greg Tatum
e6f2eda3d9 Bug 1579530 - Validate the popup preferences; r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D45077

--HG--
extra : moz-landing-system : lando
2019-09-09 18:19:50 +00:00
Jason Laster
e6d87de2fe Bug 1578672 - do not resurrect self-hosted urls. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D45107

--HG--
extra : moz-landing-system : lando
2019-09-07 00:09:17 +00:00
Bogdan Tara
48004c2667 Backed out changeset 941fe2efca5d (bug 1579913) for ES lint failure on InlinePreviews.js CLOSED TREE 2019-09-09 21:41:43 +03:00
David Walsh
a3ec84f090 Bug 1579913 - Use CodeMirror Operations to improve inline preview performance r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45212

--HG--
extra : moz-landing-system : lando
2019-09-09 17:30:08 +00:00
yulia
2c4b5e048f Bug 1579052 - use relative nodeFront walker in markup view; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D44822

--HG--
extra : moz-landing-system : lando
2019-09-09 15:23:55 +00:00
yulia
5080ab0860 Bug 1579053 - use relative nodeFront's target in pageStyles; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D44821

--HG--
extra : moz-landing-system : lando
2019-09-09 15:13:20 +00:00
Ola Gasidlo
46b7824f47 Bug 1565212 Create sidebar component, r=ladybenko,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43593

--HG--
extra : moz-landing-system : lando
2019-09-09 11:55:00 +00:00
Nicolas Chevobbe
0c958321fc Bug 1577786 - Write a mochitest to add a content object in the sidebar in Fission Browser Console. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44978

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_context_menu_object_in_sidebar.js => devtools/client/webconsole/test/browser/browser_console_content_object_in_sidebar.js
extra : moz-landing-system : lando
2019-09-09 10:02:55 +00:00
Brindusan Cristian
020e9de6e6 Backed out 2 changesets (bug 1565212) for linting failure on application.ftl:116:2. CLOSED TREE
Backed out changeset dc67f09ede45 (bug 1565212)
Backed out changeset f21e8b5c98f0 (bug 1565212)
2019-09-09 13:38:04 +03:00
Narcis Beleuzu
541d75e8ff Bug 1565212 - Fix lint failure. r=cbrindusan. CLOSED TREE
--HG--
extra : histedit_source : a1311182574d6adeb28be2d2a7b18fad1a02ad15
2019-09-09 13:17:51 +03:00
Ola Gasidlo
182e11e2ae Bug 1565212 Create sidebar component, r=ladybenko,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D43593

--HG--
extra : moz-landing-system : lando
2019-09-09 09:49:28 +00:00
Belén Albeza
c0e809a1a7 Bug 1572482 - Refetch manifest when reloading or navigating to a new page r=Ola
Differential Revision: https://phabricator.services.mozilla.com/D45003

--HG--
extra : moz-landing-system : lando
2019-09-09 09:26:17 +00:00
Nicolas Chevobbe
b4de2bd22f Bug 1579422 - Disconnect FilterBar resize observer when observed node is disconnected. r=jdescottes.
Since we don't properly unmount the Console React app,
FilterBar's componentWillUnmount is never called.
This was where we planned to disconnect the resize observer,
but it was in fact never called.
So what we do in this patch instead is in the resize observer
callback, check if the observed node is connected, and if
it's not, we disconnect the resize observer.

This prevent the console from dispatching an action, that
may slow down closing the console.

Differential Revision: https://phabricator.services.mozilla.com/D45006

--HG--
extra : moz-landing-system : lando
2019-09-09 09:05:08 +00:00
Daisuke Akatsuka
4be488567a Bug 1456167: Add test for CSS variable which can be color. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44944

--HG--
extra : moz-landing-system : lando
2019-09-09 07:02:51 +00:00
Daisuke Akatsuka
74a38cdb47 Bug 1456167: Support color swatch for css variable which can be color. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D44943

--HG--
extra : moz-landing-system : lando
2019-09-06 15:39:18 +00:00
Nicolas Chevobbe
f4e52015fa Bug 1577781 - Add a Browser Console test to expand a longstring coming from content process. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44980

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_longstring.js => devtools/client/webconsole/test/browser/browser_console_content_longstring.js
extra : moz-landing-system : lando
2019-09-06 14:44:54 +00:00
lloan
cde4de2557 Bug 1572138 - Introduce status bar for the search side panel. r=Honza,flod.
Differential Revision: https://phabricator.services.mozilla.com/D44997

--HG--
extra : moz-landing-system : lando
2019-09-09 06:43:50 +00:00
Daisuke Akatsuka
e5569f5821 Bug 1572933: Add a test whether DevTools loads from the cache even during disabling the cache. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44627

--HG--
extra : moz-landing-system : lando
2019-09-09 00:57:12 +00:00
Daisuke Akatsuka
a65bd31ef9 Bug 1572933: Introduce an attribute to raise the cache priority. r=pbro,mayhemer
For now, when we turn on `disable cache` switch in DevTools[1], web page loads
the contents without using the cache. Furthermore, DevTools as well comes to
load the contents DevTools inspects without using the cache. And, if the loaded
contents from the web page and DevTools was different, becomes impossible to
inspect the content correctly.
Thus, in order to make DevTools refer the same content the web page loaded,
makes DevTools load the contents inspecting from the cache at first, no matter
if disables the switch or not.

When turns on disable cache in DevTools, `LOAD_BYPASS_CACHE` flag is set into
`loadFlags` in the `docshell`.[2] The other hand, the content DevTools inspects
is loaded from a channel DevTools creates with `LOAD_FROM_CACHE` flag.[3]
However, because this channel is belong to same `loadGroup` of the `docshell`,
`LOAD_BYPASS_CACHE` is inherited and is choosen even if `LOAD_FROM_CACHE` is set.
Thus, in this patch, we introduce an attribute `preferCacheLoadOverBypass`
which raises the priority for `LOAD_FROM_CACHE` above `LOAD_BYPASS_CACHE` and
`LOAD_BYPASS_LOCAL_CACHE`.

[1] https://developer.mozilla.org/en-US/docs/Tools/Settings#Advanced_settings
[2] https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1227
[3] https://searchfox.org/mozilla-central/source/devtools/shared/DevToolsUtils.js#542-544

Differential Revision: https://phabricator.services.mozilla.com/D44626

--HG--
extra : moz-landing-system : lando
2019-09-09 00:57:05 +00:00
Noemi Erli
d988a687b9 Backed out 9 changesets (bug 1578623) for causing Windows build bustages CLOSED TREE
Backed out changeset 52a86c60c866 (bug 1578623)
Backed out changeset e4fddd3d24b4 (bug 1578623)
Backed out changeset 65a7c4daec27 (bug 1578623)
Backed out changeset 3badf9215788 (bug 1578623)
Backed out changeset 71e58ee8f684 (bug 1578623)
Backed out changeset 0128e12a910f (bug 1578623)
Backed out changeset 8242877392bd (bug 1578623)
Backed out changeset 6d7be8a22f8b (bug 1578623)
Backed out changeset 3be609a9be36 (bug 1578623)

--HG--
extra : amend_source : b76d374926d247982773b58d12cb26e33d9972e8
2019-09-09 03:37:09 +03:00
Karl Tomlinson
8b101b80b5 Bug 1578623 add test for syntax errors and uncaught exceptions in worklet scripts r=bhackett
Depends on D44611

Differential Revision: https://phabricator.services.mozilla.com/D44612

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_worker_error.js => devtools/client/webconsole/test/browser/browser_webconsole_worklet_error.js
extra : moz-landing-system : lando
2019-09-08 23:44:05 +00:00
Sonia Singla
6837c2f38c Bug 1569044 - Change background colour. r=Honza
When toolbar is wrapped onto two rows, the second row to have white background, class `devtools-input-toolbar` is being added up
onto `devtools-toolbar devtools-input-toolbar`

Differential Revision: https://phabricator.services.mozilla.com/D42665

--HG--
extra : moz-landing-system : lando
2019-09-08 07:17:44 +00:00
Brian Hackett
5e57aa68b6 Bug 1579583 - Restore repaint() manifest handler, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45123

--HG--
extra : moz-landing-system : lando
2019-09-07 00:40:27 +00:00
Brian Hackett
69a17508bf Bug 1576689 - Support logPoints with multiple arguments, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45116

--HG--
extra : moz-landing-system : lando
2019-09-06 23:35:34 +00:00
David Walsh
0c095e92ed Bug 1579548 - Remove no longer used download-anchor class r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45089

--HG--
extra : moz-landing-system : lando
2019-09-06 22:18:59 +00:00
Brian Hackett
518fed5491 Bug 1579319 - Distinguish objects and frames from different locations, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D44936

--HG--
extra : moz-landing-system : lando
2019-09-06 21:19:30 +00:00
Brian Hackett
560029c0e1 Bug 1579325 - Fix test failure, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D45054

--HG--
extra : moz-landing-system : lando
2019-09-06 18:35:37 +00:00
Jason Laster
bf78b08020 Bug 1553210 - Implement clearing pending breakpoints and add tests. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44295

--HG--
extra : moz-landing-system : lando
2019-09-06 19:10:27 +00:00
Brindusan Cristian
f2aabeaa59 Backed out changeset 3182a1d6debb (bug 1500142) for xpcshell failures at test_oob_cert_auth.js. CLOSED TREE 2019-09-06 23:05:31 +03:00
Jason Laster
bc31321ff9 Bug 1579379 - Debugger infinite hang when hovering over variables. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D45039

--HG--
extra : moz-landing-system : lando
2019-09-06 17:35:48 +00:00
Miriam
9b093489d4 Bug 1574190 - Add watchpoint as a trait in the server, remove watchpoints when object actor is released, add watchpoint to property descriptor object r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D45044

--HG--
extra : moz-landing-system : lando
2019-09-06 18:12:06 +00:00
Gabriel Luong
1ba46b8359 Bug 1500142 - Remove inspector bindings from toolbox. r=ochameau,yulia
Differential Revision: https://phabricator.services.mozilla.com/D40320

--HG--
extra : moz-landing-system : lando
2019-09-06 18:18:04 +00:00
Chris Muldoon
c6a70aafed Bug 1576798 - Changed css box length of Watch Expression pane r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44863

--HG--
extra : moz-landing-system : lando
2019-09-06 17:57:41 +00:00
Nicolas Chevobbe
fe325dcf21 Bug 1578675 - Make the Browser Toolbox console UI similar to Browser Console's one. r=Honza.
We are now showing the "Show content messages" checkbox, as well
as removing the "Persist logs" one.

Differential Revision: https://phabricator.services.mozilla.com/D44637

--HG--
extra : moz-landing-system : lando
2019-09-06 13:38:37 +00:00
Nicolas Chevobbe
3020c6904b Bug 1579366 - Update completion text when autocomplete is disabled and popup isn't opened. r=Honza.
If the user triggered a force autocomplete (with Ctrl + Space)
that would result in having only the completion text, writing another
letter wouldn't update the completion text, that could then lead
into having an erroneous expression in the input.
This patch fixes this issue and add a test case to make sure we
don't regress this.

Differential Revision: https://phabricator.services.mozilla.com/D44976

--HG--
extra : moz-landing-system : lando
2019-09-06 13:35:55 +00:00
Yura Zenevich
2b061cd207 Bug 1578494 - when checking for mouse only interactivity, add additional checks for text leafs and showlongdesc actions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D44868

--HG--
extra : moz-landing-system : lando
2019-09-06 12:24:18 +00:00
Belén Albeza
be69e3d5eb Bug 1577484 - Part 2: Hide ManifestLoader when not needed, add a link to ManifestEmpty r=Ola,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D44669

--HG--
extra : moz-landing-system : lando
2019-09-06 11:16:13 +00:00
Belén Albeza
bcd927a4ce Bug 1577484 - Part 1: Use async actions with thunk middleware for loading a manifest r=jdescottes,Ola
Differential Revision: https://phabricator.services.mozilla.com/D44668

--HG--
extra : moz-landing-system : lando
2019-09-06 10:34:36 +00:00
Alexandre Poirot
cc2c969ee7 Bug 1568840 - Use PageStyle from the currently selected element in the computed view. r=pbro,jdescottes
Make the PageStyleFront be a singleton managed by the inspector front,
like highlighters and walker.
It helps keep the Computed View code synchronous as it is highly sensible
to race condition. A simple event loop spin make a throw during tests.

Differential Revision: https://phabricator.services.mozilla.com/D44445

--HG--
extra : moz-landing-system : lando
2019-09-06 08:12:46 +00:00
lloan
383995b276 Bug 1575180 - Support for case sensitive search. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D44085

--HG--
extra : moz-landing-system : lando
2019-09-06 08:26:06 +00:00
Nicolas Chevobbe
eac86b480c Bug 1578681 - Lighten background of buttons in dark mode. r=fvsch.
Differential Revision: https://phabricator.services.mozilla.com/D44770

--HG--
extra : moz-landing-system : lando
2019-09-06 07:00:02 +00:00
Daisuke Akatsuka
e3584dcd2b Bug 1571942: Add a test for inspector shortcut in case that other tool is selected. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D44773

--HG--
extra : moz-landing-system : lando
2019-09-06 03:25:58 +00:00
Daisuke Akatsuka
990e565c09 Bug 1571942: Avoid to raise the toolbox whenever the shortcut key of inspector was typed. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D44772

--HG--
extra : moz-landing-system : lando
2019-09-06 03:25:43 +00:00
Karl Tomlinson
5f12a1a635 Bug 1578623 ignore self-hosted frames when testing console message stack line numbers r=bhackett
Line numbers in self-hosted frames are not controlled by the test.

Depends on D44610

Differential Revision: https://phabricator.services.mozilla.com/D44611

--HG--
extra : moz-landing-system : lando
2019-09-04 16:36:38 +00:00
Jason Laster
6e5a3a9907 Bug 1578606 - Fix jest. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44591

--HG--
rename : devtools/client/debugger/flow-typed/npm-custom/devtools-shared-utils_vx.x.x.js => devtools/client/debugger/flow-typed/npm-custom/devtools-modules_vx.x.x.js
extra : moz-landing-system : lando
2019-09-05 20:38:25 +00:00
Julien Wajsberg
234d224715 Bug 1578354 - Remove the obsolete condition so that JS frames are now properly filtered in in the call tree r=gregtatum
Bug 1557789 added categories to all JS frames, so as a result JS frames
where all filtered out because of the condition removed in this patch.
This condition is basically a premature optimization, removing it
shouldn't bring any behavior difference.

Differential Revision: https://phabricator.services.mozilla.com/D44803

--HG--
extra : moz-landing-system : lando
2019-09-05 15:20:36 +00:00
Jason Laster
06b1d905ee Bug 1569829 - Opening a code-heavy file hangs to do 6 reflows with heavy codemirror computations. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44729

--HG--
extra : moz-landing-system : lando
2019-09-05 15:10:59 +00:00
Mihai Alexandru Michis
a3f69d49df Backed out 2 changesets (bug 1578215) for causing damp failures at netmonitor/simple.js CLOSED TREE
Backed out changeset d17910e8fe6a (bug 1578215)
Backed out changeset a99353211255 (bug 1578215)
2019-09-05 23:48:17 +03:00
Gabriel Luong
b676bac12f Bug 1579150 - Remove the RDM Settings Onboarding tooltip. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D44876

--HG--
extra : moz-landing-system : lando
2019-09-05 19:13:11 +00:00
Mihai Alexandru Michis
98aef7b8a0 Bug 1578215 - Fix linting error on devtools/client/netmonitor/src/api.js a=lint-fix. CLOSED TREE 2019-09-05 21:22:09 +03:00
Jan Odvarko
dfef1c3407 Bug 1578215 - DAMP Perf regression in netmonitor har export test (+12%); r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D44437

--HG--
extra : moz-landing-system : lando
2019-09-05 17:43:23 +00:00
Chris Muldoon
f58863b070 Bug 1577295 - Change color and appearance of font in paused error reason for improved readabiity r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44766

--HG--
extra : moz-landing-system : lando
2019-09-05 15:10:14 +00:00
Alexandre Poirot
16d1ac6011 Bug 1578426 - Rename CssRuleView.target to currentTarget. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D44633

--HG--
extra : moz-landing-system : lando
2019-09-05 14:17:27 +00:00
Alexandre Poirot
2987ab1345 Bug 1578426 - Rename Inspector.target to Inspector.currentTarget. r=pbro
Rename this attribute to better significate that the target is
changing over time when the debugged target navigates to another process.

Differential Revision: https://phabricator.services.mozilla.com/D44632

--HG--
extra : moz-landing-system : lando
2019-09-05 14:17:20 +00:00
Nicolas Chevobbe
4bf8a96317 Bug 1578676 - Add missing separator left to the show content messages checkbox. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44636

--HG--
extra : moz-landing-system : lando
2019-09-05 09:24:25 +00:00
Nicolas Chevobbe
49076a161e Bug 1578665 - Create a dedicated pref for Browser Console editor state. r=Honza.
We want the Browser Console and WebConsole to have
distinct preferences, so you might have one in
editor mode, and the other one in inline mode if
you want.
This is as simple as adding the preference, and
stripping the devtools.webconsole. prefix in
the constant we use for retrieving the preference
value.

Differential Revision: https://phabricator.services.mozilla.com/D44631

--HG--
extra : moz-landing-system : lando
2019-09-05 09:23:47 +00:00
tanhengyeow
34a4c4cb17 Bug 1561873 - Support for keyboard navigation in WS frame list. r=Honza
Support for keyboard navigation in WS frame list.

Differential Revision: https://phabricator.services.mozilla.com/D42897

--HG--
extra : moz-landing-system : lando
2019-09-05 07:59:18 +00:00
Greg Tatum
2ebfd4a2eb Bug 1575682 - Stop the profiler popup from "blipping" with unrendered content r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43121

--HG--
extra : moz-landing-system : lando
2019-09-04 20:06:37 +00:00
Greg Tatum
89ca6aada1 Bug 1575682 - Add a mechanism for the popup to signal that its size has changed r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43116

--HG--
extra : moz-landing-system : lando
2019-09-04 20:06:29 +00:00
Greg Tatum
db7a4dcd82 Bug 1575682 - Rename the recording buttons, and add a cancel button r=julienw
This is broken out into a separate commit since it is a layout change
for the DevTools as well. Note, that this area is still not localized.

Differential Revision: https://phabricator.services.mozilla.com/D43120

--HG--
extra : moz-landing-system : lando
2019-09-04 20:06:06 +00:00
Greg Tatum
93aa558934 Bug 1575682 - De-duplicate the profiler popup code r=julienw
This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.

Differential Revision: https://phabricator.services.mozilla.com/D43119

--HG--
rename : devtools/client/performance-new/popup/popup.html => devtools/client/performance-new/popup/popup.xhtml
extra : moz-landing-system : lando
2019-09-04 20:05:52 +00:00
Greg Tatum
2dc86d9090 Bug 1575682 - Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw
This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D43118

--HG--
extra : moz-landing-system : lando
2019-09-04 20:05:38 +00:00
Greg Tatum
8d2804eb1f Bug 1575682 - Bridge the perf actor so that it can be reused with the popup r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43117

--HG--
extra : moz-landing-system : lando
2019-09-04 20:05:18 +00:00
David Walsh
79b6f9ba3d Bug 1576163 - Prevent line shifting from inline preview r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D44687

--HG--
extra : moz-landing-system : lando
2019-09-04 16:46:56 +00:00
Brindusan Cristian
971c2dc9aa Merge inbound to mozilla-central. a=merge 2019-09-04 19:26:46 +03:00
Brindusan Cristian
87d0935891 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-09-04 12:48:38 +03:00
Cosmin Sabou
c310c938df Bug 1542144 - Annotate test on fission cause on debug failures. r=pbone
Differential Revision: https://phabricator.services.mozilla.com//D44584
2019-09-04 03:10:04 +03:00
Noemi Erli
7a9186aefb Backed out changeset 55386bf32ae0 (bug 1578606) for devtools failures
--HG--
rename : devtools/client/debugger/flow-typed/npm-custom/devtools-modules_vx.x.x.js => devtools/client/debugger/flow-typed/npm-custom/devtools-shared-utils_vx.x.x.js
2019-09-04 05:23:11 +03:00
Jason Laster
7ea67f4d41 Bug 1578606 - Fix jest. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D44591

--HG--
rename : devtools/client/debugger/flow-typed/npm-custom/devtools-shared-utils_vx.x.x.js => devtools/client/debugger/flow-typed/npm-custom/devtools-modules_vx.x.x.js
extra : moz-landing-system : lando
2019-09-04 00:56:52 +00:00
David Walsh
7f20101b2a Bug 1573859 - Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast,flod
Differential Revision: https://phabricator.services.mozilla.com/D43682

--HG--
extra : moz-landing-system : lando
2019-09-03 19:08:39 +00:00
Julian Descottes
4eb51d8fe8 Bug 1578361 - removed unused localTransport getter on debugger-client r=ladybenko
This was initially added in Bug 907755 for old telemetry probes.

Differential Revision: https://phabricator.services.mozilla.com/D44444

--HG--
extra : moz-landing-system : lando
2019-09-04 11:15:40 +00:00
Nicolas Chevobbe
d0413845a9 Bug 1577780 - Add test for invoking getter in content object from Browser Console. r=Honza.
We're re-using the test we already have for invoking getters
in the webconsole as it is checking a lot of different cases.

Differential Revision: https://phabricator.services.mozilla.com/D44628

--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_getters.js => devtools/client/webconsole/test/browser/browser_console_content_getters.js
extra : moz-landing-system : lando
2019-09-04 09:03:44 +00:00
Nicolas Chevobbe
01653665f2 Bug 1578660 - Add missing key on EditorToolbar in App.js .r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44630

--HG--
extra : moz-landing-system : lando
2019-09-04 09:09:24 +00:00
Nicolas Chevobbe
010f6b2666 Bug 1578283 - Don't scroll jsterm viewport when inserting a tab character. r=Honza.
When we wanted to insert a string in the webconsole input,
we were setting the input value, and setting the cursor
manually. But since the editor setCursor function is calling
alignLine, there could be cases where the editor scroll position
would jump, feeling awkward for the user.
It turns out we can simplify this code a lot since codeMirror
provides a replaceRange function, which is a perfect replacement
for what we were using, without having to manage the cursor position.

The only downside to that is that inserting characters this
way *does* fire a `changes` event, that we are listening to
in the JsTerm to request autocompletion (which we don't need
as we only insert characters when accepting a completion or
adding a tab).
To mitigate that, we pass a specific jsterm origin string to
replaceRange, which let's us discriminate in the changes event
listener if those changes originate from jsterm only actions.

A test is added to ensure this works as expected (the test was
failing without the fix).

Differential Revision: https://phabricator.services.mozilla.com/D44466

--HG--
extra : moz-landing-system : lando
2019-09-04 09:02:09 +00:00
lloan
9a09073dc7 Bug 1572144 - Support search result navigation. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D43555

--HG--
extra : moz-landing-system : lando
2019-09-04 08:31:45 +00:00
Julian Descottes
fdea67edb5 Bug 1273656 - Add wait before trying to click in browser_html_tooltip-02.js r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D44356

--HG--
extra : moz-landing-system : lando
2019-09-04 07:52:21 +00:00
Emilio Cobos Álvarez
c850b60c69 Bug 1578565 - SVG and MathML elements don't follow the CSS layout model. r=pbro
We could be more explicit and also handle svg on the height / width stuff
(width and height don't apply to all SVG elements).

But this avoids the false positive for now.

Differential Revision: https://phabricator.services.mozilla.com/D44621

--HG--
extra : moz-landing-system : lando
2019-09-04 07:45:32 +00:00
janelledement
4b6fa71ccf Bug 1565715 - Stop preview highlight at non-element nodes.
By tweaking the while loop in addHighlightToTargetSiblings, the preview highlight will not continue beyond a non-text node. (Example in the case of a semi colon or a period.

Differential Revision: https://phabricator.services.mozilla.com/D44275

--HG--
extra : moz-landing-system : lando
2019-09-03 22:51:30 +00:00
Jason Laster
9d0541854d Bug 1575240 - inspect(x) should show x in the appropriate panel. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D42747

--HG--
extra : moz-landing-system : lando
2019-09-03 20:57:40 +00:00
chujun
8fb7ae2f24 Bug 1577376 - UI for disable debugger statement r=jlast
Add menu items to both secondary panel and editor
Add a mochitest
{F1539841}

Differential Revision: https://phabricator.services.mozilla.com/D44115

--HG--
extra : moz-landing-system : lando
2019-08-31 00:50:13 +00:00
Megan Bailey
63f09e5cee Bug 1491649 - Make useragent toolbar device and throlling select longer to display clearly. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D32346

--HG--
extra : moz-landing-system : lando
2019-09-03 18:12:35 +00:00
Megan Bailey
8fcd7c71a2 Bug 1542369 - Add method to highlight text if formTypes equals add. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D32510

--HG--
extra : moz-landing-system : lando
2019-09-03 18:11:39 +00:00
Maliha Islam
4922526a64 Bug 1567249 - Update a11y contrast calculation to make it work with applied simulation matrices, r=yzen,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D42417

--HG--
extra : moz-landing-system : lando
2019-09-03 05:39:18 +00:00
Jason Laster
f93e5fd1de Bug 1578252 - Highlight messages that are at the same location. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D44381

--HG--
extra : moz-landing-system : lando
2019-09-03 15:34:02 +00:00
arthur.iakab
e843afd6cd Backed out 6 changesets (bug 1575682) for causing devtools failures on browser_all_files_referenced.js CLOSED TREE
Backed out changeset 7e60a2013e96 (bug 1575682)
Backed out changeset c44c69605b87 (bug 1575682)
Backed out changeset abee6fadcd4d (bug 1575682)
Backed out changeset e4a75438c032 (bug 1575682)
Backed out changeset 985902e9abdb (bug 1575682)
Backed out changeset 31a67b9d47ab (bug 1575682)

--HG--
rename : devtools/client/performance-new/popup/popup.xhtml => devtools/client/performance-new/popup/popup.html
2019-09-03 21:01:24 +03:00
Noemi Erli
5dcfb63635 Backed out changeset 4e344973418a (bug 1572144) for failing in browser_accessibility_mutations.js CLOSED TREE 2019-09-03 20:12:10 +03:00
Razvan Maries
45a753ed46 Backed out changeset 05f1cba504d0 (bug 1573859) for perma fails on browser_misused_characters_in_strings.js. CLOSED TREE 2019-09-03 19:40:15 +03:00
Greg Tatum
b6c64887d8 Bug 1575682 - Stop the profiler popup from "blipping" with unrendered content r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43121

--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:09 +00:00
Greg Tatum
e898f6ca4c Bug 1575682 - Add a mechanism for the popup to signal that its size has changed r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43116

--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:07 +00:00
Greg Tatum
899de33c54 Bug 1575682 - Rename the recording buttons, and add a cancel button r=julienw
This is broken out into a separate commit since it is a layout change
for the DevTools as well. Note, that this area is still not localized.

Differential Revision: https://phabricator.services.mozilla.com/D43120

--HG--
extra : moz-landing-system : lando
2019-09-03 16:06:03 +00:00
Greg Tatum
adcb6873db Bug 1575682 - De-duplicate the profiler popup code r=julienw
This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.

Differential Revision: https://phabricator.services.mozilla.com/D43119

--HG--
rename : devtools/client/performance-new/popup/popup.html => devtools/client/performance-new/popup/popup.xhtml
extra : moz-landing-system : lando
2019-09-03 16:05:59 +00:00
Greg Tatum
39e7931b1e Bug 1575682 - Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw
This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D43118

--HG--
extra : moz-landing-system : lando
2019-09-03 16:05:55 +00:00
Greg Tatum
2da89fa0ed Bug 1575682 - Bridge the perf actor so that it can be reused with the popup r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D43117

--HG--
extra : moz-landing-system : lando
2019-09-03 16:04:22 +00:00
lloan
d8ffcbc0d8 Bug 1572144 - Support search result navigation. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D43555

--HG--
extra : moz-landing-system : lando
2019-09-03 15:55:02 +00:00
Jason Laster
a3fb20f8c6 Bug 1565375 - The pause overlay should include stepping buttons. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D43516

--HG--
extra : moz-landing-system : lando
2019-08-30 22:25:46 +00:00
David Walsh
e57f38026d Bug 1573859 - Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D43682

--HG--
extra : moz-landing-system : lando
2019-08-30 23:34:17 +00:00
Markus Stange
c32c68086c Bug 1566986 - Make getSymbols an async function so that callers always get a promise and never a synchronous exception. r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D44400

--HG--
extra : moz-landing-system : lando
2019-09-03 14:30:22 +00:00
Emma Malysz
392fe89b3a Bug 1569738, make PageInfo fission compatible r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D42978

--HG--
extra : moz-landing-system : lando
2019-08-29 20:31:19 +00:00
Nicolas Chevobbe
37211d770b Bug 1578389 - Fix propTypes error in console. r=Honza.
Fix 2 proptype errors: one in App.js, and the
other one in the renderStacktrace function,
that is called by Error rep.

Differential Revision: https://phabricator.services.mozilla.com/D44467

--HG--
extra : moz-landing-system : lando
2019-09-03 13:55:45 +00:00
Nicolas Chevobbe
7663347ad2 Bug 1578326 - Make history navigation icons same color as other icons in webconsole. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D44428

--HG--
extra : moz-landing-system : lando
2019-09-03 07:43:35 +00:00
Nicolas Chevobbe
9f40693a13 Bug 1577795 - Fix browser_webconsole_reverse_search_initial_value.js intermittent. r=Honza.
The failures were about pending requests to highlighters,
because we were logging node elements. Since we don't
really need to do that, we simply change the command
to not lod elements.

Differential Revision: https://phabricator.services.mozilla.com/D44367

--HG--
extra : moz-landing-system : lando
2019-09-03 07:43:33 +00:00
Jean-Yves Avenard
d65c5e0309 Bug 1556489 - P19. Fix devtools stack traces. r=honza,ochameau
DevTools rely on events when a new HttpChannel is opened, it needs to know when a DocumentChannel is.

Differential Revision: https://phabricator.services.mozilla.com/D40975
2019-09-03 10:19:46 +10:00
Jean-Yves Avenard
b43fd91ea2 Bug 1556489 - P11. Add nIIdentChannel interface. r=mayhemer
The devtools listens to http-on-opening-request event which is expected to receive a nsIHttpChannel. However future changes will make it that it's not always a nsIHttpChannel that can fire such event.

As such we create an intermediary interface nsIIdentChannel and move the subset generating such event in nsIHttpChannel there.

Differential Revision: https://phabricator.services.mozilla.com/D40968
2019-09-03 10:19:34 +10:00
Cosmin Sabou
fb4596cde5 Bug 1535451 - Skip browser_webconsole_trackingprotection_errors.js on fission. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D44094

--HG--
extra : moz-landing-system : lando
2019-09-02 12:03:10 +00:00