gecko uses IDXGIResource::GetSharedHandle(). But it is recommend not to use anymore to retrieve the handle to a shared resource.
IDXGIResource1::CreateSharedHandle() with D3D11_RESOURCE_MISC_SHARED_NTHANDLE flag should be used instead of the GetSharedHandle().
The CreateSharedHandle() could be called only once for a shared resource. Later calls fail.
HANDLEs of ID3D11Texture2D are replaced by gfx::FileHandleWrappers.
Differential Revision: https://phabricator.services.mozilla.com/D192173
Introduce a new global option in the tracer to log values.
For now, it only triggers javascript function call arguments to be logged,
but this will also impact the incoming feature logging native function calls,
and also the other incoming feature to log the returned values.
Differential Revision: https://phabricator.services.mozilla.com/D196019
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.
This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.
Differential Revision: https://phabricator.services.mozilla.com/D196020
Drop the requirement for disallowing additional properties in the order section as remote settings as its own properties, and this wasn't meant to be included.
We do check additional properties in xpcshell-tests, but need to allow for additional properties at runtime in case configurations are extended.
Depends on D196737
Differential Revision: https://phabricator.services.mozilla.com/D196738
Previously, given a string in element send keys, we iterated over each
UCS2 "character" in the string, so that non-BMP characters ended up as
separate key events, one for the high surrogate and one for the low
surrogate.
With this change we instead use the built in string iterator which
provides the surrogate pair in the case of non-BMP characters, so we
emit a single event for each unicode codepoint.
Differential Revision: https://phabricator.services.mozilla.com/D196220
Automatic update from web-platform-tests
[webnn] Add float32 tests for WebNN API argMin/Max ops (#43699)
* [webnn] Add float32 tests for WebNN API argMin/Max ops
* Update subtest's name for argMin/Max
--
wpt-commits: f5acfdeb64f6c7fa8d11bb3538e06b3f0ac3edff
wpt-pr: 43699
Automatic update from web-platform-tests
Fixed resize event to be fired on the appearance of scroll bar in iframe
Added check for change of scrollable area size in iframe
to make resize event fired on the appearance of scroll bar in iframe.
And added a test case to wpt.
Bug: 1487465
Change-Id: Ida82a010461ac6d856d879842d413bbbe19c67a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096173
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238373}
--
wpt-commits: a85f0dfe538b9cb894388a65dba7a2a21db050c7
wpt-pr: 43538
Automatic update from web-platform-tests
Run waitForCompositorReady after subframe loads in scroll-behavior WPT.
Based on local testing this appears to resolve two remaining failures
on the wpt.fyi dashboard for scroll-behavior-* which I thought had been
fixed by crrev.com/1234174.
It's a little unclear why it is needed since paint holding as described
in crbug.com/1509054 should only apply to the main frame. Some further
investigation will likely occur for crbug.com/888443.
Bug: 1489704
Change-Id: I95372952d8cfcb8357ab6619d8c51513b2bf5c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126617
Reviewed-by: David Awogbemila <awogbemila@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238312}
--
wpt-commits: 3fe62bd952884cba24393504813756b38dc64745
wpt-pr: 43696
Automatic update from web-platform-tests
[Grid] Honor the specified height of a subgrid in its contribution size
1. Fixing the behavior of `ContributionSizeForGridItem` where, similar
to CL:5109555, the contribution size of a subgrid in the block axis
was incorrectly assumed to always be its intrinsic size.
2. Removing dead code and updating the name of subgrid-specific methods
to better reflect their intention and scope.
3. Adding test coverage to the WPT suite for this issue.
Bug: 1475008
Change-Id: Ie9726866a5ab2b4f60e31a1cf1697d13ae28037f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5120550
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238255}
--
wpt-commits: 1b23add4f433ea6b092235c0cc2a67e712d2da2e
wpt-pr: 43685
Automatic update from web-platform-tests
Don't allow reportEvent() to send "reserved.*" events.
When calling `window.fence.reportEvent()` passing in just an eventType
string (i.e. the Private Aggregation path), it properly doesn't allow
sending "reserved.*" events, since those eventTypes should only be used
for automatic beacons. This check was never put in for the
`reportEvent()` path that takes in a FenceEvent. This CL adds that check
in place as well as browser-side verification to match what we do for
the Private Aggregation checks.
This CL also prevents registerAdBeacon() from registering a "reserved.*"
event that isn't already defined as a valid automatic beacon event.
Change-Id: I252a4bfa333f071f5f195c01a2e70cec5e7ec93f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5120095
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Cr-Commit-Position: refs/heads/main@{#1238247}
--
wpt-commits: 89945e7a2a610c737920f1c81484ed2b12d3a5bf
wpt-pr: 43650
Automatic update from web-platform-tests
[FLEDGE] Fix keys trustedBiddingSignalsSlotSizeMode uses.
The new trustedBiddingSignalsSlotSizeMode feature in Protected Audiences
appends query params containing ad slot size to trusted bidding signals
fetches. It currently appends "&slot-size=..." and
"&all-slots-requested-sizes=...".
All other query param names added by the Protected Audience API
use camel case, so those should be using camel case as well. This CL
renames them both.
There's one remaining comment in a mojom file that refers to the old
values that this CL doesn't fix, since that requires additional review.
Bug: 1512132
Change-Id: Iaa41334154e18eae26919d204006f974df1046c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5123157
Auto-Submit: Matt Menke <mmenke@chromium.org>
Reviewed-by: Russ Hamilton <behamilton@google.com>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1238205}
--
wpt-commits: f2e65e6194ed7218610a054663026c8114a07852
wpt-pr: 43694
Automatic update from web-platform-tests
Add the ability to parse META.yml files (#43394)
* Add the ability to parse META.yml files
Adds SchemaValue which is a container of helper functions to parse
different types of values for a given key - inspired by quicktype
Add validate_dict to ensure only the given keys in a dictionary are
allowed.
This functionality will be useful for other YAML files in the future.
* fix errors for older version of python
* simplify type hinting
* make key order deterministic
* move from_dict to SchemaValue
* add better typing
* catch yaml load exceptions
* use constructor
* fixup
* fixup
--
wpt-commits: ac2856143663f3ab5149f1795a578dc48d06a0f1
wpt-pr: 43394
Automatic update from web-platform-tests
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=260201 (#43651)
Size containment is supposed to size a box as if it had no content, so
for the purposes of grid layout this would mean that we would want to
skip parts of the algorithm that take into consideration the content.
The "Stretch auto Tracks," portion of the grid track sizing algorithm
should not be skipped, however, as it has nothing to do with the content
of the grid. We should be able to distribute any definite free space
that we computed up to this point.
--
wpt-commits: ccb431fd5075cf19bee842c3a8c4661f38d2a066
wpt-pr: 43651
Automatic update from web-platform-tests
vt: Fix bug in document-element-detatched-crash.html[sic]
This test performs actions after load but, per [1], crash tests will end
when the load event is reached. This CL adds 'test-wait' to ensure the
test code is run before the test terminates. Note, the class is removed
before the element since the test harness apparently won't finish on
element removal. This should be ok since the test harness apparently
has some asynchronicity in finishing the test.
Additionally, the test name has a typo (detatched --> detached) so PS1
renames the test. Diff from PS1 to see the test changes.
[1] https://web-platform-tests.org/writing-tests/crashtest.html
Bug: 1413903
Change-Id: I62854956c862788934ef5d7a6da602b2d446f2e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5122833
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238094}
--
wpt-commits: 1683fae2736da237ef600745a4aea47891bdadfc
wpt-pr: 43680
distutils.dir_util.copy_tree -> shutil.copytree
distutils.spawn.find_executable -> shutil.which
Also fix a warning about escape sequence in the process.
Differential Revision: https://phabricator.services.mozilla.com/D194781
It is disabled in this patch via the gfx.canvas.remote.allow-offscreen
pref. A follow up patch will enable this by default.
Differential Revision: https://phabricator.services.mozilla.com/D189532
This allows us to create a TextureClient on a different thread than the
actor without special effort on the part of the allocator. Similarly, it
also allows us to destroy a TextureClient on a different thread if it
has a readlock bound to it.
Differential Revision: https://phabricator.services.mozilla.com/D195123
If ImageBridgeChild is responsible for the textures being forwarded to
the compositor process, then the callback will happen on
ImageBridgeChild's thread instead of the main or DOM worker thread.
Differential Revision: https://phabricator.services.mozilla.com/D195121
Because we cannot control the ordering of shutdown notification from
WorkerRef, we need to choose one centralized point to begin shutdown of
the main thread or the owning DOM worker. Since there are other objects
owned by CanvasManagerChild, we also switch to a ThreadSafeWorkerRef.
Differential Revision: https://phabricator.services.mozilla.com/D195120
This patch makes the CanvasManagerChild creates/manager the
ActiveResourceTracker instead of the WebRenderBridgeChild. Since PCanvas
is now managed by PCanvasManager, and ActiveResourceTracker is only used
by the PCanvas recording plumbing, we need it on every thread that the
CanvasManagerChild can be created.
Differential Revision: https://phabricator.services.mozilla.com/D189529
This patch adds support for allocationg shmem sections for
ImageBridgeChild. The recording infrastructure depends on it.
Differential Revision: https://phabricator.services.mozilla.com/D189528
This patch allows us to create nsExpirationTracker objects off the main
thread, with the caveat that memory pressure events should/must be
handled directly by the creator rather than managed internally. With
that in mind, the threading assertions have also been updated to ensure
it is always the owning thread that accesses the tracker.
Differential Revision: https://phabricator.services.mozilla.com/D189527
This patch adds/updates the thread assertion plumbing for CanvasChild
and DrawEventRecorder to ensure that we are always accessing them on the
owning thread. It also now makes these checks compatible with running in
a DOM worker context for OffscreenCanvas using recordings.
Differential Revision: https://phabricator.services.mozilla.com/D189526
When pressing `ArrowLeft` key at:
```
<p>abc</p><p><span contenteditable=false>def</span>{}<br></p>
```
, caret is moved into the non-editable text because
`nsCaret::GetCaretFrameForNodeOffset` looks for a preceding text node from
the `BRFrame`. This is required if the preceding text node ends with a
collapsible white-space but followed by a `<br>` because the text frame
should not contain the white-space rect and `BRFrame` frame should be next
to it, i.e., the white-space looks like a overflown content.
So, for rendering a caret, the method needs to return non-editable text frame
even in the case, but for considering new caret position in the DOM tree, it
should not return non-editable text frame.
Therefore, this patch adds a param to `nsCaret::GetCaretFrameForNodeOffset()`
which forcibly return editable content frame or not and makes
`Selection::GetPrimaryOrCaretFrameForNodeOffset` call it with the new option
because its callers are the handler of caret navigation.
Differential Revision: https://phabricator.services.mozilla.com/D196259
