Summary:
the periodic file updates keep adding new reviews, and it's easy to fall behind.
This adjusts the script so it clears out any previous submissions that are still awaiting review.
Reviewers: jlorenzo
Reviewed By: jlorenzo
Bug #: 1452159
Differential Revision: https://phabricator.services.mozilla.com/D872
--HG--
extra : rebase_source : 4a36ddd91bf7e971fd6b424d02117bd4739a91ed
We'd really like the LiveSavedFrameCache to be able to assert that, if a frame
has its hasCachedSavedFrame bit set, there is indeed a cache entry for it (if
the cache hasn't been cleared completely for a compartment mismatch). See the
explanation of LiveSavedFrameCache in Stack.h, and the comments in
LiveSavedFrameCache::find.
Sometimes we do find a cache entry for the frame, but execution in that frame
has progressed to a different source position since we cached it, so the
SavedFrame in that cache entry isn't useful. When this occurs, we used to simply
pop the cache entry, and report a miss: although this did create a situation
where a frame with its bit set had no cache entry, that was only temporary: we
would push a new entry for the frame as we build the new SavedFrame chain.
Unless, of course, SavedFrame construction encounters an OOM and the whole
process aborts early.
This patch clears a frame's hasCachedSavedFrame bit when we report a cache miss
due to a pc mismatch. Under normal circumstances, the frame will soon be cached
again and its bit re-set. If an OOM does occur, the absence of the cache entry
is accurately reported.
--HG--
extra : rebase_source : 5e980e5732b7fd5ff1dd6a68c1a49a1c538010c6
extra : source : 2ed6d9d910b0f3dd24e163f17e3a70d327286582
This entails implementing corresponding methods on each variant of
FramePtr::Ptr.
--HG--
extra : rebase_source : 3b810cd4d3aa78d014f830acbf2d6e6794694415
extra : source : 014fdec944a9e82fd74e7ff4644cb4f9e96076c2
OOM tests often depend on invoking a function repeatedly, failing a different
allocation each time. Flushing the caches helps ensure consistent behavior from
one invocation to the next.
--HG--
extra : rebase_source : 0bf4a46c7c3e0bceb0fe77bbf96e422558a988c4
extra : source : 1a11067ab1e6b62602b79081e3208dcad31807bd
Note that on the new style system (a.k.a stylo) the test case hasn't caused
any assertions.
MozReview-Commit-ID: AALHnuW48Rb
--HG--
extra : rebase_source : 8253507eff2522bcc4ccc155aae5c1307a81421d
We don’t currently log what the script timeout was when throwing
ScriptTimeoutError. It would provide more value to the user to
include the timeout duration than to record "Timed out" as we do
currently.
MozReview-Commit-ID: 3DM1Xer3Qbz
--HG--
extra : rebase_source : 1c4dfc96957dd9b64562e8354526da1b7350e6cf
The Display trait implementation for ExitStatus returns "exit code:
0", leading to a convoluted sentence such as "Browser process
stopped with exit status exit code: 0".
MozReview-Commit-ID: 2D1JsFIhF7d
--HG--
extra : rebase_source : 044d1961485073a11aefc978eff3e382c59db4cc
