Commit Graph

656286 Commits

Author SHA1 Message Date
Alastor Wu
81efe13915 Bug 1557882 - part2 : add wpt 'start_alignment.html'. r=heycam
Add a new wpt 'start_alignment.html' to ensure that two cues would have different text alignment.

In addition, add `line:0` in vtt file to put cue on the top in order to reduce the complexity of using CSS to markup the test, because if we don't specifiy the postion for cue, those two cues won't be put the bottom of the video, instead they would be move upward one line above the bottom according to the spec.

The reason is that the base moving unit for adjusting cue box's position is the Bsize of the first line box, it would require extra moving if one cue contains two different cues which line boxes are not the same height.

Differential Revision: https://phabricator.services.mozilla.com/D34641

--HG--
extra : moz-landing-system : lando
2019-06-13 19:05:09 +00:00
Alastor Wu
0b9fc3bd0f Bug 1557882 - part1 : delay setting 'unicode-bidi' until finishing the position calculation. r=heycam
Because of bug1558431, now the text alignment for `bidi` won't take effect on the initial reflow of the document, so we have to delay setting 'unicode-bidi' in order to trigger reflow again as a workaround.

It would make the `bidi` text showing correctly after reflow.

Differential Revision: https://phabricator.services.mozilla.com/D34640

--HG--
extra : moz-landing-system : lando
2019-06-13 18:59:35 +00:00
Yury Delendik
827de35634 Bug 1555518 - Fixes original stack display for wasm files, and ref to original source. r=jlast
- Fixes expandFrames() to ensure the thread property is set
- Refactors getSourceLocationFromMouseEvent to use fromEditorLine
- Replaces dwarf_to_json (for proper DWARF conversion)

Differential Revision: https://phabricator.services.mozilla.com/D33092

--HG--
extra : moz-landing-system : lando
2019-06-13 18:02:14 +00:00
Marco Bonardo
c91a3fe44a * Bug 1557302 - Enter on a fully typed @alias should move the caret at the end. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D34908

--HG--
extra : moz-landing-system : lando
2019-06-13 16:54:23 +00:00
Brendan Dahl
fad31878d9 Bug 1552049 - Enable XUL persistence for all system privilege docs. r=smaug
Remove the mozpersist attribute and XULDocument requirement to use XUL
persistence and allow any system privilege document to use it by default.

Differential Revision: https://phabricator.services.mozilla.com/D34602

--HG--
extra : moz-landing-system : lando
2019-06-13 18:15:54 +00:00
Andrea Marchesini
7b8d04654c Bug 1559109 - Improve comments about StructuredCloneTags, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D34881

--HG--
extra : moz-landing-system : lando
2019-06-13 17:37:15 +00:00
Myk Melez
9c002b4396 Bug 1557161 - enable rkv consumers to migrate LMDB environments across architecture changes r=lina,keeler,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D33863

--HG--
extra : moz-landing-system : lando
2019-06-13 19:14:59 +00:00
Olli Pettay
ca30f8e0b0 Bug 1559207 - Make XULPersist::AttributeChanged a bit faster in the common case, r=bdahl
GetAttr returns false if the attribute isn't there at all.

Differential Revision: https://phabricator.services.mozilla.com/D34920

--HG--
extra : moz-landing-system : lando
2019-06-13 19:06:12 +00:00
Nika Layzell
d2fa23f7c9 Bug 1557730 - Enable HTTPResponseProcessSelection for windowProxy_transplant test, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D34907

--HG--
extra : moz-landing-system : lando
2019-06-13 18:09:22 +00:00
Andrea Marchesini
9023382549 Bug 1558923 - Remove nsContentUtils::GetThreadSafe{ASCII,UTF8}Origin, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34767

--HG--
extra : moz-landing-system : lando
2019-06-13 19:45:52 +00:00
Andrea Marchesini
7009293bd7 Bug 1558923 - Simplify URL API, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34766

--HG--
extra : moz-landing-system : lando
2019-06-13 19:45:19 +00:00
Brindusan Cristian
e6cda35f79 Backed out 2 changesets (bug 1550137) for bc failures at browser_masterPassword.js. CLOSED TREE
Backed out changeset d7b5c95addb1 (bug 1550137)
Backed out changeset db2092bd295b (bug 1550137)
2019-06-13 22:54:17 +03:00
Brindusan Cristian
a2461d871d Backed out changeset 3876241cc1ec (bug 1558506) for mochitest failrues at test_contextmenu_list.xul. CLOSED TREE 2019-06-13 22:52:41 +03:00
Narcis Beleuzu
01662f5eb8 Backed out changeset 62ac95a65617 (bug 1495621) for marionette mozprocess timed out failures. 2019-06-13 22:20:03 +03:00
Narcis Beleuzu
ed60adfc3c Backed out 5 changesets (bug 1510569) for bustages on BrowserChild.cpp . CLOSED TREE
Backed out changeset 4f0f5351be8b (bug 1510569)
Backed out changeset 14bbe0916bdd (bug 1510569)
Backed out changeset 19e734aeffa9 (bug 1510569)
Backed out changeset abb51690fd32 (bug 1510569)
Backed out changeset 1bf1907ee0c9 (bug 1510569)
2019-06-13 22:08:23 +03:00
alwu
2e33188362 Bug 1557548 - part2 : enable wpt 'navigate_cue_position.html'. r=heycam
Disable on Windows is because sometime iframe can't load successfully, which makes our test file showing wrong image.

Differential Revision: https://phabricator.services.mozilla.com/D34778

--HG--
extra : moz-landing-system : lando
2019-06-13 17:52:40 +00:00
alwu
f81594ca2d Bug 1557548 - part1 : remove 'controls' attribute from video. r=heycam
It's no need to add 'controls' attribute in this test because it's totally unrelated with navigation and we even have to add extra offset for the cue text in the reference file.

Differential Revision: https://phabricator.services.mozilla.com/D34777

--HG--
extra : moz-landing-system : lando
2019-06-13 17:52:33 +00:00
alwu
7ff878afe4 Bug 1555836 - use the pref to dynamically switch vtt debug log. r=heycam
It would be more convenient to use the pref to dynamically switch vtt debug log on/off without changing any code.

Differential Revision: https://phabricator.services.mozilla.com/D33220

--HG--
extra : moz-landing-system : lando
2019-06-13 18:43:08 +00:00
Barret Rennie
75f83f43fc Bug 1510569 - Port Content:LoadURIResult message to IPDL r=mconley
The `WebProgress#sendLoadCallResult` method only existed to send a empty async
message and was only called from the `WebNavigationChild`. Since
`WebNavigationChild` is in the process of being removed, it makes sense to
inline the replaced method into its call site.

Differential Revision: https://phabricator.services.mozilla.com/D34566

--HG--
extra : moz-landing-system : lando
2019-06-13 17:55:04 +00:00
Barret Rennie
37753c93de Bug 1510569 - Move Content:BrowserChildReady from WebProgressChild.jsm into the browser child frame script r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D34565

--HG--
extra : moz-landing-system : lando
2019-06-13 17:54:50 +00:00
Barret Rennie
37bd16225a Bug 1510569 - Order the RefreshBlocker's messages to the parent after the BrowserChild's r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D34564

--HG--
extra : moz-landing-system : lando
2019-06-13 17:54:35 +00:00
Barret Rennie
15c17bbb9f Bug 1510569 - Port onLocationChange notifications inside WebProgressChild.jsm to C++ r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D34563

--HG--
extra : moz-landing-system : lando
2019-06-13 17:54:23 +00:00
Barret Rennie
3630abbeca Bug 1510569 - Correctly reconstruct nsIRequest in tab parent r=Ehsan
When `TabParent::ReconstructWebProgressRequest` was introduced in
31b206e2046f63af31424489e3d61d7761805878, it mistakenly was unconditionally
constructing an `nsIRequest` from the received `RequestData`, even when the URI
was null.

Additionally `ReconstructWebProgressRequest` has been updated to use the Gecko
style for out parameters (accepting an `nsIFoo**` and passing
`getter_AddRefs(...)` instead of `nsCOMPtr<nsIFoo>&`).

Differential Revision: https://phabricator.services.mozilla.com/D34445

--HG--
extra : moz-landing-system : lando
2019-06-13 17:54:10 +00:00
Luca Greco
8628f0f273 Bug 1558540 - Show report checkbox in uninstall addon dialog only for supported addon types. r=jaws,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D34643

--HG--
extra : moz-landing-system : lando
2019-06-13 18:25:45 +00:00
Emilio Cobos Álvarez
7d1f93b8c6 Bug 1536871 - Make 'line-height: normal' return the 'normal' keyword from getComputedStyle() on Nightly and Early Beta, for now. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D25119

--HG--
extra : moz-landing-system : lando
2019-06-13 18:30:07 +00:00
Mike Conley
350ce5bb67 Bug 1558506 - Don't send a message for context menus when we know we don't want to open one. r=NeilDeakin
This fixes Bug 1558506 by making it so that the parent process ignores the context menu event
when right-clicking on the remote <browser> hosting the Add-on Options page. Before, we were
handling the event, stopping it from propagating and preventDefault'ing it, and then sending
a message to the parent that ultimately did nothing (since we knew that we didn't want to
display the context menu). Stopping propagation and preventDefault'ing meant that the event
was never fired in the Extension process for the options page.

With the parent process now returning early in the event that it knows that it doesn't want
to be the one to open the context menu, the underlying ContextMenuSpecialProcessChild can
handle the contextmenu event in the extension process, and do the right thing.

Differential Revision: https://phabricator.services.mozilla.com/D34901

--HG--
extra : moz-landing-system : lando
2019-06-13 18:23:41 +00:00
Chris Manchester
c74a1fa131 Bug 1558996 - Require rust 1.35 r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D34794

--HG--
extra : moz-landing-system : lando
2019-06-13 06:02:05 +00:00
Henrik Skupin
50f64995b8 Bug 1477977 - [wdspec] Add test to make sure "Switch To Window" keeps tab modal status between tabs. r=webdriver-reviewers,automatedtester
Differential Revision: https://phabricator.services.mozilla.com/D34140

--HG--
extra : moz-landing-system : lando
2019-06-07 13:34:45 +00:00
Henrik Skupin
5b1247be4e Bug 1477977 - [marionette] Support dynamic handling of modal dialogs and tab modal alerts. r=maja_zf
With this patch Marionette registers globally for the dialog notifications
and events while a session is active. Also it provides an interface for
custom dialog handlers to hook in.

Instead of the callbacks custom events could have been fired, but that would
be some more work, and should preferable be done in a follow-up bug.

Differential Revision: https://phabricator.services.mozilla.com/D34139

--HG--
extra : moz-landing-system : lando
2019-06-13 18:26:53 +00:00
Henrik Skupin
15d145a042 Bug 1477977 - [marionette] Handle "tabmodal-dialog-loaded" to observe new tab modal dialogs. r=maja_zf
Differential Revision: https://phabricator.services.mozilla.com/D34138

--HG--
extra : moz-landing-system : lando
2019-06-07 18:36:48 +00:00
Boris Chiou
36f22dc0e1 Bug 1543839 - Update test_interfaces.js for ResizeObserver. r=smaug
Drop nightly true because it is enabled on all versions.

Differential Revision: https://phabricator.services.mozilla.com/D34757

--HG--
extra : moz-landing-system : lando
2019-06-12 18:29:46 +00:00
Boris Chiou
b5d55c0966 Bug 1543839 - Enable ResizeObserver preference by default on all versions. r=dholbert
Reorder it alphabetically, and enable on beta/release.

Differential Revision: https://phabricator.services.mozilla.com/D33722

--HG--
extra : moz-landing-system : lando
2019-06-12 18:24:35 +00:00
Andreas Farre
922a3b8cbe Bug 1555287 - Make sure to detach browsing context children early. r=nika
Waiting for docshells and frameloaders to destroy will leave attached
browsing contexts attached too long. In case the children of a
browsing contexts cannot be cached we want to detach all of them as
soon as possible.

Also normalizes the use of BrowsingContext::mGroup.

Differential Revision: https://phabricator.services.mozilla.com/D33602

--HG--
extra : moz-landing-system : lando
2019-06-13 16:11:47 +00:00
Jared Wein
6dbc494407 Bug 1550137 - Change from aria-hidden to HTML5 hidden. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D34601

--HG--
extra : moz-landing-system : lando
2019-06-12 17:46:41 +00:00
Jared Wein
f32e91d391 Bug 1550137 - Import button for migrator in the about:logins menu. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D34600

--HG--
extra : moz-landing-system : lando
2019-06-12 17:46:43 +00:00
alwu
5e73cc45e1 Bug 1555197 - part5 : enable wpt 'track-webvtt-two-cue-layout-after-first-end.html'. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D32938

--HG--
extra : moz-landing-system : lando
2019-05-30 07:42:51 +00:00
alwu
e401f02324 Bug 1555197 - part4 : modify wpt 'track-webvtt-two-cue-layout-after-first-end.html' and 'track-webvtt-two-cue-layout-after-first-end-ref.html'. r=jya
For `track-webvtt-two-cue-layout-after-first-end.html`

(1) modify cue1's start time

According to the text track cue order [1], "cues must be sorted by their start time, earliest first; then, any cues with the same start time must be sorted by their end time, latest first".

This order also decides which cue we would display first. As this test would like show `cue1` at top and show another cue at bottom, we should modify cue1's `startTime` in order to put it before cue [0:3] in the cue list.

[1] https://html.spec.whatwg.org/multipage/media.html#text-track-cue-order

(2) listen for cue1's `exit`

As this cue would like to stop when the first cue ends, it should listen `exit` event.

---

For `track-webvtt-two-cue-layout-after-first-end-ref.html`, we should call `video.play()` in order to clear `show-poster` flag [2] and run `TimeMarchesOn` to show the cue.

If we didn't call it to reset the flag, we won't display any cue.

[2] https://html.spec.whatwg.org/multipage/media.html#playing-the-media-resource:show-poster-flag

Differential Revision: https://phabricator.services.mozilla.com/D32937

--HG--
extra : moz-landing-system : lando
2019-06-07 01:05:39 +00:00
alwu
4b5ebae438 Bug 1555197 - part3 : modify log. r=jya
Add and modify some log content in order to help debugging.

Differential Revision: https://phabricator.services.mozilla.com/D32936

--HG--
extra : moz-landing-system : lando
2019-05-30 07:39:40 +00:00
alwu
de12be8c5d Bug 1555197 - part2 : handle state REUSE AND CLEAR. r=heycam
According to the spec [1] step 13, if we won't reset cues' display state, we should reuse them.

If the amount of displaying cues changes, which means some cues should disappear from the screen and some of them should still be showed, we have to clear the screen and resume displaying cues' display state.

As the amount of displaying cues might affect the computed result of cues' display state, if we recompute cues' display state in this situaion, the result would be different from the one we had last time.

For example, there are two cues, Cue0 [0:2], Cue1 [1:5]. When Cue0 disappears, Cue1 should stay in the same position.

```
  [playing at 1s]
*-------------------*
|        Cue1       |
|        Cue0       |
*-------------------*

  [playing at 3s] (correct)
*-------------------*
|        Cue1       |
|                   |
*-------------------*

  [playing at 3s] (incorrect)
*-------------------*
|                   |
|        Cue1       |
*-------------------*
```

[1] https://w3c.github.io/webvtt/#rules-for-updating-the-display-of-webvtt-text-tracks

Differential Revision: https://phabricator.services.mozilla.com/D32935

--HG--
extra : moz-landing-system : lando
2019-06-13 18:03:32 +00:00
alwu
5e558f7e28 Bug 1555197 - part1 : introduce new state to distinguish different situations for showing cues' display state. r=heycam
Cue's display state is a DIV element with corresponding CSS style to display cue on the screen. When the cue is being displayed first time, we will compute its display state.

After that, we could reuse its state until following conditions happen.
(1) control changes : it means the rendering area changes so we should recompute cues' position.
(2) cue's `hasBeenReset` flag is true : it means cues' line or position property has been modified, we also need to recompute cues' position.
(3) the amount of showing cues changes : it means some cue would disappear but other cues should stay at the same place without recomputing, so we can resume their display state.

The new state includes `REUSE`, `REUSE AND CLEAR` and `COMPUTE AND CLEAR`, our current behavior doesn't handle `REUSE AND CLEAR, which would be implemented in next patch.

Differential Revision: https://phabricator.services.mozilla.com/D32934

--HG--
extra : moz-landing-system : lando
2019-06-13 17:56:43 +00:00
alwu
cabe387e46 Bug 1555825 - part2 - enable wpt 'track-cue-empty.html'. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D33216

--HG--
extra : moz-landing-system : lando
2019-06-13 15:42:19 +00:00
alwu
42a422a332 Bug 1555825 - part1 : append a text node with empty value when input is an empty string. r=heycam
According to the spec [1], text node has a value to represent its text, even when its text is an empty string.

Therefore, we should append a text node with a value for empty text string on the DocumentFragment we return, when input sting is an empty string.

[1] https://w3c.github.io/webvtt/#webvtt-text-object

Differential Revision: https://phabricator.services.mozilla.com/D33215

--HG--
extra : moz-landing-system : lando
2019-06-13 15:42:11 +00:00
Tom Schuster
03f9aefa9d Bug 1557736 - Manually fix some of the tests. r=jgraham
Depends on D34840

Differential Revision: https://phabricator.services.mozilla.com/D34841

--HG--
extra : moz-landing-system : lando
2019-06-13 17:14:39 +00:00
Tom Schuster
eb030068fb Bug 1557736 - Mechanical fix for polyglot HTML/JS tests. r=jgraham
This was done automatically by using the following script: https://gist.github.com/evilpie/50f63f485799c3ac9db3e93142562bca

Do note that this produces some buggy results, which I manually fixed in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D34840

--HG--
extra : moz-landing-system : lando
2019-06-13 17:14:56 +00:00
Narcis Beleuzu
8e2da98d46 Backed out 2 changesets (bug 1558923) for mochitest crashes on AssertIsOnMainThread(). CLOSED TREE
Backed out changeset 643de99320a8 (bug 1558923)
Backed out changeset f758b5ccd0c0 (bug 1558923)
2019-06-13 20:59:33 +03:00
Brindusan Cristian
9b7249b587 Backed out changeset ced634e12fc3 (bug 1533958) for xpcshell failures at test_ext_telemetry.js. CLOSED TREE 2019-06-13 20:29:19 +03:00
Brendan Dahl
8496f09e8e Bug 1558704 - Fix spellchecker when XUL is loaded as XHTML r=masayuki
Temporary workaround to use the document element as the root content node
in XHTML pages that have a XUL root element.

Differential Revision: https://phabricator.services.mozilla.com/D34657

--HG--
extra : moz-landing-system : lando
2019-06-13 11:53:12 +00:00
Jonathan Kew
d67f73d9bc Bug 1557044 - Don't eagerly load cmap of user font in gfxMacPlatformFontList::MakePlatformFont, let it load on first use like other platforms. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D33796

--HG--
extra : moz-landing-system : lando
2019-06-13 17:06:18 +00:00
Luca Greco
023205187f Bug 1549290 - Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r=robwu,aswan
Differential Revision: https://phabricator.services.mozilla.com/D34849

--HG--
extra : moz-landing-system : lando
2019-06-13 16:44:44 +00:00
Bob Clary
d8c7febb88 Bug 1522113 - schedule test-verify by test framework and directories rather than test source files, r=gbrown.
Differential Revision: https://phabricator.services.mozilla.com/D31622

--HG--
extra : moz-landing-system : lando
2019-05-17 22:29:33 +00:00