Commit Graph

8891 Commits

Author SHA1 Message Date
Eitan Isaacson
84896a7a88 Bug 1690342 - P1: Introduce moxAncestorSearch for finding ancestors. r=morgan DONTBUILD
It looks like we need to do this often. Adding it to the protocol/base class allows
us to not have to worry each time about typing and traversing past MOX accessibles.

Differential Revision: https://phabricator.services.mozilla.com/D103799
2021-02-08 23:26:24 +00:00
Paul Zuehlcke
cbda00d7e1 Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-02-05 13:40:42 +00:00
Tim Nguyen
864f262237 Bug 1691077 - Remove obsolete Fennec special case for nsDeckFrame a11y code. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D104240
2021-02-07 23:03:40 +00:00
Mihai Alexandru Michis
6da97a654e Backed out 2 changesets (bug 1689445) for causing bc failures in browser_search.js
Backed out changeset 2b1ec882c4c1 (bug 1689445)
Backed out changeset bcb4ba398ee0 (bug 1689445)
2021-02-06 05:33:02 +02:00
Yura Zenevich
d3beb62c1d Bug 1689445 - revert EventUtils.sendMouseEvent back to being sync. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D104127
2021-02-05 21:26:54 +00:00
James Teh
e81436a8a8 Bug 1689936: Move pending a11y content insertions into a temporary data structure before processing them. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103977
2021-02-05 00:01:59 +00:00
Morgan Reschenberg
b6cdc22e2b Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
Morgan Reschenberg
1f72fbb6eb Bug 1680840: Fire table styling changed event when style changes that may affect data/layout table classification r=emilio,eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103254
2021-02-04 20:50:05 +00:00
Morgan Reschenberg
ced0045bea Bug 1688490: Make GetNativeFromGeckoAccessible null-safe r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103813
2021-02-04 19:41:30 +00:00
Morgan Reschenberg
6b8df6efbe Bug 1686744: Fire AXMenuItemSelected notification when menu item is pressed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103954
2021-02-04 19:41:37 +00:00
James Teh
1b4d4c6a32 Bug 1690456: Don't allow nsAccessibilityService to be shut down while a parent document is still shutting down. r=yzen
DocAccessible::Shutdown calls DocManager::NotifyOfDocumentShutdown, which can shut down nsAccessibilityService if there are no more consumers.
Previously, this could happen even when shutting down child documents.
Since shutting down the service shuts down all documents, this resulted in shutting down the parent document within an outer call to shut down that same document.
Even if that reentry were prevented, the service would have been gone when returning to the outer Shutdown call, which still needs the service to complete its cleanup.

To fix this, DocManager::NotifyOfDocumentShutdown takes an argument specifying whether to allow service shutdown.
This is set to false when shutting down child documents.
The service is thus allowed to shut down when returning to the parent document Shutdown.

In addition, mPresShell is cleared before shutting down child documents to prevent reentry like this.
While this should no longer happen, this should safeguard against similar pain in future.

Differential Revision: https://phabricator.services.mozilla.com/D103966
2021-02-04 01:10:52 +00:00
Morgan Reschenberg
62aed9ef20 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-02 21:30:58 +00:00
Morgan Reschenberg
67cee8a3e4 Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-02 21:10:26 +00:00
Butkovits Atila
2af3edc6b9 Backed out 2 changesets (bug 1688730) for causing mochitest failures. CLOSED TREE
Backed out changeset 677c17ec48ea (bug 1688730)
Backed out changeset a7d0770117c8 (bug 1688730)
2021-02-02 02:04:28 +02:00
Morgan Reschenberg
876affb062 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 20:23:23 +00:00
Morgan Reschenberg
84efd51514 Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-01 20:23:17 +00:00
Butkovits Atila
e13215fdec Backed out 2 changesets (bug 1688730) for causing build bustage on mozTableAccessible.mm. CLOSED TREE
Backed out changeset bd6d78d36cee (bug 1688730)
Backed out changeset dd03939b850e (bug 1688730)
2021-02-01 21:44:02 +02:00
Morgan Reschenberg
3b5f7255b1 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 17:54:13 +00:00
Morgan Reschenberg
cdce5e2be5 Bug 1688730: Fire relevant object attr changed events when layout table status may have changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102993
2021-02-01 18:30:07 +00:00
Eitan Isaacson
d3876360b5 Bug 1688972 - Make FocusedChild work across document/process boundaries. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D103102
2021-02-01 17:54:23 +00:00
Narcis Beleuzu
868935867c Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Nika Layzell
bbaf7fbc65 Bug 1682285 - Part 2: Track LOAD_FLAGS_FROM_EXTERNAL separately from LOAD_TYPE, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D103365
2021-01-29 22:06:36 +00:00
Dorel Luca
dc191572ea Backed out changeset 4572c1ba670a (bug 1688972) for Browser-chrome failures in accessible/tests/browser/fission/browser_take_focus.js. CLOSED TREE 2021-01-30 01:17:00 +02:00
Eitan Isaacson
ba6174e679 Bug 1688972 - Make FocusedChild work across document/process boundaries. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D103102
2021-01-29 20:57:30 +00:00
Emilio Cobos Álvarez
3994678bd5 Bug 1689285 - Fix test_visibility.xhtml to not depend on theme values. r=eeejay
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:

    wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'

Get what we want to test more explicitly by setting the height of the
menuitems appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D103267
2021-01-29 16:54:21 +00:00
Paul Zuehlcke
3d476753eb Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-29 16:11:08 +00:00
James Teh
42351bc1af Bug 1688532: Don't use the cached column header on a previous table cell if that cell starts in a different column. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103146
2021-01-28 17:21:47 +00:00
Mihai Alexandru Michis
2cf7d8a32b Backed out changeset 7b30dc27f552 (bug 1689285) for causing accessible failures in test_visibility.xhtml
CLOSED TREE
2021-01-29 00:58:11 +02:00
Emilio Cobos Álvarez
924021206c Bug 1689285 - Fix test_visibility.xhtml to not depend on theme values. r=eeejay
It's relying on the other menuitems being tall enough so that they
overflow 5em. When the non-native theme is enabled, this assumption
breaks because that theme doesn't add padding to XUL menuitems, and we
get the failure:

    wrong state bits for 'mi_file1.2.4' !got '0', expected 'offscreen'

Get what we want to test more explicitly by setting the height of the
menuitems appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D103267
2021-01-28 17:19:16 +00:00
Brindusan Cristian
e117dc4695 Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00
Paul Zuehlcke
bbdb4f3b7b Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-28 12:14:43 +00:00
Morgan Reschenberg
897cbb0e6e Bug 1688490: Gather moxParent directly instead of querying the parent of our gecko accessible r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102965
2021-01-26 21:12:11 +00:00
James Teh
38a46d893a Bug 493683 part 5: When aria-labell/describedby is set, set HasName/DescriptionDependent on the target subtree. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102680
2021-01-25 17:31:19 +00:00
James Teh
49597d49e1 Bug 493683 part 4: Add a PivotRule to match any local Accessible in the same document. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102679
2021-01-25 01:12:17 +00:00
James Teh
c9893f0237 Bug 493683 part 3: When an Accessible mutates, fire description change events on an Accessible described by it (or an ancestor thereof) via a relation. r=eeejay
This uses a similar approach to HasNameDependent, introducing a new HasDescriptionDependent.
However, we don't fire events on ancestors, since a description is never computed from an Accessible's own subtree without an explicit described by relation.

Differential Revision: https://phabricator.services.mozilla.com/D102678
2021-01-27 00:39:08 +00:00
James Teh
77fe9db976 Bug 493683 part 2: When an Accessible mutates, fire name change events on an Accessible labelled by it (or an ancestor thereof) via a relation. r=eeejay
HasNameDependent is now set on an Accessible (and thus its descendants) which has A LABEL_FOR relation.
When text mutations occur on such an Accessible, EventQueue::PushNameChange now queues a name change for the Accessible being labelled.

Differential Revision: https://phabricator.services.mozilla.com/D102677
2021-01-27 00:34:21 +00:00
James Teh
1af2138c00 Bug 493683 part 1: Rename HasNameDependentParent to HasNameDependent due to upcoming broader usage. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102676
2021-01-25 00:39:39 +00:00
Eitan Isaacson
92f8f50dd8 Bug 1688680 - Don't include AXTextStateSync in read-only collapsed text selection events. r=morgan.
Differential Revision: https://phabricator.services.mozilla.com/D102948
2021-01-25 17:58:52 +00:00
Eitan Isaacson
0921a6cd36 Bug 1688938 - Uncomment state change tests. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D103076
2021-01-26 19:26:29 +00:00
Eitan Isaacson
81befd069d Bug 1686832 - Cache MULTI_LINE in mozAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D101842
2021-01-22 20:42:26 +00:00
Steven MacLeod
079775e780 Bug 1656107 - remove FindContentForSubDocument use from NotificationController. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D98613
2021-01-21 00:46:15 +00:00
Mats Palmgren
b41a2b9d21 Bug 1687239 part 2 - Remove plugin support from layout/. r=emilio
Note that there's still a little plugin related code in
widget/ and gfx/ etc after this.  That can be removed
once we remove plugin support from dom/ etc.
The removal from layout/ should be pretty complete though.

Differential Revision: https://phabricator.services.mozilla.com/D102140
2021-01-25 11:53:49 +00:00
Mats Palmgren
334efb391e Bug 1687239 part 1 - Remove plugin tests from layout/, dom/ and accessible/. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D102139
2021-01-25 11:53:31 +00:00
Morgan Reschenberg
7dc8c1a190 Bug 1686238: Only attempt to traverse containers menu if containers are enabled and defined r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D102799
2021-01-22 21:02:50 +00:00
Eitan Isaacson
135c36619d Bug 1686995 - Add AXTextSelectionDirection and AXTextSelectionGranularity to text selection events. r=morgan
.. and also add AXTextSelectionChangedFocus and AXTextStateSync when needed.

Differential Revision: https://phabricator.services.mozilla.com/D102509
2021-01-22 21:12:56 +00:00
Morgan Reschenberg
09060aa168 Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 19:58:13 +00:00
Bas Schouten
57732c3083 Bug 1687535: Give several LazyInstantiator functions fast paths that avoid a11y instantiation. r=Jamie
This prevents us from instantiating accessibility (and incurring a significant performance cost later in the runtime) when we already know the answers a caller will receive if a11y were instantiated.

Differential Revision: https://phabricator.services.mozilla.com/D102371
2021-01-21 17:19:47 +00:00
Brindusan Cristian
ff8e5cb389 Backed out changeset 2860943a09a3 (bug 1686164) for build bustages at mozSelectableElements.mm. CLOSED TREE 2021-01-21 10:58:18 +02:00
Morgan Reschenberg
fdab0ce3d7 Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 08:42:02 +00:00
Yura Zenevich
9ed618367f Bug 1667998 - skip some accessible related browser-chrome tests when running a11y-checks. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D100841
2021-01-15 21:51:50 +00:00