See https://stackoverflow.com/a/24026735.
Adding the `docs` package requirement is not ideal, but it's not worth
the effort to install it only in automation (or in the relevant task),
and it's not *that* large: 1.0G on my macOS installation.
Differential Revision: https://phabricator.services.mozilla.com/D35834
--HG--
extra : moz-landing-system : lando
4.3.3 is the strict minimum required for v-c-t's config wizard, but it
is preferable people use more modern versions. We could go with 5.0, but
it feels like people still using 4.8 and 4.9 don't really need to be
bugged to update to a more recent version, they are kind of modern
enough. OTOH MozillaBuild comes with 4.5.x, and this will force an
upgrade for those.
Differential Revision: https://phabricator.services.mozilla.com/D35756
--HG--
extra : moz-landing-system : lando
This makes the bootstrap behavior wrt. Mercurial consistent on all
platforms, making Windows bootstrap only upgrade Mercurial if the
version is older than MODERN_MERCURIAL_VERSION.
As a side effect, this avoids upgrading to version 5.0.1, which doesn't
come with wheels at the moment.
Differential Revision: https://phabricator.services.mozilla.com/D35754
--HG--
extra : moz-landing-system : lando
The `mach resource-usage` page supports a list of build resource data,
but only ever displays the first one. Nothing actually creates a list
with multiple items automatically, but one might want to do that
manually to explore data from multiple builds more conveniently.
So if such a list exists, we expose a dropdown list of all the data
available, and switch the graph when a different item is chosen from the
list.
Differential Revision: https://phabricator.services.mozilla.com/D35757
--HG--
extra : moz-landing-system : lando
In the clang-cl 9 case where we have semicolon-separated paths, the `dirs` variable is never read, so the libclang detection fails.
Differential Revision: https://phabricator.services.mozilla.com/D35825
--HG--
extra : moz-landing-system : lando
Looks like onload event is not enough, so we still have intermittents.
Based on the suggestion in html spec:
https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode
We decode the image in parallel, and only inserting it into the DOM (and thus
causing it to be painted) once the decoding process is complete.
Because the decode() method attempts to ensure that the decoded image data is
available for at least one frame, it can be combined with the
requestAnimationFrame() API. This means it can be used with coding styles or
frameworks that ensure that all DOM modifications are batched together as
animation frame callbacks.
Hope this could reduce the occurrence rate of this intermittent.
Differential Revision: https://phabricator.services.mozilla.com/D35732
--HG--
extra : moz-landing-system : lando
Gecko layouts typically produce a picture cache where the origin
of the picture rect is an integer. However, it can occasionally
be a fractional origin.
In these cases, we need to ensure the content origin is floored,
to maintain consistent snapping. When this case occurs, the UV
rect for the tile also needs adjusting, to ensure the exact
1:1 texel:pixel mapping when drawing the tile.
Differential Revision: https://phabricator.services.mozilla.com/D35761
--HG--
extra : moz-landing-system : lando
This patch addresses bug 1548933. It adds/removes the preview highlight to related tokens (if necessary) as well as the target token. This happens when one token is broken into pieces due to a search query that only covers part of the token.
Differential Revision: https://phabricator.services.mozilla.com/D34749
--HG--
extra : moz-landing-system : lando
Clap is a very slow crate to build and we're using bindgen as a library, so we don't really need to build it.
Unfortunately other crates (binast / geckodriver) do rely on clap, so it doesn't completely go away from the dependency graph.
Differential Revision: https://phabricator.services.mozilla.com/D35827
--HG--
extra : moz-landing-system : lando
Later, once we have enough video metadata, the binding will decide whether or not to display the toggle again.
Differential Revision: https://phabricator.services.mozilla.com/D35811
--HG--
extra : moz-landing-system : lando
Showing moz-extension URLs in the debugger is not helpful -- we should display the name of the extension instead.
Differential Revision: https://phabricator.services.mozilla.com/D34427
--HG--
extra : moz-landing-system : lando
If the theme is persisted as an xpi we'll use GeckoJarReader to read get the
image from inside the archive otherwise read it directly.
Differential Revision: https://phabricator.services.mozilla.com/D35808
--HG--
extra : moz-landing-system : lando
According to the documentation -
https://developer.android.com/reference/android/app/Service.html
"The Intent supplied to Context.startService(Intent) may be null if the service
is being restarted after its process has gone away, and it had previously
returned anything except START_STICKY_COMPATIBILITY."
We will ignore the case when the system restarts our Service as we only expect
it to be properly started by us, in the event of a crash.
Differential Revision: https://phabricator.services.mozilla.com/D35790
--HG--
extra : moz-landing-system : lando
Our uninstaller currently calls the NSIS RMDir instruction on the `defaults`
directory with the /REBOOTOK flag set, which means that NSIS will register
the directory for deletion during the next reboot if it can't be removed
immediately for any reason. The problem here is that "any reason" includes
"the directory wasn't empty", and setting the reboot flag is not at all
the right thing to do in that situation. It won't help resolve the problem,
and those directories are expected to be empty at that point in the uninstall,
because we've already removed all the files that we know we put there, so
anything left is something we don't know about and shouldn't try to delete.
So the right thing to do here is just to remove the /REBOOTOK and allow the
RMDir to fail, so that any user files are never touched and we don't show
an unnecessary reboot prompt at the end of the wizard.
I also removed the FileExists checks, because the RMDir instruction does that.
Differential Revision: https://phabricator.services.mozilla.com/D34938
--HG--
extra : moz-landing-system : lando
