I don't think all this complexity is worth it for having a
marginally-more-realistic testing story. Using the pref just works and we should
do that, I think.
Differential Revision: https://phabricator.services.mozilla.com/D59980
In order to test its parsing and serialization, we expose it but protect
it behind a pref.
Besides, I would like to drop layout.css.aspect-ratio-number.enabled in
the next patch because the spec has been updated. It seems we don't have
to keep this pref and we should always use Number.
Differential Revision: https://phabricator.services.mozilla.com/D74955
The MDNCompatibility library will be shared between the upcoming
Compatibility Actor and the Compatibility Panel in the inspector.
This library is necessary for tests in Compatibility Panel and
hence is being moved to the devtools/shared looking at it's
requirements in client as well as the devtools/server/actors
Differential Revision: https://phabricator.services.mozilla.com/D75998
The context menu of the network blocking panel have options to
"Enable all" and "Disable all" for enabling and disbaling all the
patters in the request blocking panel at once.
This patch disables those options in case all the URLs are already
enabled or disabled. Having the buttons active all the time might
lead to confusing situtaions especially with long blocking pattern
list where it may lead the user to think there is a URL that has not
been enabled/disabled eve after clicking the menu option.
Differential Revision: https://phabricator.services.mozilla.com/D75247
Reinstate customUserAgent interface for nsIDocShell. This is so it can be used
as a choke-point to catch setting values on docshells which are in the process
of changing process. We don't want to send changes which will be rejected on the
parent side.
This code should be removed once callers setting customUserAgent are refactored
to only occur from parent process.
Differential Revision: https://phabricator.services.mozilla.com/D75006
Fix up the browser_tab_label_during_restore.js test to wait for the right number of tab title changes, since the timing of the tab title updating has now changed.
Differential Revision: https://phabricator.services.mozilla.com/D72562
This is needs a few things to complete, but is ready for gathering initial feedback
- Added a new Url Preview Component
- Refactored the UX for the summary sections
Todo
- Fix the tests
- Fix Console errors
- Cleanups
- Rebase over D71916 after that lands
Differential Revision: https://phabricator.services.mozilla.com/D73192
Drag and drop is a nice little feature to have to add URL to blocked
list. Current implementation allows for blocking the URL from the
context menu but drag and drop is a nifty little feature for
convenience.
Current implementation will only allowed an unblocked URL to be
dragged and dropped. The dragging is blocked is the network
blocking panel isn't opened.
Note: This is just an RFC. @Harald had raised a question of
discoverabilty of the feature given there are no other elements
that can be dragged and dropped within the network monitor. This
is just a proposal to see if it's addition is beneficial.
Differential Revision: https://phabricator.services.mozilla.com/D74535
In network analysis in Netmonitor, the headers are being cropped, even when there is space available. This is due to the `cropLimit` property. In this revision, the `cropLimit` property is removed so that the headers take up all available space.
Differential Revision: https://phabricator.services.mozilla.com/D75688
Added a new hasPrettyTab() selector function.
Renamed the function and prop in SourcesTreeItem to reflect the new hasPrettyTab() selector function.
Updated the snapshot test for the pretty print icon.
Differential Revision: https://phabricator.services.mozilla.com/D75733
Now that nsIScriptError have a `isPromiseRejection` flag, we can consume it
in the console to indicate to the user that we're dealing with a promise rejection.
The exception message is then: "Uncaught (in promise) XXX".
A few tests needed to be updated, and we take this as an opportunity to
ensure we have a stacktrace for uncaught promise rejection.
Differential Revision: https://phabricator.services.mozilla.com/D75780
When resizing the output, if the height was modified, the scrollbar position
was updated and could lose its pinned-to-bottom state.
This patch adds a resizeObserver to the console output node, where we
scroll the output to the bottom if it's needed.
In order to be able to do that, some changes were done in how we were
detecting that the output was pinned to the bottom.
We now have an intersection observer on the last message element,
which flips a flag when the element isn't intersecting the viewport
anymore.
Some test cases are added to ensure the console has the expected
behavior in different situations.
Depends on D74708
Differential Revision: https://phabricator.services.mozilla.com/D75297
See https://bugzilla.mozilla.org/show_bug.cgi?id=932410#c2 for the
context for which this pseudo-element was added.
In the previous patch, I had to special-case range appearance because of
this pseudo-class, but that patch makes this pseudo-class completely
redundant, as now all form controls, themed and unthemed, display
outlines, unless the native theme displays a focus indicator on its own.
Remove the special case, and make ranges use outlines like everything
else rather than this bespoke pseudo-element.
Differential Revision: https://phabricator.services.mozilla.com/D74734
See https://bugzilla.mozilla.org/show_bug.cgi?id=932410#c2 for the
context for which this pseudo-element was added.
In the previous patch, I had to special-case range appearance because of
this pseudo-class, but that patch makes this pseudo-class completely
redundant, as now all form controls, themed and unthemed, display
outlines, unless the native theme displays a focus indicator on its own.
Remove the special case, and make ranges use outlines like everything
else rather than this bespoke pseudo-element.
Differential Revision: https://phabricator.services.mozilla.com/D74734