James Teh
fca9213cd0
Bug 1322621: If aria-activedescendant is removed or changed to an invalid id while an element is focused, move accessible focus to the element itself. r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D4732
--HG--
extra : moz-landing-system : lando
2018-08-31 07:00:59 +00:00
Eitan Isaacson
f8996dd01f
Bug 1486887 - Use binding parent for input[type] retrieval. r=surkov
2018-08-31 15:11:00 +03:00
Dave Townsend
e63bb1c465
Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D4681
--HG--
extra : rebase_source : ae253571d7d47c4a113a98a8b7c29bf712a0d764
2018-08-29 16:15:33 -07:00
Dave Townsend
e1f6637191
Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8
...
Two cases were hiding permanently failing tests. I've commented those out and
filed bug 1487431.
Differential Revision: https://phabricator.services.mozilla.com/D4680
--HG--
extra : rebase_source : 232fa6173de8844a9c47d59926ec8e39d0640ecd
2018-08-29 16:12:55 -07:00
Margareta Eliza Balazs
edc8edfcd7
Merge inbound to mozilla-central. a=merge
2018-08-31 12:23:17 +03:00
Margareta Eliza Balazs
5ddcd7b745
Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout
2018-08-31 12:17:27 +03:00
Gurzau Raul
6b4d87cf7c
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-08-31 07:08:44 +03:00
Alexander Surkov
ef0cc6d04c
Bug 1487313 - stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y, r=jamie
2018-08-31 09:17:38 +08:00
Gijs Kruitbosch
9d70cb3843
Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
...
Differential Revision: https://phabricator.services.mozilla.com/D4466
--HG--
extra : moz-landing-system : lando
2018-08-30 15:07:36 +00:00
Narcis Beleuzu
1bb581bc8f
Merge mozilla-central to inbound.
...
--HG--
extra : rebase_source : 063f3df7ad6d834fa3e72cd6825c31792716586b
2018-08-30 16:09:37 +03:00
Narcis Beleuzu
a4ec006bb0
Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout
2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702
Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
...
Differential Revision: https://phabricator.services.mozilla.com/D4466
--HG--
extra : moz-landing-system : lando
2018-08-29 17:58:25 +00:00
Paolo Amadini
5aaf848c8b
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D4531
--HG--
extra : rebase_source : 502aa0ff24d0e3d46ef60c7a14498e25c66d1c81
2018-08-29 14:04:25 +01:00
Alexander Surkov
e36505da67
Bug 1486671 - stop using nsIDOMXULCheckboxElement, r=jamie
2018-08-29 15:42:31 +08:00
Paolo Amadini
bfef02108d
Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D4306
--HG--
extra : rebase_source : e8b4946c8f657e2283bc96cb08de802493e3a826
2018-08-24 15:44:38 +01:00
Xidorn Quan
47b25bfcca
Bug 1486329 - Fix some clang-cl warnings in accessible. r=eeejay
...
Specifically this fixes pessimizing-move warnings and some others.
Differential Revision: https://phabricator.services.mozilla.com/D4302
--HG--
extra : moz-landing-system : lando
2018-08-27 15:49:01 +00:00
Eitan Isaacson
dd36aade7d
Bug 1485862 - Set correct text-input-type for input[type=number]. r=surkov
2018-08-24 13:34:00 +03:00
Tiberius Oros
2ee9341d01
Merge inbound to mozilla-central. a=merge
2018-08-24 12:43:45 +03:00
James Teh
2a8cad4bfc
Bug 1479678: Fix incorrect start offset when retrieving accessible text attributes if the last spelling error is not within this accessible. r=surkov
...
When dealing with an editor which contains multiple accessibles, the previous spelling error range might be in a previous accessible, not the accessible currently being queried.
In this case, DOMPointToOffset will return the length of this accessible.
Previously, we weren't checking for this and were overriding the start offset of the returned range regardless, resulting in broken offsets.
Now, we leave the start offset alone in this case.
Differential Revision: https://phabricator.services.mozilla.com/D3960
--HG--
extra : moz-landing-system : lando
2018-08-24 03:08:28 +00:00
Kris Maglione
3a5c05e76f
Bug 1484496: Part 5e - Convert remaining nsISimpleEnumerator users to use JS iteration. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D3733
--HG--
extra : rebase_source : c0fac176d7b3d840c4dbb14f8d95ccfc7f83a5a8
extra : histedit_source : a92c40117d0808a3ad68c972f622a7a42c9ae8ba
2018-08-18 18:13:14 -07:00
Eitan Isaacson
4cba5259d5
Bug 1484778 - Null-check scroll frame in DispatchScrollingEvent. r=surkov
2018-08-21 10:24:00 -04:00
Eitan Isaacson
57a25953a0
Bug 1483911 - Defer scrolling events until after ipc doc construction. r=Jamie
2018-08-20 15:51:00 +03:00
Joanmarie Diggs
7471d4968b
Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov
...
Change the name calculation rule of HTML 'table' element from eNoNameRule
to eNameFromSubtreeIfReqRule. That way the table won't get an accessible
name, but will be descended when building a name from a parent element's
contents.
--HG--
extra : rebase_source : 218aec9f90b0c420a5f6785e929e5512b6704567
2018-08-17 08:14:00 +03:00
Yura Zenevich
ff402b25e1
Bug 1481924 - use WINDOW_CONTENT_CHANGED instead of WINDOW_STATE_CHANGED when viewport changes to ensure accessible bounds are re-drawn correctly. r=eeejay, jchen
...
MozReview-Commit-ID: 92bKGZMwJkP
2018-08-17 09:46:55 -04:00
Eitan Isaacson
8d5dad89ed
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2018-08-15 13:07:00 -04:00
Cosmin Sabou
c2b1fcd31c
Backed out changeset dad95d849302 (bug 1479591) for causing linux debug leaks and security issues.
2018-08-15 04:39:43 +03:00
Eitan Isaacson
0f281891a2
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2018-08-14 11:46:00 +03:00
Daniel Varga
9355025fd5
Merge mozilla-central to mozilla-inbound
2018-08-14 01:09:48 +03:00
Ting-Yu Lin
48d02834a5
Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D3155
2018-08-13 14:29:28 -07:00
Adrian Wielgosik
be0c1a4f55
Bug 1481645 - Remove some redundant uses of do_QueryInterface. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D2893
--HG--
extra : moz-landing-system : lando
2018-08-13 09:05:19 +00:00
James Teh
0912c08892
Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ
...
Differential Revision: https://phabricator.services.mozilla.com/D3076
--HG--
extra : moz-landing-system : lando
2018-08-13 06:28:35 +00:00
Masayuki Nakano
c0e869978e
Bug 1482012 - part 2: Create TextEditor::PasteAsAction() as non-virtual method for outer C++ code r=m_kato
...
User may paste a lot with pressing Accel+V for a while (i.e., with auto repeat).
So, calling nsIEditor::Paste() may be in a hot path and we can now make
non-virtual public method with AsHTMLEditor().
Differential Revision: https://phabricator.services.mozilla.com/D2993
--HG--
extra : moz-landing-system : lando
2018-08-13 04:37:56 +00:00
Kris Maglione
637cac1ea7
Bug 1481024: Stop relying on lexical variables being available across frame scripts. r=yzen
...
The accessibility tests currently rely, in many places, on lexical variables
defined in global frame scripts being available to other non-global frame
scripts. While that is currently the case, it will stop being so soon.
And, while the simplest solution would be to define them as properties on the
frame message manager by using `var` rather than `let`, storing references to
the current content window in a frame script scope is unsafe at best, and
should be avoided at all costs.
MozReview-Commit-ID: 4FCGtLgcFzl
--HG--
extra : rebase_source : d21206c9f119ca0ce61f9956f84a2e2d11484bca
2018-08-02 20:19:50 -07:00
Yura Zenevich
e0c82272d3
Bug 1481924 - added GevkoView accessibility tests for scrolling. r=eeejay, jchen
...
MozReview-Commit-ID: ATGNFruDGAI
2018-08-10 13:13:35 -04:00
Yura Zenevich
2b1f8c8ae8
Bug 1481922 - add support for select action and view selected event. r=eeejay, jchen
...
MozReview-Commit-ID: FaLz7majPhz
2018-08-10 13:13:27 -04:00
Eitan Isaacson
704a28b360
Bug 1478727 - Move IDSet out of windows to base for Android use. r=jteh
...
--HG--
rename : accessible/windows/msaa/IDSet.h => accessible/base/IDSet.h
2018-08-09 14:56:00 +03:00
Eitan Isaacson
4561e8e337
Bug 1479036 - Android classes role additions. r=surkov
...
--HG--
extra : rebase_source : a3612efad26d164c33e7724079722c3163b5cf71
2018-08-09 14:43:00 +03:00
Gabriele Svelto
15adf94f4d
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
...
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant C++ functions are updated to take a typed enum. JavaScript
calls are unaffected but they will throw if the string argument does not
correspond to one of the known entries in the C++ enum. The existing whitelists
and blacklists of annotations are also generated from the YAML file and all
duplicate code related to them has been consolidated. Once written out to the
.extra file the annotations are converted in string form and are no different
than the existing ones.
All existing annotations have been included in the list (and some obsolete ones
have been removed) and all call sites have been updated including tests where
appropriate.
--HG--
extra : source : 4f6c43f2830701ec5552e08e3f1b06fe6d045860
2018-07-05 15:42:11 +02:00
Jonathan Kingston
2f0987a202
Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
...
Summary: Depends on D2046
Reviewers: ckerschb!, Gijs!
Tags: #secure-revision
Bug #: 1362034
Differential Revision: https://phabricator.services.mozilla.com/D2047
--HG--
extra : source : 33884d05cc94463950b31fab1fd2f37ada9becef
extra : intermediate-source : 72471adb75d5ec3dc2b0c8f972a6f1f26bfd3ae2
extra : histedit_source : f384cbab58401575afc3443c9a431b73cff806d4
2018-07-06 21:16:29 +01:00
Mike Hommey
6d197a0707
Bug 1481719 - Disable profile-instr-out-of-date warnings explicitly rather than allowing all warnings where they appear. r=dmajor
2018-08-09 06:07:33 +09:00
dvarga
12f19b94e9
Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
...
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)
--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
c15f69d427
Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
...
Summary: Depends on D2046
Reviewers: ckerschb, Gijs
Reviewed By: ckerschb, Gijs
Bug #: 1362034
Differential Revision: https://phabricator.services.mozilla.com/D2047
--HG--
extra : rebase_source : ccded0f06a0dc4567b827f42ee29f4b8954154fe
extra : amend_source : 94da8ecc053e56958fa4137d7e497362fa2c11f1
2018-08-08 20:05:30 +03:00
James Teh
5a83999558
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov
...
The XULSelectControlAccessible selection methods don't handle ARIA selection.
Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods.
We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL.
Being able to retrieve multiple selection programmatically is far more important than being able to set it.
MozReview-Commit-ID: CmVp9KyieMY
--HG--
extra : rebase_source : e3fa93aad4726b322956babb5422dceebfa0fbb2
2018-08-03 13:31:43 +10:00
James Teh
46ba6df249
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov
...
We need to be able to call these methods from const methods, so they must take a const Accessible*.
MozReview-Commit-ID: CDsWZG1ik31
--HG--
extra : rebase_source : 4721669afcd9101cb017361bd8f87fb8a860664a
2018-08-02 16:27:18 +10:00
James Teh
6647aa6cc0
Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov
...
MozReview-Commit-ID: JeV5vBffQIq
--HG--
extra : rebase_source : 3e6979e1e1995e62951250937d0c28f1128dcbac
2018-08-02 16:25:09 +10:00
Andreea Pavel
f5c1119983
Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
...
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
4ca581ffed
Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
...
Summary: Depends on D2046
Reviewers: ckerschb, Gijs
Reviewed By: ckerschb, Gijs
Bug #: 1362034
Differential Revision: https://phabricator.services.mozilla.com/D2047
--HG--
extra : rebase_source : 4bb9e7feb0704239756e6e38623c0fea81669f7b
extra : amend_source : 9417f96547735fbdc55ea23666327a5cb86ac92f
2018-08-06 19:56:37 +03:00
Tokio Kajitsuka
0b25579f2d
Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov
...
change the type of AccessibleNode::mRelationProperties to nsRefPtrHashtable and add it to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE
2018-08-04 19:47:50 +09:00
Masatoshi Kimura
3b21b7868b
Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
...
--HG--
extra : rebase_source : c09366fb93e5b0f72abe1e99d3094e3d96a934fb
extra : intermediate-source : 5950c9d63c3b4fd63a25464a7b50944aaec7079f
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Boris Zbarsky
d4993da381
Bug 1476142 part 4. Remove some unnecessary QIs on window in various parts of the tree. r=kmag
...
The crashtest was not testing anything useful, because getInterface is no longer exposed to web content.
2018-08-02 15:26:48 -04:00