Automatic update from web-platform-tests
[css-pseudo] Fix text selection and drag-and-drop for pseudo-elements
Before this patch, if you had a tree like
<div><div::before>abc</div::before>def</div>
and you tried to select "bc", Chromium would end up selecting "ef" in
some cases. Similarly, trying to drag a text and drop it between "bc",
would end up inserting the text between "ef".
This patch fixes the problem, now trying to select "bc" won't select
anything. And dropping some text between "bc" will insert it between
the "cd".
BUG=1051685
TEST=external/wpt/css/css-pseudo/text-selection.html
TEST=fast/css-generated-content/drag-and-drop.html
The 2nd test is internal because I didn't manage to properly simulate
drag and drop using testdriver.js
Change-Id: Iedd594b46022ed434bdb1462232c717ec08f5304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047287
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#741909}
--
wpt-commits: 410f5ece454de3f304f4ac885be244ed9755ac18
wpt-pr: 21808
Automatic update from web-platform-tests
Fix resources path in lazy load tests
When moving lazy load tests to html/semantics/embedded-content/the-img-element
the internal resources paths were not adjusted, so do it in this change.
--
wpt-commits: 0ffd3515e2a53c04c5465687153d77bc50328c86
wpt-pr: 21821
Automatic update from web-platform-tests
Use six.iteritems to iterate over dictionary's items in tools
This corresponds to dictionary.iteritems() on Python 2 and
dictionary.items() on Python 3.
--
wpt-commits: 70efafb7da25cb0c44beb95dfbb4198e80a557b9
wpt-pr: 21835
Automatic update from web-platform-tests
[WPT/mixed-content] Remove websocket + redirect tests
Redirects are forbidden (see Step 12 and the warning at the bottom:
https://fetch.spec.whatwg.org/#concept-websocket-establish ).
Previously, websocket + redirect tests were generated, but
their behavior was the same as websocket + no-redirect,
because the websocket subresource endpoint ignores
redirect-related parameters.
This CL removes such redundant tests.
Bug: 906850
Change-Id: I86be33d1812b4d16ba463f14320fb23369321cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058707
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741851}
--
wpt-commits: 2d1c196b4bb245aa80b4fafe5824384fee386a82
wpt-pr: 21832
Automatic update from web-platform-tests
[WPT/common/security-features] Transition `spec.src.json` to JSON5
To allow inline comments in `spec.src.json` to make it more
descriptive, this CL parses `spec.src.json`s as JSON5,
using `json5` non-standard library.
After parsing, we still use `json` module for outputting
JSON objects.
Subsequent CLs e.g. [1] will actually add inline comments
to `spec.src.json`s.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2049953
This CL doesn't change the generated results.
Bug: 906850, https://github.com/web-platform-tests/wpt/issues/21824
Change-Id: I8c6472b41ae55a051889fc29cf57d392ef60b69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058706
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741850}
--
wpt-commits: 8205a7e07caf3606abed03306d5b51c0d688252a
wpt-pr: 21826
Automatic update from web-platform-tests
SharedWorker: Fire an error event when type or credentials mismatch
This CL adds the step to check if type and credentials values are same
with these of matched SharedWorkerGlobalScope before connecting to it.
This is just added to the spec.
Spec issue: https://github.com/whatwg/html/issues/5235
Pull request: https://github.com/whatwg/html/pull/5258
WPT: https://github.com/web-platform-tests/wpt/pull/21651
This changes the behavior, and WPT is already added from the public pull
requests to WPT GitHub:
wpt/workers/shared-worker-options-mismatch.html
In this CL, http/tests/workers/shared-worker-shared.html is modified.
Since the way to catch worker's error had changed, this test was no
longer catching the error properly. This test was attempting to create
SharedWorker with non-existing script url so ErrorEvent had been fired.
However, this test couldn't successfully catch ErrorEvent and this is
found out since the console error log added in this CL is printed as
"text diff". Fixing this test is out-of-scope, so this CL avoid this
console error by using an existing script url.
Bug: 1050438
Change-Id: I03232ff19db89560d99d3ddc6a25cdd8f1898222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041386
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741848}
--
wpt-commits: 497675f53a9542bdb77c0640cd683e5990659a94
wpt-pr: 21795
Automatic update from web-platform-tests
Iterating over dictionary's items with six library for PY2 & PY3 compatibility.
--
wpt-commits: ef72cc2212e324334032148aea9169edf2562ef5
wpt-pr: 21822
Automatic update from web-platform-tests
[WPT/mixed-content] Flatten subresource types
To unify `spec.src.json`, this CL flattens subresource types
in `mixed-content/spec.src.json`, to match the structure with
other `spec.src.json`s.
A subsequent CL
https://chromium-review.googlesource.com/c/chromium/src/+/2049953
will actually merge some parts of `spec.src.json`s.
This CL doesn't change the generated results.
Bug: 906850
Change-Id: I38963dbc847b09fb314907e8d068232c15e7cffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058705
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741847}
--
wpt-commits: b2331fccbc54f5b0a57d66190d30d40341cbc957
wpt-pr: 21823
Automatic update from web-platform-tests
Add new comprehensive test for image-set rendering (#21539)
* Add new comprehensive test for image-set rendering
* Use dpr 1 for now for test - no sufficient infra for DPR setting
--
wpt-commits: 1b7dcb06ea477226e90ca0fbc0b86262a410f7ad
wpt-pr: 21539
Automatic update from web-platform-tests
Remove CSS Rhythmic Sizing tests
Two years ago, when applying vertical rhythm algorithms, the
risk of accidental rounding up was raised. This is a widely
known, unavoidable risk in any vertical rhythm algorithms.
The CSSWG was in favor to accept it 8 years ago, but this
time, two members considered the risk is critical.
https://github.com/w3c/csswg-drafts/issues/938
Last month, the CSSWG discussed this again. One invited expert
was still strong not to accept the risk, and that the CSSWG
resolved to remove tests.
https://github.com/w3c/csswg-drafts/issues/938#issuecomment-577640685
Reduces 4 failures, as the feature is no longer implemented in
LayoutNG nor in any other implementations.
TBR=ikilpatrick@chromium.org, tabatkins@chromium.org
Bug: 586413
Change-Id: Ia0d50d77550cc5c8b681f001a4f25a825e6504ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059692
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741820}
--
wpt-commits: ac16628eb7eb601957382053011363d2bcf8ce44
wpt-pr: 21828
Automatic update from web-platform-tests
[LayoutNG] Generate first baseline for kInlineBlock baseline algorithm.
In https://chromium-review.googlesource.com/c/chromium/src/+/1988376 I
simplified the logic a little too much.
We (occasionally) need the first-baseline of a child inside an
inline-block. We need this when we are aligning a list-marker.
This modifies the NGBaselineAlgorithmType::kInlineBlock to always
produce both the first and last baselines.
Bug: 1051181
Change-Id: I4844dfe44d3525a68ee8b8d7f0f50bd995de9367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057344
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741798}
--
wpt-commits: 2cd67814c72b152489684d47023a7a5ce9d0aced
wpt-pr: 21820
Automatic update from web-platform-tests
Update test processing of StageParameters changes
Currently the test code only sends the stage parameters as Display Info
updates. Now that WebVr has been removed, this code path is one that is
being considered for removal.
The real runtimes utilize both this VRDisplayInfo update path as well as
updating the stage parameters with frame data.
This changes the test runtime to do the same (i.e. send up stage
parameters via both DisplayInfo and FrameData).
Fixed: 983363
Change-Id: I3c0a3f59b97163c3ac3b8f4b6529183142688d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056501
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741671}
--
wpt-commits: 8debe68e88d3b10393ea3dc5862d4130c663f496
wpt-pr: 21811
Automatic update from web-platform-tests
[Image-Orientation] Fix canvas drawImage
Image orientation was not correctly applied in base_rendering_context_2d,
resulting in always oriented images sometimes drawn with the wrong source
rect. This change fixes that.
The image-orientation setting we respect always comes from the canvas
into which the image is being drawn. This keeps the rules for which
orientation to apply simple.
As part of this change, orientation is added to StaticBitmapImage and
used in the necessary cases to track the orientation of the source
image.
As part of this change, the code to correct an image source rect is
moved to Image and callers updated.
Bug: 1043790
Change-Id: I13d74b66cff912382f8f5efe0050eae6a0f283c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044050
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741635}
--
wpt-commits: 24baba70548b528ff0179b22c77ddaabb8134a7d
wpt-pr: 21788
Automatic update from web-platform-tests
Fix lint.whitelist after 8636d91 (#21819)
The lint for audit.js is based on the exact line location, which changed
when https://github.com/web-platform-tests/wpt/pull/21804 added two more
lines to the file.
--
wpt-commits: 089627b582021a156250007160690ee7d339c0ea
wpt-pr: 21819
Automatic update from web-platform-tests
Adds flex gap tests (#20414)
* horizontal test stubbed
* vertical test stubbed
* adding basic horizontal gap test
* adding basic vertical flex gap test
* adding flex wrap gap test on extrinsic children
* adding horizontal flex gap test on intrinsic children
* adding vertical flex gap test on intrinsic children
* cruft removal
* adding horizontal flex gap test on wrapping intrinsic children
* adding vertical flex gap test on wrapping intrinsic children
* started writing mode gap tests
* page title fixes and switched to logical sizing
* flex vertical stack writing mode tests and refs done
* renamed file to be more succinct
* rtl tests for flex stacks
* removed gaps from ref impls
* title updates
* renamed files to scale better with the test matrix
* rows and columns writing mode tests are good
* intrinsic columns writing mode tests are good
* intrinsic rows writing mode tests are good
* wrap intrinsic writing mode tests are good
* wrap intrinsic columns writing mode tests are good
* test for separative row and column gap sizes
* update match meta to latest ref test title
* mixed units gaps, percentage and rem
* calc flex gap examples
* cruft fix
* fix human assertion text
* pacify linter
* fixes colors, updates copy
--
wpt-commits: 8037fe7f0d98f045bc813f3e21f228a2821dca5e
wpt-pr: 20414
Automatic update from web-platform-tests
[LayoutNG] Text indent with leading float
This change avoids breaking after leading floats in the case where
there is a text indentation.
Doing so fixes the following scenario:
<div style="width: 100px; text-indent: 40px;">
<div style="float: left; width: 60px; height: 10px;"></div>
<div style="display: inline-block; width: 60px; height: 20px;"></div>
</div>
In the above example, the following steps will happen:
1. The inline div will attempt to fit on the same line as the float.
It does not, and a new line opportunity will be created on the next
line.
2. The inline div overflows this new line opportunity due to the indent.
3. HandleOverflow() checks if the previous element (ie. the float)
can break after. The float can, so it will attempt to rewind.
4. This causes a break in a later DCHECK.
Not allowing breaks after leading floats in the case of an indentation
fixes the above issue, and appears to match the behavior of other
browsers.
Bug: 1014247
Change-Id: Icf551f5908a0fcb8e0b80a8b9329c965435dd805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896509
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#741487}
--
wpt-commits: 3c631e2f32dae04804e5cc0f1448cf5e8615458b
wpt-pr: 20096
Automatic update from web-platform-tests
getAnimations from the Document instead of from Timeline
Per the spec, Document::getAnimations() must report all Animations whose
target effect is the given document.
Spec:
https://drafts.csswg.org/web-animations/#extensions-to-the-documentorshadowroot-interface-mixin
Bug: 828585
Change-Id: I92a5cab69d0b9869fea0238e2cfb8e98d995a3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024539
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741473}
--
wpt-commits: e617314c6aa4b7c0fb83627d47063d00106b47a1
wpt-pr: 21518
Automatic update from web-platform-tests
[css-scroll-anchoring] Add WPT for zero scroll offset suppression.
Chromium has always had a scroll anchoring suppression trigger when the
scroll offset is zero. This suppression trigger was added to the spec in
https://github.com/w3c/csswg-drafts/pull/4679.
Change-Id: I2f38b23803e610aa04976c43211357e173cecbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045200
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741108}
--
wpt-commits: 91d1d5d10ddb68fcee2c1c66f27f53b7bd50001f
wpt-pr: 21675
Automatic update from web-platform-tests
Update chromium logger to identify subtest failures. (#21763)
This also fixes a bug where a subtest failure would be hidden because
the expected_status was evaluated too late in `test_end`. For a
subtest failurei the test status is Pass. But for Chromium, we flip this
"actual" status to a failure.
But the actual status is also used as a fall-back for the expected status
(see explanation in chromium.py:126). So if "expected" is evaluated after the
"flip", it will just match "actual" and the failure will be marked as
an "expected" failure.
--
wpt-commits: 22a79941ccc023ef301a48734158451f1b8873fb
wpt-pr: 21763
Automatic update from web-platform-tests
Use errno attribute to handle socket.error for PY2 and PY3 compatibility
Python 3 has introduced Built-in Exception class 'ConnectionRefusedError'
as a subclass of ConnectionError for connection-related issue.
--
wpt-commits: f2682272ecf2883db0f5302d8fae6d1b74411d64
wpt-pr: 21802
Automatic update from web-platform-tests
Revert "Worker: Add data URL tests for nested dedicated workers"
This reverts commit 1d73a2eb29cb7088b4920cf8958b6b3d053b093a.
Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322)
Original change's description:
> Worker: Add data URL tests for nested dedicated workers
>
> This CL renames data-url.html to data-url.any.js in order to run the
> tests on a dedicated worker. Previously these tests only ran on window.
>
> Bug: n/a
> Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741367}
TBR=nhiroki@chromium.org,shimazu@chromium.org
Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: n/a
Bug: 1052322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741417}
--
wpt-commits: a36ca8f94aed6644abaab1553dd634f3f5251a5d
wpt-pr: 21801
Automatic update from web-platform-tests
Remove jugglinmike from some "reviewers" lists
--
wpt-commits: ebc61f8be775c9a20d72d07459c529d4c2f2c0fe
wpt-pr: 21794
Automatic update from web-platform-tests
Make external/wpt/css/cssom-view/elementFromPoint.html robust on browsers
This patch changes "elementFromPoint.html" to call |getBoundingClientRect()|
on <img> instead of <area> because all browsers returns different value for
<area>, maybe size-less inline element, for improving robustness of test.
Because test itself verifies |elementFromPoint()| instead of
|getBoundingClientRect()|, this patch doesn't change testing
Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741374}
--
wpt-commits: 9819db110bad9ebffa1f1ea7498e612767169099
wpt-pr: 21796
Automatic update from web-platform-tests
Worker: Add data URL tests for nested dedicated workers
This CL renames data-url.html to data-url.any.js in order to run the
tests on a dedicated worker. Previously these tests only ran on window.
Bug: n/a
Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741367}
--
wpt-commits: d156ea32da9e13e7f0ba2729584433dc027c111b
wpt-pr: 21797
Automatic update from web-platform-tests
[webnfc] Add test for smart poster record with more than one uri record
NDEFRecordInit#data for smart-poster record contains more than
one uri record should throw TypeError.
BUG=520391
Change-Id: I5d876f7cdf0f6a847412b34ce06b50a922138874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053985
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#741304}
--
wpt-commits: 70dce81be7bcf6803357c2d8b48baed9fd4f7173
wpt-pr: 21774
Automatic update from web-platform-tests
Move contain-intrinsic-size tests to WPT
The CSSWG has approved a resolution to update the spec; these tests
match that resolution: https://github.com/w3c/csswg-drafts/issues/4531R=vmpstr@chromium.org
Bug: 991096
Change-Id: I021e5fb2b14eb5049cf7077e06c79810fd60e622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055740
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741254}
--
wpt-commits: c8671a2d15e8c57b652915956312b94a0236a974
wpt-pr: 21790
Automatic update from web-platform-tests
docs: Fix links in Running Tests from Local System
--
wpt-commits: 27088b913716d1350c144e30388830b62fe9f740
wpt-pr: 21792
Automatic update from web-platform-tests
Revert "Remove inDocument check for emitting change events"
This reverts commit 07d811aaeb0724d0d019b8d6bdba3d5de1dc9a5e.
The change this reverts fixed http://crbug.com/773680 which was intended
to fire change events for detached radio and checkbox input elements
when using input.dispatchEvent(new MouseEvent('click')), but also caused
input.click() to fire change events. Although these may seem to be the
same thing, firefox actually fires change events on input.dispatchEvent
but not input.click(). WebKit, and chrome before the patch this reverts
fire change events in neither of these cases.
I will file an html spec issue to address this compat issue. For now, it
seems important to stop firing these change events because it is getting
more attention than the lack of change events.
Bug: 773680, 1051482
Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741251}
--
wpt-commits: 365db564379b12f979d4cd7139179c18d0bcc4fb
wpt-pr: 21789
