Mark Banner
9651d46673
Bug 1378711 - Ensure that current places transactions have completed before clearing batch processing mode to avoid messing up the undo queue. r=mak
...
MozReview-Commit-ID: 7k0sgZIaUyB
--HG--
extra : rebase_source : 36a599395a13374550644dd5a2c63f8938de8d6d
2017-07-06 11:57:44 +01:00
Marco Bonardo
deccd6c2ca
Bug 1380302 - Fix -Wmaybe-uninitialized warnings in Places. r=adw
...
MozReview-Commit-ID: 2HxDMhYzaib
--HG--
extra : rebase_source : dfaab44c56d811c551999208025fe449ed3c1d92
2017-07-12 21:29:58 +02:00
Kit Cambridge
7d92c90880
Bug 1379412 - Don't fall back to the history visit title when fetching folder children. r=mak
...
MozReview-Commit-ID: 3ynWSLAPDZ3
--HG--
extra : rebase_source : 0127cee5cb826a75b6c388018e769951724a9166
2017-07-10 11:27:39 -07:00
Kit Cambridge
8311a354e2
Bug 1379798 - Ensure insertTree
notifies observers with the correct parent ID. r=standard8
...
MozReview-Commit-ID: LBm8VddumPJ
--HG--
extra : rebase_source : 6c1624a408843afe64f7efab24704502034bee9d
2017-07-10 14:38:21 -07:00
Mark Banner
35f3666937
Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
...
MozReview-Commit-ID: EnhSBHMjurr
--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
Marco Bonardo
bfc44708bc
Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw
...
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.
MozReview-Commit-ID: 6ccPUZ651m0
--HG--
extra : rebase_source : 07376076eb42c84caaedeffd75f133d83a6c3d70
2017-06-09 18:51:09 +02:00
Mark Banner
dc479341cf
Bug 1379630 - Update more places xpcshell-tests in tests/unit to use the new async bookmark APIs. r=mak
...
MozReview-Commit-ID: 8AnnJ1nPRiI
--HG--
extra : rebase_source : 11991b4f68b3faf72431945cdd9dcc1cd3d76e1e
2017-07-07 11:44:30 +01:00
Kit Cambridge
0c16f513c9
Bug 1378551 - Separate pullNewChanges
and markChangesAsSyncing
. r=markh
...
MozReview-Commit-ID: FcysoHJtG60
--HG--
extra : rebase_source : 902460b486ef230c939608ee9bede93374069776
2017-07-05 13:49:48 -07:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Marco Bonardo
ce21419923
Bug 1356812 - Use telemetry to report unfixable corrupt Places databases. r=bsmedberg,past
...
MozReview-Commit-ID: EZKfMlnCKCf
--HG--
extra : rebase_source : a52d57e9775d680d310688a158997b913ae3a554
2017-06-23 18:15:46 +02:00
Kit Cambridge
8098b7036f
Bug 1378554 - Allow empty titles for synced separators. r=markh
...
MozReview-Commit-ID: 7dDcIBjhDS4
--HG--
extra : rebase_source : 1acee6f8364f354af8412cebdf7cfebf3c4b9cbc
2017-07-05 11:25:02 -07:00
Marco Bonardo
4eff9ae7a0
Bug 1377864 - Stop using Promise.jsm in Places head_common.js. r=Paolo
...
MozReview-Commit-ID: 8vP0UKfSWic
--HG--
extra : rebase_source : d114cfecc12d390820fa1105474261989a70e916
2017-07-03 14:28:47 +02:00
Marco Bonardo
d3bad38937
Bug 1376929 - Fix places-related mochitests in chrome/ for async-transactions. r=standard8
...
MozReview-Commit-ID: ILrvOGzu1zo
--HG--
extra : rebase_source : de00f7f734711e2d2c8521626ad8857ab858bb97
2017-07-03 15:46:56 +02:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
90cc3a89f7
Bug 982099 - Properly extend Array in PlacesTransaction.jsm. r=standard8
...
MozReview-Commit-ID: 1gQfVgDVcVm
--HG--
extra : rebase_source : 5f290c1620fcf2e4bff789be135ce49cf2d9ec7a
2017-06-30 18:28:06 -07:00
Kit Cambridge
31ccf3dc94
Bug 1360872
- Return empty strings for null
bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
2017-06-06 14:37:22 -07:00
Mark Hammond
663a825756
Bug 1366658 - Tweak engine registration process to better facilitate external engines. r=tcsc
...
MozReview-Commit-ID: GRKQEwkpbWc
--HG--
extra : rebase_source : b274e37f446f6c78ea3d07a97eeec0354d2dd257
2017-05-19 16:53:54 +10:00
Sebastian Hengst
acb0601c26
Backed out changeset d7e7ced3622f (bug 1360872
) for failing xpcshell's test_async_transactions.js | test_creating_and_removing_a_separator, at least on OS X. r=backout
2017-06-30 19:29:17 +02:00
Kit Cambridge
c1537b7958
Bug 1360872
- Return empty strings for null
bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 8b09ca049f0891cfc3a909f7b7d2807511586b48
2017-06-06 14:37:22 -07:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
a2c238b900
Bug 1095425 - Convert PlacesTransactions to the new Bookmarks.jsm API. r=standard8
...
MozReview-Commit-ID: 12pPCGmzV4X
--HG--
extra : rebase_source : 1f8a73a5e84f34cd683abfba854c8413b0cd49b8
2015-04-28 15:19:43 +03:00
Carsten "Tomcat" Book
daa67cc9e3
merge mozilla-inbound to mozilla-central a=merge
2017-06-30 12:59:45 +02:00
Paolo Amadini
2c8564b0b5
Bug 1376986 - Remove ability to customize restriction tokens. r=mak
...
MozReview-Commit-ID: 3JuLExJwF6z
--HG--
extra : rebase_source : 1121d85ee910eb7e84a346cb1ead4c591e2ca066
2017-06-29 01:10:37 +01:00
Sebastian Hengst
c880c0301d
Backed out changeset 5659f6c9a7c5 (bug 1119282)
2017-06-29 04:00:21 +02:00
Mark Banner
c4048deb35
Bug 1119282 - Update most browser/components/places browser mochitests to pass with async Places transations and fix some async transaction issues. r=mak
...
MozReview-Commit-ID: Lc5oWCx1onJ
--HG--
extra : rebase_source : 6272b9cc6bc5907e3d022d647a9dd33c41db23a5
2017-06-27 15:08:31 -07:00
Nan Jiang
29b9ec51dc
Bug 1352502 - Part 2. Add API to update the page meta info for Places. r=mak
...
MozReview-Commit-ID: K3SjQr3ayjS
--HG--
extra : rebase_source : 8fda3d2d7ea5f5e1883b2a96e03175c7265f7e52
2017-06-23 14:30:27 -04:00
Nan Jiang
eb809f32a5
Bug 1352502 - Part 1. Add description
and preview_image_url
to Places. r=mak
...
MozReview-Commit-ID: 4dvVboTm4kf
--HG--
extra : rebase_source : 8e5a0ebc9c9e4930b2a0f013c47c7018deb6ad54
2017-05-23 14:54:13 -04:00
Carsten "Tomcat" Book
7918eeee02
merge mozilla-inbound to mozilla-central a=merge
2017-06-28 13:23:29 +02:00
Mark Banner
2db2a46875
Bug 1376234 - Convert more xpcshell-tests in toolkit/components/places/tests/unit to async Bookmarks.jsm API. r=mak
...
MozReview-Commit-ID: FF7URaUt5fM
--HG--
extra : rebase_source : f51426da947d3d659c6bdd8209adde150be9393d
2017-06-26 12:52:29 -07:00
Mark Banner
10d2d118a3
Bug 1376234 - Convert some xpcshell-tests in toolkit/components/places/tests/unit to async Bookmarks.jsm API. r=mak
...
MozReview-Commit-ID: 8c5NZDfrh4e
--HG--
extra : rebase_source : 40253fc2114edc7d254bbca55d648e42f838d1bb
2017-06-25 12:13:21 +01:00
Mark Banner
333108d7f0
Bug 1376232 - When updating date added the async Bookmarks.update API should also change the last modified date. r=mak
...
MozReview-Commit-ID: BGiT1w8BVlq
--HG--
extra : rebase_source : 65525014511d46491d6b7d3294260fb65f9cae40
2017-06-25 20:17:12 +01:00
Mats Palmgren
e7a32e265e
Bug 1376471 - Just use Put rather than Get+Remove+Put when an entry already exist. r=froydnj
...
MozReview-Commit-ID: EQDSF4mkQZ3
2017-06-28 01:03:17 +02:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Sebastian Hengst
2cfb02f19d
Backed out changeset c0fd6c0590be (bug 1360872
) for unused parentId at toolkit/components/places/Bookmarks.jsm:461. r=backout
2017-06-30 00:16:35 +02:00
Kit Cambridge
e80441db92
Bug 1360872
- Return empty strings for null
bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : bea2d2589b2a09ba70a5c8e2b50ceee21acf3f0b
2017-06-06 14:37:22 -07:00
Mark Banner
cd84e4a9db
Bug 1377181 - PlacesUtils.getFolderContents should throw if a non-id is passed. r=mak
...
MozReview-Commit-ID: KknK4wTYBAc
--HG--
extra : rebase_source : f375a8c6fb3fae21515623ac2fcbc8b36b3fcc30
2017-06-29 11:28:11 -07:00
Mark Banner
63bd606b32
Bug 1119282 - Update most browser/components/places browser mochitests to pass with async Places transations and fix some async transaction issues. r=mak
...
MozReview-Commit-ID: Lc5oWCx1onJ
--HG--
extra : rebase_source : 6272b9cc6bc5907e3d022d647a9dd33c41db23a5
2017-06-27 15:08:31 -07:00
Carsten "Tomcat" Book
259377b6ab
merge mozilla-inbound to mozilla-central a=merge
2017-06-26 13:25:51 +02:00
Carsten "Tomcat" Book
7af37a52bd
Merge mozilla-central to mozilla-inbound
2017-06-23 11:44:21 +02:00
Carsten "Tomcat" Book
5f51e5596e
merge mozilla-inbound to mozilla-central a=merge
2017-06-23 11:28:19 +02:00
Florian Quèze
721c3ada5e
Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley.
2017-06-23 11:25:18 +02:00
Nicholas Nethercote
58786e1ea7
Bug 1375392 - Tweak the PROFILER_LABEL* macros. r=mstange.
...
This patch makes the following changes to the macros.
- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
mostly misused.
- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
universally available now anyway.
- Combines the first two string literal arguments of PROFILER_LABEL and
PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
them to be separate, and it forced a '::' in the label, which isn't always
appropriate. Also, the meaning of the "name_space" argument was interpreted
in an interesting variety of ways.
- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
it clearer they construct RAII objects rather than just being function calls.
(I myself have screwed up the scoping because of this in the past.)
- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
the caller doesn't need to. This makes a *lot* more of the uses fit onto a
single line.
The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).
- Fixes a bunch of labels that had gotten out of sync with the name of the
class and/or function that encloses them.
- Removes a useless PROFILER_LABEL use within a trivial scope in
EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
a good idea.
- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
done within them, instead of at their callsites, because that's a more
standard way of doing things.
--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
2017-06-22 17:08:53 +10:00
Nicholas Nethercote
f1364a75ea
Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj.
...
All the instances are converted as follows.
- nsSubstring --> nsAString
- nsCSubstring --> nsACString
--HG--
extra : rebase_source : cfd2238c52e3cb4d13e3bd5ddb80ba6584ab6d91
2017-06-20 19:19:52 +10:00
Marco Bonardo
a60ccaff04
Bug 1263378 - Intermittent leaks from browser_bug461710.js. r=standard8
...
MozReview-Commit-ID: FQQkGaiE0xZ
--HG--
extra : rebase_source : 5cdb8a0de4cdc5afd923ab596f9c01ebf344bc9f
2017-06-21 13:30:13 +02:00
Florian Quèze
7375dcec46
Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop.
2017-06-22 12:51:43 +02:00
Florian Quèze
fb91723a8a
Bug 1374282 - hand cleanup for the script generated patch to remove Task.jsm calls, r=Mossop.
2017-06-22 12:51:42 +02:00
Wes Kocher
ac0fd2038c
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: 3LXFVwSoMvs
2017-06-21 17:58:17 -07:00
Nathan Froyd
27c58cf89f
Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian
2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Hemant Singh Patwal
fc015fcb0b
Bug 1276128 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks/test_393498.js to Bookmarks.jsm API. r=standard8
...
MozReview-Commit-ID: 8KdFVQ7zx1w
--HG--
extra : rebase_source : 1951012f2764d7677dd814889edc4665aece7aa4
2017-06-23 18:15:41 +05:30
Carsten "Tomcat" Book
e3ba7c834b
Merge mozilla-central to autoland
2017-06-23 11:46:07 +02:00
MilindL
9cd6e1d046
Bug 1107364 - remove findNodeByDetails and maintain a map to fetch a node by details speedily, r=mak
...
This patch removes the interface/header/implementation.
This adds a Map to PlacesTreeView to maintain the relation between node
details and the nodes, based on changes in `this._rows` or on
node details changed events. The Map exists from node details
to nodes (not rows).
MozReview-Commit-ID: EUNiXNIB5rN
--HG--
extra : rebase_source : 5391d9240e1f871c53d8aa26ae951b440b7280ad
2017-06-08 20:51:51 +05:30